<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[191158] trunk/LayoutTests</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191158">191158</a></dd>

<dt>Author</dt> <dd>dino@apple.com</dd>

<dt>Date</dt> <dd>2015-10-15 18:33:00 -0700 (Thu, 15 Oct 2015)</dd>

</dl>

<h3>Log Message</h3>

<pre>Remove deprecated function insertRule(), replace with appendRule()

https://bugs.webkit.org/show_bug.cgi?id=150188

Unreviewed. This was a mistake in my review of Ryan's patch.

The CSSOM is confusing. This test was not always using a CSSKeyframesRule

object, so it should still be calling insertRule. This does produce

a console message, so added that to the expected result.

* http/tests/css/resources/shared-stylesheet-mutation.js:

(executeTests): Back to insertRule.

* http/tests/css/shared-stylesheet-mutation-expected.txt:

* http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt:

* http/tests/css/resources/shared-stylesheet-mutation.js:

(executeTests): Back to insertRule.</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>

<li><a href="#trunkLayoutTestshttptestscssresourcessharedstylesheetmutationjs">trunk/LayoutTests/http/tests/css/resources/shared-stylesheet-mutation.js</a></li>

<li><a href="#trunkLayoutTestshttptestscsssharedstylesheetmutationexpectedtxt">trunk/LayoutTests/http/tests/css/shared-stylesheet-mutation-expected.txt</a></li>

<li><a href="#trunkLayoutTestshttptestscsssharedstylesheetmutationpreconstructexpectedtxt">trunk/LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkLayoutTestsChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (191157 => 191158)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/ChangeLog        2015-10-16 00:34:38 UTC (rev 191157)

+++ trunk/LayoutTests/ChangeLog        2015-10-16 01:33:00 UTC (rev 191158)

</span><span class="lines">@@ -1,3 +1,21 @@

</span><ins>+2015-10-15  Dean Jackson  &lt;dino@apple.com&gt;

+

+        Remove deprecated function insertRule(), replace with appendRule()

+        https://bugs.webkit.org/show_bug.cgi?id=150188

+

+        Unreviewed. This was a mistake in my review of Ryan's patch.

+        The CSSOM is confusing. This test was not always using a CSSKeyframesRule

+        object, so it should still be calling insertRule. This does produce

+        a console message, so added that to the expected result.

+

+        * http/tests/css/resources/shared-stylesheet-mutation.js:

+        (executeTests): Back to insertRule.

+        * http/tests/css/shared-stylesheet-mutation-expected.txt:

+        * http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt:

+

+        * http/tests/css/resources/shared-stylesheet-mutation.js:

+        (executeTests): Back to insertRule.

+

</ins><span class="cx"> 2015-10-15  Commit Queue  &lt;commit-queue@webkit.org&gt;

</span><span class="cx"> 

<span class="cx">         Unreviewed, rolling out r191156.

</span></span></pre></div>

<a id="trunkLayoutTestshttptestscssresourcessharedstylesheetmutationjs"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/css/resources/shared-stylesheet-mutation.js (191157 => 191158)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/http/tests/css/resources/shared-stylesheet-mutation.js        2015-10-16 00:34:38 UTC (rev 191157)

+++ trunk/LayoutTests/http/tests/css/resources/shared-stylesheet-mutation.js        2015-10-16 01:33:00 UTC (rev 191158)

</span><span class="lines">@@ -77,9 +77,9 @@

</span><span class="cx"> 

</span><span class="cx">     mutationTest(0, '', 'red');

</span><span class="cx"> 

</span><del>-    mutationTest(1, 'sheet.appendRule(&quot;#testdiv { background-color: green; }&quot;, 3)', 'green');

</del><ins>+    mutationTest(1, 'sheet.insertRule(&quot;#testdiv { background-color: green; }&quot;, 3)', 'green');

</ins><span class="cx">     mutationTest(2, 'sheet.deleteRule(2)');

</span><del>-    mutationTest(3, 'sheet.cssRules[2].appendRule(&quot;#testdiv { background-color: green; }&quot;, 1)', 'green');

</del><ins>+    mutationTest(3, 'sheet.cssRules[2].insertRule(&quot;#testdiv { background-color: green; }&quot;, 1)', 'green');

</ins><span class="cx">     mutationTest(4, 'sheet.cssRules[2].deleteRule(0)', 'green');

</span><span class="cx">     mutationTest(5, 'sheet.cssRules[2].cssRules[0].style.setProperty(&quot;background-color&quot;, &quot;green&quot;, &quot;&quot;)', 'green');

</span><span class="cx">     mutationTest(6, 'sheet.cssRules[2].cssRules[0].style.removeProperty(&quot;background-color&quot;)', 'green');

</span><span class="lines">@@ -95,7 +95,7 @@

</span><span class="cx">     

</span><span class="cx">     var testString = '\

</span><span class="cx">         sheet.deleteRule(3);\

</span><del>-        sheet.appendRule(&quot;#testdiv { background-color: green; }&quot;, 1);\

</del><ins>+        sheet.insertRule(&quot;#testdiv { background-color: green; }&quot;, 1);\

</ins><span class="cx">         sheet.deleteRule(2);\

</span><span class="cx">         sheet.deleteRule(0);\

</span><span class="cx">         sheet.deleteRule(3);\

</span><span class="lines">@@ -105,10 +105,10 @@

</span><span class="cx">     mutationTest(11, testString, 'green');

</span><span class="cx"> 

</span><span class="cx">     var importRule = '@import &quot;data:text/css;charset=utf-8,%23testdiv%7Bbackground-color%3Agreen%20!important%7D&quot;;';

</span><del>-    mutationTest(12, &quot;sheet.appendRule('&quot;+importRule+&quot;', 1)&quot;, 'green');

</del><ins>+    mutationTest(12, &quot;sheet.insertRule('&quot;+importRule+&quot;', 1)&quot;, 'green');

</ins><span class="cx"> 

</span><span class="cx">     mutationTest(13, 'sheet.cssRules[3].selectorText = &quot;foo&quot;', 'red');

</span><del>-    mutationTest(14, 'sheet.cssRules[4].appendRule(&quot;40% { left: 40px; }&quot;)', 'red');

</del><ins>+    mutationTest(14, 'sheet.cssRules[4].insertRule(&quot;40% { left: 40px; }&quot;)', 'red');

</ins><span class="cx">     mutationTest(15, 'sheet.cssRules[4].deleteRule(&quot;100%&quot;)', 'red');

</span><span class="cx">     mutationTest(16, 'sheet.cssRules[5].style.setProperty(&quot;font-family&quot;, &quot;Bar&quot;, &quot;&quot;)', 'red');

</span><span class="cx"> 

</span></span></pre></div>

<a id="trunkLayoutTestshttptestscsssharedstylesheetmutationexpectedtxt"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/css/shared-stylesheet-mutation-expected.txt (191157 => 191158)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/http/tests/css/shared-stylesheet-mutation-expected.txt        2015-10-16 00:34:38 UTC (rev 191157)

+++ trunk/LayoutTests/http/tests/css/shared-stylesheet-mutation-expected.txt        2015-10-16 01:33:00 UTC (rev 191158)

</span><span class="lines">@@ -1,3 +1,4 @@

<ins>+CONSOLE MESSAGE: line 1: CSSKeyframesRule 'insertRule' function is deprecated.  Use 'appendRule' instead.

</ins><span class="cx"> The test loads the same stylesheet to different frames and then mutates them. The mutations should not affect other frames.

</span><span class="cx"> 

<span class="cx"> On success, you will see a series of &quot;PASS&quot; messages, followed by &quot;TEST COMPLETE&quot;.

</span></span></pre></div>

<a id="trunkLayoutTestshttptestscsssharedstylesheetmutationpreconstructexpectedtxt"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt (191157 => 191158)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt        2015-10-16 00:34:38 UTC (rev 191157)

+++ trunk/LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt        2015-10-16 01:33:00 UTC (rev 191158)

</span><span class="lines">@@ -1,3 +1,4 @@

<ins>+CONSOLE MESSAGE: line 1: CSSKeyframesRule 'insertRule' function is deprecated.  Use 'appendRule' instead.

</ins><span class="cx"> The test loads the same stylesheet to different frames and then mutates them. The mutations should not affect other frames.

</span><span class="cx"> 

<span class="cx"> On success, you will see a series of &quot;PASS&quot; messages, followed by &quot;TEST COMPLETE&quot;.

</span></span></pre>

</div>

</div>

</body>

</html>