<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191140] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191140">191140</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2015-10-15 14:59:24 -0700 (Thu, 15 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Cocoa] Stop using WKSetNSURLConnectionDefersCallbacks
https://bugs.webkit.org/show_bug.cgi?id=150189
Reviewed by Anders Carlsson.
Source/WebCore:
* platform/ios/WebCoreSystemInterfaceIOS.mm: Removed definition.
* platform/mac/WebCoreSystemInterface.h: Removed declaration.
* platform/mac/WebCoreSystemInterface.mm: Removed definition.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start): Changed to use -[NSURLConnection setDefersLoading:].
(WebCore::ResourceHandle::platformSetDefersLoading): Ditto.
* platform/spi/cocoa/NSURLConnectionSPI.h: Added declaration of
-[NSURLConnection setDefersLoading:].
Source/WebKit/mac:
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Removed initialization.
Source/WebKit2:
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Removed initialization.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformiosWebCoreSystemInterfaceIOSmm">trunk/Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformmacWebCoreSystemInterfaceh">trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h</a></li>
<li><a href="#trunkSourceWebCoreplatformmacWebCoreSystemInterfacemm">trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkmacResourceHandleMacmm">trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformspicocoaNSURLConnectionSPIh">trunk/Source/WebCore/platform/spi/cocoa/NSURLConnectionSPI.h</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebSystemInterfacemm">trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportmacWebSystemInterfacemm">trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (191139 => 191140)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-10-15 21:52:05 UTC (rev 191139)
+++ trunk/Source/WebCore/ChangeLog 2015-10-15 21:59:24 UTC (rev 191140)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-10-15 Dan Bernstein <mitz@apple.com>
+
+ [Cocoa] Stop using WKSetNSURLConnectionDefersCallbacks
+ https://bugs.webkit.org/show_bug.cgi?id=150189
+
+ Reviewed by Anders Carlsson.
+
+ * platform/ios/WebCoreSystemInterfaceIOS.mm: Removed definition.
+ * platform/mac/WebCoreSystemInterface.h: Removed declaration.
+ * platform/mac/WebCoreSystemInterface.mm: Removed definition.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::start): Changed to use -[NSURLConnection setDefersLoading:].
+ (WebCore::ResourceHandle::platformSetDefersLoading): Ditto.
+
+ * platform/spi/cocoa/NSURLConnectionSPI.h: Added declaration of
+ -[NSURLConnection setDefersLoading:].
+
</ins><span class="cx"> 2015-10-15 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> CSSKeyframesRule::appendRule is deprecated, but is actually the spec
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformiosWebCoreSystemInterfaceIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm (191139 => 191140)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm 2015-10-15 21:52:05 UTC (rev 191139)
+++ trunk/Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm 2015-10-15 21:59:24 UTC (rev 191140)
</span><span class="lines">@@ -38,7 +38,6 @@
</span><span class="cx"> WEBCORE_EXPORT CGAffineTransform (*wkGetUserToBaseCTM)(CGContextRef);
</span><span class="cx"> WEBCORE_EXPORT bool (*wkCGContextIsPDFContext)(CGContextRef);
</span><span class="cx"> WEBCORE_EXPORT NSString* (*wkCopyNSURLResponseStatusLine)(NSURLResponse*);
</span><del>-WEBCORE_EXPORT void (*wkSetNSURLConnectionDefersCallbacks)(NSURLConnection *, BOOL);
</del><span class="cx"> WEBCORE_EXPORT void (*wkSetNSURLRequestShouldContentSniff)(NSMutableURLRequest *, BOOL);
</span><span class="cx"> WEBCORE_EXPORT id (*wkCreateNSURLConnectionDelegateProxy)(void);
</span><span class="cx"> WEBCORE_EXPORT unsigned (*wkInitializeMaximumHTTPConnectionCountPerHost)(unsigned preferredConnectionCount);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmacWebCoreSystemInterfaceh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h (191139 => 191140)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h 2015-10-15 21:52:05 UTC (rev 191139)
+++ trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h 2015-10-15 21:59:24 UTC (rev 191140)
</span><span class="lines">@@ -197,7 +197,6 @@
</span><span class="cx"> extern void (*wkSetCookieStoragePrivateBrowsingEnabled)(BOOL);
</span><span class="cx"> extern void (*wkSetDragImage)(NSImage*, NSPoint offset);
</span><span class="cx"> #endif
</span><del>-extern void (*wkSetNSURLConnectionDefersCallbacks)(NSURLConnection *, BOOL);
</del><span class="cx"> extern void (*wkSetNSURLRequestShouldContentSniff)(NSMutableURLRequest *, BOOL);
</span><span class="cx"> extern void (*wkSetBaseCTM)(CGContextRef, CGAffineTransform);
</span><span class="cx"> extern void (*wkSetPatternPhaseInUserSpace)(CGContextRef, CGPoint);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmacWebCoreSystemInterfacemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm (191139 => 191140)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm 2015-10-15 21:52:05 UTC (rev 191139)
+++ trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm 2015-10-15 21:59:24 UTC (rev 191140)
</span><span class="lines">@@ -81,7 +81,6 @@
</span><span class="cx"> void (*wkSetPatternPhaseInUserSpace)(CGContextRef, CGPoint point);
</span><span class="cx"> CGAffineTransform (*wkGetUserToBaseCTM)(CGContextRef);
</span><span class="cx"> bool (*wkCGContextIsPDFContext)(CGContextRef);
</span><del>-void (*wkSetNSURLConnectionDefersCallbacks)(NSURLConnection *, BOOL);
</del><span class="cx"> void (*wkSetNSURLRequestShouldContentSniff)(NSMutableURLRequest *, BOOL);
</span><span class="cx"> unsigned (*wkInitializeMaximumHTTPConnectionCountPerHost)(unsigned preferredConnectionCount);
</span><span class="cx"> int (*wkGetHTTPRequestPriority)(CFURLRequestRef);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkmacResourceHandleMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm (191139 => 191140)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2015-10-15 21:52:05 UTC (rev 191139)
+++ trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2015-10-15 21:59:24 UTC (rev 191140)
</span><span class="lines">@@ -297,7 +297,7 @@
</span><span class="cx">
</span><span class="cx"> if (d->m_connection) {
</span><span class="cx"> if (d->m_defersLoading)
</span><del>- wkSetNSURLConnectionDefersCallbacks(connection(), YES);
</del><ins>+ connection().defersCallbacks = YES;
</ins><span class="cx">
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -321,7 +321,7 @@
</span><span class="cx"> void ResourceHandle::platformSetDefersLoading(bool defers)
</span><span class="cx"> {
</span><span class="cx"> if (d->m_connection)
</span><del>- wkSetNSURLConnectionDefersCallbacks(d->m_connection.get(), defers);
</del><ins>+ [d->m_connection setDefersCallbacks:defers];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(MAC)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformspicocoaNSURLConnectionSPIh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/spi/cocoa/NSURLConnectionSPI.h (191139 => 191140)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/spi/cocoa/NSURLConnectionSPI.h 2015-10-15 21:52:05 UTC (rev 191139)
+++ trunk/Source/WebCore/platform/spi/cocoa/NSURLConnectionSPI.h 2015-10-15 21:59:24 UTC (rev 191140)
</span><span class="lines">@@ -31,6 +31,7 @@
</span><span class="cx">
</span><span class="cx"> @interface NSURLConnection ()
</span><span class="cx"> + (CFRunLoopRef)resourceLoaderRunLoop;
</span><ins>+- (void)setDefersCallbacks:(BOOL)defers;
</ins><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (191139 => 191140)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2015-10-15 21:52:05 UTC (rev 191139)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-10-15 21:59:24 UTC (rev 191140)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-10-15 Dan Bernstein <mitz@apple.com>
+
+ [Cocoa] Stop using WKSetNSURLConnectionDefersCallbacks
+ https://bugs.webkit.org/show_bug.cgi?id=150189
+
+ Reviewed by Anders Carlsson.
+
+ * WebCoreSupport/WebSystemInterface.mm:
+ (InitWebCoreSystemInterface): Removed initialization.
+
</ins><span class="cx"> 2015-10-14 Zhuo Li <zachli@apple.com>
</span><span class="cx">
</span><span class="cx"> Augment <input type=search>’s recent search history with the time each entry was added,
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebSystemInterfacemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm (191139 => 191140)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm 2015-10-15 21:52:05 UTC (rev 191139)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm 2015-10-15 21:59:24 UTC (rev 191140)
</span><span class="lines">@@ -94,7 +94,6 @@
</span><span class="cx"> INIT(SetHTTPRequestPriority);
</span><span class="cx"> INIT(SetHTTPRequestMinimumFastLanePriority);
</span><span class="cx"> INIT(HTTPRequestEnablePipelining);
</span><del>- INIT(SetNSURLConnectionDefersCallbacks);
</del><span class="cx"> INIT(SetNSURLRequestShouldContentSniff);
</span><span class="cx"> INIT(SetPatternPhaseInUserSpace);
</span><span class="cx"> INIT(CGContextIsPDFContext);
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (191139 => 191140)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-10-15 21:52:05 UTC (rev 191139)
+++ trunk/Source/WebKit2/ChangeLog 2015-10-15 21:59:24 UTC (rev 191140)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-10-15 Dan Bernstein <mitz@apple.com>
+
+ [Cocoa] Stop using WKSetNSURLConnectionDefersCallbacks
+ https://bugs.webkit.org/show_bug.cgi?id=150189
+
+ Reviewed by Anders Carlsson.
+
+ * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
+ (InitWebCoreSystemInterface): Removed initialization.
+
</ins><span class="cx"> 2015-10-15 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix build.
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportmacWebSystemInterfacemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm (191139 => 191140)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm 2015-10-15 21:52:05 UTC (rev 191139)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm 2015-10-15 21:59:24 UTC (rev 191140)
</span><span class="lines">@@ -100,7 +100,6 @@
</span><span class="cx"> INIT(SetHTTPRequestMaximumPriority);
</span><span class="cx"> INIT(SetHTTPRequestPriority);
</span><span class="cx"> INIT(SetHTTPRequestMinimumFastLanePriority);
</span><del>- INIT(SetNSURLConnectionDefersCallbacks);
</del><span class="cx"> INIT(SetNSURLRequestShouldContentSniff);
</span><span class="cx"> INIT(SetPatternPhaseInUserSpace);
</span><span class="cx"> INIT(CreatePrivateStorageSession);
</span></span></pre>
</div>
</div>
</body>
</html>