<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191081] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191081">191081</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-10-14 20:53:49 -0700 (Wed, 14 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION: Web Inspector hangs for many seconds when trying to reload page
https://bugs.webkit.org/show_bug.cgi?id=150065
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-14
Reviewed by Mark Lam.
When debugging Web Pages, the same Debugger (PageScriptDebugServer) is
attached to each of the different JSGlobalObjects on the page. This could
mean multiple frames or isolated scripting contexts. Therefore we should
only need to send sourceParsed events to the frontend for scripts within
this new JSGlobalObject, not any JSGlobalObject that has this debugger.
* debugger/Debugger.cpp:
(JSC::Debugger::attach):
Only send sourceParsed events for Scripts in this JSGlobalObject.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredebuggerDebuggercpp">trunk/Source/JavaScriptCore/debugger/Debugger.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (191080 => 191081)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-10-15 01:21:19 UTC (rev 191080)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-10-15 03:53:49 UTC (rev 191081)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2015-10-14 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ REGRESSION: Web Inspector hangs for many seconds when trying to reload page
+ https://bugs.webkit.org/show_bug.cgi?id=150065
+
+ Reviewed by Mark Lam.
+
+ When debugging Web Pages, the same Debugger (PageScriptDebugServer) is
+ attached to each of the different JSGlobalObjects on the page. This could
+ mean multiple frames or isolated scripting contexts. Therefore we should
+ only need to send sourceParsed events to the frontend for scripts within
+ this new JSGlobalObject, not any JSGlobalObject that has this debugger.
+
+ * debugger/Debugger.cpp:
+ (JSC::Debugger::attach):
+ Only send sourceParsed events for Scripts in this JSGlobalObject.
+
+2015-10-14 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Remove unimplemented methods in CopiedSpace
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=150143
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredebuggerDebuggercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/debugger/Debugger.cpp (191080 => 191081)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/debugger/Debugger.cpp 2015-10-15 01:21:19 UTC (rev 191080)
+++ trunk/Source/JavaScriptCore/debugger/Debugger.cpp 2015-10-15 03:53:49 UTC (rev 191081)
</span><span class="lines">@@ -41,10 +41,10 @@
</span><span class="cx">
</span><span class="cx"> struct GatherSourceProviders : public MarkedBlock::VoidFunctor {
</span><span class="cx"> HashSet<SourceProvider*> sourceProviders;
</span><del>- JSC::Debugger* m_debugger;
</del><ins>+ JSGlobalObject* m_globalObject;
</ins><span class="cx">
</span><del>- GatherSourceProviders(JSC::Debugger* debugger)
- : m_debugger(debugger) { }
</del><ins>+ GatherSourceProviders(JSGlobalObject* globalObject)
+ : m_globalObject(globalObject) { }
</ins><span class="cx">
</span><span class="cx"> IterationStatus operator()(JSCell* cell)
</span><span class="cx"> {
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx"> if (!function)
</span><span class="cx"> return IterationStatus::Continue;
</span><span class="cx">
</span><del>- if (function->scope()->globalObject()->debugger() != m_debugger)
</del><ins>+ if (function->scope()->globalObject() != m_globalObject)
</ins><span class="cx"> return IterationStatus::Continue;
</span><span class="cx">
</span><span class="cx"> if (!function->executable()->isFunctionExecutable())
</span><span class="lines">@@ -143,8 +143,8 @@
</span><span class="cx"> globalObject->setDebugger(this);
</span><span class="cx"> m_globalObjects.add(globalObject);
</span><span class="cx">
</span><del>- // Call sourceParsed() because it will execute JavaScript in the inspector.
- GatherSourceProviders gatherSourceProviders(this);
</del><ins>+ // Call sourceParsed because it will execute JavaScript in the inspector.
+ GatherSourceProviders gatherSourceProviders(globalObject);
</ins><span class="cx"> {
</span><span class="cx"> HeapIterationScope iterationScope(m_vm.heap);
</span><span class="cx"> m_vm.heap.objectSpace().forEachLiveCell(iterationScope, gatherSourceProviders);
</span></span></pre>
</div>
</div>
</body>
</html>