<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191078] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191078">191078</a></dd>
<dt>Author</dt> <dd>aestes@apple.com</dd>
<dt>Date</dt> <dd>2015-10-14 17:57:38 -0700 (Wed, 14 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[iOS] build-dumprendertree does not build ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=150152
Reviewed by Tim Horton.
run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
WebKit.xcworkspace), tests that rely on image diffing won't work properly.
There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
fine on that platform, and results in ImageDiff being built.
* Scripts/build-dumprendertree:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptsbuilddumprendertree">trunk/Tools/Scripts/build-dumprendertree</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (191077 => 191078)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-10-15 00:52:23 UTC (rev 191077)
+++ trunk/Tools/ChangeLog 2015-10-15 00:57:38 UTC (rev 191078)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-10-14 Andy Estes <aestes@apple.com>
+
+ [iOS] build-dumprendertree does not build ImageDiff
+ https://bugs.webkit.org/show_bug.cgi?id=150152
+
+ Reviewed by Tim Horton.
+
+ run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
+ On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
+ as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
+ WebKit.xcworkspace), tests that rely on image diffing won't work properly.
+
+ There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
+ fine on that platform, and results in ImageDiff being built.
+
+ * Scripts/build-dumprendertree:
+
</ins><span class="cx"> 2015-10-14 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win] Enforce launcher/library naming scheme
</span></span></pre></div>
<a id="trunkToolsScriptsbuilddumprendertree"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/build-dumprendertree (191077 => 191078)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/build-dumprendertree 2015-10-15 00:52:23 UTC (rev 191077)
+++ trunk/Tools/Scripts/build-dumprendertree 2015-10-15 00:57:38 UTC (rev 191078)
</span><span class="lines">@@ -65,8 +65,7 @@
</span><span class="cx">
</span><span class="cx"> my $result;
</span><span class="cx"> if (isAppleMacWebKit()) {
</span><del>- my @target = isIOSWebKit() ? ("-target", "DumpRenderTree.app") : ();
- $result = buildXCodeProject("DumpRenderTree", $clean, XcodeOptions(), (@ARGV, @target));
</del><ins>+ $result = buildXCodeProject("DumpRenderTree", $clean, XcodeOptions(), @ARGV);
</ins><span class="cx"> } elsif (isGtk() || isEfl() || isAnyWindows()) {
</span><span class="cx"> # Gtk, EFL, and Windows build everything in one shot. No need to build anything here.
</span><span class="cx"> $result = 0;
</span></span></pre>
</div>
</div>
</body>
</html>