<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191064] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191064">191064</a></dd>
<dt>Author</dt> <dd>dino@apple.com</dd>
<dt>Date</dt> <dd>2015-10-14 13:05:02 -0700 (Wed, 14 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Implement CanvasRenderingContext2D::commit
https://bugs.webkit.org/show_bug.cgi?id=150110
<rdar://problem/23057398>
Reviewed by Anders Carlsson.
Source/WebCore:
As part of getting as close as possible to the HTML5 specification,
implement the commit() method on 2d canvas, even though it doesn't
do anything.
Test: fast/canvas/commit.html
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2D::commit): Intercept it here to
avoid adding a method to the actual implementation.
* html/canvas/CanvasRenderingContext2D.idl: Add commit.
LayoutTests:
* fast/canvas/commit-expected.txt: Added.
* fast/canvas/commit.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSCanvasRenderingContext2DCustomcpp">trunk/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasCanvasRenderingContext2Didl">trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcanvascommitexpectedtxt">trunk/LayoutTests/fast/canvas/commit-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcanvascommithtml">trunk/LayoutTests/fast/canvas/commit.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (191063 => 191064)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-10-14 20:03:14 UTC (rev 191063)
+++ trunk/LayoutTests/ChangeLog 2015-10-14 20:05:02 UTC (rev 191064)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-10-14 Dean Jackson <dino@apple.com>
+
+ Implement CanvasRenderingContext2D::commit
+ https://bugs.webkit.org/show_bug.cgi?id=150110
+ <rdar://problem/23057398>
+
+ Reviewed by Anders Carlsson.
+
+ * fast/canvas/commit-expected.txt: Added.
+ * fast/canvas/commit.html: Added.
+
</ins><span class="cx"> 2015-10-14 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Add SPI for reloading without content blockers
</span></span></pre></div>
<a id="trunkLayoutTestsfastcanvascommitexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/canvas/commit-expected.txt (0 => 191064)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/canvas/commit-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/canvas/commit-expected.txt 2015-10-14 20:05:02 UTC (rev 191064)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+PASS
+
+
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/canvas/commit-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="svnkeywords"></a>
<div class="addfile"><h4>Added: svn:keywords</h4></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<a id="trunkLayoutTestsfastcanvascommithtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/canvas/commit.html (0 => 191064)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/canvas/commit.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/commit.html 2015-10-14 20:05:02 UTC (rev 191064)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+<script>
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+window.addEventListener("load", function () {
+ var output = document.querySelector("p");
+ var canvas = document.querySelector("canvas");
+ var context = canvas.getContext("2d");
+
+ if ("commit" in context)
+ output.textContent = "PASS";
+ else
+ output.textContent = "FAIL";
+}, false);
+
+</script>
+<p></p>
+<canvas></canvas>
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/canvas/commit.html
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="svnkeywords"></a>
<div class="addfile"><h4>Added: svn:keywords</h4></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (191063 => 191064)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-10-14 20:03:14 UTC (rev 191063)
+++ trunk/Source/WebCore/ChangeLog 2015-10-14 20:05:02 UTC (rev 191064)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2015-10-14 Dean Jackson <dino@apple.com>
+
+ Implement CanvasRenderingContext2D::commit
+ https://bugs.webkit.org/show_bug.cgi?id=150110
+ <rdar://problem/23057398>
+
+ Reviewed by Anders Carlsson.
+
+ As part of getting as close as possible to the HTML5 specification,
+ implement the commit() method on 2d canvas, even though it doesn't
+ do anything.
+
+ Test: fast/canvas/commit.html
+
+ * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+ (WebCore::JSCanvasRenderingContext2D::commit): Intercept it here to
+ avoid adding a method to the actual implementation.
+ * html/canvas/CanvasRenderingContext2D.idl: Add commit.
+
</ins><span class="cx"> 2015-10-14 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Add SPI for reloading without content blockers
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSCanvasRenderingContext2DCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp (191063 => 191064)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp 2015-10-14 20:03:14 UTC (rev 191063)
+++ trunk/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp 2015-10-14 20:05:02 UTC (rev 191064)
</span><span class="lines">@@ -59,6 +59,12 @@
</span><span class="cx"> return CanvasStyle();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+JSValue JSCanvasRenderingContext2D::commit(ExecState&)
+{
+ // This is a no-op in a direct-2d canvas.
+ return jsUndefined();
+}
+
</ins><span class="cx"> JSValue JSCanvasRenderingContext2D::strokeStyle(ExecState& state) const
</span><span class="cx"> {
</span><span class="cx"> return toJS(&state, globalObject(), impl().strokeStyle());
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasCanvasRenderingContext2Didl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl (191063 => 191064)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl 2015-10-14 20:03:14 UTC (rev 191063)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl 2015-10-14 20:05:02 UTC (rev 191064)
</span><span class="lines">@@ -31,6 +31,8 @@
</span><span class="cx"> void save();
</span><span class="cx"> void restore();
</span><span class="cx">
</span><ins>+ [Custom] void commit();
+
</ins><span class="cx"> void scale(unrestricted float sx, unrestricted float sy);
</span><span class="cx"> void rotate(unrestricted float angle);
</span><span class="cx"> void translate(unrestricted float tx, unrestricted float ty);
</span></span></pre>
</div>
</div>
</body>
</html>