<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190976] releases/WebKitGTK/webkit-2.10</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190976">190976</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-10-13 05:01:53 -0700 (Tue, 13 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/190820">r190820</a> - Garbage texture data with composited table row
https://bugs.webkit.org/show_bug.cgi?id=148984
Reviewed by Zalan Bujtas.
Source/WebCore:
Don't pretend to know if the layer for a table header, section or cell is
opaque, since table painting is special.
Test: compositing/contents-opaque/table-parts.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
* compositing/contents-opaque/table-parts-expected.txt: Added.
* compositing/contents-opaque/table-parts.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit210SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit210SourceWebCorerenderingRenderLayercpp">releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderLayer.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestscompositingcontentsopaquetablepartsexpectedtxt">releases/WebKitGTK/webkit-2.10/LayoutTests/compositing/contents-opaque/table-parts-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestscompositingcontentsopaquetablepartshtml">releases/WebKitGTK/webkit-2.10/LayoutTests/compositing/contents-opaque/table-parts.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit210LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog (190975 => 190976)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog 2015-10-13 12:00:54 UTC (rev 190975)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog 2015-10-13 12:01:53 UTC (rev 190976)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2015-10-09 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ Garbage texture data with composited table row
+ https://bugs.webkit.org/show_bug.cgi?id=148984
+
+ Reviewed by Zalan Bujtas.
+
+ * compositing/contents-opaque/table-parts-expected.txt: Added.
+ * compositing/contents-opaque/table-parts.html: Added.
+
+2015-10-09 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> Garbage pixels on enphaseenergy.com site
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149915
</span><span class="cx"> rdar://problem/22976184
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit210LayoutTestscompositingcontentsopaquetablepartsexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.10/LayoutTests/compositing/contents-opaque/table-parts-expected.txt (0 => 190976)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/compositing/contents-opaque/table-parts-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/compositing/contents-opaque/table-parts-expected.txt 2015-10-13 12:01:53 UTC (rev 190976)
</span><span class="lines">@@ -0,0 +1,25 @@
</span><ins>+Table cell
+Table cell
+(GraphicsLayer
+ (anchor 0.00 0.00)
+ (bounds 800.00 600.00)
+ (children 1
+ (GraphicsLayer
+ (bounds 800.00 600.00)
+ (contentsOpaque 1)
+ (children 2
+ (GraphicsLayer
+ (position 28.00 20.00)
+ (bounds 252.00 102.00)
+ (drawsContent 1)
+ )
+ (GraphicsLayer
+ (position 28.00 142.00)
+ (bounds 252.00 102.00)
+ (drawsContent 1)
+ )
+ )
+ )
+ )
+)
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit210LayoutTestscompositingcontentsopaquetablepartshtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.10/LayoutTests/compositing/contents-opaque/table-parts.html (0 => 190976)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/compositing/contents-opaque/table-parts.html (rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/compositing/contents-opaque/table-parts.html 2015-10-13 12:01:53 UTC (rev 190976)
</span><span class="lines">@@ -0,0 +1,55 @@
</span><ins>+<!DOCTYPE html>
+
+<html>
+<head>
+ <style>
+
+ table {
+ border-collapse: collapse;
+ margin: 20px;
+ }
+
+ tr {
+ background-color: silver;
+ border-right: 100px solid gray;
+ }
+
+ td {
+ width: 200px;
+ height: 100px;
+ }
+
+ .composited {
+ -webkit-transform: translateZ(0);
+ }
+
+ td.composited {
+ background-color: silver;
+ }
+ </style>
+ <script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
+ function doTest() {
+ if (window.testRunner && window.internals)
+ document.getElementById('layertree').innerText = window.internals.layerTreeAsText(document);
+ }
+ window.addEventListener('load', doTest, false);
+ </script>
+</head>
+<body>
+<table>
+ <tr class="composited">
+ <td>Table cell</td>
+ </tr>
+</table>
+
+<table>
+ <tr>
+ <td class="composited">Table cell</td>
+ </tr>
+</table>
+<pre id="layertree"></pre>
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit210SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (190975 => 190976)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog 2015-10-13 12:00:54 UTC (rev 190975)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog 2015-10-13 12:01:53 UTC (rev 190976)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2015-10-09 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ Garbage texture data with composited table row
+ https://bugs.webkit.org/show_bug.cgi?id=148984
+
+ Reviewed by Zalan Bujtas.
+
+ Don't pretend to know if the layer for a table header, section or cell is
+ opaque, since table painting is special.
+
+ Test: compositing/contents-opaque/table-parts.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
+
+2015-10-09 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> Garbage pixels on enphaseenergy.com site
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149915
</span><span class="cx"> rdar://problem/22976184
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit210SourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderLayer.cpp (190975 => 190976)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderLayer.cpp 2015-10-13 12:00:54 UTC (rev 190975)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/rendering/RenderLayer.cpp 2015-10-13 12:01:53 UTC (rev 190976)
</span><span class="lines">@@ -6143,6 +6143,10 @@
</span><span class="cx"> if (m_zOrderListsDirty || m_normalFlowListDirty)
</span><span class="cx"> return false;
</span><span class="cx">
</span><ins>+ // Table painting is special; a table paints its sections.
+ if (renderer().isTablePart())
+ return false;
+
</ins><span class="cx"> // FIXME: We currently only check the immediate renderer,
</span><span class="cx"> // which will miss many cases.
</span><span class="cx"> if (renderer().backgroundIsKnownToBeOpaqueInRect(localRect))
</span></span></pre>
</div>
</div>
</body>
</html>