<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[191002] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191002">191002</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-10-13 12:15:55 -0700 (Tue, 13 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Avoid useless copies in range-loops that are using 'auto'
https://bugs.webkit.org/show_bug.cgi?id=150091
Reviewed by Sam Weinig.
Avoid useless copies in range-loops that are using 'auto'. Also use
'auto*' instead of 'auto' when range values are pointers for clarity.
Source/bmalloc:
* bmalloc/Deallocator.cpp:
(bmalloc::Deallocator::processObjectLog):
Source/WebKit/mac:
* WebView/WebFrame.mm:
(-[WebFrame getDictationResultRanges:andMetadatas:]):
Source/WebKit2:
* UIProcess/VisitedLinkStore.cpp:
(WebKit::VisitedLinkStore::pendingVisitedLinksTimerFired):
(WebKit::VisitedLinkStore::resizeTable):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::releaseRemainingIconsForPageURLs):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::plugins):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityTablecpp">trunk/Source/WebCore/accessibility/AccessibilityTable.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityTreecpp">trunk/Source/WebCore/accessibility/AccessibilityTree.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSParsercpp">trunk/Source/WebCore/css/CSSParser.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomPositioncpp">trunk/Source/WebCore/dom/Position.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderappcacheApplicationCacheStoragecpp">trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDragControllercpp">trunk/Source/WebCore/page/DragController.cpp</a></li>
<li><a href="#trunkSourceWebCorepageanimationCompositeAnimationcpp">trunk/Source/WebCore/page/animation/CompositeAnimation.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformaudioPlatformMediaSessionManagercpp">trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsFontCachecpp">trunk/Source/WebCore/platform/graphics/FontCache.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsPathUtilitiescpp">trunk/Source/WebCore/platform/graphics/PathUtilities.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationobjcMediaPlayerPrivateMediaStreamAVFObjCmm">trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscaGraphicsLayerCAcpp">trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformiosWebVideoFullscreenModelVideoElementmm">trunk/Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformmediastreamRealtimeMediaSourcecpp">trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingInlineFlowBoxcpp">trunk/Source/WebCore/rendering/InlineFlowBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockcpp">trunk/Source/WebCore/rendering/RenderBlock.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockFlowcpp">trunk/Source/WebCore/rendering/RenderBlockFlow.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxcpp">trunk/Source/WebCore/rendering/RenderBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderInlinecpp">trunk/Source/WebCore/rendering/RenderInline.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjectcpp">trunk/Source/WebCore/rendering/RenderObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTextLineBoxescpp">trunk/Source/WebCore/rendering/RenderTextLineBoxes.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTreeAsTextcpp">trunk/Source/WebCore/rendering/RenderTreeAsText.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgSVGTextMetricsBuildercpp">trunk/Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGSVGElementcpp">trunk/Source/WebCore/svg/SVGSVGElement.cpp</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebFramemm">trunk/Source/WebKit/mac/WebView/WebFrame.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessVisitedLinkStorecpp">trunk/Source/WebKit2/UIProcess/VisitedLinkStore.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessProxycpp">trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebsiteDataWebsiteDataStorecpp">trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp</a></li>
<li><a href="#trunkSourcebmallocChangeLog">trunk/Source/bmalloc/ChangeLog</a></li>
<li><a href="#trunkSourcebmallocbmallocDeallocatorcpp">trunk/Source/bmalloc/bmalloc/Deallocator.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/ChangeLog 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-10-13 Chris Dumez <cdumez@apple.com>
+
+ Avoid useless copies in range-loops that are using 'auto'
+ https://bugs.webkit.org/show_bug.cgi?id=150091
+
+ Reviewed by Sam Weinig.
+
+ Avoid useless copies in range-loops that are using 'auto'. Also use
+ 'auto*' instead of 'auto' when range values are pointers for clarity.
+
</ins><span class="cx"> 2015-10-13 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Move Image::drawPattern for CG into GraphicsContext
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityTablecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityTable.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -474,7 +474,7 @@
</span><span class="cx"> addTableCellChild(obj, appendedRows, maxColumnCount);
</span><span class="cx"> continue;
</span><span class="cx"> }
</span><del>- for (auto child = obj->firstChild(); child; child = child->nextSibling())
</del><ins>+ for (auto* child = obj->firstChild(); child; child = child->nextSibling())
</ins><span class="cx"> queue.append(child);
</span><span class="cx"> }
</span><span class="cx"> } else
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityTreecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityTree.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityTree.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/accessibility/AccessibilityTree.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -77,7 +77,7 @@
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> Deque<Node*> queue;
</span><del>- for (auto child = node->firstChild(); child; child = child->nextSibling())
</del><ins>+ for (auto* child = node->firstChild(); child; child = child->nextSibling())
</ins><span class="cx"> queue.append(child);
</span><span class="cx">
</span><span class="cx"> while (!queue.isEmpty()) {
</span><span class="lines">@@ -90,7 +90,7 @@
</span><span class="cx"> if (!nodeHasRole(child, "group"))
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- for (auto groupChild = child->firstChild(); groupChild; groupChild = groupChild->nextSibling())
</del><ins>+ for (auto* groupChild = child->firstChild(); groupChild; groupChild = groupChild->nextSibling())
</ins><span class="cx"> queue.append(groupChild);
</span><span class="cx"> }
</span><span class="cx"> return true;
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParser.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParser.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -10013,7 +10013,7 @@
</span><span class="cx"> {
</span><span class="cx"> // The filter is a list of functional primitives that specify individual operations.
</span><span class="cx"> RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
</span><del>- for (auto value = valueList.current(); value; value = valueList.next()) {
</del><ins>+ for (auto* value = valueList.current(); value; value = valueList.next()) {
</ins><span class="cx"> if (value->unit != CSSPrimitiveValue::CSS_URI && (value->unit != CSSParserValue::Function || !value->function))
</span><span class="cx"> return false;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/dom/Document.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -2328,7 +2328,7 @@
</span><span class="cx"> if (!m_clientToIDMap.isEmpty() && page()) {
</span><span class="cx"> Vector<WebCore::MediaPlaybackTargetClient*> clients;
</span><span class="cx"> copyKeysToVector(m_clientToIDMap, clients);
</span><del>- for (auto client : clients)
</del><ins>+ for (auto* client : clients)
</ins><span class="cx"> removePlaybackTargetPickerClient(*client);
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="lines">@@ -3545,7 +3545,7 @@
</span><span class="cx"> void Document::updateIsPlayingMedia(uint64_t sourceElementID)
</span><span class="cx"> {
</span><span class="cx"> MediaProducer::MediaStateFlags state = MediaProducer::IsNotPlaying;
</span><del>- for (auto audioProducer : m_audioProducers)
</del><ins>+ for (auto* audioProducer : m_audioProducers)
</ins><span class="cx"> state |= audioProducer->mediaState();
</span><span class="cx">
</span><span class="cx"> #if ENABLE(MEDIA_SESSION)
</span><span class="lines">@@ -3575,7 +3575,7 @@
</span><span class="cx">
</span><span class="cx"> void Document::pageMutedStateDidChange()
</span><span class="cx"> {
</span><del>- for (auto audioProducer : m_audioProducers)
</del><ins>+ for (auto* audioProducer : m_audioProducers)
</ins><span class="cx"> audioProducer->pageMutedStateDidChange();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomPositioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Position.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Position.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/dom/Position.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -710,7 +710,7 @@
</span><span class="cx">
</span><span class="cx"> unsigned textOffset = currentPos.offsetInLeafNode();
</span><span class="cx"> auto lastTextBox = textRenderer.lastTextBox();
</span><del>- for (auto box = textRenderer.firstTextBox(); box; box = box->nextTextBox()) {
</del><ins>+ for (auto* box = textRenderer.firstTextBox(); box; box = box->nextTextBox()) {
</ins><span class="cx"> if (textOffset <= box->start() + box->len()) {
</span><span class="cx"> if (textOffset > box->start())
</span><span class="cx"> return currentPos;
</span><span class="lines">@@ -838,7 +838,7 @@
</span><span class="cx">
</span><span class="cx"> unsigned textOffset = currentPos.offsetInLeafNode();
</span><span class="cx"> auto lastTextBox = textRenderer.lastTextBox();
</span><del>- for (auto box = textRenderer.firstTextBox(); box; box = box->nextTextBox()) {
</del><ins>+ for (auto* box = textRenderer.firstTextBox(); box; box = box->nextTextBox()) {
</ins><span class="cx"> if (textOffset <= box->end()) {
</span><span class="cx"> if (textOffset >= box->start())
</span><span class="cx"> return currentPos;
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderappcacheApplicationCacheStoragecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -272,7 +272,7 @@
</span><span class="cx"> ASSERT(!url.hasFragmentIdentifier());
</span><span class="cx">
</span><span class="cx"> // Check if an appropriate cache already exists in memory.
</span><del>- for (auto group : m_cachesInMemory.values()) {
</del><ins>+ for (auto* group : m_cachesInMemory.values()) {
</ins><span class="cx"> ASSERT(!group->isObsolete());
</span><span class="cx">
</span><span class="cx"> if (ApplicationCache* cache = group->newestCache()) {
</span><span class="lines">@@ -1284,7 +1284,7 @@
</span><span class="cx"> // Clear the storage IDs for the caches in memory.
</span><span class="cx"> // The caches will still work, but cached resources will not be saved to disk
</span><span class="cx"> // until a cache update process has been initiated.
</span><del>- for (auto group : m_cachesInMemory.values())
</del><ins>+ for (auto* group : m_cachesInMemory.values())
</ins><span class="cx"> group->clearStorageID();
</span><span class="cx">
</span><span class="cx"> checkForDeletedResources();
</span></span></pre></div>
<a id="trunkSourceWebCorepageDragControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DragController.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DragController.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/page/DragController.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -649,7 +649,7 @@
</span><span class="cx"> state.type = DragSourceActionNone;
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- for (auto renderer = startElement->renderer(); renderer; renderer = renderer->parent()) {
</del><ins>+ for (auto* renderer = startElement->renderer(); renderer; renderer = renderer->parent()) {
</ins><span class="cx"> Element* element = renderer->nonPseudoElement();
</span><span class="cx"> if (!element) {
</span><span class="cx"> // Anonymous render blocks don't correspond to actual DOM elements, so we skip over them
</span></span></pre></div>
<a id="trunkSourceWebCorepageanimationCompositeAnimationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/animation/CompositeAnimation.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/animation/CompositeAnimation.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/page/animation/CompositeAnimation.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -293,7 +293,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Now remove the animations from the list.
</span><del>- for (auto nameForRemoval : animsToBeRemoved)
</del><ins>+ for (auto* nameForRemoval : animsToBeRemoved)
</ins><span class="cx"> m_keyframeAnimations.remove(nameForRemoval);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformaudioPlatformMediaSessionManagercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -332,7 +332,7 @@
</span><span class="cx"> if (m_interrupted)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- for (auto session : m_sessions)
</del><ins>+ for (auto* session : m_sessions)
</ins><span class="cx"> session->beginInterruption(PlatformMediaSession::SystemSleep);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -341,7 +341,7 @@
</span><span class="cx"> if (m_interrupted)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- for (auto session : m_sessions)
</del><ins>+ for (auto* session : m_sessions)
</ins><span class="cx"> session->endInterruption(PlatformMediaSession::MayResumePlaying);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsFontCachecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/FontCache.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/FontCache.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/platform/graphics/FontCache.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -441,7 +441,7 @@
</span><span class="cx"> if (entry.value && !cachedFonts().contains(*entry.value))
</span><span class="cx"> keysToRemove.append(entry.key);
</span><span class="cx"> }
</span><del>- for (auto key : keysToRemove)
</del><ins>+ for (auto& key : keysToRemove)
</ins><span class="cx"> fontPlatformDataCache().remove(key);
</span><span class="cx">
</span><span class="cx"> #if ENABLE(OPENTYPE_VERTICAL)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsPathUtilitiescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/PathUtilities.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/PathUtilities.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/platform/graphics/PathUtilities.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -160,7 +160,7 @@
</span><span class="cx"> // point with the greatest internal angle.
</span><span class="cx"> FloatPointGraph::Node* nextNode = nullptr;
</span><span class="cx"> float nextNodeAngle = 0;
</span><del>- for (auto potentialNextNode : currentNode->nextPoints()) {
</del><ins>+ for (auto* potentialNextNode : currentNode->nextPoints()) {
</ins><span class="cx"> if (potentialNextNode == currentNode)
</span><span class="cx"> continue;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationobjcMediaPlayerPrivateMediaStreamAVFObjCmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -146,7 +146,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> m_previewLayer = nullptr;
</span><del>- for (auto track : m_MediaStreamPrivate->tracks()) {
</del><ins>+ for (auto& track : m_MediaStreamPrivate->tracks()) {
</ins><span class="cx"> if (track->type() == RealtimeMediaSource::Type::Video)
</span><span class="cx"> m_previewLayer = static_cast<AVVideoCaptureSource*>(track->source())->previewLayer();
</span><span class="cx"> }
</span><span class="lines">@@ -190,7 +190,7 @@
</span><span class="cx"> {
</span><span class="cx"> m_playing = true;
</span><span class="cx">
</span><del>- for (auto track : m_MediaStreamPrivate->tracks())
</del><ins>+ for (auto& track : m_MediaStreamPrivate->tracks())
</ins><span class="cx"> track->source()->startProducingData();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -208,7 +208,7 @@
</span><span class="cx"> {
</span><span class="cx"> m_playing = false;
</span><span class="cx">
</span><del>- for (auto track : m_MediaStreamPrivate->tracks())
</del><ins>+ for (auto& track : m_MediaStreamPrivate->tracks())
</ins><span class="cx"> track->source()->stopProducingData();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -229,7 +229,7 @@
</span><span class="cx">
</span><span class="cx"> void MediaPlayerPrivateMediaStreamAVFObjC::setMuted(bool muted)
</span><span class="cx"> {
</span><del>- for (auto track : m_MediaStreamPrivate->tracks()) {
</del><ins>+ for (auto& track : m_MediaStreamPrivate->tracks()) {
</ins><span class="cx"> if (track->type() == RealtimeMediaSource::Type::Audio)
</span><span class="cx"> track->source()->setMuted(muted);
</span><span class="cx"> }
</span><span class="lines">@@ -238,7 +238,7 @@
</span><span class="cx"> FloatSize MediaPlayerPrivateMediaStreamAVFObjC::naturalSize() const
</span><span class="cx"> {
</span><span class="cx"> FloatSize floatSize(0, 0);
</span><del>- for (auto track : m_MediaStreamPrivate->tracks()) {
</del><ins>+ for (auto& track : m_MediaStreamPrivate->tracks()) {
</ins><span class="cx"> if (track->type() == RealtimeMediaSource::Type::Video) {
</span><span class="cx"> AVVideoCaptureSource* source = (AVVideoCaptureSource*)track->source();
</span><span class="cx"> if (!source->stopped() && track->enabled()) {
</span><span class="lines">@@ -254,7 +254,7 @@
</span><span class="cx">
</span><span class="cx"> bool MediaPlayerPrivateMediaStreamAVFObjC::hasVideo() const
</span><span class="cx"> {
</span><del>- for (auto track : m_MediaStreamPrivate->tracks()) {
</del><ins>+ for (auto& track : m_MediaStreamPrivate->tracks()) {
</ins><span class="cx"> if (track->type() == RealtimeMediaSource::Type::Video)
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -263,7 +263,7 @@
</span><span class="cx">
</span><span class="cx"> bool MediaPlayerPrivateMediaStreamAVFObjC::hasAudio() const
</span><span class="cx"> {
</span><del>- for (auto track : m_MediaStreamPrivate->tracks()) {
</del><ins>+ for (auto& track : m_MediaStreamPrivate->tracks()) {
</ins><span class="cx"> if (track->type() == RealtimeMediaSource::Type::Audio)
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscaGraphicsLayerCAcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -1795,7 +1795,7 @@
</span><span class="cx"> primaryLayer()->setSublayerTransform(m_childrenTransform);
</span><span class="cx">
</span><span class="cx"> if (LayerMap* layerCloneMap = primaryLayerClones()) {
</span><del>- for (auto & layer : layerCloneMap->values())
</del><ins>+ for (auto& layer : layerCloneMap->values())
</ins><span class="cx"> layer->setSublayerTransform(m_childrenTransform);
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -1805,7 +1805,7 @@
</span><span class="cx"> m_layer->setMasksToBounds(m_masksToBounds);
</span><span class="cx">
</span><span class="cx"> if (LayerMap* layerCloneMap = m_layerClones.get()) {
</span><del>- for (auto & layer : layerCloneMap->values())
</del><ins>+ for (auto& layer : layerCloneMap->values())
</ins><span class="cx"> layer->setMasksToBounds(m_masksToBounds);
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -1820,7 +1820,7 @@
</span><span class="cx"> m_layer->setContents(nullptr);
</span><span class="cx">
</span><span class="cx"> if (LayerMap* layerCloneMap = m_layerClones.get()) {
</span><del>- for (auto & layer : layerCloneMap->values())
</del><ins>+ for (auto& layer : layerCloneMap->values())
</ins><span class="cx"> layer->setContents(nullptr);
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -1838,7 +1838,7 @@
</span><span class="cx"> m_layer->setOpaque(contentsOpaque);
</span><span class="cx">
</span><span class="cx"> if (LayerMap* layerCloneMap = m_layerClones.get()) {
</span><del>- for (auto & layer : layerCloneMap->values())
</del><ins>+ for (auto& layer : layerCloneMap->values())
</ins><span class="cx"> layer->setOpaque(contentsOpaque);
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformiosWebVideoFullscreenModelVideoElementmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -88,7 +88,7 @@
</span><span class="cx"> m_videoElement->setVideoFullscreenLayer(nullptr);
</span><span class="cx">
</span><span class="cx"> if (m_videoElement && m_isListening) {
</span><del>- for (auto eventName : observedEventNames())
</del><ins>+ for (auto& eventName : observedEventNames())
</ins><span class="cx"> m_videoElement->removeEventListener(eventName, this, false);
</span><span class="cx"> }
</span><span class="cx"> m_isListening = false;
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx"> if (!m_videoElement)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- for (auto eventName : observedEventNames())
</del><ins>+ for (auto& eventName : observedEventNames())
</ins><span class="cx"> m_videoElement->addEventListener(eventName, this, false);
</span><span class="cx"> m_isListening = true;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmediastreamRealtimeMediaSourcecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -113,7 +113,7 @@
</span><span class="cx">
</span><span class="cx"> m_stopped = true;
</span><span class="cx">
</span><del>- for (auto observer : m_observers) {
</del><ins>+ for (auto* observer : m_observers) {
</ins><span class="cx"> if (observer != callingObserver)
</span><span class="cx"> observer->sourceStopped();
</span><span class="cx"> }
</span><span class="lines">@@ -126,7 +126,7 @@
</span><span class="cx"> if (stopped())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- for (auto observer : m_observers) {
</del><ins>+ for (auto* observer : m_observers) {
</ins><span class="cx"> if (observer->preventSourceFromStopping())
</span><span class="cx"> return;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingInlineFlowBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/InlineFlowBox.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/InlineFlowBox.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/rendering/InlineFlowBox.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -1171,7 +1171,7 @@
</span><span class="cx"> containingBlockPaintsContinuationOutline = false;
</span><span class="cx"> else {
</span><span class="cx"> containingBlock = enclosingAnonymousBlock->containingBlock();
</span><del>- for (auto box = &renderer(); box != containingBlock; box = &box->parent()->enclosingBoxModelObject()) {
</del><ins>+ for (auto* box = &renderer(); box != containingBlock; box = &box->parent()->enclosingBoxModelObject()) {
</ins><span class="cx"> if (box->hasSelfPaintingLayer()) {
</span><span class="cx"> containingBlockPaintsContinuationOutline = false;
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -1039,7 +1039,7 @@
</span><span class="cx">
</span><span class="cx"> void RenderBlock::addOverflowFromBlockChildren()
</span><span class="cx"> {
</span><del>- for (auto child = firstChildBox(); child; child = child->nextSiblingBox()) {
</del><ins>+ for (auto* child = firstChildBox(); child; child = child->nextSiblingBox()) {
</ins><span class="cx"> if (!child->isFloatingOrOutOfFlowPositioned())
</span><span class="cx"> addOverflowFromChild(child);
</span><span class="cx"> }
</span><span class="lines">@@ -1192,7 +1192,7 @@
</span><span class="cx"> box->computeOverflow(box->lineTop(), box->lineBottom(), textBoxDataMap);
</span><span class="cx"> }
</span><span class="cx"> } else {
</span><del>- for (auto box = firstChildBox(); box; box = box->nextSiblingBox()) {
</del><ins>+ for (auto* box = firstChildBox(); box; box = box->nextSiblingBox()) {
</ins><span class="cx"> if (!box->isOutOfFlowPositioned())
</span><span class="cx"> box->layoutIfNeeded();
</span><span class="cx"> }
</span><span class="lines">@@ -1451,7 +1451,7 @@
</span><span class="cx">
</span><span class="cx"> void RenderBlock::paintChildren(PaintInfo& paintInfo, const LayoutPoint& paintOffset, PaintInfo& paintInfoForChild, bool usePrintRect)
</span><span class="cx"> {
</span><del>- for (auto child = firstChildBox(); child; child = child->nextSiblingBox()) {
</del><ins>+ for (auto* child = firstChildBox(); child; child = child->nextSiblingBox()) {
</ins><span class="cx"> if (!paintChild(*child, paintInfo, paintOffset, paintInfoForChild, usePrintRect))
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -2507,7 +2507,7 @@
</span><span class="cx"> HitTestAction childHitTest = hitTestAction;
</span><span class="cx"> if (hitTestAction == HitTestChildBlockBackgrounds)
</span><span class="cx"> childHitTest = HitTestChildBlockBackground;
</span><del>- for (auto child = lastChildBox(); child; child = child->previousSiblingBox()) {
</del><ins>+ for (auto* child = lastChildBox(); child; child = child->previousSiblingBox()) {
</ins><span class="cx"> LayoutPoint childPoint = flipForWritingModeForChild(child, accumulatedOffset);
</span><span class="cx"> if (!child->hasSelfPaintingLayer() && !child->isFloating() && child->nodeAtPoint(request, result, locationInContainer, childPoint, childHitTest))
</span><span class="cx"> return true;
</span><span class="lines">@@ -2629,7 +2629,7 @@
</span><span class="cx"> || (!blocksAreFlipped && pointInLogicalContents.y() == logicalTopForChild(*lastCandidateBox)))
</span><span class="cx"> return positionForPointRespectingEditingBoundaries(*this, *lastCandidateBox, pointInContents);
</span><span class="cx">
</span><del>- for (auto childBox = firstChildBox(); childBox; childBox = childBox->nextSiblingBox()) {
</del><ins>+ for (auto* childBox = firstChildBox(); childBox; childBox = childBox->nextSiblingBox()) {
</ins><span class="cx"> if (!isChildHitTestCandidate(*childBox, region, pointInLogicalContents))
</span><span class="cx"> continue;
</span><span class="cx"> LayoutUnit childLogicalBottom = logicalTopForChild(*childBox) + logicalHeightForChild(*childBox);
</span><span class="lines">@@ -2915,7 +2915,7 @@
</span><span class="cx"> return Optional<int>();
</span><span class="cx">
</span><span class="cx"> bool haveNormalFlowChild = false;
</span><del>- for (auto box = lastChildBox(); box; box = box->previousSiblingBox()) {
</del><ins>+ for (auto* box = lastChildBox(); box; box = box->previousSiblingBox()) {
</ins><span class="cx"> if (box->isFloatingOrOutOfFlowPositioned())
</span><span class="cx"> continue;
</span><span class="cx"> haveNormalFlowChild = true;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockFlowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -161,7 +161,7 @@
</span><span class="cx"> // that will outlast this block. In the non-anonymous block case those
</span><span class="cx"> // children will be destroyed by the time we return from this function.
</span><span class="cx"> if (isAnonymousBlock()) {
</span><del>- for (auto box = firstRootBox(); box; box = box->nextRootBox()) {
</del><ins>+ for (auto* box = firstRootBox(); box; box = box->nextRootBox()) {
</ins><span class="cx"> while (auto childBox = box->firstChild())
</span><span class="cx"> childBox->removeFromParent();
</span><span class="cx"> }
</span><span class="lines">@@ -2038,7 +2038,7 @@
</span><span class="cx">
</span><span class="cx"> void RenderBlockFlow::updateStylesForColumnChildren()
</span><span class="cx"> {
</span><del>- for (auto child = firstChildBox(); child && (child->isInFlowRenderFlowThread() || child->isRenderMultiColumnSet()); child = child->nextSiblingBox())
</del><ins>+ for (auto* child = firstChildBox(); child && (child->isInFlowRenderFlowThread() || child->isRenderMultiColumnSet()); child = child->nextSiblingBox())
</ins><span class="cx"> child->setStyle(RenderStyle::createAnonymousStyleWithDisplay(&style(), BLOCK));
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2934,7 +2934,7 @@
</span><span class="cx"> if (childrenInline()) {
</span><span class="cx"> const_cast<RenderBlockFlow&>(*this).ensureLineBoxes();
</span><span class="cx">
</span><del>- for (auto box = firstRootBox(); box; box = box->nextRootBox()) {
</del><ins>+ for (auto* box = firstRootBox(); box; box = box->nextRootBox()) {
</ins><span class="cx"> if (box->firstChild())
</span><span class="cx"> left = std::min(left, x + LayoutUnit(box->firstChild()->x()));
</span><span class="cx"> if (box->lastChild())
</span><span class="lines">@@ -3219,7 +3219,7 @@
</span><span class="cx"> return nullptr;
</span><span class="cx">
</span><span class="cx"> if (childrenInline()) {
</span><del>- for (auto box = firstRootBox(); box; box = box->nextRootBox()) {
</del><ins>+ for (auto* box = firstRootBox(); box; box = box->nextRootBox()) {
</ins><span class="cx"> if (!i--)
</span><span class="cx"> return box;
</span><span class="cx"> }
</span><span class="lines">@@ -3248,8 +3248,8 @@
</span><span class="cx"> ASSERT(!stopRootInlineBox);
</span><span class="cx"> return simpleLineLayout->lineCount();
</span><span class="cx"> }
</span><del>- for (auto box = firstRootBox(); box; box = box->nextRootBox()) {
- count++;
</del><ins>+ for (auto* box = firstRootBox(); box; box = box->nextRootBox()) {
+ ++count;
</ins><span class="cx"> if (box == stopRootInlineBox) {
</span><span class="cx"> if (found)
</span><span class="cx"> *found = true;
</span><span class="lines">@@ -3280,13 +3280,13 @@
</span><span class="cx"> return -1;
</span><span class="cx">
</span><span class="cx"> if (block.childrenInline()) {
</span><del>- for (auto box = block.firstRootBox(); box; box = box->nextRootBox()) {
</del><ins>+ for (auto* box = block.firstRootBox(); box; box = box->nextRootBox()) {
</ins><span class="cx"> if (++count == lineCount)
</span><span class="cx"> return box->lineBottom() + (includeBottom ? (block.borderBottom() + block.paddingBottom()) : LayoutUnit());
</span><span class="cx"> }
</span><span class="cx"> } else {
</span><span class="cx"> RenderBox* normalFlowChildWithoutLines = nullptr;
</span><del>- for (auto obj = block.firstChildBox(); obj; obj = obj->nextSiblingBox()) {
</del><ins>+ for (auto* obj = block.firstChildBox(); obj; obj = obj->nextSiblingBox()) {
</ins><span class="cx"> if (is<RenderBlockFlow>(*obj) && shouldCheckLines(downcast<RenderBlockFlow>(*obj))) {
</span><span class="cx"> int result = getHeightForLineCount(downcast<RenderBlockFlow>(*obj), lineCount, false, count);
</span><span class="cx"> if (result != -1)
</span><span class="lines">@@ -3316,7 +3316,7 @@
</span><span class="cx"> ensureLineBoxes();
</span><span class="cx">
</span><span class="cx"> setHasMarkupTruncation(false);
</span><del>- for (auto box = firstRootBox(); box; box = box->nextRootBox())
</del><ins>+ for (auto* box = firstRootBox(); box; box = box->nextRootBox())
</ins><span class="cx"> box->clearTruncation();
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -3329,8 +3329,8 @@
</span><span class="cx">
</span><span class="cx"> bool RenderBlockFlow::containsNonZeroBidiLevel() const
</span><span class="cx"> {
</span><del>- for (auto root = firstRootBox(); root; root = root->nextRootBox()) {
- for (auto box = root->firstLeafChild(); box; box = box->nextLeafChild()) {
</del><ins>+ for (auto* root = firstRootBox(); root; root = root->nextRootBox()) {
+ for (auto* box = root->firstLeafChild(); box; box = box->nextLeafChild()) {
</ins><span class="cx"> if (box->bidiLevel())
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBox.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -3278,7 +3278,7 @@
</span><span class="cx"> // FIXME: The static distance computation has not been patched for mixed writing modes yet.
</span><span class="cx"> if (child->parent()->style().direction() == LTR) {
</span><span class="cx"> LayoutUnit staticPosition = child->layer()->staticInlinePosition() - containerBlock->borderLogicalLeft();
</span><del>- for (auto current = child->parent(); current && current != containerBlock; current = current->container()) {
</del><ins>+ for (auto* current = child->parent(); current && current != containerBlock; current = current->container()) {
</ins><span class="cx"> if (is<RenderBox>(*current)) {
</span><span class="cx"> staticPosition += downcast<RenderBox>(*current).logicalLeft();
</span><span class="cx"> if (region && is<RenderBlock>(*current)) {
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderInlinecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderInline.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderInline.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/rendering/RenderInline.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -96,7 +96,7 @@
</span><span class="cx"> // not have a parent that means they are either already disconnected or
</span><span class="cx"> // root lines that can just be destroyed without disconnecting.
</span><span class="cx"> if (firstLineBox()->parent()) {
</span><del>- for (auto box = firstLineBox(); box; box = box->nextLineBox())
</del><ins>+ for (auto* box = firstLineBox(); box; box = box->nextLineBox())
</ins><span class="cx"> box->removeFromParent();
</span><span class="cx"> }
</span><span class="cx"> } else if (parent())
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -914,7 +914,7 @@
</span><span class="cx">
</span><span class="cx"> void RenderLayer::updateAncestorChainHasBlendingDescendants()
</span><span class="cx"> {
</span><del>- for (auto layer = this; layer; layer = layer->parent()) {
</del><ins>+ for (auto* layer = this; layer; layer = layer->parent()) {
</ins><span class="cx"> if (!layer->hasNotIsolatedBlendingDescendantsStatusDirty() && layer->hasNotIsolatedBlendingDescendants())
</span><span class="cx"> break;
</span><span class="cx"> layer->m_hasNotIsolatedBlendingDescendants = true;
</span><span class="lines">@@ -929,7 +929,7 @@
</span><span class="cx">
</span><span class="cx"> void RenderLayer::dirtyAncestorChainHasBlendingDescendants()
</span><span class="cx"> {
</span><del>- for (auto layer = this; layer; layer = layer->parent()) {
</del><ins>+ for (auto* layer = this; layer; layer = layer->parent()) {
</ins><span class="cx"> if (layer->hasNotIsolatedBlendingDescendantsStatusDirty())
</span><span class="cx"> break;
</span><span class="cx">
</span><span class="lines">@@ -1285,13 +1285,13 @@
</span><span class="cx"> // Transformed or preserve-3d descendants can only be in the z-order lists, not
</span><span class="cx"> // in the normal flow list, so we only need to check those.
</span><span class="cx"> if (Vector<RenderLayer*>* positiveZOrderList = posZOrderList()) {
</span><del>- for (auto layer : *positiveZOrderList)
</del><ins>+ for (auto* layer : *positiveZOrderList)
</ins><span class="cx"> m_has3DTransformedDescendant |= layer->update3DTransformedDescendantStatus();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Now check our negative z-index children.
</span><span class="cx"> if (Vector<RenderLayer*>* negativeZOrderList = negZOrderList()) {
</span><del>- for (auto layer : *negativeZOrderList)
</del><ins>+ for (auto* layer : *negativeZOrderList)
</ins><span class="cx"> m_has3DTransformedDescendant |= layer->update3DTransformedDescendantStatus();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3850,7 +3850,7 @@
</span><span class="cx"> request.key->setOverlapTestResult(true);
</span><span class="cx"> overlappedRequestClients.append(request.key);
</span><span class="cx"> }
</span><del>- for (auto client : overlappedRequestClients)
</del><ins>+ for (auto* client : overlappedRequestClients)
</ins><span class="cx"> overlapTestRequests.remove(client);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4207,7 +4207,7 @@
</span><span class="cx"> renderer().view().flowThreadController().collectFixedPositionedLayers(fixedLayers);
</span><span class="cx">
</span><span class="cx"> // Paint the layers
</span><del>- for (auto fixedLayer : fixedLayers)
</del><ins>+ for (auto* fixedLayer : fixedLayers)
</ins><span class="cx"> fixedLayer->paintLayer(context, paintingInfo, paintFlags);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4430,7 +4430,7 @@
</span><span class="cx"> LayerListMutationDetector mutationChecker(this);
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- for (auto childLayer : *list) {
</del><ins>+ for (auto* childLayer : *list) {
</ins><span class="cx"> if (childLayer->isFlowThreadCollectingGraphicsLayersUnderRegions())
</span><span class="cx"> continue;
</span><span class="cx"> childLayer->paintLayer(context, paintingInfo, paintFlags);
</span><span class="lines">@@ -5974,7 +5974,7 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> if (Vector<RenderLayer*>* negZOrderList = this->negZOrderList()) {
</span><del>- for (auto curLayer : *negZOrderList) {
</del><ins>+ for (auto* curLayer : *negZOrderList) {
</ins><span class="cx"> if (flags & IncludeCompositedDescendants || !curLayer->isComposited()) {
</span><span class="cx"> LayoutRect childUnionBounds = curLayer->calculateLayerBounds(this, curLayer->offsetFromAncestor(this), descendantFlags);
</span><span class="cx"> unionBounds.unite(childUnionBounds);
</span><span class="lines">@@ -5983,7 +5983,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (Vector<RenderLayer*>* posZOrderList = this->posZOrderList()) {
</span><del>- for (auto curLayer : *posZOrderList) {
</del><ins>+ for (auto* curLayer : *posZOrderList) {
</ins><span class="cx"> // The RenderNamedFlowThread is ignored when we calculate the bounds of the RenderView.
</span><span class="cx"> if ((flags & IncludeCompositedDescendants || !curLayer->isComposited()) && !curLayer->isFlowThreadCollectingGraphicsLayersUnderRegions()) {
</span><span class="cx"> LayoutRect childUnionBounds = curLayer->calculateLayerBounds(this, curLayer->offsetFromAncestor(this), descendantFlags);
</span><span class="lines">@@ -5993,7 +5993,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (Vector<RenderLayer*>* normalFlowList = this->normalFlowList()) {
</span><del>- for (auto curLayer : *normalFlowList) {
</del><ins>+ for (auto* curLayer : *normalFlowList) {
</ins><span class="cx"> // RenderView will always return the size of the document, before reaching this point,
</span><span class="cx"> // so there's no way we could hit a RenderNamedFlowThread here.
</span><span class="cx"> ASSERT(!curLayer->isFlowThreadCollectingGraphicsLayersUnderRegions());
</span><span class="lines">@@ -6348,24 +6348,24 @@
</span><span class="cx">
</span><span class="cx"> if (isStackingContainer()) {
</span><span class="cx"> if (Vector<RenderLayer*>* list = negZOrderList()) {
</span><del>- for (auto childLayer : *list)
</del><ins>+ for (auto* childLayer : *list)
</ins><span class="cx"> layersToUpdate.append(childLayer);
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (Vector<RenderLayer*>* list = normalFlowList()) {
</span><del>- for (auto childLayer : *list)
</del><ins>+ for (auto* childLayer : *list)
</ins><span class="cx"> layersToUpdate.append(childLayer);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (isStackingContainer()) {
</span><span class="cx"> if (Vector<RenderLayer*>* list = posZOrderList()) {
</span><del>- for (auto childLayer : *list)
</del><ins>+ for (auto* childLayer : *list)
</ins><span class="cx"> layersToUpdate.append(childLayer);
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- for (auto childLayer : layersToUpdate) {
</del><ins>+ for (auto* childLayer : layersToUpdate) {
</ins><span class="cx"> childLayer->updateLayerListsIfNeeded();
</span><span class="cx"> if (recursive)
</span><span class="cx"> childLayer->updateDescendantsLayerListsIfNeeded(true);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -1712,7 +1712,7 @@
</span><span class="cx"> // If we hit the anonymous renderers inside generated content we should
</span><span class="cx"> // actually hit the generated content so walk up to the PseudoElement.
</span><span class="cx"> if (!node && parent() && parent()->isBeforeOrAfterContent()) {
</span><del>- for (auto renderer = parent(); renderer && !node; renderer = renderer->parent())
</del><ins>+ for (auto* renderer = parent(); renderer && !node; renderer = renderer->parent())
</ins><span class="cx"> node = renderer->element();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTextLineBoxescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTextLineBoxes.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTextLineBoxes.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/rendering/RenderTextLineBoxes.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -64,7 +64,7 @@
</span><span class="cx"> if (box.prevTextBox())
</span><span class="cx"> box.prevTextBox()->setNextTextBox(nullptr);
</span><span class="cx"> box.setPreviousTextBox(nullptr);
</span><del>- for (auto current = &box; current; current = current->nextTextBox())
</del><ins>+ for (auto* current = &box; current; current = current->nextTextBox())
</ins><span class="cx"> current->setExtracted();
</span><span class="cx">
</span><span class="cx"> checkConsistency();
</span><span class="lines">@@ -80,7 +80,7 @@
</span><span class="cx"> } else
</span><span class="cx"> m_first = &box;
</span><span class="cx"> InlineTextBox* last = nullptr;
</span><del>- for (auto current = &box; current; current = current->nextTextBox()) {
</del><ins>+ for (auto* current = &box; current; current = current->nextTextBox()) {
</ins><span class="cx"> current->setExtracted(false);
</span><span class="cx"> last = current;
</span><span class="cx"> }
</span><span class="lines">@@ -112,7 +112,7 @@
</span><span class="cx"> renderer.parent()->dirtyLinesFromChangedChild(renderer);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><del>- for (auto box = m_first; box; box = box->nextTextBox())
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox())
</ins><span class="cx"> box->removeFromParent();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -121,7 +121,7 @@
</span><span class="cx"> if (!m_first)
</span><span class="cx"> return;
</span><span class="cx"> InlineTextBox* next;
</span><del>- for (auto current = m_first; current; current = next) {
</del><ins>+ for (auto* current = m_first; current; current = next) {
</ins><span class="cx"> next = current->nextTextBox();
</span><span class="cx"> delete current;
</span><span class="cx"> }
</span><span class="lines">@@ -153,7 +153,7 @@
</span><span class="cx"> // Return the width of the minimal left side and the maximal right side.
</span><span class="cx"> float logicalLeftSide = 0;
</span><span class="cx"> float logicalRightSide = 0;
</span><del>- for (auto current = m_first; current; current = current->nextTextBox()) {
</del><ins>+ for (auto* current = m_first; current; current = current->nextTextBox()) {
</ins><span class="cx"> if (current == m_first || current->logicalLeft() < logicalLeftSide)
</span><span class="cx"> logicalLeftSide = current->logicalLeft();
</span><span class="cx"> if (current == m_first || current->logicalRight() > logicalRightSide)
</span><span class="lines">@@ -184,7 +184,7 @@
</span><span class="cx"> // Return the width of the minimal left side and the maximal right side.
</span><span class="cx"> auto logicalLeftSide = LayoutUnit::max();
</span><span class="cx"> auto logicalRightSide = LayoutUnit::min();
</span><del>- for (auto current = m_first; current; current = current->nextTextBox()) {
</del><ins>+ for (auto* current = m_first; current; current = current->nextTextBox()) {
</ins><span class="cx"> logicalLeftSide = std::min(logicalLeftSide, current->logicalLeftVisualOverflow());
</span><span class="cx"> logicalRightSide = std::max(logicalRightSide, current->logicalRightVisualOverflow());
</span><span class="cx"> }
</span><span class="lines">@@ -201,7 +201,7 @@
</span><span class="cx">
</span><span class="cx"> bool RenderTextLineBoxes::hasRenderedText() const
</span><span class="cx"> {
</span><del>- for (auto box = m_first; box; box = box->nextTextBox()) {
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox()) {
</ins><span class="cx"> if (box->len())
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -233,7 +233,7 @@
</span><span class="cx">
</span><span class="cx"> bool RenderTextLineBoxes::containsOffset(const RenderText& renderer, unsigned offset, OffsetType type) const
</span><span class="cx"> {
</span><del>- for (auto box = m_first; box; box = box->nextTextBox()) {
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox()) {
</ins><span class="cx"> if (offset < box->start() && !renderer.containsReversedText())
</span><span class="cx"> return false;
</span><span class="cx"> unsigned boxEnd = box->start() + box->len();
</span><span class="lines">@@ -252,7 +252,7 @@
</span><span class="cx"> unsigned RenderTextLineBoxes::countCharacterOffsetsUntil(unsigned offset) const
</span><span class="cx"> {
</span><span class="cx"> unsigned result = 0;
</span><del>- for (auto box = m_first; box; box = box->nextTextBox()) {
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox()) {
</ins><span class="cx"> if (offset < box->start())
</span><span class="cx"> return result;
</span><span class="cx"> if (offset <= box->start() + box->len()) {
</span><span class="lines">@@ -402,7 +402,7 @@
</span><span class="cx"> bool blocksAreFlipped = renderer.style().isFlippedBlocksWritingMode();
</span><span class="cx">
</span><span class="cx"> InlineTextBox* lastBox = nullptr;
</span><del>- for (auto box = m_first; box; box = box->nextTextBox()) {
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox()) {
</ins><span class="cx"> if (box->isLineBreak() && !box->prevLeafChild() && box->nextLeafChild() && !box->nextLeafChild()->isLineBreak())
</span><span class="cx"> box = box->nextTextBox();
</span><span class="cx">
</span><span class="lines">@@ -440,7 +440,7 @@
</span><span class="cx"> void RenderTextLineBoxes::setSelectionState(RenderText& renderer, RenderObject::SelectionState state)
</span><span class="cx"> {
</span><span class="cx"> if (state == RenderObject::SelectionInside || state == RenderObject::SelectionNone) {
</span><del>- for (auto box = m_first; box; box = box->nextTextBox())
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox())
</ins><span class="cx"> box->root().setHasSelectedChildren(state == RenderObject::SelectionInside);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -456,7 +456,7 @@
</span><span class="cx"> } else if (state == RenderObject::SelectionEnd)
</span><span class="cx"> start = 0;
</span><span class="cx">
</span><del>- for (auto box = m_first; box; box = box->nextTextBox()) {
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox()) {
</ins><span class="cx"> if (box->isSelected(start, end))
</span><span class="cx"> box->root().setHasSelectedChildren(true);
</span><span class="cx"> }
</span><span class="lines">@@ -487,7 +487,7 @@
</span><span class="cx"> LayoutRect RenderTextLineBoxes::selectionRectForRange(unsigned start, unsigned end)
</span><span class="cx"> {
</span><span class="cx"> LayoutRect rect;
</span><del>- for (auto box = m_first; box; box = box->nextTextBox()) {
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox()) {
</ins><span class="cx"> rect.unite(box->localSelectionRect(start, end));
</span><span class="cx"> rect.unite(ellipsisRectForBox(*box, start, end));
</span><span class="cx"> }
</span><span class="lines">@@ -496,7 +496,7 @@
</span><span class="cx">
</span><span class="cx"> void RenderTextLineBoxes::collectSelectionRectsForRange(unsigned start, unsigned end, Vector<LayoutRect>& rects)
</span><span class="cx"> {
</span><del>- for (auto box = m_first; box; box = box->nextTextBox()) {
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox()) {
</ins><span class="cx"> LayoutRect rect;
</span><span class="cx"> rect.unite(box->localSelectionRect(start, end));
</span><span class="cx"> rect.unite(ellipsisRectForBox(*box, start, end));
</span><span class="lines">@@ -508,7 +508,7 @@
</span><span class="cx"> Vector<IntRect> RenderTextLineBoxes::absoluteRects(const LayoutPoint& accumulatedOffset) const
</span><span class="cx"> {
</span><span class="cx"> Vector<IntRect> rects;
</span><del>- for (auto box = m_first; box; box = box->nextTextBox())
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox())
</ins><span class="cx"> rects.append(enclosingIntRect(FloatRect(accumulatedOffset + box->topLeft(), box->size())));
</span><span class="cx"> return rects;
</span><span class="cx"> }
</span><span class="lines">@@ -536,7 +536,7 @@
</span><span class="cx"> Vector<IntRect> RenderTextLineBoxes::absoluteRectsForRange(const RenderText& renderer, unsigned start, unsigned end, bool useSelectionHeight, bool* wasFixed) const
</span><span class="cx"> {
</span><span class="cx"> Vector<IntRect> rects;
</span><del>- for (auto box = m_first; box; box = box->nextTextBox()) {
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox()) {
</ins><span class="cx"> // Note: box->end() returns the index of the last character, not the index past it
</span><span class="cx"> if (start <= box->start() && box->end() < end) {
</span><span class="cx"> FloatRect boundaries = box->calculateBoundaries();
</span><span class="lines">@@ -564,7 +564,7 @@
</span><span class="cx"> Vector<FloatQuad> RenderTextLineBoxes::absoluteQuads(const RenderText& renderer, bool* wasFixed, ClippingOption option) const
</span><span class="cx"> {
</span><span class="cx"> Vector<FloatQuad> quads;
</span><del>- for (auto box = m_first; box; box = box->nextTextBox()) {
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox()) {
</ins><span class="cx"> FloatRect boundaries = box->calculateBoundaries();
</span><span class="cx">
</span><span class="cx"> // Shorten the width of this text box if it ends in an ellipsis.
</span><span class="lines">@@ -584,7 +584,7 @@
</span><span class="cx"> Vector<FloatQuad> RenderTextLineBoxes::absoluteQuadsForRange(const RenderText& renderer, unsigned start, unsigned end, bool useSelectionHeight, bool* wasFixed) const
</span><span class="cx"> {
</span><span class="cx"> Vector<FloatQuad> quads;
</span><del>- for (auto box = m_first; box; box = box->nextTextBox()) {
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox()) {
</ins><span class="cx"> // Note: box->end() returns the index of the last character, not the index past it
</span><span class="cx"> if (start <= box->start() && box->end() < end) {
</span><span class="cx"> FloatRect boundaries = box->calculateBoundaries();
</span><span class="lines">@@ -610,7 +610,7 @@
</span><span class="cx">
</span><span class="cx"> void RenderTextLineBoxes::dirtyAll()
</span><span class="cx"> {
</span><del>- for (auto box = m_first; box; box = box->nextTextBox())
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox())
</ins><span class="cx"> box->dirtyLineBoxes();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -621,7 +621,7 @@
</span><span class="cx">
</span><span class="cx"> // Dirty all text boxes that include characters in between offset and offset+len.
</span><span class="cx"> bool dirtiedLines = false;
</span><del>- for (auto current = m_first; current; current = current->nextTextBox()) {
</del><ins>+ for (auto* current = m_first; current; current = current->nextTextBox()) {
</ins><span class="cx"> // FIXME: This shouldn't rely on the end of a dirty line box. See https://bugs.webkit.org/show_bug.cgi?id=97264
</span><span class="cx"> // Text run is entirely before the affected range.
</span><span class="cx"> if (current->end() < start)
</span><span class="lines">@@ -675,7 +675,7 @@
</span><span class="cx"> firstRootBox->markDirty();
</span><span class="cx"> dirtiedLines = true;
</span><span class="cx"> }
</span><del>- for (auto current = firstRootBox; current && current != lastRootBox; current = current->nextRootBox()) {
</del><ins>+ for (auto* current = firstRootBox; current && current != lastRootBox; current = current->nextRootBox()) {
</ins><span class="cx"> if (current->lineBreakObj() == &renderer && current->lineBreakPos() > end)
</span><span class="cx"> current->setLineBreakPos(current->lineBreakPos() + lengthDelta);
</span><span class="cx"> }
</span><span class="lines">@@ -693,7 +693,7 @@
</span><span class="cx"> #if !ASSERT_DISABLED
</span><span class="cx"> #ifdef CHECK_CONSISTENCY
</span><span class="cx"> const InlineTextBox* prev = nullptr;
</span><del>- for (auto child = m_first; child; child = child->nextTextBox()) {
</del><ins>+ for (auto* child = m_first; child; child = child->nextTextBox()) {
</ins><span class="cx"> ASSERT(child->renderer() == this);
</span><span class="cx"> ASSERT(child->prevTextBox() == prev);
</span><span class="cx"> prev = child;
</span><span class="lines">@@ -714,7 +714,7 @@
</span><span class="cx"> #if !ASSERT_WITH_SECURITY_IMPLICATION_DISABLED
</span><span class="cx"> void RenderTextLineBoxes::invalidateParentChildLists()
</span><span class="cx"> {
</span><del>- for (auto box = m_first; box; box = box->nextTextBox())
</del><ins>+ for (auto* box = m_first; box; box = box->nextTextBox())
</ins><span class="cx"> box->invalidateParentChildList();
</span><span class="cx"> }
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTreeAsTextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTreeAsText.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTreeAsText.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/rendering/RenderTreeAsText.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -549,7 +549,7 @@
</span><span class="cx"> writeSimpleLine(ts, text, run.rect(), run.text());
</span><span class="cx"> }
</span><span class="cx"> } else {
</span><del>- for (auto box = text.firstTextBox(); box; box = box->nextTextBox()) {
</del><ins>+ for (auto* box = text.firstTextBox(); box; box = box->nextTextBox()) {
</ins><span class="cx"> writeIndent(ts, indent + 1);
</span><span class="cx"> writeTextRun(ts, text, *box);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgSVGTextMetricsBuildercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -176,7 +176,7 @@
</span><span class="cx">
</span><span class="cx"> void SVGTextMetricsBuilder::walkTree(RenderElement& start, RenderSVGInlineText* stopAtLeaf, MeasureTextData* data)
</span><span class="cx"> {
</span><del>- for (auto child = start.firstChild(); child; child = child->nextSibling()) {
</del><ins>+ for (auto* child = start.firstChild(); child; child = child->nextSibling()) {
</ins><span class="cx"> if (is<RenderSVGInlineText>(*child)) {
</span><span class="cx"> RenderSVGInlineText& text = downcast<RenderSVGInlineText>(*child);
</span><span class="cx"> if (stopAtLeaf && stopAtLeaf != &text) {
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGSVGElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGSVGElement.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGSVGElement.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebCore/svg/SVGSVGElement.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -676,7 +676,7 @@
</span><span class="cx"> if (element && element->isDescendantOf(this))
</span><span class="cx"> return element;
</span><span class="cx"> if (treeScope().containsMultipleElementsWithId(id)) {
</span><del>- for (auto element : *treeScope().getAllElementsById(id)) {
</del><ins>+ for (auto* element : *treeScope().getAllElementsById(id)) {
</ins><span class="cx"> if (element->isDescendantOf(this))
</span><span class="cx"> return element;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-10-13 Chris Dumez <cdumez@apple.com>
+
+ Avoid useless copies in range-loops that are using 'auto'
+ https://bugs.webkit.org/show_bug.cgi?id=150091
+
+ Reviewed by Sam Weinig.
+
+ Avoid useless copies in range-loops that are using 'auto'. Also use
+ 'auto*' instead of 'auto' when range values are pointers for clarity.
+
+ * WebView/WebFrame.mm:
+ (-[WebFrame getDictationResultRanges:andMetadatas:]):
+
</ins><span class="cx"> 2015-10-09 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Don't allow plug-ins to override image types for <embed> elements
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebFramemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebFrame.mm (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebFrame.mm 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebKit/mac/WebView/WebFrame.mm 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -1720,7 +1720,7 @@
</span><span class="cx">
</span><span class="cx"> for (Node* node = root; node; node = NodeTraversal::next(*node)) {
</span><span class="cx"> auto markers = document->markers().markersFor(node);
</span><del>- for (auto marker : markers) {
</del><ins>+ for (auto* marker : markers) {
</ins><span class="cx">
</span><span class="cx"> if (marker->type() != DocumentMarker::DictationResult)
</span><span class="cx"> continue;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebKit2/ChangeLog 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-10-13 Chris Dumez <cdumez@apple.com>
+
+ Avoid useless copies in range-loops that are using 'auto'
+ https://bugs.webkit.org/show_bug.cgi?id=150091
+
+ Reviewed by Sam Weinig.
+
+ Avoid useless copies in range-loops that are using 'auto'. Also use
+ 'auto*' instead of 'auto' when range values are pointers for clarity.
+
+ * UIProcess/VisitedLinkStore.cpp:
+ (WebKit::VisitedLinkStore::pendingVisitedLinksTimerFired):
+ (WebKit::VisitedLinkStore::resizeTable):
+ * UIProcess/WebProcessProxy.cpp:
+ (WebKit::WebProcessProxy::releaseRemainingIconsForPageURLs):
+ * UIProcess/WebsiteData/WebsiteDataStore.cpp:
+ (WebKit::WebsiteDataStore::fetchData):
+ (WebKit::WebsiteDataStore::removeData):
+ (WebKit::WebsiteDataStore::plugins):
+
</ins><span class="cx"> 2015-10-13 Said Abou-Hallawa <sabouhallawa@apple.com>
</span><span class="cx">
</span><span class="cx"> Add debug settings for using giant tiles (4096x4096)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessVisitedLinkStorecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/VisitedLinkStore.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/VisitedLinkStore.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebKit2/UIProcess/VisitedLinkStore.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -178,10 +178,10 @@
</span><span class="cx">
</span><span class="cx"> Vector<WebCore::LinkHash> addedVisitedLinks;
</span><span class="cx">
</span><del>- for (auto linkHash : m_pendingVisitedLinks) {
</del><ins>+ for (auto& linkHash : m_pendingVisitedLinks) {
</ins><span class="cx"> if (m_table.addLinkHash(linkHash)) {
</span><span class="cx"> addedVisitedLinks.append(linkHash);
</span><del>- m_keyCount++;
</del><ins>+ ++m_keyCount;
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -235,7 +235,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- for (auto linkHash : m_pendingVisitedLinks) {
</del><ins>+ for (auto& linkHash : m_pendingVisitedLinks) {
</ins><span class="cx"> if (m_table.addLinkHash(linkHash))
</span><span class="cx"> m_keyCount++;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -479,10 +479,10 @@
</span><span class="cx"> if (!iconDatabase)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- for (auto iter : m_pageURLRetainCountMap) {
- uint64_t count = iter.value;
</del><ins>+ for (auto& entry : m_pageURLRetainCountMap) {
+ uint64_t count = entry.value;
</ins><span class="cx"> for (uint64_t i = 0; i < count; ++i)
</span><del>- iconDatabase->releaseIconForPageURL(iter.key);
</del><ins>+ iconDatabase->releaseIconForPageURL(entry.key);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> m_pageURLRetainCountMap.clear();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebsiteDataWebsiteDataStorecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -244,7 +244,7 @@
</span><span class="cx">
</span><span class="cx"> auto networkProcessAccessType = computeNetworkProcessAccessTypeForDataFetch(dataTypes, !isPersistent());
</span><span class="cx"> if (networkProcessAccessType != ProcessAccessType::None) {
</span><del>- for (auto processPool : processPools()) {
</del><ins>+ for (auto& processPool : processPools()) {
</ins><span class="cx"> switch (networkProcessAccessType) {
</span><span class="cx"> case ProcessAccessType::OnlyIfLaunched:
</span><span class="cx"> if (!processPool->networkProcess())
</span><span class="lines">@@ -360,7 +360,7 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(DATABASE_PROCESS)
</span><span class="cx"> if (dataTypes & WebsiteDataTypeIndexedDBDatabases && isPersistent()) {
</span><del>- for (auto processPool : processPools()) {
</del><ins>+ for (auto& processPool : processPools()) {
</ins><span class="cx"> processPool->ensureDatabaseProcess();
</span><span class="cx">
</span><span class="cx"> callbackAggregator->addPendingCallback();
</span><span class="lines">@@ -512,7 +512,7 @@
</span><span class="cx">
</span><span class="cx"> auto networkProcessAccessType = computeNetworkProcessAccessTypeForDataRemoval(dataTypes, !isPersistent());
</span><span class="cx"> if (networkProcessAccessType != ProcessAccessType::None) {
</span><del>- for (auto processPool : processPools()) {
</del><ins>+ for (auto& processPool : processPools()) {
</ins><span class="cx"> switch (networkProcessAccessType) {
</span><span class="cx"> case ProcessAccessType::OnlyIfLaunched:
</span><span class="cx"> if (!processPool->networkProcess())
</span><span class="lines">@@ -607,7 +607,7 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(DATABASE_PROCESS)
</span><span class="cx"> if (dataTypes & WebsiteDataTypeIndexedDBDatabases && isPersistent()) {
</span><del>- for (auto processPool : processPools()) {
</del><ins>+ for (auto& processPool : processPools()) {
</ins><span class="cx"> processPool->ensureDatabaseProcess();
</span><span class="cx">
</span><span class="cx"> callbackAggregator->addPendingCallback();
</span><span class="lines">@@ -727,7 +727,7 @@
</span><span class="cx">
</span><span class="cx"> auto networkProcessAccessType = computeNetworkProcessAccessTypeForDataRemoval(dataTypes, !isPersistent());
</span><span class="cx"> if (networkProcessAccessType != ProcessAccessType::None) {
</span><del>- for (auto processPool : processPools()) {
</del><ins>+ for (auto& processPool : processPools()) {
</ins><span class="cx"> switch (networkProcessAccessType) {
</span><span class="cx"> case ProcessAccessType::OnlyIfLaunched:
</span><span class="cx"> if (!processPool->networkProcess())
</span><span class="lines">@@ -843,7 +843,7 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(DATABASE_PROCESS)
</span><span class="cx"> if (dataTypes & WebsiteDataTypeIndexedDBDatabases && isPersistent()) {
</span><del>- for (auto processPool : processPools()) {
</del><ins>+ for (auto& processPool : processPools()) {
</ins><span class="cx"> processPool->ensureDatabaseProcess();
</span><span class="cx">
</span><span class="cx"> callbackAggregator->addPendingCallback();
</span><span class="lines">@@ -1001,7 +1001,7 @@
</span><span class="cx"> {
</span><span class="cx"> Vector<PluginModuleInfo> plugins;
</span><span class="cx">
</span><del>- for (auto processPool : processPools()) {
</del><ins>+ for (auto& processPool : processPools()) {
</ins><span class="cx"> for (auto& plugin : processPool->pluginInfoStore().plugins())
</span><span class="cx"> plugins.append(plugin);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourcebmallocChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/ChangeLog (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/ChangeLog 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/bmalloc/ChangeLog 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-10-13 Chris Dumez <cdumez@apple.com>
+
+ Avoid useless copies in range-loops that are using 'auto'
+ https://bugs.webkit.org/show_bug.cgi?id=150091
+
+ Reviewed by Sam Weinig.
+
+ Avoid useless copies in range-loops that are using 'auto'. Also use
+ 'auto*' instead of 'auto' when range values are pointers for clarity.
+
+ * bmalloc/Deallocator.cpp:
+ (bmalloc::Deallocator::processObjectLog):
+
</ins><span class="cx"> 2015-10-12 Geoffrey Garen <ggaren@apple.com>
</span><span class="cx">
</span><span class="cx"> bmalloc: Don't ASSERT that all syscalls succeed
</span></span></pre></div>
<a id="trunkSourcebmallocbmallocDeallocatorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/bmalloc/Deallocator.cpp (191001 => 191002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/bmalloc/Deallocator.cpp 2015-10-13 19:03:46 UTC (rev 191001)
+++ trunk/Source/bmalloc/bmalloc/Deallocator.cpp 2015-10-13 19:15:55 UTC (rev 191002)
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx"> std::lock_guard<StaticMutex> lock(PerProcess<Heap>::mutex());
</span><span class="cx"> Heap* heap = PerProcess<Heap>::getFastCase();
</span><span class="cx">
</span><del>- for (auto object : m_objectLog) {
</del><ins>+ for (auto* object : m_objectLog) {
</ins><span class="cx"> if (isSmall(object)) {
</span><span class="cx"> SmallLine* line = SmallLine::get(object);
</span><span class="cx"> heap->derefSmallLine(lock, line);
</span></span></pre>
</div>
</div>
</body>
</html>