<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[191031] trunk/Tools</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/191031">191031</a></dd>

<dt>Author</dt> <dd>ap@apple.com</dd>

<dt>Date</dt> <dd>2015-10-13 21:54:37 -0700 (Tue, 13 Oct 2015)</dd>

</dl>

<h3>Log Message</h3>

<pre>Build fix for mac-debug EWS queue.

Unreviewed.

Pass --debug to run-webkit-tests.

While at it, removed unsupported run_webkit_unit_tests_command. All the test steps

will need to be substantially modified to work in EWS, so the dummy implementation

was not helpful.

* Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.run_javascriptcore_tests_command):

(DeprecatedPort):

(DeprecatedPort.run_webkit_tests_command):

(DeprecatedPort.run_python_unittests_command):

(DeprecatedPort.run_webkit_unit_tests_command): Deleted.

* Scripts/webkitpy/common/config/ports_mock.py:

(MockPort.run_javascriptcore_tests_command):

(MockPort):

(MockPort.run_webkit_tests_command):

(MockPort.run_bindings_tests_command):

(MockPort.run_webkit_unit_tests_command): Deleted.

* Scripts/webkitpy/tool/commands/download_unittest.py:

* Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

* Scripts/webkitpy/tool/steps/runtests_unittest.py:

(RunTestsTest.test_webkit_run_unit_tests):

* Scripts/webkitpy/tool/steps/steps_unittest.py:

(StepsTest.test_runtests_args):</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>

<li><a href="#trunkToolsScriptswebkitpycommonconfigportspy">trunk/Tools/Scripts/webkitpy/common/config/ports.py</a></li>

<li><a href="#trunkToolsScriptswebkitpycommonconfigports_mockpy">trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py</a></li>

<li><a href="#trunkToolsScriptswebkitpytoolcommandsdownload_unittestpy">trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py</a></li>

<li><a href="#trunkToolsScriptswebkitpytoolstepsruntestspy">trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py</a></li>

<li><a href="#trunkToolsScriptswebkitpytoolstepsruntests_unittestpy">trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py</a></li>

<li><a href="#trunkToolsScriptswebkitpytoolstepssteps_unittestpy">trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkToolsChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (191030 => 191031)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Tools/ChangeLog        2015-10-14 03:56:53 UTC (rev 191030)

+++ trunk/Tools/ChangeLog        2015-10-14 04:54:37 UTC (rev 191031)

</span><span class="lines">@@ -1,3 +1,35 @@

</span><ins>+2015-10-13  Alexey Proskuryakov  &lt;ap@apple.com&gt;

+

+        Build fix for mac-debug EWS queue.

+

+        Unreviewed.

+

+        Pass --debug to run-webkit-tests.

+

+        While at it, removed unsupported run_webkit_unit_tests_command. All the test steps

+        will need to be substantially modified to work in EWS, so the dummy implementation

+        was not helpful.

+

+        * Scripts/webkitpy/common/config/ports.py:

+        (DeprecatedPort.run_javascriptcore_tests_command):

+        (DeprecatedPort):

+        (DeprecatedPort.run_webkit_tests_command):

+        (DeprecatedPort.run_python_unittests_command):

+        (DeprecatedPort.run_webkit_unit_tests_command): Deleted.

+        * Scripts/webkitpy/common/config/ports_mock.py:

+        (MockPort.run_javascriptcore_tests_command):

+        (MockPort):

+        (MockPort.run_webkit_tests_command):

+        (MockPort.run_bindings_tests_command):

+        (MockPort.run_webkit_unit_tests_command): Deleted.

+        * Scripts/webkitpy/tool/commands/download_unittest.py:

+        * Scripts/webkitpy/tool/steps/runtests.py:

+        (RunTests.run):

+        * Scripts/webkitpy/tool/steps/runtests_unittest.py:

+        (RunTestsTest.test_webkit_run_unit_tests):

+        * Scripts/webkitpy/tool/steps/steps_unittest.py:

+        (StepsTest.test_runtests_args):

+

</ins><span class="cx"> 2015-10-13  Brent Fulgham  &lt;bfulgham@apple.com&gt;

</span><span class="cx"> 

</span><span class="cx">         [Win] Generate Crash Traces

</span></span></pre></div>

<a id="trunkToolsScriptswebkitpycommonconfigportspy"></a>

<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/common/config/ports.py (191030 => 191031)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Tools/Scripts/webkitpy/common/config/ports.py        2015-10-14 03:56:53 UTC (rev 191030)

+++ trunk/Tools/Scripts/webkitpy/common/config/ports.py        2015-10-14 04:54:37 UTC (rev 191031)

</span><span class="lines">@@ -104,12 +104,14 @@

</span><span class="cx">     def run_javascriptcore_tests_command(self):

</span><span class="cx">         return self.script_shell_command(&quot;run-javascriptcore-tests&quot;)

</span><span class="cx"> 

</span><del>-    def run_webkit_unit_tests_command(self):

-        return None

</del><ins>+    def run_webkit_tests_command(self, build_style=None):

+        command = self.script_shell_command(&quot;run-webkit-tests&quot;)

+        if build_style == &quot;debug&quot;:

+            command.append(&quot;--debug&quot;)

+        if build_style == &quot;release&quot;:

+            command.append(&quot;--release&quot;)

+        return command

</ins><span class="cx"> 

</span><del>-    def run_webkit_tests_command(self):

-        return self.script_shell_command(&quot;run-webkit-tests&quot;)

-

</del><span class="cx">     def run_python_unittests_command(self):

</span><span class="cx">         return self.script_shell_command(&quot;test-webkitpy&quot;)

</span><span class="cx"> 

</span></span></pre></div>

<a id="trunkToolsScriptswebkitpycommonconfigports_mockpy"></a>

<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py (191030 => 191031)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py        2015-10-14 03:56:53 UTC (rev 191030)

+++ trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py        2015-10-14 04:54:37 UTC (rev 191031)

</span><span class="lines">@@ -52,10 +52,7 @@

</span><span class="cx">     def run_javascriptcore_tests_command(self):

</span><span class="cx">         return ['mock-run-javacriptcore-tests']

</span><span class="cx"> 

</span><del>-    def run_webkit_unit_tests_command(self):

-        return ['mock-run-webkit-unit-tests']

-

-    def run_webkit_tests_command(self):

</del><ins>+    def run_webkit_tests_command(self, build_style=None):

</ins><span class="cx">         return ['mock-run-webkit-tests']

</span><span class="cx"> 

</span><span class="cx">     def run_bindings_tests_command(self):

</span></span></pre></div>

<a id="trunkToolsScriptswebkitpytoolcommandsdownload_unittestpy"></a>

<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py (191030 => 191031)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py        2015-10-14 03:56:53 UTC (rev 191030)

+++ trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py        2015-10-14 04:54:37 UTC (rev 191031)

</span><span class="lines">@@ -76,7 +76,7 @@

</span><span class="cx">     def _default_options(self):

</span><span class="cx">         options = MockOptions()

</span><span class="cx">         options.build = True

</span><del>-        options.build_style = True

</del><ins>+        options.build_style = &quot;release&quot;

</ins><span class="cx">         options.check_style = True

</span><span class="cx">         options.check_style_filter = None

</span><span class="cx">         options.clean = True

</span><span class="lines">@@ -101,7 +101,6 @@

</span><span class="cx"> Running Perl unit tests

</span><span class="cx"> Running JavaScriptCore tests

</span><span class="cx"> Running bindings generation tests

</span><del>-Running WebKit unit tests

</del><span class="cx"> Running run-webkit-tests

</span><span class="cx"> &quot;&quot;&quot;

</span><span class="cx">         self.assert_execute_outputs(BuildAndTest(), [], options=self._default_options(), expected_logs=expected_logs)

</span><span class="lines">@@ -143,7 +142,6 @@

</span><span class="cx"> Running Perl unit tests

</span><span class="cx"> Running JavaScriptCore tests

</span><span class="cx"> Running bindings generation tests

</span><del>-Running WebKit unit tests

</del><span class="cx"> Running run-webkit-tests

</span><span class="cx"> Committed r49824: &lt;http://trac.webkit.org/changeset/49824&gt;

</span><span class="cx"> Updating bug 50000

</span><span class="lines">@@ -172,8 +170,6 @@

</span><span class="cx"> MOCK run_and_throw_if_fail: ['mock-run-javacriptcore-tests'], cwd=/mock-checkout

</span><span class="cx"> Running bindings generation tests

</span><span class="cx"> MOCK run_and_throw_if_fail: ['mock-run-bindings-tests'], cwd=/mock-checkout

</span><del>-Running WebKit unit tests

-MOCK run_and_throw_if_fail: ['mock-run-webkit-unit-tests'], cwd=/mock-checkout

</del><span class="cx"> Running run-webkit-tests

</span><span class="cx"> MOCK run_and_throw_if_fail: ['mock-run-webkit-tests', '--quiet'], cwd=/mock-checkout

</span><span class="cx"> Committed r49824: &lt;http://trac.webkit.org/changeset/49824&gt;

</span><span class="lines">@@ -192,7 +188,6 @@

</span><span class="cx"> Running Perl unit tests

</span><span class="cx"> Running JavaScriptCore tests

</span><span class="cx"> Running bindings generation tests

</span><del>-Running WebKit unit tests

</del><span class="cx"> Running run-webkit-tests

</span><span class="cx"> Committed r49824: &lt;http://trac.webkit.org/changeset/49824&gt;

</span><span class="cx"> Updating bug 50000

</span><span class="lines">@@ -224,7 +219,6 @@

</span><span class="cx"> Running Perl unit tests

</span><span class="cx"> Running JavaScriptCore tests

</span><span class="cx"> Running bindings generation tests

</span><del>-Running WebKit unit tests

</del><span class="cx"> Running run-webkit-tests

</span><span class="cx"> Committed r49824: &lt;http://trac.webkit.org/changeset/49824&gt;