<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190908] trunk/PerformanceTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190908">190908</a></dd>
<dt>Author</dt> <dd>jonlee@apple.com</dd>
<dt>Date</dt> <dd>2015-10-12 17:11:16 -0700 (Mon, 12 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Refactor tune() to pass in an integer-based count
https://bugs.webkit.org/show_bug.cgi?id=150060
<rdar://problem/23079425>
Reviewed by Dean Jackson.
All of the tune functions do an initial step of flooring the
# of painting objects to add or remove. Factor that out since
the complexity of all of these tests is always expressed in terms
of countable items.
* Animometer/tests/resources/main.js:
(Benchmark.prototype.update): Update the tuneValue.
* Animometer/tests/bouncing-particles/resources/bouncing-particles.js:
(BouncingParticlesStage.prototype.tune): Remove the count adjustment.
* Animometer/tests/examples/resources/canvas-electrons.js:
(CanvasElectronsStage.prototype.tune): Ditto.
* Animometer/tests/examples/resources/canvas-stars.js:
(CanvasStarsStage.prototype.tune): Ditto.
* Animometer/tests/text/resources/layering-text.js:
(LayeringTextStage.prototype.tune): Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkPerformanceTestsAnimometertestsbouncingparticlesresourcesbouncingparticlesjs">trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js</a></li>
<li><a href="#trunkPerformanceTestsAnimometertestsexamplesresourcescanvaselectronsjs">trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-electrons.js</a></li>
<li><a href="#trunkPerformanceTestsAnimometertestsexamplesresourcescanvasstarsjs">trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-stars.js</a></li>
<li><a href="#trunkPerformanceTestsAnimometertestsresourcesmainjs">trunk/PerformanceTests/Animometer/tests/resources/main.js</a></li>
<li><a href="#trunkPerformanceTestsAnimometerteststextresourceslayeringtextjs">trunk/PerformanceTests/Animometer/tests/text/resources/layering-text.js</a></li>
<li><a href="#trunkPerformanceTestsChangeLog">trunk/PerformanceTests/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkPerformanceTestsAnimometertestsbouncingparticlesresourcesbouncingparticlesjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js (190907 => 190908)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js 2015-10-13 00:03:31 UTC (rev 190907)
+++ trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js 2015-10-13 00:11:16 UTC (rev 190908)
</span><span class="lines">@@ -95,8 +95,6 @@
</span><span class="cx">
</span><span class="cx"> BouncingParticlesStage.prototype.tune = function(count)
</span><span class="cx"> {
</span><del>- count = count > 0 ? Math.floor(count) : Math.ceil(count);
-
</del><span class="cx"> if (count == 0)
</span><span class="cx"> return this._particles.length;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkPerformanceTestsAnimometertestsexamplesresourcescanvaselectronsjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-electrons.js (190907 => 190908)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-electrons.js 2015-10-13 00:03:31 UTC (rev 190907)
+++ trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-electrons.js 2015-10-13 00:11:16 UTC (rev 190908)
</span><span class="lines">@@ -60,8 +60,6 @@
</span><span class="cx">
</span><span class="cx"> CanvasElectronsStage.prototype.tune = function(count)
</span><span class="cx"> {
</span><del>- count = count > 0 ? Math.floor(count) : Math.ceil(count);
-
</del><span class="cx"> if (count == 0)
</span><span class="cx"> return this._electrons.length;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkPerformanceTestsAnimometertestsexamplesresourcescanvasstarsjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-stars.js (190907 => 190908)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-stars.js 2015-10-13 00:03:31 UTC (rev 190907)
+++ trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-stars.js 2015-10-13 00:11:16 UTC (rev 190908)
</span><span class="lines">@@ -61,8 +61,6 @@
</span><span class="cx">
</span><span class="cx"> CanvasStarsStage.prototype.tune = function(count)
</span><span class="cx"> {
</span><del>- count = count > 0 ? Math.floor(count) : Math.ceil(count);
-
</del><span class="cx"> if (count == 0)
</span><span class="cx"> return this._objects.length;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkPerformanceTestsAnimometertestsresourcesmainjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/tests/resources/main.js (190907 => 190908)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/tests/resources/main.js 2015-10-13 00:03:31 UTC (rev 190907)
+++ trunk/PerformanceTests/Animometer/tests/resources/main.js 2015-10-13 00:11:16 UTC (rev 190908)
</span><span class="lines">@@ -183,6 +183,7 @@
</span><span class="cx"> // The relationship between frameRate and test complexity is inverse-proportional so we
</span><span class="cx"> // need to use the negative of PIDController.tune() to change the complexity of the test.
</span><span class="cx"> tuneValue = -this._controller.tune(currentFrameRate, timeDelta / 1000);
</span><ins>+ tuneValue = tuneValue > 0 ? Math.floor(tuneValue) : Math.ceil(tuneValue);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var currentComplexity = this.tune(tuneValue);
</span></span></pre></div>
<a id="trunkPerformanceTestsAnimometerteststextresourceslayeringtextjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/tests/text/resources/layering-text.js (190907 => 190908)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/tests/text/resources/layering-text.js 2015-10-13 00:03:31 UTC (rev 190907)
+++ trunk/PerformanceTests/Animometer/tests/text/resources/layering-text.js 2015-10-13 00:11:16 UTC (rev 190908)
</span><span class="lines">@@ -220,8 +220,6 @@
</span><span class="cx">
</span><span class="cx"> LayeringTextStage.prototype.tune = function(count)
</span><span class="cx"> {
</span><del>- count = count > 0 ? Math.floor(count) : Math.ceil(count);
-
</del><span class="cx"> if (count == 0)
</span><span class="cx"> return this._textElements.length;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkPerformanceTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/ChangeLog (190907 => 190908)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/ChangeLog 2015-10-13 00:03:31 UTC (rev 190907)
+++ trunk/PerformanceTests/ChangeLog 2015-10-13 00:11:16 UTC (rev 190908)
</span><span class="lines">@@ -1,5 +1,30 @@
</span><span class="cx"> 2015-10-12 Jon Lee <jonlee@apple.com>
</span><span class="cx">
</span><ins>+ Refactor tune() to pass in an integer-based count
+ https://bugs.webkit.org/show_bug.cgi?id=150060
+ <rdar://problem/23079425>
+
+ Reviewed by Dean Jackson.
+
+ All of the tune functions do an initial step of flooring the
+ # of painting objects to add or remove. Factor that out since
+ the complexity of all of these tests is always expressed in terms
+ of countable items.
+
+ * Animometer/tests/resources/main.js:
+ (Benchmark.prototype.update): Update the tuneValue.
+
+ * Animometer/tests/bouncing-particles/resources/bouncing-particles.js:
+ (BouncingParticlesStage.prototype.tune): Remove the count adjustment.
+ * Animometer/tests/examples/resources/canvas-electrons.js:
+ (CanvasElectronsStage.prototype.tune): Ditto.
+ * Animometer/tests/examples/resources/canvas-stars.js:
+ (CanvasStarsStage.prototype.tune): Ditto.
+ * Animometer/tests/text/resources/layering-text.js:
+ (LayeringTextStage.prototype.tune): Ditto.
+
+2015-10-12 Jon Lee <jonlee@apple.com>
+
</ins><span class="cx"> Store test-interval in localStorage
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=150055
</span><span class="cx"> <rdar://problem/23078879>
</span></span></pre>
</div>
</div>
</body>
</html>