<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190901] trunk/PerformanceTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190901">190901</a></dd>
<dt>Author</dt> <dd>jonlee@apple.com</dd>
<dt>Date</dt> <dd>2015-10-12 16:20:24 -0700 (Mon, 12 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update graph styles for legibility.
https://bugs.webkit.org/show_bug.cgi?id=150052
<rdar://problem/23078503>
Reviewed by Dean Jackson.
* Animometer/runner/resources/animometer.css: Update colors and
stroke thicknesses to make the graphs easier to read.
(.smaple-time): Correct to .sample-time
* Animometer/runner/resources/graph.js:
(graph): Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkPerformanceTestsAnimometerrunnerresourcesanimometercss">trunk/PerformanceTests/Animometer/runner/resources/animometer.css</a></li>
<li><a href="#trunkPerformanceTestsAnimometerrunnerresourcesgraphjs">trunk/PerformanceTests/Animometer/runner/resources/graph.js</a></li>
<li><a href="#trunkPerformanceTestsChangeLog">trunk/PerformanceTests/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkPerformanceTestsAnimometerrunnerresourcesanimometercss"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/runner/resources/animometer.css (190900 => 190901)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/runner/resources/animometer.css 2015-10-12 23:05:43 UTC (rev 190900)
+++ trunk/PerformanceTests/Animometer/runner/resources/animometer.css 2015-10-12 23:20:24 UTC (rev 190901)
</span><span class="lines">@@ -186,36 +186,38 @@
</span><span class="cx"> .axis path,
</span><span class="cx"> .axis line {
</span><span class="cx"> fill: none;
</span><del>- stroke: rgb(235, 235, 235);
</del><ins>+ stroke: #999;
</ins><span class="cx"> shape-rendering: crispEdges;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .left-samples {
</span><span class="cx"> fill: none;
</span><del>- stroke: steelblue;
</del><ins>+ stroke: #7ADD49;
</ins><span class="cx"> stroke-width: 1.5px;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .right-samples {
</span><span class="cx"> fill: none;
</span><del>- stroke: red;
</del><ins>+ stroke: #FA4925;
</ins><span class="cx"> stroke-width: 1.5px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.smaple-time {
</del><ins>+.sample-time {
</ins><span class="cx"> fill: none;
</span><del>- stroke: green;
- stroke-width: 1.5px;
</del><ins>+ stroke: #5493D6;
+ stroke-width: 1px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .left-mean {
</span><span class="cx"> fill: none;
</span><del>- stroke: yellow;
- stroke-width: 1.5px;
</del><ins>+ stroke: #7ADD49;
+ stroke-width: 1px;
+ opacity: .8;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .right-mean {
</span><span class="cx"> fill: none;
</span><del>- stroke: magenta;
- stroke-width: 1.5px;
</del><ins>+ stroke: #FA4925;
+ stroke-width: 1px;
+ opacity: .8;
</ins><span class="cx"> }
</span></span></pre></div>
<a id="trunkPerformanceTestsAnimometerrunnerresourcesgraphjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/runner/resources/graph.js (190900 => 190901)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/runner/resources/graph.js 2015-10-12 23:05:43 UTC (rev 190900)
+++ trunk/PerformanceTests/Animometer/runner/resources/graph.js 2015-10-12 23:20:24 UTC (rev 190901)
</span><span class="lines">@@ -76,13 +76,13 @@
</span><span class="cx"> // yLeft-axis
</span><span class="cx"> svg.append("g")
</span><span class="cx"> .attr("class", "y axis")
</span><del>- .attr("fill", "steelblue")
</del><ins>+ .attr("fill", "#7ADD49")
</ins><span class="cx"> .call(yAxisLeft)
</span><span class="cx"> .append("text")
</span><span class="cx"> .attr("class", "label")
</span><span class="cx"> .attr("transform", "rotate(-90)")
</span><span class="cx"> .attr("y", 6)
</span><del>- .attr("fill", "steelblue")
</del><ins>+ .attr("fill", "#7ADD49")
</ins><span class="cx"> .attr("dy", ".71em")
</span><span class="cx"> .style("text-anchor", "end")
</span><span class="cx"> .text(axes[0]);
</span><span class="lines">@@ -90,14 +90,14 @@
</span><span class="cx"> // yRight-axis
</span><span class="cx"> svg.append("g")
</span><span class="cx"> .attr("class", "y axis")
</span><del>- .attr("fill", "red")
</del><ins>+ .attr("fill", "#FA4925")
</ins><span class="cx"> .attr("transform", "translate(" + size.width + ", 0)")
</span><span class="cx"> .call(yAxisRight)
</span><span class="cx"> .append("text")
</span><span class="cx"> .attr("class", "label")
</span><span class="cx"> .attr("transform", "rotate(-90)")
</span><span class="cx"> .attr("y", 6)
</span><del>- .attr("fill", "red")
</del><ins>+ .attr("fill", "#FA4925")
</ins><span class="cx"> .attr("dy", ".71em")
</span><span class="cx"> .style("text-anchor", "end")
</span><span class="cx"> .text(axes[1]);
</span><span class="lines">@@ -124,7 +124,7 @@
</span><span class="cx"> .attr("x2", x(samplingTimeOffset))
</span><span class="cx"> .attr("y1", yLeft(0))
</span><span class="cx"> .attr("y2", yLeft(yAxisLeft.scale().domain()[1]))
</span><del>- .attr("class", "smaple-time");
</del><ins>+ .attr("class", "sample-time");
</ins><span class="cx">
</span><span class="cx"> // left-samples
</span><span class="cx"> svg.append("path")
</span></span></pre></div>
<a id="trunkPerformanceTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/ChangeLog (190900 => 190901)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/ChangeLog 2015-10-12 23:05:43 UTC (rev 190900)
+++ trunk/PerformanceTests/ChangeLog 2015-10-12 23:20:24 UTC (rev 190901)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-10-12 Jon Lee <jonlee@apple.com>
+
+ Update graph styles for legibility.
+ https://bugs.webkit.org/show_bug.cgi?id=150052
+ <rdar://problem/23078503>
+
+ Reviewed by Dean Jackson.
+
+ * Animometer/runner/resources/animometer.css: Update colors and
+ stroke thicknesses to make the graphs easier to read.
+ (.smaple-time): Correct to .sample-time
+ * Animometer/runner/resources/graph.js:
+ (graph): Ditto.
+
</ins><span class="cx"> 2015-10-12 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, revert an unintended commit.
</span></span></pre>
</div>
</div>
</body>
</html>