<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190818] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190818">190818</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2015-10-09 14:07:25 -0700 (Fri, 09 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Garbage pixels on enphaseenergy.com site
https://bugs.webkit.org/show_bug.cgi?id=149915
rdar://problem/22976184
Reviewed by Darin Adler.
Source/WebCore:
When the <html> gets a composited RenderLayer, and we ask whether its background
is opaque, return false, since the document element's background propagates
to the root, and is painted by the RenderView.
Also improve the compositing logging to indicate when fore- and background layers
are present.
Test: compositing/contents-opaque/negative-z-before-html.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
LayoutTests:
New ref test. Also update the expected result for another test that uses negative
z-index children.
* compositing/contents-opaque/body-background-painted-expected.txt:
* compositing/contents-opaque/negative-z-before-html-expected.html: Added.
* compositing/contents-opaque/negative-z-before-html.html: Added.
* platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestscompositingcontentsopaquebodybackgroundpaintedexpectedtxt">trunk/LayoutTests/compositing/contents-opaque/body-background-painted-expected.txt</a></li>
<li><a href="#trunkLayoutTestscompositingcontentsopaquebodybackgroundpaintedhtml">trunk/LayoutTests/compositing/contents-opaque/body-background-painted.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2compositingcontentsopaquebodybackgroundpaintedexpectedtxt">trunk/LayoutTests/platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerCompositorcpp">trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscompositingcontentsopaquenegativezbeforehtmlexpectedhtml">trunk/LayoutTests/compositing/contents-opaque/negative-z-before-html-expected.html</a></li>
<li><a href="#trunkLayoutTestscompositingcontentsopaquenegativezbeforehtmlhtml">trunk/LayoutTests/compositing/contents-opaque/negative-z-before-html.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (190817 => 190818)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-10-09 21:00:27 UTC (rev 190817)
+++ trunk/LayoutTests/ChangeLog 2015-10-09 21:07:25 UTC (rev 190818)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-10-09 Simon Fraser <simon.fraser@apple.com>
+
+ Garbage pixels on enphaseenergy.com site
+ https://bugs.webkit.org/show_bug.cgi?id=149915
+ rdar://problem/22976184
+
+ Reviewed by Darin Adler.
+
+ New ref test. Also update the expected result for another test that uses negative
+ z-index children.
+
+ * compositing/contents-opaque/body-background-painted-expected.txt:
+ * compositing/contents-opaque/negative-z-before-html-expected.html: Added.
+ * compositing/contents-opaque/negative-z-before-html.html: Added.
+ * platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt:
+
</ins><span class="cx"> 2015-10-09 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><span class="cx"> Dynamic background color changes do not update until a layout is forced
</span></span></pre></div>
<a id="trunkLayoutTestscompositingcontentsopaquebodybackgroundpaintedexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/compositing/contents-opaque/body-background-painted-expected.txt (190817 => 190818)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/contents-opaque/body-background-painted-expected.txt 2015-10-09 21:00:27 UTC (rev 190817)
+++ trunk/LayoutTests/compositing/contents-opaque/body-background-painted-expected.txt 2015-10-09 21:07:25 UTC (rev 190818)
</span><span class="lines">@@ -8,7 +8,6 @@
</span><span class="cx"> (children 1
</span><span class="cx"> (GraphicsLayer
</span><span class="cx"> (bounds 800.00 600.00)
</span><del>- (contentsOpaque 1)
</del><span class="cx"> (drawsContent 1)
</span><span class="cx"> (children 2
</span><span class="cx"> (GraphicsLayer
</span></span></pre></div>
<a id="trunkLayoutTestscompositingcontentsopaquebodybackgroundpaintedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/compositing/contents-opaque/body-background-painted.html (190817 => 190818)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/contents-opaque/body-background-painted.html 2015-10-09 21:00:27 UTC (rev 190817)
+++ trunk/LayoutTests/compositing/contents-opaque/body-background-painted.html 2015-10-09 21:07:25 UTC (rev 190818)
</span><span class="lines">@@ -28,7 +28,7 @@
</span><span class="cx"> </head>
</span><span class="cx"> <!-- Composited body over the child div. -->
</span><span class="cx"> <!-- Root <html> element has a background-color. -->
</span><del>- <!-- Background for the body element is painted in this case. ->
</del><ins>+ <!-- Background for the body element is painted in this case. -->
</ins><span class="cx"> <!-- GraphicsLayer::contentsOpaque for the body layer should be false. -->
</span><span class="cx"> <body>
</span><span class="cx"> <!-- Box under the body. -->
</span></span></pre></div>
<a id="trunkLayoutTestscompositingcontentsopaquenegativezbeforehtmlexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/contents-opaque/negative-z-before-html-expected.html (0 => 190818)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/contents-opaque/negative-z-before-html-expected.html (rev 0)
+++ trunk/LayoutTests/compositing/contents-opaque/negative-z-before-html-expected.html 2015-10-09 21:07:25 UTC (rev 190818)
</span><span class="lines">@@ -0,0 +1,28 @@
</span><ins>+<html>
+<head>
+ <style>
+ body {
+ margin: 0;
+ }
+
+ .before {
+ background: blue;
+ margin: 10px;
+ width: 200px;
+ height: 200px;
+ position: fixed;
+ }
+
+ html {
+ background-image: linear-gradient(white, white);
+ background-attachment: fixed;
+ background-position: 50% 50%;
+ background-size: 400px 400px;
+ background-color: red;
+ }
+ </style>
+</head>
+<body>
+ <div class="before"></div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestscompositingcontentsopaquenegativezbeforehtmlhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/contents-opaque/negative-z-before-html.html (0 => 190818)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/contents-opaque/negative-z-before-html.html (rev 0)
+++ trunk/LayoutTests/compositing/contents-opaque/negative-z-before-html.html 2015-10-09 21:07:25 UTC (rev 190818)
</span><span class="lines">@@ -0,0 +1,29 @@
</span><ins>+<html>
+<head>
+ <style>
+ body {
+ margin: 0;
+ }
+
+ html:before {
+ content: '';
+ background: blue;
+ margin: 10px;
+ width: 200px;
+ height: 200px;
+ position: fixed;
+ z-index: -1;
+ }
+
+ html {
+ background-image: linear-gradient(white, white);
+ background-attachment: fixed;
+ background-position: 50% 50%;
+ background-size: 400px 400px;
+ background-color: red;
+ }
+ </style>
+</head>
+<body>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2compositingcontentsopaquebodybackgroundpaintedexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt (190817 => 190818)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt 2015-10-09 21:00:27 UTC (rev 190817)
+++ trunk/LayoutTests/platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt 2015-10-09 21:07:25 UTC (rev 190818)
</span><span class="lines">@@ -9,7 +9,6 @@
</span><span class="cx"> (children 1
</span><span class="cx"> (GraphicsLayer
</span><span class="cx"> (bounds 800.00 600.00)
</span><del>- (contentsOpaque 1)
</del><span class="cx"> (drawsContent 1)
</span><span class="cx"> (children 2
</span><span class="cx"> (GraphicsLayer
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (190817 => 190818)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-10-09 21:00:27 UTC (rev 190817)
+++ trunk/Source/WebCore/ChangeLog 2015-10-09 21:07:25 UTC (rev 190818)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2015-10-09 Simon Fraser <simon.fraser@apple.com>
+
+ Garbage pixels on enphaseenergy.com site
+ https://bugs.webkit.org/show_bug.cgi?id=149915
+ rdar://problem/22976184
+
+ Reviewed by Darin Adler.
+
+ When the <html> gets a composited RenderLayer, and we ask whether its background
+ is opaque, return false, since the document element's background propagates
+ to the root, and is painted by the RenderView.
+
+ Also improve the compositing logging to indicate when fore- and background layers
+ are present.
+
+ Test: compositing/contents-opaque/negative-z-before-html.html
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGeometry):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::logLayerInfo):
+
</ins><span class="cx"> 2015-10-09 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><span class="cx"> Dynamic background color changes do not update until a layout is forced
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (190817 => 190818)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2015-10-09 21:00:27 UTC (rev 190817)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2015-10-09 21:07:25 UTC (rev 190818)
</span><span class="lines">@@ -6127,6 +6127,12 @@
</span><span class="cx"> if (paintsWithTransparency(PaintBehaviorNormal))
</span><span class="cx"> return false;
</span><span class="cx">
</span><ins>+ if (renderer().isRoot()) {
+ // Normally the document element doens't have a layer. If it does have a layer, its background propagates to the RenderView
+ // so this layer doesn't draw it.
+ return false;
+ }
+
</ins><span class="cx"> // We can't use hasVisibleContent(), because that will be true if our renderer is hidden, but some child
</span><span class="cx"> // is visible and that child doesn't cover the entire rect.
</span><span class="cx"> if (renderer().style().visibility() != VISIBLE)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerCompositorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (190817 => 190818)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2015-10-09 21:00:27 UTC (rev 190817)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2015-10-09 21:07:25 UTC (rev 190818)
</span><span class="lines">@@ -861,12 +861,32 @@
</span><span class="cx"> logString.append(logReasonsForCompositing(layer));
</span><span class="cx"> logString.appendLiteral(") ");
</span><span class="cx">
</span><del>- if (backing->graphicsLayer()->contentsOpaque() || backing->paintsIntoCompositedAncestor()) {
</del><ins>+ if (backing->graphicsLayer()->contentsOpaque() || backing->paintsIntoCompositedAncestor() || backing->foregroundLayer() || backing->backgroundLayer()) {
</ins><span class="cx"> logString.append('[');
</span><del>- if (backing->graphicsLayer()->contentsOpaque())
</del><ins>+ bool prependSpace = false;
+ if (backing->graphicsLayer()->contentsOpaque()) {
</ins><span class="cx"> logString.appendLiteral("opaque");
</span><del>- if (backing->paintsIntoCompositedAncestor())
</del><ins>+ prependSpace = true;
+ }
+
+ if (backing->paintsIntoCompositedAncestor()) {
+ if (prependSpace)
+ logString.appendLiteral(", ");
</ins><span class="cx"> logString.appendLiteral("paints into ancestor");
</span><ins>+ prependSpace = true;
+ }
+
+ if (backing->foregroundLayer() || backing->backgroundLayer()) {
+ if (prependSpace)
+ logString.appendLiteral(", ");
+ if (backing->foregroundLayer() && backing->backgroundLayer())
+ logString.appendLiteral("foreground+background");
+ else if (backing->foregroundLayer())
+ logString.appendLiteral("foreground");
+ else
+ logString.appendLiteral("background");
+ }
+
</ins><span class="cx"> logString.appendLiteral("] ");
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>