<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190800] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190800">190800</a></dd>
<dt>Author</dt> <dd>wenson_hsieh@apple.com</dd>
<dt>Date</dt> <dd>2015-10-09 08:18:42 -0700 (Fri, 09 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Backgrounds bleed out of natively rendered text fields
https://bugs.webkit.org/show_bug.cgi?id=149843
<rdar://problem/22896977>
Reviewed by Darin Adler.
Source/WebCore:
When natively rendering a text field with a background on Mac, the background bleeds out
of the text field's border when the graphics context is scaled (as a result of a retina
display or zoom/scale effects). This is because when we render the text field in bezeled
style within a certain frame, AppKit adds 1 device pixel insets on all sides of the frame,
which renders a text field that is slightly smaller than the frame. To adjust for this, we
inflate the paint rect.
Test: fast/forms/hidpi-textfield-background-bleeding.html
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintTextField):
LayoutTests:
Add a layout test to check that the background of a natively rendered text field
cell does not bleed.
* TestExpectations:
* fast/forms/hidpi-textfield-background-bleeding-expected.html: Added.
* fast/forms/hidpi-textfield-background-bleeding.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorTestExpectations">trunk/LayoutTests/platform/ios-simulator/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeMacmm">trunk/Source/WebCore/rendering/RenderThemeMac.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastformshidpitextfieldbackgroundbleedingexpectedhtml">trunk/LayoutTests/fast/forms/hidpi-textfield-background-bleeding-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastformshidpitextfieldbackgroundbleedinghtml">trunk/LayoutTests/fast/forms/hidpi-textfield-background-bleeding.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (190799 => 190800)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-10-09 14:22:26 UTC (rev 190799)
+++ trunk/LayoutTests/ChangeLog 2015-10-09 15:18:42 UTC (rev 190800)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-10-08 Wenson Hsieh <wenson_hsieh@apple.com>
+
+ Backgrounds bleed out of natively rendered text fields
+ https://bugs.webkit.org/show_bug.cgi?id=149843
+ <rdar://problem/22896977>
+
+ Reviewed by Darin Adler.
+
+ Add a layout test to check that the background of a natively rendered text field
+ cell does not bleed.
+
+ * TestExpectations:
+ * fast/forms/hidpi-textfield-background-bleeding-expected.html: Added.
+ * fast/forms/hidpi-textfield-background-bleeding.html: Added.
+
</ins><span class="cx"> 2015-10-08 Nikita Vasilyev <nvasilyev@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Stack trace view doesn't properly display lines without function names
</span></span></pre></div>
<a id="trunkLayoutTestsfastformshidpitextfieldbackgroundbleedingexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/hidpi-textfield-background-bleeding-expected.html (0 => 190800)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/hidpi-textfield-background-bleeding-expected.html (rev 0)
+++ trunk/LayoutTests/fast/forms/hidpi-textfield-background-bleeding-expected.html 2015-10-09 15:18:42 UTC (rev 190800)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+<html>
+<head>
+ <style>
+ body {
+ margin: 0;
+ }
+
+ div {
+ position: absolute;
+ top: 0;
+ left: 0;
+ border: 0.5px black solid;
+ width: 99px;
+ height: 99px;
+ background-color: yellow;
+ }
+ </style>
+</head>
+
+<body>
+ <div />
+</body>
+
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastformshidpitextfieldbackgroundbleedinghtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/hidpi-textfield-background-bleeding.html (0 => 190800)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/hidpi-textfield-background-bleeding.html (rev 0)
+++ trunk/LayoutTests/fast/forms/hidpi-textfield-background-bleeding.html 2015-10-09 15:18:42 UTC (rev 190800)
</span><span class="lines">@@ -0,0 +1,28 @@
</span><ins>+<html>
+<head>
+ <style>
+ div, input {
+ position: absolute;
+ top: 0;
+ left: 0;
+ }
+
+ input {
+ background-color: yellow;
+ width: 100px;
+ height: 100px;
+ }
+
+ div {
+ border: 0.5px black solid;
+ width: 99px;
+ height: 99px;
+ }
+ </style>
+</head>
+
+<body>
+ <input /><div />
+</body>
+
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (190799 => 190800)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2015-10-09 14:22:26 UTC (rev 190799)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2015-10-09 15:18:42 UTC (rev 190800)
</span><span class="lines">@@ -1714,6 +1714,7 @@
</span><span class="cx"> fast/forms/focus-change-on-keypress.html [ Failure ]
</span><span class="cx"> fast/forms/focus-selection-input.html [ Failure ]
</span><span class="cx"> fast/forms/hidpi-textarea-on-subpixel-position.html [ ImageOnlyFailure ]
</span><ins>+fast/forms/hidpi-textfield-background-bleeding.html [ ImageOnlyFailure ]
</ins><span class="cx"> fast/forms/implicit-submission.html [ Failure ]
</span><span class="cx"> fast/forms/input-baseline.html [ Failure ]
</span><span class="cx"> fast/forms/input-first-letter-edit.html [ ImageOnlyFailure ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (190799 => 190800)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2015-10-09 14:22:26 UTC (rev 190799)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2015-10-09 15:18:42 UTC (rev 190800)
</span><span class="lines">@@ -728,6 +728,9 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/147254 media/restore-from-page-cache.html [ Pass Failure ]
</span><span class="cx">
</span><ins>+# After Mavericks, native text fields are rendered slightly smaller, causing backgrounds to bleed on platforms.
+[ Mavericks ] fast/forms/hidpi-textfield-background-bleeding.html [ ImageOnlyFailure ]
+
</ins><span class="cx"> # These fast/forms/select tests open a pop-up menu (visible on screen even when using run-webkit-tests), and get stuck in its nested event loop.
</span><span class="cx"> webkit.org/b/87748 fast/forms/select/optgroup-clicking.html [ Skip ]
</span><span class="cx"> webkit.org/b/73304 fast/forms/select/menulist-popup-crash.html [ Skip ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (190799 => 190800)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-10-09 14:22:26 UTC (rev 190799)
+++ trunk/Source/WebCore/ChangeLog 2015-10-09 15:18:42 UTC (rev 190800)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-10-08 Wenson Hsieh <wenson_hsieh@apple.com>
+
+ Backgrounds bleed out of natively rendered text fields
+ https://bugs.webkit.org/show_bug.cgi?id=149843
+ <rdar://problem/22896977>
+
+ Reviewed by Darin Adler.
+
+ When natively rendering a text field with a background on Mac, the background bleeds out
+ of the text field's border when the graphics context is scaled (as a result of a retina
+ display or zoom/scale effects). This is because when we render the text field in bezeled
+ style within a certain frame, AppKit adds 1 device pixel insets on all sides of the frame,
+ which renders a text field that is slightly smaller than the frame. To adjust for this, we
+ inflate the paint rect.
+
+ Test: fast/forms/hidpi-textfield-background-bleeding.html
+
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::paintTextField):
+
</ins><span class="cx"> 2015-10-09 Xabier Rodriguez Calvar <calvaris@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> Refactor WebCore JS builtins to prepare for automatic generation
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (190799 => 190800)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2015-10-09 14:22:26 UTC (rev 190799)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2015-10-09 15:18:42 UTC (rev 190800)
</span><span class="lines">@@ -853,12 +853,20 @@
</span><span class="cx"> {
</span><span class="cx"> LocalCurrentGraphicsContext localContext(paintInfo.context());
</span><span class="cx">
</span><ins>+ // <rdar://problem/22896977> We adjust the paint rect here to account for how AppKit draws the text
+ // field cell slightly smaller than the rect we pass to drawWithFrame.
+ FloatRect adjustedPaintRect(r);
+ AffineTransform transform = paintInfo.context().getCTM();
+ if (transform.xScale() > 1 || transform.yScale() > 1) {
+ adjustedPaintRect.inflateX(1 / transform.xScale());
+ adjustedPaintRect.inflateY(1 / transform.yScale());
+ }
</ins><span class="cx"> NSTextFieldCell *textField = this->textField();
</span><span class="cx">
</span><span class="cx"> GraphicsContextStateSaver stateSaver(paintInfo.context());
</span><span class="cx">
</span><span class="cx"> [textField setEnabled:(isEnabled(o) && !isReadOnlyControl(o))];
</span><del>- [textField drawWithFrame:NSRect(r) inView:documentViewFor(o)];
</del><ins>+ [textField drawWithFrame:NSRect(adjustedPaintRect) inView:documentViewFor(o)];
</ins><span class="cx">
</span><span class="cx"> [textField setControlView:nil];
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>