<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190733] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190733">190733</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2015-10-08 10:44:18 -0700 (Thu, 08 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>fast/events/scroll-after-click-on-tab-index.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=149859
Reviewed by Simon Fraser.
* fast/events/scroll-after-click-on-tab-index-expected.txt:
* fast/events/scroll-after-click-on-tab-index.html:
* platform/mac/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventsscrollafterclickontabindexexpectedtxt">trunk/LayoutTests/fast/events/scroll-after-click-on-tab-index-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsscrollafterclickontabindexhtml">trunk/LayoutTests/fast/events/scroll-after-click-on-tab-index.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (190732 => 190733)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-10-08 17:40:09 UTC (rev 190732)
+++ trunk/LayoutTests/ChangeLog 2015-10-08 17:44:18 UTC (rev 190733)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-10-08 Alexey Proskuryakov <ap@apple.com>
+
+ fast/events/scroll-after-click-on-tab-index.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=149859
+
+ Reviewed by Simon Fraser.
+
+ * fast/events/scroll-after-click-on-tab-index-expected.txt:
+ * fast/events/scroll-after-click-on-tab-index.html:
+ * platform/mac/TestExpectations:
+
</ins><span class="cx"> 2015-10-08 Jiewen Tan <jiewen_tan@apple.com>
</span><span class="cx">
</span><span class="cx"> Add NULL check for renderBox::layer() on applying zoom level change
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsscrollafterclickontabindexexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/scroll-after-click-on-tab-index-expected.txt (190732 => 190733)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/scroll-after-click-on-tab-index-expected.txt 2015-10-08 17:40:09 UTC (rev 190732)
+++ trunk/LayoutTests/fast/events/scroll-after-click-on-tab-index-expected.txt 2015-10-08 17:44:18 UTC (rev 190733)
</span><span class="lines">@@ -1,10 +1,9 @@
</span><span class="cx"> ALERT: Scroll position 0
</span><span class="cx"> Click the text below and then try to scroll.
</span><ins>+PASS Scroll position is more than 0
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><del>-Scroll position is more than 0
-PASS document.body.scrollTop > 0 is true
</del><span class="cx">
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsscrollafterclickontabindexhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/scroll-after-click-on-tab-index.html (190732 => 190733)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/scroll-after-click-on-tab-index.html 2015-10-08 17:40:09 UTC (rev 190732)
+++ trunk/LayoutTests/fast/events/scroll-after-click-on-tab-index.html 2015-10-08 17:44:18 UTC (rev 190733)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> <html>
</span><del>-<script src="../../resources/js-test-pre.js"></script>
</del><ins>+<script src="../../resources/js-test.js"></script>
</ins><span class="cx"> <script>
</span><span class="cx"> function getCenterFor(element)
</span><span class="cx"> {
</span><span class="lines">@@ -14,8 +14,7 @@
</span><span class="cx"> if (!window.eventSender)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- testRunner.waitUntilDone();
- testRunner.dumpAsText();
</del><ins>+ jsTestIsAsync = true;
</ins><span class="cx">
</span><span class="cx"> alert("Scroll position " + document.body.scrollTop);
</span><span class="cx"> center = getCenterFor(document.getElementById("sp"));
</span><span class="lines">@@ -23,14 +22,23 @@
</span><span class="cx"> eventSender.mouseDown();
</span><span class="cx"> eventSender.mouseUp();
</span><span class="cx"> eventSender.keyDown("downArrow");
</span><del>- setTimeout(verifyScrolling, 15);
</del><ins>+ intervalID = setInterval(function() {
+ if (document.body.scrollTop > 0) {
+ testPassed("Scroll position is more than 0");
+ done();
+ }
+ }, 10);
+ timeoutID = setTimeout(function() {
+ testFailed("Scroll position was still 10 after 20 seconds");
+ done();
+ }, 20000);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-function verifyScrolling()
</del><ins>+function done()
</ins><span class="cx"> {
</span><del>- debug("Scroll position is more than 0");
- shouldBe("document.body.scrollTop > 0", "true");
- testRunner.notifyDone();
</del><ins>+ clearInterval(intervalID);
+ clearTimeout(timeoutID);
+ finishJSTest();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> </script>
</span><span class="lines">@@ -39,7 +47,6 @@
</span><span class="cx"> <body onload="runTest();">
</span><span class="cx"> <input type="radio" id="myradio">Click the text below and then try to scroll.<br>
</span><span class="cx"> <div id="console"></div>
</span><del>-<script src="../../resources/js-test-post.js"></script>
</del><span class="cx"> <br><br><br><br><br><br><br><br><br><br>
</span><span class="cx"> <span tabindex=1 id="sp">My span</span>
</span><span class="cx"> <br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (190732 => 190733)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2015-10-08 17:40:09 UTC (rev 190732)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2015-10-08 17:44:18 UTC (rev 190733)
</span><span class="lines">@@ -1334,6 +1334,3 @@
</span><span class="cx">
</span><span class="cx"> # Marking test as flaky in El Capitan
</span><span class="cx"> webkit.org/b/149819 [ Debug ElCapitan+ ] compositing/video/video-poster.html [ Pass Crash ]
</span><del>-
-# Marking test as flaky
-webkit.org/b/149859 fast/events/scroll-after-click-on-tab-index.html [ Pass Failure ]
</del></span></pre>
</div>
</div>
</body>
</html>