<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190696] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190696">190696</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-10-07 17:17:21 -0700 (Wed, 07 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Allow custom revisions to be specified in A/B testing
https://bugs.webkit.org/show_bug.cgi?id=149905
Reviewed by Chris Dumez.
Allow custom revision number on each "repository" when creating a test group.
* public/v2/app.css:
(form .analysis-group [name=customValue]): Added.
* public/v2/app.js:
(App.AnalysisTaskController._createConfiguration): Added "Custom" as a revision option.
Also added point labels such as (point 3) on "None" for when some points are missing revision info.
(App.AnalysisTaskController._labelForPoints): Extracted from _createConfiguration.
(App.AnalysisTaskController.actions.createTestGroup): Respect the custom revision number when custom
revision option is selected.
* public/v2/index.html: Added a text field for specifying a custom revision number.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2appcss">trunk/Websites/perf.webkit.org/public/v2/app.css</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2appjs">trunk/Websites/perf.webkit.org/public/v2/app.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2indexhtml">trunk/Websites/perf.webkit.org/public/v2/index.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (190695 => 190696)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-10-07 23:34:41 UTC (rev 190695)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-10-08 00:17:21 UTC (rev 190696)
</span><span class="lines">@@ -1,5 +1,26 @@
</span><span class="cx"> 2015-10-07 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ Allow custom revisions to be specified in A/B testing
+ https://bugs.webkit.org/show_bug.cgi?id=149905
+
+ Reviewed by Chris Dumez.
+
+ Allow custom revision number on each "repository" when creating a test group.
+
+ * public/v2/app.css:
+ (form .analysis-group [name=customValue]): Added.
+
+ * public/v2/app.js:
+ (App.AnalysisTaskController._createConfiguration): Added "Custom" as a revision option.
+ Also added point labels such as (point 3) on "None" for when some points are missing revision info.
+ (App.AnalysisTaskController._labelForPoints): Extracted from _createConfiguration.
+ (App.AnalysisTaskController.actions.createTestGroup): Respect the custom revision number when custom
+ revision option is selected.
+
+ * public/v2/index.html: Added a text field for specifying a custom revision number.
+
+2015-10-07 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> Make the site name configurable in perf dashboard
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149894
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2appcss"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/app.css (190695 => 190696)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/app.css 2015-10-07 23:34:41 UTC (rev 190695)
+++ trunk/Websites/perf.webkit.org/public/v2/app.css 2015-10-08 00:17:21 UTC (rev 190696)
</span><span class="lines">@@ -437,6 +437,10 @@
</span><span class="cx"> margin: 0.5rem;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+form .analysis-group [name=customValue] {
+ display: block;
+}
+
</ins><span class="cx"> #analysis-tasks,
</span><span class="cx"> .analysis-group table {
</span><span class="cx"> border: solid 0px #999;
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2appjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (190695 => 190696)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-10-07 23:34:41 UTC (rev 190695)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-10-08 00:17:21 UTC (rev 190696)
</span><span class="lines">@@ -1391,12 +1391,14 @@
</span><span class="cx"> _createConfiguration: function(repository, commits, analysisPoints) {
</span><span class="cx"> var repositoryId = repository.get('id');
</span><span class="cx">
</span><del>- var options = [{label: 'None'}];
</del><span class="cx"> var revisionToPoints = {};
</span><ins>+ var missingPoints = [];
</ins><span class="cx"> analysisPoints.forEach(function (point, pointIndex) {
</span><span class="cx"> var revision = point.measurement.revisionForRepository(repositoryId);
</span><del>- if (!revision)
</del><ins>+ if (!revision) {
+ missingPoints.push(pointIndex);
</ins><span class="cx"> return;
</span><ins>+ }
</ins><span class="cx"> if (!revisionToPoints[revision])
</span><span class="cx"> revisionToPoints[revision] = [];
</span><span class="cx"> revisionToPoints[revision].push(pointIndex);
</span><span class="lines">@@ -1408,29 +1410,50 @@
</span><span class="cx"> commits.push({revision: revision});
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ var options = [{label: 'None'}, {label: 'Custom', isCustom: true}];
+ if (missingPoints.length) {
+ options[0].label += ' ' + this._labelForPoints(missingPoints);
+ options[0].points = missingPoints;
+ }
+
</ins><span class="cx"> for (var commit of commits) {
</span><span class="cx"> var revision = commit.revision;
</span><ins>+ var points = revisionToPoints[revision];
</ins><span class="cx"> var label = Measurement.formatRevisionRange(revision).label;
</span><del>- var points = revisionToPoints[revision];
- if (points) {
- var serializedPoints = this._serializeNumbersSkippingConsecutiveEntries(revisionToPoints[revision]);
- label += ' ' + ['(', points.length > 1 ? 'points' : 'point', serializedPoints, ')'].join(' ');
- }
- options.push({value: revision, label: label});
</del><ins>+ if (points)
+ label += ' ' + this._labelForPoints(points);
+ options.push({value: revision, label: label, points: points});
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+ var firstOption = null;
+ var lastOption = null;
+ for (var option of options) {
+ var points = option.points;
+ if (!points)
+ continue;
+ if (points.indexOf(0) >= 0)
+ firstOption = option;
+ if (points.indexOf(analysisPoints.length - 1) >= 0)
+ lastOption = option;
+ }
+
</ins><span class="cx"> return Ember.Object.create({
</span><span class="cx"> repository: repository,
</span><span class="cx"> name: repository.get('name'),
</span><span class="cx"> sets: [
</span><span class="cx"> Ember.Object.create({name: 'A[' + repositoryId + ']',
</span><span class="cx"> options: options,
</span><del>- selection: options[1]}),
</del><ins>+ selection: firstOption}),
</ins><span class="cx"> Ember.Object.create({name: 'B[' + repositoryId + ']',
</span><span class="cx"> options: options,
</span><del>- selection: options[options.length - 1]}),
</del><ins>+ selection: lastOption}),
</ins><span class="cx"> ]});
</span><span class="cx"> },
</span><ins>+ _labelForPoints: function (points)
+ {
+ var serializedPoints = this._serializeNumbersSkippingConsecutiveEntries(points);
+ return ['(', points.length > 1 ? 'points' : 'point', serializedPoints, ')'].join(' ');
+ },
</ins><span class="cx"> _serializeNumbersSkippingConsecutiveEntries: function (numbers) {
</span><span class="cx"> var result = numbers[0];
</span><span class="cx"> for (var i = 1; i < numbers.length; i++) {
</span><span class="lines">@@ -1495,14 +1518,20 @@
</span><span class="cx"> var rootConfigurations = this.get('rootConfigurations').toArray();
</span><span class="cx"> for (var root of rootConfigurations) {
</span><span class="cx"> var sets = root.get('sets');
</span><del>- var hasSelection = function (item) { return item.get('selection') && item.get('selection').value; };
</del><ins>+ var hasSelection = function (item) {
+ var selection = item.get('selection');
+ return selection.value || (selection.isCustom && item.get('customValue'));
+ }
</ins><span class="cx"> if (!sets.any(hasSelection))
</span><span class="cx"> continue;
</span><span class="cx"> if (!sets.every(hasSelection)) {
</span><span class="cx"> alert('Only some configuration specifies ' + root.get('name'));
</span><span class="cx"> return;
</span><span class="cx"> }
</span><del>- roots[root.get('name')] = sets.map(function (item) { return item.get('selection').value; });
</del><ins>+ roots[root.get('name')] = sets.map(function (item) {
+ var selection = item.get('selection');
+ return selection.isCustom ? item.get('customValue') : selection.value;
+ });
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> App.TestGroup.create(analysisTask, name, roots, repetitionCount).then(function () {
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2indexhtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/index.html (190695 => 190696)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/index.html 2015-10-07 23:34:41 UTC (rev 190695)
+++ trunk/Websites/perf.webkit.org/public/v2/index.html 2015-10-08 00:17:21 UTC (rev 190696)
</span><span class="lines">@@ -726,9 +726,14 @@
</span><span class="cx"> <tr>
</span><span class="cx"> <th>{{name}}</th>
</span><span class="cx"> {{#each sets}}
</span><del>- <td>{{view Ember.Select name=name content=options
- optionValuePath="content.value" optionLabelPath="content.label"
- selection=selection}}</td>
</del><ins>+ <td>
+ {{view Ember.Select name=name content=options
+ optionValuePath="content.value" optionLabelPath="content.label"
+ selection=selection}}
+ {{#if selection.isCustom}}
+ {{input name="customValue" type=text value=customValue}}
+ {{/if}}
+ </td>
</ins><span class="cx"> {{/each}}
</span><span class="cx"> </tr>
</span><span class="cx"> {{/each}}
</span></span></pre>
</div>
</div>
</body>
</html>