<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190687] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190687">190687</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-10-07 14:24:54 -0700 (Wed, 07 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make the site name configurable in perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=149894
Reviewed by Chris Dumez.
Added "siteTitle" as a new configuration key to specify the site name.
* public/include/db.php:
(config): Now takes the default value as an argument.
* public/include/manifest.php:
(ManifestGenerator::generate): Include siteTitle in the manifest.
* public/index.html: Update the title and the heading when the manifest is loaded.
* public/v2/index.html: Use App.Manifest.siteTitle as the heading. document.title needs to be updated manually.
* public/v2/manifest.js:
(App.MetricSerializer.normalizePayload): Update document.title and App.Manifest.siteTitle.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicincludedbphp">trunk/Websites/perf.webkit.org/public/include/db.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicincludemanifestphp">trunk/Websites/perf.webkit.org/public/include/manifest.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicindexhtml">trunk/Websites/perf.webkit.org/public/index.html</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2indexhtml">trunk/Websites/perf.webkit.org/public/v2/index.html</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2manifestjs">trunk/Websites/perf.webkit.org/public/v2/manifest.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (190686 => 190687)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-10-07 21:19:15 UTC (rev 190686)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-10-07 21:24:54 UTC (rev 190687)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2015-10-07 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ Make the site name configurable in perf dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=149894
+
+ Reviewed by Chris Dumez.
+
+ Added "siteTitle" as a new configuration key to specify the site name.
+
+ * public/include/db.php:
+ (config): Now takes the default value as an argument.
+ * public/include/manifest.php:
+ (ManifestGenerator::generate): Include siteTitle in the manifest.
+ * public/index.html: Update the title and the heading when the manifest is loaded.
+ * public/v2/index.html: Use App.Manifest.siteTitle as the heading. document.title needs to be updated manually.
+ * public/v2/manifest.js:
+ (App.MetricSerializer.normalizePayload): Update document.title and App.Manifest.siteTitle.
+
+2015-10-07 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> Perf dashboard doesn't show analysis tasks anchored at outliers
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149870
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicincludedbphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/include/db.php (190686 => 190687)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/include/db.php 2015-10-07 21:19:15 UTC (rev 190686)
+++ trunk/Websites/perf.webkit.org/public/include/db.php 2015-10-07 21:24:54 UTC (rev 190687)
</span><span class="lines">@@ -29,11 +29,11 @@
</span><span class="cx">
</span><span class="cx"> define('CONFIG_DIR', dirname(__FILE__) . '/../../');
</span><span class="cx">
</span><del>-function config($key) {
</del><ins>+function config($key, $default = NULL) {
</ins><span class="cx"> global $_config;
</span><span class="cx"> if (!$_config)
</span><span class="cx"> $_config = json_decode(file_get_contents(CONFIG_DIR . 'config.json'), true);
</span><del>- return $_config[$key];
</del><ins>+ return array_get($_config, $key, $default);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function config_path($key, $path) {
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicincludemanifestphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/include/manifest.php (190686 => 190687)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/include/manifest.php 2015-10-07 21:19:15 UTC (rev 190686)
+++ trunk/Websites/perf.webkit.org/public/include/manifest.php 2015-10-07 21:24:54 UTC (rev 190687)
</span><span class="lines">@@ -27,6 +27,7 @@
</span><span class="cx"> $row = $row['commit_repository'];
</span><span class="cx">
</span><span class="cx"> $this->manifest = array(
</span><ins>+ 'siteTitle' => config('siteTitle', 'Performance Dashboard'),
</ins><span class="cx"> 'tests' => (object)$this->tests(),
</span><span class="cx"> 'metrics' => (object)$this->metrics(),
</span><span class="cx"> 'all' => (object)$this->platforms($config_table, $platform_table, false),
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicindexhtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/index.html (190686 => 190687)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/index.html 2015-10-07 21:19:15 UTC (rev 190686)
+++ trunk/Websites/perf.webkit.org/public/index.html 2015-10-07 21:24:54 UTC (rev 190687)
</span><span class="lines">@@ -1,7 +1,7 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <html>
</span><span class="cx"> <head>
</span><del>-<title>WebKit Perf Monitor</title>
</del><ins>+<title>Perf Monitor is Loading...</title>
</ins><span class="cx"> <script src="js/jquery.js" defer></script>
</span><span class="cx"> <script src="js/jquery.flot.js" defer></script>
</span><span class="cx"> <script src="js/jquery.flot.crosshair.js" defer></script>
</span><span class="lines">@@ -1220,6 +1220,9 @@
</span><span class="cx"> builders = manifest.builders;
</span><span class="cx"> bugTrackers = manifest.bugTrackers;
</span><span class="cx">
</span><ins>+ document.title = manifest.siteTitle;
+ document.getElementById('siteTitle').textContent = manifest.siteTitle;
+
</ins><span class="cx"> setMode(URLState.get('mode', 'dashboard'));
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="lines">@@ -1231,7 +1234,7 @@
</span><span class="cx"> <body>
</span><span class="cx">
</span><span class="cx"> <header id="title">
</span><del>-<h1><a href="/">WebKit Perf Monitor</a></h1>
</del><ins>+<h1><a id="siteTitle" href="/">Perf Monitor</a></h1>
</ins><span class="cx"> <ul>
</span><span class="cx"> <li id="numberOfDaysPicker"><input id="numberOfDays" type="range" min="1" max="5.9" step="0.001" value="2.3"><span class="output"></span></li>
</span><span class="cx"> <li><a href="javascript:setMode('dashboard');">Dashboard</a></li>
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2indexhtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/index.html (190686 => 190687)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/index.html 2015-10-07 21:19:15 UTC (rev 190686)
+++ trunk/Websites/perf.webkit.org/public/v2/index.html 2015-10-07 21:24:54 UTC (rev 190687)
</span><span class="lines">@@ -2,7 +2,7 @@
</span><span class="cx"> <html>
</span><span class="cx"> <head>
</span><span class="cx"> <meta charset="utf-8">
</span><del>- <title>WebKit Performance Monitor (Beta)</title>
</del><ins>+ <title>Performance Dashboard is Loading...</title>
</ins><span class="cx">
</span><span class="cx"> <link rel="prefetch" href="../data/manifest.json">
</span><span class="cx"> <script type="application/json" src="../data/manifest.json"></script>
</span><span class="lines">@@ -486,7 +486,7 @@
</span><span class="cx">
</span><span class="cx"> <script type="text/x-handlebars" data-template-name="navbar">
</span><span class="cx"> <nav id="navigation" role="navigation">
</span><del>- <h1><a href="#">WebKit Perf Monitor</a></h1>
</del><ins>+ <h1><a href="#">{{App.Manifest.siteTitle}}</a></h1>
</ins><span class="cx"> <ul>
</span><span class="cx"> {{#each App.Manifest.dashboards}}
</span><span class="cx"> {{#if name}}
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2manifestjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/manifest.js (190686 => 190687)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/manifest.js 2015-10-07 21:19:15 UTC (rev 190686)
+++ trunk/Websites/perf.webkit.org/public/v2/manifest.js 2015-10-07 21:24:54 UTC (rev 190687)
</span><span class="lines">@@ -214,6 +214,12 @@
</span><span class="cx"> id++;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ var siteTitle = payload['siteTitle'];
+ if (siteTitle) {
+ App.Manifest.set('siteTitle', siteTitle);
+ document.title = siteTitle;
+ }
+
</ins><span class="cx"> return results;
</span><span class="cx"> },
</span><span class="cx"> _normalizeIdMap: function (idMap)
</span></span></pre>
</div>
</div>
</body>
</html>