<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190658] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190658">190658</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2015-10-06 19:51:29 -0700 (Tue, 06 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/
https://bugs.webkit.org/show_bug.cgi?id=149535
rdar://problem/22874920
Reviewed by Simon Fraser.
When due to some style change, a renderer's self-painting layer is getting destroyed
and the parent's overflow is no longer set to visible, we don't clean up the overflow part.
When a renderer has a self-painting layer, the parent stops tracking the child's
visual overflow rect. All overflow painting is delegated to the self-painting layer.
However when this layer gets destroyed, no-one issues repaint to clean up
the overflow bits.
This patch ensures that we issue a repaint when the self-painting layer is destroyed
and the triggering style change requires full repaint.
Source/WebCore:
Test: fast/repaint/overflow-hidden-with-self-painting-child-layer.html
* rendering/RenderLayer.h:
* rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
LayoutTests:
* css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt: progression.
* fast/repaint/absolute-position-change-containing-block-expected.txt: progression.
* fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt: Added.
* fast/repaint/overflow-hidden-with-self-painting-child-layer.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestscss3blendingrepaintblendmodeisolatestackingcontextexpectedtxt">trunk/LayoutTests/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastrepaintabsolutepositionchangecontainingblockexpectedtxt">trunk/LayoutTests/fast/repaint/absolute-position-change-containing-block-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerh">trunk/Source/WebCore/rendering/RenderLayer.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerModelObjectcpp">trunk/Source/WebCore/rendering/RenderLayerModelObject.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastrepaintoverflowhiddenwithselfpaintingchildlayerexpectedtxt">trunk/LayoutTests/fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastrepaintoverflowhiddenwithselfpaintingchildlayerhtml">trunk/LayoutTests/fast/repaint/overflow-hidden-with-self-painting-child-layer.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (190657 => 190658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-10-07 02:11:09 UTC (rev 190657)
+++ trunk/LayoutTests/ChangeLog 2015-10-07 02:51:29 UTC (rev 190658)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2015-10-06 Zalan Bujtas <zalan@apple.com>
+
+ Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/
+ https://bugs.webkit.org/show_bug.cgi?id=149535
+ rdar://problem/22874920
+
+ Reviewed by Simon Fraser.
+
+ When due to some style change, a renderer's self-painting layer is getting destroyed
+ and the parent's overflow is no longer set to visible, we don't clean up the overflow part.
+
+ When a renderer has a self-painting layer, the parent stops tracking the child's
+ visual overflow rect. All overflow painting is delegated to the self-painting layer.
+ However when this layer gets destroyed, no-one issues repaint to clean up
+ the overflow bits.
+ This patch ensures that we issue a repaint when the self-painting layer is destroyed
+ and the triggering style change requires full repaint.
+
+ * css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt: progression.
+ * fast/repaint/absolute-position-change-containing-block-expected.txt: progression.
+ * fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt: Added.
+ * fast/repaint/overflow-hidden-with-self-painting-child-layer.html: Added.
+
</ins><span class="cx"> 2015-10-06 Jon Honeycutt <jhoneycutt@apple.com>
</span><span class="cx">
</span><span class="cx"> More unreviewed Windows test gardening after r190629.
</span></span></pre></div>
<a id="trunkLayoutTestscss3blendingrepaintblendmodeisolatestackingcontextexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt (190657 => 190658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt 2015-10-07 02:11:09 UTC (rev 190657)
+++ trunk/LayoutTests/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt 2015-10-07 02:51:29 UTC (rev 190658)
</span><span class="lines">@@ -19,6 +19,7 @@
</span><span class="cx"> (rect 48 172 60 60)
</span><span class="cx"> (rect 28 290 60 60)
</span><span class="cx"> (rect 48 290 60 60)
</span><ins>+ (rect 28 290 60 60)
</ins><span class="cx"> (rect 48 290 60 60)
</span><span class="cx"> (rect 48 408 60 60)
</span><span class="cx"> (rect 48 408 60 60)
</span><span class="lines">@@ -26,6 +27,7 @@
</span><span class="cx"> (rect 48 526 60 60)
</span><span class="cx"> (rect 48 644 60 60)
</span><span class="cx"> (rect 68 644 60 60)
</span><ins>+ (rect 48 644 60 60)
</ins><span class="cx"> (rect 68 644 60 60)
</span><span class="cx"> (rect 28 290 60 60)
</span><span class="cx"> (rect 48 644 60 60)
</span></span></pre></div>
<a id="trunkLayoutTestsfastrepaintabsolutepositionchangecontainingblockexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/repaint/absolute-position-change-containing-block-expected.txt (190657 => 190658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/absolute-position-change-containing-block-expected.txt 2015-10-07 02:11:09 UTC (rev 190657)
+++ trunk/LayoutTests/fast/repaint/absolute-position-change-containing-block-expected.txt 2015-10-07 02:51:29 UTC (rev 190658)
</span><span class="lines">@@ -2,6 +2,7 @@
</span><span class="cx"> (rect 8 5000 100 100)
</span><span class="cx"> (rect 108 5100 100 100)
</span><span class="cx"> (rect 8 8 784 2000)
</span><ins>+ (rect 8 5000 100 100)
</ins><span class="cx"> (rect 108 5100 100 100)
</span><span class="cx"> (rect 100 100 100 100)
</span><span class="cx"> (rect 16 5008 100 100)
</span></span></pre></div>
<a id="trunkLayoutTestsfastrepaintoverflowhiddenwithselfpaintingchildlayerexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt (0 => 190658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt 2015-10-07 02:51:29 UTC (rev 190658)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+PASS window.internals.repaintRectsAsText().indexOf('200 200') is not -1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastrepaintoverflowhiddenwithselfpaintingchildlayerhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/overflow-hidden-with-self-painting-child-layer.html (0 => 190658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/overflow-hidden-with-self-painting-child-layer.html (rev 0)
+++ trunk/LayoutTests/fast/repaint/overflow-hidden-with-self-painting-child-layer.html 2015-10-07 02:51:29 UTC (rev 190658)
</span><span class="lines">@@ -0,0 +1,45 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<script>jsTestIsAsync = true;</script>
+<script src="../../resources/js-test-pre.js"></script>
+<head>
+<title>This tests that we don't leave bits behind, when the self-painting child layer get destroyed while the parent becomes overflow: hidden.</title>
+<style>
+#container {
+ position: relative;
+ overflow: visible;
+ height: 100px;
+ width: 100px;
+}
+
+#content {
+ position: relative;
+ height: 200px;
+ width: 200px;
+ background: green;
+}
+</style>
+</head>
+<body>
+<div id=container>
+ <div id=content></div>
+</div>
+<script>
+setTimeout(
+ function() {
+ if (window.internals)
+ internals.startTrackingRepaints();
+ document.getElementById("container").style.overflow = "hidden";
+ document.getElementById("content").style.position = "static";
+ document.body.offsetWidth;
+
+ if (window.internals) {
+ shouldNotBe("window.internals.repaintRectsAsText().indexOf('200 200')", "-1");
+ internals.stopTrackingRepaints();
+ }
+ finishJSTest();
+ }, 0);
+</script>
+</body>
+<script src="../../resources/js-test-post.js"></script>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (190657 => 190658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-10-07 02:11:09 UTC (rev 190657)
+++ trunk/Source/WebCore/ChangeLog 2015-10-07 02:51:29 UTC (rev 190658)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2015-10-06 Zalan Bujtas <zalan@apple.com>
+
+ Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/
+ https://bugs.webkit.org/show_bug.cgi?id=149535
+ rdar://problem/22874920
+
+ Reviewed by Simon Fraser.
+
+ When due to some style change, a renderer's self-painting layer is getting destroyed
+ and the parent's overflow is no longer set to visible, we don't clean up the overflow part.
+
+ When a renderer has a self-painting layer, the parent stops tracking the child's
+ visual overflow rect. All overflow painting is delegated to the self-painting layer.
+ However when this layer gets destroyed, no-one issues repaint to clean up
+ the overflow bits.
+ This patch ensures that we issue a repaint when the self-painting layer is destroyed
+ and the triggering style change requires full repaint.
+
+ Test: fast/repaint/overflow-hidden-with-self-painting-child-layer.html
+
+ * rendering/RenderLayer.h:
+ * rendering/RenderLayerModelObject.cpp:
+ (WebCore::RenderLayerModelObject::styleDidChange):
+
</ins><span class="cx"> 2015-10-06 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> [Mac] REGRESSION(r173318): Seeks never complete for media loaded with QTKit.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.h (190657 => 190658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.h 2015-10-07 02:11:09 UTC (rev 190657)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2015-10-07 02:51:29 UTC (rev 190658)
</span><span class="lines">@@ -536,6 +536,7 @@
</span><span class="cx"> LayoutRect repaintRectIncludingNonCompositingDescendants() const;
</span><span class="cx">
</span><span class="cx"> void setRepaintStatus(RepaintStatus status) { m_repaintStatus = status; }
</span><ins>+ RepaintStatus repaintStatus() const { return static_cast<RepaintStatus>(m_repaintStatus); }
</ins><span class="cx">
</span><span class="cx"> LayoutUnit staticInlinePosition() const { return m_staticInlinePosition; }
</span><span class="cx"> LayoutUnit staticBlockPosition() const { return m_staticBlockPosition; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerModelObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerModelObject.cpp (190657 => 190658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerModelObject.cpp 2015-10-07 02:11:09 UTC (rev 190657)
+++ trunk/Source/WebCore/rendering/RenderLayerModelObject.cpp 2015-10-07 02:51:29 UTC (rev 190658)
</span><span class="lines">@@ -159,6 +159,9 @@
</span><span class="cx"> #endif
</span><span class="cx"> setHasTransformRelatedProperty(false); // All transform-related propeties force layers, so we know we don't have one or the object doesn't support them.
</span><span class="cx"> setHasReflection(false);
</span><ins>+ // Repaint the about to be destroyed self-painting layer when style change also triggers repaint.
+ if (layer()->isSelfPaintingLayer() && layer()->repaintStatus() == NeedsFullRepaint)
+ repaintUsingContainer(containerForRepaint(), layer()->repaintRect());
</ins><span class="cx"> layer()->removeOnlyThisLayer(); // calls destroyLayer() which clears m_layer
</span><span class="cx"> if (s_wasFloating && isFloating())
</span><span class="cx"> setChildNeedsLayout();
</span></span></pre>
</div>
</div>
</body>
</html>