<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190618] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190618">190618</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-10-06 09:35:01 -0700 (Tue, 06 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Cairo] fast/canvas/canvas-imageSmoothingFoo tests failed after <a href="http://trac.webkit.org/projects/webkit/changeset/190383">r190383</a>.
https://bugs.webkit.org/show_bug.cgi?id=149752
Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2015-10-06
Reviewed by Carlos Garcia Campos.
CG's low interpolation quality setting is equivalent to most other browsers default or high settings.
Source/WebCore:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
LayoutTests:
* platform/efl/fast/canvas/canvas-imageSmoothingQuality-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-imageSmoothingQuality-expected.txt: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasCanvasRenderingContext2Dcpp">trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformeflfastcanvascanvasimageSmoothingQualityexpectedtxt">trunk/LayoutTests/platform/efl/fast/canvas/canvas-imageSmoothingQuality-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfastcanvascanvasimageSmoothingQualityexpectedtxt">trunk/LayoutTests/platform/gtk/fast/canvas/canvas-imageSmoothingQuality-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (190617 => 190618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-10-06 16:33:21 UTC (rev 190617)
+++ trunk/LayoutTests/ChangeLog 2015-10-06 16:35:01 UTC (rev 190618)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-10-06 Hunseop Jeong <hs85.jeong@samsung.com>
+
+ [Cairo] fast/canvas/canvas-imageSmoothingFoo tests failed after r190383.
+ https://bugs.webkit.org/show_bug.cgi?id=149752
+
+ Reviewed by Carlos Garcia Campos.
+
+ CG's low interpolation quality setting is equivalent to most other browsers default or high settings.
+
+ * platform/efl/fast/canvas/canvas-imageSmoothingQuality-expected.txt: Added.
+ * platform/gtk/fast/canvas/canvas-imageSmoothingQuality-expected.txt: Added.
+
</ins><span class="cx"> 2015-10-06 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Report error when main resource is blocked by content blocker
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflfastcanvascanvasimageSmoothingQualityexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/efl/fast/canvas/canvas-imageSmoothingQuality-expected.txt (0 => 190618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/fast/canvas/canvas-imageSmoothingQuality-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/fast/canvas/canvas-imageSmoothingQuality-expected.txt 2015-10-06 16:35:01 UTC (rev 190618)
</span><span class="lines">@@ -0,0 +1,40 @@
</span><ins>+Tests for the imageSmoothingQuality attribute.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+
+PASS lowContext.imageSmoothingQuality is 'low'
+PASS mediumContext.imageSmoothingQuality is 'medium'
+PASS highContext.imageSmoothingQuality is 'high'
+
+PASS lowData is not mediumData
+PASS mediumData is not highData
+PASS lowData is not highData
+
+PASS sampleAlpha(lowData) is >= sampleAlpha(mediumData)
+PASS sampleAlpha(mediumData) is >= sampleAlpha(highData)
+
+FAIL defaultContext.imageSmoothingQuality should be low. Was medium.
+
+PASS highContext.imageSmoothingEnabled = false; highContext.imageSmoothingQuality is 'high'
+PASS highContext.imageSmoothingQuality = 'medium'; highContext.imageSmoothingQuality is 'medium'
+
+highContext.imageSmoothingEnabled = true; highContext.imageSmoothingQuality = 'high';
+PASS scaleImageData(highCanvas, '3223') did not throw exception.
+PASS highContext.imageSmoothingQuality is 'high'
+PASS scaleImageData(highCanvas, 'bad_input') did not throw exception.
+PASS highContext.imageSmoothingQuality is 'high'
+PASS scaleImageData(highCanvas, 'LOW') did not throw exception.
+PASS highContext.imageSmoothingQuality is 'high'
+PASS scaleImageData(highCanvas, 'Medium') did not throw exception.
+PASS highContext.imageSmoothingQuality is 'high'
+
+highContext.save(); highContext.imageSmoothingQuality = 'medium';
+PASS highContext.restore(); highContext.imageSmoothingQuality is 'high'
+PASS scaleImageData(highCanvas, highCanvas.imageSmoothingQuality); is highData
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformgtkfastcanvascanvasimageSmoothingQualityexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/gtk/fast/canvas/canvas-imageSmoothingQuality-expected.txt (0 => 190618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/fast/canvas/canvas-imageSmoothingQuality-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/canvas/canvas-imageSmoothingQuality-expected.txt 2015-10-06 16:35:01 UTC (rev 190618)
</span><span class="lines">@@ -0,0 +1,40 @@
</span><ins>+Tests for the imageSmoothingQuality attribute.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+
+PASS lowContext.imageSmoothingQuality is 'low'
+PASS mediumContext.imageSmoothingQuality is 'medium'
+PASS highContext.imageSmoothingQuality is 'high'
+
+PASS lowData is not mediumData
+PASS mediumData is not highData
+PASS lowData is not highData
+
+PASS sampleAlpha(lowData) is >= sampleAlpha(mediumData)
+PASS sampleAlpha(mediumData) is >= sampleAlpha(highData)
+
+FAIL defaultContext.imageSmoothingQuality should be low. Was medium.
+
+PASS highContext.imageSmoothingEnabled = false; highContext.imageSmoothingQuality is 'high'
+PASS highContext.imageSmoothingQuality = 'medium'; highContext.imageSmoothingQuality is 'medium'
+
+highContext.imageSmoothingEnabled = true; highContext.imageSmoothingQuality = 'high';
+PASS scaleImageData(highCanvas, '3223') did not throw exception.
+PASS highContext.imageSmoothingQuality is 'high'
+PASS scaleImageData(highCanvas, 'bad_input') did not throw exception.
+PASS highContext.imageSmoothingQuality is 'high'
+PASS scaleImageData(highCanvas, 'LOW') did not throw exception.
+PASS highContext.imageSmoothingQuality is 'high'
+PASS scaleImageData(highCanvas, 'Medium') did not throw exception.
+PASS highContext.imageSmoothingQuality is 'high'
+
+highContext.save(); highContext.imageSmoothingQuality = 'medium';
+PASS highContext.restore(); highContext.imageSmoothingQuality is 'high'
+PASS scaleImageData(highCanvas, highCanvas.imageSmoothingQuality); is highData
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (190617 => 190618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-10-06 16:33:21 UTC (rev 190617)
+++ trunk/Source/WebCore/ChangeLog 2015-10-06 16:35:01 UTC (rev 190618)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-10-06 Hunseop Jeong <hs85.jeong@samsung.com>
+
+ [Cairo] fast/canvas/canvas-imageSmoothingFoo tests failed after r190383.
+ https://bugs.webkit.org/show_bug.cgi?id=149752
+
+ Reviewed by Carlos Garcia Campos.
+
+ CG's low interpolation quality setting is equivalent to most other browsers default or high settings.
+
+ * html/canvas/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::State::State):
+
</ins><span class="cx"> 2015-10-06 Daniel Bates <dbates@webkit.org>
</span><span class="cx">
</span><span class="cx"> Enable XSLT when building WebKit for iOS using the public iOS SDK
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasCanvasRenderingContext2Dcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (190617 => 190618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2015-10-06 16:33:21 UTC (rev 190617)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2015-10-06 16:35:01 UTC (rev 190618)
</span><span class="lines">@@ -70,6 +70,12 @@
</span><span class="cx"> #include "Settings.h"
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+#if USE(CG)
+#define DefaultSmoothingQuality SmoothingQuality::Low
+#else
+#define DefaultSmoothingQuality SmoothingQuality::Medium
+#endif
+
</ins><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> using namespace HTMLNames;
</span><span class="lines">@@ -172,7 +178,7 @@
</span><span class="cx"> , hasInvertibleTransform(true)
</span><span class="cx"> , lineDashOffset(0)
</span><span class="cx"> , imageSmoothingEnabled(true)
</span><del>- , imageSmoothingQuality(SmoothingQuality::Low)
</del><ins>+ , imageSmoothingQuality(DefaultSmoothingQuality)
</ins><span class="cx"> , textAlign(StartTextAlign)
</span><span class="cx"> , textBaseline(AlphabeticTextBaseline)
</span><span class="cx"> , direction(Direction::Inherit)
</span></span></pre>
</div>
</div>
</body>
</html>