<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190616] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190616">190616</a></dd>
<dt>Author</dt> <dd>bfulgham@apple.com</dd>
<dt>Date</dt> <dd>2015-10-06 09:28:38 -0700 (Tue, 06 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Win] Correct positioning error introduced in <a href="http://trac.webkit.org/projects/webkit/changeset/190235">r190235</a>
https://bugs.webkit.org/show_bug.cgi?id=149631
<rdar://problem/22635080>
Reviewed by Simon Fraser.
Covered by existing compositing tests:
css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html
fast/layers/no-clipping-overflow-hidden-added-after-transform.html
fast/layers/no-clipping-overflow-hidden-added-after-transition.html
fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html
transforms/2d/preserve3d-not-fixed-container.html
* platform/graphics/ca/TileGrid.cpp:
(TileGrid::platformCALayerPaintContents): No need to do this extra flipping step
on Windows.
* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::displayCallback): We should always flip the
coordinate system when drawing these layers on Windows.
(shouldInvertBeforeDrawingContent): Deleted.
* platform/graphics/ca/win/WebTiledBackingLayerWin.cpp:
(WebTiledBackingLayerWin::displayCallback): We do not need to flip coordinates
for these tiled layers; that's already accounted for in common tile drawing code.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscaTileGridcpp">trunk/Source/WebCore/platform/graphics/ca/TileGrid.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscawinPlatformCALayerWinInternalcpp">trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscawinWebTiledBackingLayerWincpp">trunk/Source/WebCore/platform/graphics/ca/win/WebTiledBackingLayerWin.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (190615 => 190616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-10-06 16:21:04 UTC (rev 190615)
+++ trunk/Source/WebCore/ChangeLog 2015-10-06 16:28:38 UTC (rev 190616)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2015-10-06 Brent Fulgham <bfulgham@apple.com>
+
+ [Win] Correct positioning error introduced in r190235
+ https://bugs.webkit.org/show_bug.cgi?id=149631
+ <rdar://problem/22635080>
+
+ Reviewed by Simon Fraser.
+
+ Covered by existing compositing tests:
+ css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html
+ fast/layers/no-clipping-overflow-hidden-added-after-transform.html
+ fast/layers/no-clipping-overflow-hidden-added-after-transition.html
+ fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html
+ transforms/2d/preserve3d-not-fixed-container.html
+
+ * platform/graphics/ca/TileGrid.cpp:
+ (TileGrid::platformCALayerPaintContents): No need to do this extra flipping step
+ on Windows.
+ * platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
+ (PlatformCALayerWinInternal::displayCallback): We should always flip the
+ coordinate system when drawing these layers on Windows.
+ (shouldInvertBeforeDrawingContent): Deleted.
+ * platform/graphics/ca/win/WebTiledBackingLayerWin.cpp:
+ (WebTiledBackingLayerWin::displayCallback): We do not need to flip coordinates
+ for these tiled layers; that's already accounted for in common tile drawing code.
+
</ins><span class="cx"> 2015-10-06 Emanuele Aina <emanuele.aina@collabora.com>
</span><span class="cx">
</span><span class="cx"> Fix ENABLE_OPENGL=OFF builds
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscaTileGridcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/TileGrid.cpp (190615 => 190616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/TileGrid.cpp 2015-10-06 16:21:04 UTC (rev 190615)
+++ trunk/Source/WebCore/platform/graphics/ca/TileGrid.cpp 2015-10-06 16:28:38 UTC (rev 190616)
</span><span class="lines">@@ -669,13 +669,8 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> int repaintCount = platformCALayerIncrementRepaintCount(platformCALayer);
</span><del>- if (m_controller.rootLayer().owner()->platformCALayerShowRepaintCounter(0)) {
-#if OS(WINDOWS)
- // Tiled layers in Windows have flipped coordinates
- PlatformCALayer::flipContext(context.platformContext(), platformCALayer->bounds().size().height());
-#endif
</del><ins>+ if (m_controller.rootLayer().owner()->platformCALayerShowRepaintCounter(0))
</ins><span class="cx"> PlatformCALayer::drawRepaintIndicator(context.platformContext(), platformCALayer, repaintCount, cachedCGColor(m_controller.tileDebugBorderColor(), ColorSpaceDeviceRGB));
</span><del>- }
</del><span class="cx">
</span><span class="cx"> if (m_controller.scrollingPerformanceLoggingEnabled()) {
</span><span class="cx"> FloatRect visiblePart(platformCALayer->position().x(), platformCALayer->position().y(), platformCALayer->bounds().size().width(), platformCALayer->bounds().size().height());
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscawinPlatformCALayerWinInternalcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp (190615 => 190616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp 2015-10-06 16:21:04 UTC (rev 190615)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp 2015-10-06 16:28:38 UTC (rev 190616)
</span><span class="lines">@@ -71,12 +71,6 @@
</span><span class="cx"> self->displayCallback(retainedContext->layer.get(), retainedContext->context.get());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static bool shouldInvertBeforeDrawingContent(PlatformCALayer::LayerType layerType, GraphicsLayer::CompositingCoordinatesOrientation coordinateOrientation)
-{
- return (layerType != PlatformCALayer::LayerTypeTiledBackingTileLayer)
- && (coordinateOrientation == GraphicsLayer::CompositingCoordinatesTopDown);
-}
-
</del><span class="cx"> static bool repaintCountersAreDrawnByGridController(PlatformCALayer::LayerType layerType)
</span><span class="cx"> {
</span><span class="cx"> return layerType == PlatformCALayer::LayerTypeTiledBackingTileLayer;
</span><span class="lines">@@ -100,8 +94,7 @@
</span><span class="cx"> PlatformCALayerClient* client = owner()->owner();
</span><span class="cx"> GraphicsLayer::CompositingCoordinatesOrientation orientation = client->platformCALayerContentsOrientation();
</span><span class="cx">
</span><del>- if (shouldInvertBeforeDrawingContent(layerType, orientation))
- PlatformCALayer::flipContext(context, layerBounds.size.height);
</del><ins>+ PlatformCALayer::flipContext(context, layerBounds.size.height);
</ins><span class="cx">
</span><span class="cx"> GraphicsContext graphicsContext(context);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscawinWebTiledBackingLayerWincpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/win/WebTiledBackingLayerWin.cpp (190615 => 190616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/win/WebTiledBackingLayerWin.cpp 2015-10-06 16:21:04 UTC (rev 190615)
+++ trunk/Source/WebCore/platform/graphics/ca/win/WebTiledBackingLayerWin.cpp 2015-10-06 16:28:38 UTC (rev 190616)
</span><span class="lines">@@ -87,8 +87,6 @@
</span><span class="cx"> PlatformCALayerClient* client = owner()->owner();
</span><span class="cx"> GraphicsLayer::CompositingCoordinatesOrientation orientation = client->platformCALayerContentsOrientation();
</span><span class="cx">
</span><del>- PlatformCALayer::flipContext(context, layerBounds.size.height);
-
</del><span class="cx"> GraphicsContext graphicsContext(context);
</span><span class="cx">
</span><span class="cx"> // It's important to get the clip from the context, because it may be significantly
</span></span></pre>
</div>
</div>
</body>
</html>