<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190604] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190604">190604</a></dd>
<dt>Author</dt> <dd>jer.noble@apple.com</dd>
<dt>Date</dt> <dd>2015-10-05 21:13:32 -0700 (Mon, 05 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[iOS] REGRESSION(<a href="http://trac.webkit.org/projects/webkit/changeset/190434">r190434</a>): Media continues to play when locking screen
https://bugs.webkit.org/show_bug.cgi?id=149822
Reviewed by Brent Fulgham.
Source/WebCore:
In MediaSessionManagerIOS.mm, both -applicationWillEnterForeground: and
-applicationDidBecomeActive: called
PlatformMediaSessionManager::applicationWillEnterForeground(), leading to the
PlatformMediaSession's m_interruptionCount becoming increasingly unbalanced.
Rename PlatformMediaSessionManager::applicationWillEnterForeground() to
applicationDidEnterForeground() to more correctly reflect when this notification will be
called. Add a new method, MediaSessionManagerIOS::applicationWillEnterForeground(bool),
whose paramater is whether the screen was locked. This allows the beginInterruption() and
endInterruption() methods to be correctly balanced.
Drive-by fix: remove the unimplemented declarations for application{will,did}Enter{Fore,Back}ground()
from PlatformMediaSession.h.
* platform/audio/PlatformMediaSession.h:
* platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::applicationDidEnterForeground):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground): Deleted.
* platform/audio/PlatformMediaSessionManager.h:
* platform/audio/ios/MediaSessionManagerIOS.h:
* platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::applicationDidEnterBackground):
(WebCore::MediaSessionManageriOS::applicationWillEnterForeground):
(-[WebMediaSessionHelper applicationWillEnterForeground:]):
(-[WebMediaSessionHelper applicationDidBecomeActive:]):
* testing/Internals.cpp:
(WebCore::Internals::applicationDidEnterForeground):
(WebCore::Internals::applicationWillEnterForeground): Deleted.
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit2:
Pass through isSuspendedUnderLock when notifying the WebPage that the
applicationWillEnterForeground, and pass that boolean in the userInfo of the
WebUIApplicationWillEnterForegroundNotification.
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::applicationWillEnterForeground):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::applicationWillEnterForeground):
LayoutTests:
applicationWillEnterForeground() -> applicationDidEnterForeground().
* media/video-background-playback-expected.txt:
* media/video-background-playback.html:
* media/video-background-tab-playback-expected.txt:
* media/video-background-tab-playback.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsmediavideobackgroundplaybackexpectedtxt">trunk/LayoutTests/media/video-background-playback-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediavideobackgroundplaybackhtml">trunk/LayoutTests/media/video-background-playback.html</a></li>
<li><a href="#trunkLayoutTestsmediavideobackgroundtabplaybackexpectedtxt">trunk/LayoutTests/media/video-background-tab-playback-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediavideobackgroundtabplaybackhtml">trunk/LayoutTests/media/video-background-tab-playback.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformaudioPlatformMediaSessionh">trunk/Source/WebCore/platform/audio/PlatformMediaSession.h</a></li>
<li><a href="#trunkSourceWebCoreplatformaudioPlatformMediaSessionManagercpp">trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformaudioPlatformMediaSessionManagerh">trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.h</a></li>
<li><a href="#trunkSourceWebCoreplatformaudioiosMediaSessionManagerIOSh">trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h</a></li>
<li><a href="#trunkSourceWebCoreplatformaudioiosMediaSessionManagerIOSmm">trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
<li><a href="#trunkSourceWebCoretestingInternalsh">trunk/Source/WebCore/testing/Internals.h</a></li>
<li><a href="#trunkSourceWebCoretestingInternalsidl">trunk/Source/WebCore/testing/Internals.idl</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosWebPageProxyIOSmm">trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPageh">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagemessagesin">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageiosWebPageIOSmm">trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/LayoutTests/ChangeLog 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-10-05 Jer Noble <jer.noble@apple.com>
+
+ [iOS] REGRESSION(r190434): Media continues to play when locking screen
+ https://bugs.webkit.org/show_bug.cgi?id=149822
+
+ Reviewed by Brent Fulgham.
+
+ applicationWillEnterForeground() -> applicationDidEnterForeground().
+
+ * media/video-background-playback-expected.txt:
+ * media/video-background-playback.html:
+ * media/video-background-tab-playback-expected.txt:
+ * media/video-background-tab-playback.html:
+
</ins><span class="cx"> 2015-10-05 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Invalid CSS Selector for Content Blockers invalidates others
</span></span></pre></div>
<a id="trunkLayoutTestsmediavideobackgroundplaybackexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/video-background-playback-expected.txt (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/video-background-playback-expected.txt 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/LayoutTests/media/video-background-playback-expected.txt 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -21,7 +21,7 @@
</span><span class="cx"> EXPECTED (audio.paused == 'false') OK
</span><span class="cx">
</span><span class="cx"> ** Simulate switch back to foreground, video should resume.
</span><del>-RUN(internals.applicationWillEnterForeground())
</del><ins>+RUN(internals.applicationDidEnterForeground())
</ins><span class="cx">
</span><span class="cx"> EVENT(playing)
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsmediavideobackgroundplaybackhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/video-background-playback.html (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/video-background-playback.html 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/LayoutTests/media/video-background-playback.html 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -23,7 +23,7 @@
</span><span class="cx"> testExpected("audio.paused", false);
</span><span class="cx"> state = "foreground";
</span><span class="cx"> consoleWrite("<br>** Simulate switch back to foreground, video should resume.");
</span><del>- run("internals.applicationWillEnterForeground()");
</del><ins>+ run("internals.applicationDidEnterForeground()");
</ins><span class="cx"> setTimeout(checkState, 100);
</span><span class="cx"> consoleWrite("");
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkLayoutTestsmediavideobackgroundtabplaybackexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/video-background-tab-playback-expected.txt (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/video-background-tab-playback-expected.txt 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/LayoutTests/media/video-background-tab-playback-expected.txt 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -16,7 +16,7 @@
</span><span class="cx"> EXPECTED (video.paused == 'true') OK
</span><span class="cx">
</span><span class="cx"> ** Simulate switch back to foreground, video should remain paused.
</span><del>-RUN(internals.applicationWillEnterForeground())
</del><ins>+RUN(internals.applicationDidEnterForeground())
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> ** 100ms timer fired...
</span></span></pre></div>
<a id="trunkLayoutTestsmediavideobackgroundtabplaybackhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/video-background-tab-playback.html (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/video-background-tab-playback.html 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/LayoutTests/media/video-background-tab-playback.html 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -13,7 +13,7 @@
</span><span class="cx"> testExpected("video.paused", true);
</span><span class="cx"> state = "foreground";
</span><span class="cx"> consoleWrite("<br>** Simulate switch back to foreground, video should remain paused.");
</span><del>- run("internals.applicationWillEnterForeground()");
</del><ins>+ run("internals.applicationDidEnterForeground()");
</ins><span class="cx"> setTimeout(checkState, 100);
</span><span class="cx"> consoleWrite("");
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/Source/WebCore/ChangeLog 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -1,3 +1,41 @@
</span><ins>+2015-10-05 Jer Noble <jer.noble@apple.com>
+
+ [iOS] REGRESSION(r190434): Media continues to play when locking screen
+ https://bugs.webkit.org/show_bug.cgi?id=149822
+
+ Reviewed by Brent Fulgham.
+
+ In MediaSessionManagerIOS.mm, both -applicationWillEnterForeground: and
+ -applicationDidBecomeActive: called
+ PlatformMediaSessionManager::applicationWillEnterForeground(), leading to the
+ PlatformMediaSession's m_interruptionCount becoming increasingly unbalanced.
+
+ Rename PlatformMediaSessionManager::applicationWillEnterForeground() to
+ applicationDidEnterForeground() to more correctly reflect when this notification will be
+ called. Add a new method, MediaSessionManagerIOS::applicationWillEnterForeground(bool),
+ whose paramater is whether the screen was locked. This allows the beginInterruption() and
+ endInterruption() methods to be correctly balanced.
+
+ Drive-by fix: remove the unimplemented declarations for application{will,did}Enter{Fore,Back}ground()
+ from PlatformMediaSession.h.
+
+ * platform/audio/PlatformMediaSession.h:
+ * platform/audio/PlatformMediaSessionManager.cpp:
+ (WebCore::PlatformMediaSessionManager::applicationDidEnterForeground):
+ (WebCore::PlatformMediaSessionManager::applicationWillEnterForeground): Deleted.
+ * platform/audio/PlatformMediaSessionManager.h:
+ * platform/audio/ios/MediaSessionManagerIOS.h:
+ * platform/audio/ios/MediaSessionManagerIOS.mm:
+ (WebCore::MediaSessionManageriOS::applicationDidEnterBackground):
+ (WebCore::MediaSessionManageriOS::applicationWillEnterForeground):
+ (-[WebMediaSessionHelper applicationWillEnterForeground:]):
+ (-[WebMediaSessionHelper applicationDidBecomeActive:]):
+ * testing/Internals.cpp:
+ (WebCore::Internals::applicationDidEnterForeground):
+ (WebCore::Internals::applicationWillEnterForeground): Deleted.
+ * testing/Internals.h:
+ * testing/Internals.idl:
+
</ins><span class="cx"> 2015-10-05 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Invalid CSS Selector for Content Blockers invalidates others
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformaudioPlatformMediaSessionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/audio/PlatformMediaSession.h (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/audio/PlatformMediaSession.h 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/Source/WebCore/platform/audio/PlatformMediaSession.h 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -84,10 +84,6 @@
</span><span class="cx"> void beginInterruption(InterruptionType);
</span><span class="cx"> void endInterruption(EndInterruptionFlags);
</span><span class="cx">
</span><del>- void applicationWillEnterForeground() const;
- void applicationWillEnterBackground() const;
- void applicationDidEnterBackground(bool isSuspendedUnderLock) const;
-
</del><span class="cx"> bool clientWillBeginPlayback();
</span><span class="cx"> bool clientWillPausePlayback();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformaudioPlatformMediaSessionManagercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -288,9 +288,9 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PlatformMediaSessionManager::applicationWillEnterForeground() const
</del><ins>+void PlatformMediaSessionManager::applicationDidEnterForeground() const
</ins><span class="cx"> {
</span><del>- LOG(Media, "PlatformMediaSessionManager::applicationWillEnterForeground");
</del><ins>+ LOG(Media, "PlatformMediaSessionManager::applicationDidEnterForeground");
</ins><span class="cx">
</span><span class="cx"> if (!m_isApplicationInBackground)
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformaudioPlatformMediaSessionManagerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.h (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.h 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.h 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx"> WEBCORE_EXPORT void beginInterruption(PlatformMediaSession::InterruptionType);
</span><span class="cx"> WEBCORE_EXPORT void endInterruption(PlatformMediaSession::EndInterruptionFlags);
</span><span class="cx">
</span><del>- WEBCORE_EXPORT void applicationWillEnterForeground() const;
</del><ins>+ WEBCORE_EXPORT void applicationDidEnterForeground() const;
</ins><span class="cx"> WEBCORE_EXPORT void applicationWillEnterBackground() const;
</span><span class="cx">
</span><span class="cx"> void stopAllMediaPlaybackForDocument(const Document*);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformaudioiosMediaSessionManagerIOSh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -49,6 +49,7 @@
</span><span class="cx"> void externalOutputDeviceAvailableDidChange();
</span><span class="cx"> virtual bool hasWirelessTargetsAvailable() override;
</span><span class="cx"> void applicationDidEnterBackground(bool isSuspendedUnderLock);
</span><ins>+ void applicationWillEnterForeground(bool isSuspendedUnderLock);
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> friend class PlatformMediaSessionManager;
</span><span class="lines">@@ -67,6 +68,7 @@
</span><span class="cx"> virtual bool sessionCanLoadMedia(const PlatformMediaSession&) const override;
</span><span class="cx">
</span><span class="cx"> RetainPtr<WebMediaSessionHelper> m_objcObserver;
</span><ins>+ bool m_isInBackground { false };
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformaudioiosMediaSessionManagerIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -252,6 +252,10 @@
</span><span class="cx"> {
</span><span class="cx"> LOG(Media, "MediaSessionManageriOS::applicationDidEnterBackground");
</span><span class="cx">
</span><ins>+ if (m_isInBackground)
+ return;
+ m_isInBackground = true;
+
</ins><span class="cx"> if (!isSuspendedUnderLock)
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -262,7 +266,24 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void MediaSessionManageriOS::applicationWillEnterForeground(bool isSuspendedUnderLock)
+{
+ LOG(Media, "MediaSessionManageriOS::applicationWillEnterForeground");
</ins><span class="cx">
</span><ins>+ if (!m_isInBackground)
+ return;
+ m_isInBackground = false;
+
+ if (!isSuspendedUnderLock)
+ return;
+
+ Vector<PlatformMediaSession*> sessions = this->sessions();
+ for (auto* session : sessions) {
+ if (restrictions(session->mediaType()) & BackgroundProcessPlaybackRestricted)
+ session->endInterruption(PlatformMediaSession::MayResumePlaying);
+ }
+}
+
</ins><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> @implementation WebMediaSessionHelper
</span><span class="lines">@@ -432,11 +453,13 @@
</span><span class="cx">
</span><span class="cx"> LOG(Media, "-[WebMediaSessionHelper applicationWillEnterForeground]");
</span><span class="cx">
</span><ins>+ BOOL isSuspendedUnderLock = [[[notification userInfo] objectForKey:@"isSuspendedUnderLock"] boolValue];
+
</ins><span class="cx"> WebThreadRun(^{
</span><span class="cx"> if (!_callback)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- _callback->applicationWillEnterForeground();
</del><ins>+ _callback->applicationWillEnterForeground(isSuspendedUnderLock);
</ins><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -453,7 +476,7 @@
</span><span class="cx"> if (!_callback)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- _callback->applicationWillEnterForeground();
</del><ins>+ _callback->applicationDidEnterForeground();
</ins><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/Source/WebCore/testing/Internals.cpp 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -2730,9 +2730,9 @@
</span><span class="cx"> PlatformMediaSessionManager::sharedManager().endInterruption(flags);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void Internals::applicationWillEnterForeground() const
</del><ins>+void Internals::applicationDidEnterForeground() const
</ins><span class="cx"> {
</span><del>- PlatformMediaSessionManager::sharedManager().applicationWillEnterForeground();
</del><ins>+ PlatformMediaSessionManager::sharedManager().applicationDidEnterForeground();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Internals::applicationWillEnterBackground() const
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.h (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.h 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/Source/WebCore/testing/Internals.h 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -388,7 +388,7 @@
</span><span class="cx"> #if ENABLE(VIDEO)
</span><span class="cx"> void beginMediaSessionInterruption(const String&, ExceptionCode&);
</span><span class="cx"> void endMediaSessionInterruption(const String&);
</span><del>- void applicationWillEnterForeground() const;
</del><ins>+ void applicationDidEnterForeground() const;
</ins><span class="cx"> void applicationWillEnterBackground() const;
</span><span class="cx"> void setMediaSessionRestrictions(const String& mediaType, const String& restrictions, ExceptionCode&);
</span><span class="cx"> void setMediaElementRestrictions(HTMLMediaElement*, const String& restrictions, ExceptionCode&);
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalsidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.idl (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.idl 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/Source/WebCore/testing/Internals.idl 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -372,7 +372,7 @@
</span><span class="cx"> [Conditional=MEDIA_SESSION] DOMString mediaSessionCurrentState(MediaSession session);
</span><span class="cx"> [Conditional=MEDIA_SESSION] double mediaElementPlayerVolume(HTMLMediaElement element);
</span><span class="cx"> [Conditional=MEDIA_SESSION] void sendMediaControlEvent(MediaControlEvent event);
</span><del>- [Conditional=VIDEO] void applicationWillEnterForeground();
</del><ins>+ [Conditional=VIDEO] void applicationDidEnterForeground();
</ins><span class="cx"> [Conditional=VIDEO] void applicationWillEnterBackground();
</span><span class="cx"> [Conditional=VIDEO, RaisesException] void setMediaSessionRestrictions(DOMString mediaType, DOMString restrictions);
</span><span class="cx"> [Conditional=VIDEO, RaisesException] void setMediaElementRestrictions(HTMLMediaElement element, DOMString restrictions);
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/Source/WebKit2/ChangeLog 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-10-05 Jer Noble <jer.noble@apple.com>
+
+ [iOS] REGRESSION(r190434): Media continues to play when locking screen
+ https://bugs.webkit.org/show_bug.cgi?id=149822
+
+ Reviewed by Brent Fulgham.
+
+ Pass through isSuspendedUnderLock when notifying the WebPage that the
+ applicationWillEnterForeground, and pass that boolean in the userInfo of the
+ WebUIApplicationWillEnterForegroundNotification.
+
+ * UIProcess/ios/WebPageProxyIOS.mm:
+ (WebKit::WebPageProxy::applicationWillEnterForeground):
+ * WebProcess/WebPage/WebPage.h:
+ * WebProcess/WebPage/WebPage.messages.in:
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::applicationWillEnterForeground):
+
</ins><span class="cx"> 2015-10-05 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Get rid of some dead code
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosWebPageProxyIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -621,7 +621,8 @@
</span><span class="cx">
</span><span class="cx"> void WebPageProxy::applicationWillEnterForeground()
</span><span class="cx"> {
</span><del>- m_process->send(Messages::WebPage::ApplicationWillEnterForeground(), m_pageID);
</del><ins>+ bool isSuspendedUnderLock = [UIApp isSuspendedUnderLock];
+ m_process->send(Messages::WebPage::ApplicationWillEnterForeground(isSuspendedUnderLock), m_pageID);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebPageProxy::applicationWillResignActive()
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -807,7 +807,7 @@
</span><span class="cx"> void willStartUserTriggeredZooming();
</span><span class="cx"> void applicationWillResignActive();
</span><span class="cx"> void applicationDidEnterBackground(bool isSuspendedUnderLock);
</span><del>- void applicationWillEnterForeground();
</del><ins>+ void applicationWillEnterForeground(bool isSuspendedUnderLock);
</ins><span class="cx"> void applicationDidBecomeActive();
</span><span class="cx"> void zoomToRect(WebCore::FloatRect, double minimumScale, double maximumScale);
</span><span class="cx"> void completePendingSyntheticClickForContentChangeObserver();
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagemessagesin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -87,7 +87,7 @@
</span><span class="cx"> SetAssistedNodeSelectedIndex(uint32_t index, bool allowMultipleSelection)
</span><span class="cx"> ApplicationWillResignActive()
</span><span class="cx"> ApplicationDidEnterBackground(bool isSuspendedUnderLock)
</span><del>- ApplicationWillEnterForeground()
</del><ins>+ ApplicationWillEnterForeground(bool isSuspendedUnderLock)
</ins><span class="cx"> ApplicationDidBecomeActive()
</span><span class="cx"> ContentSizeCategoryDidChange(String contentSizeCategory)
</span><span class="cx"> ExecuteEditCommandWithCallback(String name, uint64_t callbackID)
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageiosWebPageIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (190603 => 190604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2015-10-06 03:00:36 UTC (rev 190603)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2015-10-06 04:13:32 UTC (rev 190604)
</span><span class="lines">@@ -2844,12 +2844,12 @@
</span><span class="cx"> m_volatilityTimer.startRepeating(std::chrono::milliseconds(200));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebPage::applicationWillEnterForeground()
</del><ins>+void WebPage::applicationWillEnterForeground(bool isSuspendedUnderLock)
</ins><span class="cx"> {
</span><span class="cx"> m_volatilityTimer.stop();
</span><span class="cx"> setLayerTreeStateIsFrozen(false);
</span><span class="cx">
</span><del>- [[NSNotificationCenter defaultCenter] postNotificationName:WebUIApplicationWillEnterForegroundNotification object:nil];
</del><ins>+ [[NSNotificationCenter defaultCenter] postNotificationName:WebUIApplicationWillEnterForegroundNotification object:nil userInfo:@{@"isSuspendedUnderLock": @(isSuspendedUnderLock)}];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebPage::applicationDidBecomeActive()
</span></span></pre>
</div>
</div>
</body>
</html>