<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190566] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190566">190566</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2015-10-05 11:13:15 -0700 (Mon, 05 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove unused HistoryItem::targetItem()
<https://webkit.org/b/149803>
Reviewed by Anders Carlsson.
Source/WebCore:
This is ancient code with no remaining clients since 2010 (<a href="http://trac.webkit.org/projects/webkit/changeset/53650">r53650</a>)
* history/HistoryItem.cpp:
(WebCore::HistoryItem::findTargetItem): Deleted.
(WebCore::HistoryItem::targetItem): Deleted.
* history/HistoryItem.h:
Source/WebKit/mac:
Remove the only (unused) client of HistoryItem::targetItem().
* History/WebHistoryItem.mm:
* History/WebHistoryItemPrivate.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehistoryHistoryItemcpp">trunk/Source/WebCore/history/HistoryItem.cpp</a></li>
<li><a href="#trunkSourceWebCorehistoryHistoryItemh">trunk/Source/WebCore/history/HistoryItem.h</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacHistoryWebHistoryItemmm">trunk/Source/WebKit/mac/History/WebHistoryItem.mm</a></li>
<li><a href="#trunkSourceWebKitmacHistoryWebHistoryItemPrivateh">trunk/Source/WebKit/mac/History/WebHistoryItemPrivate.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (190565 => 190566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-10-05 17:58:59 UTC (rev 190565)
+++ trunk/Source/WebCore/ChangeLog 2015-10-05 18:13:15 UTC (rev 190566)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-10-05 Andreas Kling <akling@apple.com>
+
+ Remove unused HistoryItem::targetItem()
+ <https://webkit.org/b/149803>
+
+ Reviewed by Anders Carlsson.
+
+ This is ancient code with no remaining clients since 2010 (r53650)
+
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::findTargetItem): Deleted.
+ (WebCore::HistoryItem::targetItem): Deleted.
+ * history/HistoryItem.h:
+
</ins><span class="cx"> 2015-10-05 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> Unprefix -webkit-font-feature-settings
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryHistoryItemcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/HistoryItem.cpp (190565 => 190566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/HistoryItem.cpp 2015-10-05 17:58:59 UTC (rev 190565)
+++ trunk/Source/WebCore/history/HistoryItem.cpp 2015-10-05 18:13:15 UTC (rev 190566)
</span><span class="lines">@@ -383,27 +383,6 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-// <rdar://problem/4895849> HistoryItem::findTargetItem() should be replaced with a non-recursive method.
-HistoryItem* HistoryItem::findTargetItem()
-{
- if (m_isTargetItem)
- return this;
- unsigned size = m_children.size();
- for (unsigned i = 0; i < size; ++i) {
- // FIXME: targetItem() cannot return null currently, which is wrong.
- if (HistoryItem* match = m_children[i]->targetItem())
- return match;
- }
- return nullptr;
-}
-
-HistoryItem* HistoryItem::targetItem()
-{
- HistoryItem* foundItem = findTargetItem();
- // FIXME: This should probably not fall back to |this|.
- return foundItem ? foundItem : this;
-}
-
</del><span class="cx"> const HistoryItemVector& HistoryItem::children() const
</span><span class="cx"> {
</span><span class="cx"> return m_children;
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryHistoryItemh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/HistoryItem.h (190565 => 190566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/HistoryItem.h 2015-10-05 17:58:59 UTC (rev 190565)
+++ trunk/Source/WebCore/history/HistoryItem.h 2015-10-05 18:13:15 UTC (rev 190566)
</span><span class="lines">@@ -143,7 +143,6 @@
</span><span class="cx"> void setChildItem(Ref<HistoryItem>&&);
</span><span class="cx"> WEBCORE_EXPORT HistoryItem* childItemWithTarget(const String&);
</span><span class="cx"> HistoryItem* childItemWithDocumentSequenceNumber(long long number);
</span><del>- WEBCORE_EXPORT HistoryItem* targetItem();
</del><span class="cx"> WEBCORE_EXPORT const HistoryItemVector& children() const;
</span><span class="cx"> WEBCORE_EXPORT bool hasChildren() const;
</span><span class="cx"> void clearChildren();
</span><span class="lines">@@ -215,8 +214,6 @@
</span><span class="cx">
</span><span class="cx"> bool hasSameDocumentTree(HistoryItem& otherItem) const;
</span><span class="cx">
</span><del>- HistoryItem* findTargetItem();
-
</del><span class="cx"> String m_urlString;
</span><span class="cx"> String m_originalURLString;
</span><span class="cx"> String m_referrer;
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (190565 => 190566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2015-10-05 17:58:59 UTC (rev 190565)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-10-05 18:13:15 UTC (rev 190566)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2015-10-05 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><ins>+ Remove unused HistoryItem::targetItem()
+ <https://webkit.org/b/149803>
+
+ Reviewed by Anders Carlsson.
+
+ Remove the only (unused) client of HistoryItem::targetItem().
+
+ * History/WebHistoryItem.mm:
+ * History/WebHistoryItemPrivate.h:
+
+2015-10-05 Andreas Kling <akling@apple.com>
+
</ins><span class="cx"> Remove unused HistoryItem::parent
</span><span class="cx"> <https://webkit.org/b/149803>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacHistoryWebHistoryItemmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/History/WebHistoryItem.mm (190565 => 190566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/History/WebHistoryItem.mm 2015-10-05 17:58:59 UTC (rev 190565)
+++ trunk/Source/WebKit/mac/History/WebHistoryItem.mm 2015-10-05 18:13:15 UTC (rev 190566)
</span><span class="lines">@@ -543,11 +543,6 @@
</span><span class="cx"> return url;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (WebHistoryItem *)targetItem
-{
- return kit(core(_private)->targetItem());
-}
-
</del><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> + (void)_releaseAllPendingPageCaches
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebKitmacHistoryWebHistoryItemPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/History/WebHistoryItemPrivate.h (190565 => 190566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/History/WebHistoryItemPrivate.h 2015-10-05 17:58:59 UTC (rev 190565)
+++ trunk/Source/WebKit/mac/History/WebHistoryItemPrivate.h 2015-10-05 18:13:15 UTC (rev 190566)
</span><span class="lines">@@ -54,7 +54,6 @@
</span><span class="cx">
</span><span class="cx"> - (NSArray *)_redirectURLs;
</span><span class="cx">
</span><del>-- (WebHistoryItem *)targetItem;
</del><span class="cx"> - (NSString *)target;
</span><span class="cx"> - (BOOL)isTargetItem;
</span><span class="cx"> - (NSArray *)children;
</span></span></pre>
</div>
</div>
</body>
</html>