<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190451] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190451">190451</a></dd>
<dt>Author</dt> <dd>wenson_hsieh@apple.com</dd>
<dt>Date</dt> <dd>2015-10-01 21:27:32 -0700 (Thu, 01 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Convert focused-input-should-assist-on-touch.html into an automated test
https://bugs.webkit.org/show_bug.cgi?id=149724
Reviewed by Simon Fraser.
.:
Remove a manual test that can now be rewritten as an automated test.
* ManualTests/ios/focused-input-should-assist-on-touch.html: Removed.
LayoutTests:
Tests that an input that focuses itself on touch and then prevents default is
able to trigger node assistance, even when it is already focused before the
user gesture.
* fast/events/ios/focused-input-should-assist-on-touch-expected.txt: Added.
* fast/events/ios/focused-input-should-assist-on-touch.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasteventsiosfocusedinputshouldassistontouchexpectedtxt">trunk/LayoutTests/fast/events/ios/focused-input-should-assist-on-touch-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsiosfocusedinputshouldassistontouchhtml">trunk/LayoutTests/fast/events/ios/focused-input-should-assist-on-touch.html</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkManualTestsiosfocusedinputshouldassistontouchhtml">trunk/ManualTests/ios/focused-input-should-assist-on-touch.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (190450 => 190451)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog 2015-10-02 03:45:53 UTC (rev 190450)
+++ trunk/ChangeLog 2015-10-02 04:27:32 UTC (rev 190451)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
+
+ Convert focused-input-should-assist-on-touch.html into an automated test
+ https://bugs.webkit.org/show_bug.cgi?id=149724
+
+ Reviewed by Simon Fraser.
+
+ Remove a manual test that can now be rewritten as an automated test.
+
+ * ManualTests/ios/focused-input-should-assist-on-touch.html: Removed.
+
</ins><span class="cx"> 2015-10-01 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win] Unreviewed CMake build fix.
</span></span></pre></div>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (190450 => 190451)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-10-02 03:45:53 UTC (rev 190450)
+++ trunk/LayoutTests/ChangeLog 2015-10-02 04:27:32 UTC (rev 190451)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
+
+ Convert focused-input-should-assist-on-touch.html into an automated test
+ https://bugs.webkit.org/show_bug.cgi?id=149724
+
+ Reviewed by Simon Fraser.
+
+ Tests that an input that focuses itself on touch and then prevents default is
+ able to trigger node assistance, even when it is already focused before the
+ user gesture.
+
+ * fast/events/ios/focused-input-should-assist-on-touch-expected.txt: Added.
+ * fast/events/ios/focused-input-should-assist-on-touch.html: Added.
+
</ins><span class="cx"> 2015-10-01 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> Rollout r190446 for the moment. It broke the build.
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsiosfocusedinputshouldassistontouchexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/ios/focused-input-should-assist-on-touch-expected.txt (0 => 190451)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/ios/focused-input-should-assist-on-touch-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/ios/focused-input-should-assist-on-touch-expected.txt 2015-10-02 04:27:32 UTC (rev 190451)
</span><span class="lines">@@ -0,0 +1,2 @@
</span><ins>+
+Successfully showed keyboard.
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventsiosfocusedinputshouldassistontouchhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/ios/focused-input-should-assist-on-touch.html (0 => 190451)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/ios/focused-input-should-assist-on-touch.html (rev 0)
+++ trunk/LayoutTests/fast/events/ios/focused-input-should-assist-on-touch.html 2015-10-02 04:27:32 UTC (rev 190451)
</span><span class="lines">@@ -0,0 +1,62 @@
</span><ins>+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
+
+<html>
+<head>
+ <meta name="viewport" content="initial-scale=1.0">
+ <script id="ui-script" type="text/plain">
+ (function() {
+ uiController.didShowKeyboardCallback = function() {
+ uiController.uiScriptComplete("Successfully showed keyboard.");
+ }
+ uiController.singleTapAtPoint(50, 25, function() { });
+ })();
+ </script>
+
+ <script>
+ if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+ }
+
+ function getUIScript()
+ {
+ return document.getElementById("ui-script").text;
+ }
+
+ function handleTouchEvent(event)
+ {
+ event.target.focus();
+ event.preventDefault();
+ }
+
+ function runTest()
+ {
+ if (window.testRunner && testRunner.runUIScript)
+ testRunner.runUIScript(getUIScript(), function(result) {
+ document.getElementById("console").textContent = result;
+ testRunner.notifyDone();
+ });
+ else
+ document.getElementById("console").textContent = "This tests that a node can be assisted when focused due to a touch event, even when the focus does not change. Tapping the below input should show the keyboard. Best run using WKTR."
+ }
+ </script>
+
+ <style>
+ input:focus {
+ outline: none;
+ border: 1px solid #4D90FE;
+ }
+
+ input {
+ width: 100px;
+ height: 50px;
+ }
+ </style>
+
+</head>
+
+<body style="margin: 0;" onload="runTest()">
+ <input autofocus ontouchstart="handleTouchEvent(event)"></input>
+ <div id="console">Failed to show keyboard.</div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkManualTestsiosfocusedinputshouldassistontouchhtml"></a>
<div class="delfile"><h4>Deleted: trunk/ManualTests/ios/focused-input-should-assist-on-touch.html (190450 => 190451)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ManualTests/ios/focused-input-should-assist-on-touch.html 2015-10-02 03:45:53 UTC (rev 190450)
+++ trunk/ManualTests/ios/focused-input-should-assist-on-touch.html 2015-10-02 04:27:32 UTC (rev 190451)
</span><span class="lines">@@ -1,25 +0,0 @@
</span><del>-<html>
-<head>
- <meta name="viewport" content="width=device-width, initial-scale=1">
- <script>
- function handleTouchEvent(event) {
- event.target.focus();
- event.preventDefault();
- }
- </script>
-
- <style>
- input:focus {
- outline: none;
- border: 1px solid #4D90FE;
- }
- </style>
-
-</head>
-
-<body style="margin: 0;">
- <p>This tests checks that a node can be assisted when focused due to a touch event, even when the focus does not change.</p>
- <p>Tapping the below input should show the keyboard.</p>
- <input autofocus ontouchstart="handleTouchEvent(event);"></input>
-</body>
-</html>
</del></span></pre>
</div>
</div>
</body>
</html>