<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190376] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190376">190376</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-09-30 17:08:18 -0700 (Wed, 30 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Reduce `delete` in TreeElements and DataGridNodes
https://bugs.webkit.org/show_bug.cgi?id=149680
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-09-30
Reviewed by Timothy Hatcher.
* UserInterface/Views/BreakpointTreeElement.js:
(WebInspector.BreakpointTreeElement):
(WebInspector.BreakpointTreeElement.prototype._removeProbeSet):
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype._editingCommitted.moveToNextCell):
(WebInspector.DataGrid.prototype._editingCommitted):
(WebInspector.DataGrid.prototype._editingCancelled):
(WebInspector.DataGrid.prototype.removeColumn):
(WebInspector.DataGridNode.prototype.refreshIfNeeded):
(WebInspector.DataGridNode.prototype.refresh):
(WebInspector.DataGridNode.prototype.expand):
(WebInspector.DataGridNode.prototype.restorePosition):
(WebInspector.DataGridNode):
* UserInterface/Views/GeneralTreeElement.js:
(WebInspector.GeneralTreeElement.prototype.ondetach):
* UserInterface/Views/ResourceTimelineDataGridNode.js:
(WebInspector.ResourceTimelineDataGridNode.prototype.refresh):
* UserInterface/Views/TreeOutline.js:
(WebInspector.TreeElement.prototype._fireDidChange):
(WebInspector.TreeElement.prototype.expand):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsBreakpointTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDataGridjs">trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsGeneralTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsResourceTimelineDataGridNodejs">trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTreeOutlinejs">trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (190375 => 190376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-10-01 00:04:10 UTC (rev 190375)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-10-01 00:08:18 UTC (rev 190376)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2015-09-30 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Reduce `delete` in TreeElements and DataGridNodes
+ https://bugs.webkit.org/show_bug.cgi?id=149680
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/BreakpointTreeElement.js:
+ (WebInspector.BreakpointTreeElement):
+ (WebInspector.BreakpointTreeElement.prototype._removeProbeSet):
+ * UserInterface/Views/DataGrid.js:
+ (WebInspector.DataGrid.prototype._editingCommitted.moveToNextCell):
+ (WebInspector.DataGrid.prototype._editingCommitted):
+ (WebInspector.DataGrid.prototype._editingCancelled):
+ (WebInspector.DataGrid.prototype.removeColumn):
+ (WebInspector.DataGridNode.prototype.refreshIfNeeded):
+ (WebInspector.DataGridNode.prototype.refresh):
+ (WebInspector.DataGridNode.prototype.expand):
+ (WebInspector.DataGridNode.prototype.restorePosition):
+ (WebInspector.DataGridNode):
+ * UserInterface/Views/GeneralTreeElement.js:
+ (WebInspector.GeneralTreeElement.prototype.ondetach):
+ * UserInterface/Views/ResourceTimelineDataGridNode.js:
+ (WebInspector.ResourceTimelineDataGridNode.prototype.refresh):
+ * UserInterface/Views/TreeOutline.js:
+ (WebInspector.TreeElement.prototype._fireDidChange):
+ (WebInspector.TreeElement.prototype.expand):
+
</ins><span class="cx"> 2015-09-30 Andres Gomez <agomez@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Web Inspector: Add GTK+ icon for the Bezier curve visual editor
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsBreakpointTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js (190375 => 190376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js 2015-10-01 00:04:10 UTC (rev 190375)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js 2015-10-01 00:08:18 UTC (rev 190376)
</span><span class="lines">@@ -35,6 +35,7 @@
</span><span class="cx"> super(["breakpoint", className], title, null, breakpoint, false);
</span><span class="cx">
</span><span class="cx"> this._breakpoint = breakpoint;
</span><ins>+ this._probeSet = null;
</ins><span class="cx">
</span><span class="cx"> this._listeners = new WebInspector.EventListenerSet(this, "BreakpointTreeElement listeners");
</span><span class="cx"> if (!title)
</span><span class="lines">@@ -194,7 +195,7 @@
</span><span class="cx">
</span><span class="cx"> probeSet.removeEventListener(WebInspector.ProbeSet.Event.SamplesCleared, this._samplesCleared, this);
</span><span class="cx"> probeSet.dataTable.removeEventListener(WebInspector.ProbeSetDataTable.Event.FrameInserted, this._dataUpdated, this);
</span><del>- delete this._probeSet;
</del><ins>+ this._probeSet = null;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _probeSetAdded(event)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDataGridjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (190375 => 190376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2015-10-01 00:04:10 UTC (rev 190375)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2015-10-01 00:08:18 UTC (rev 190376)
</span><span class="lines">@@ -315,7 +315,7 @@
</span><span class="cx"> var moveCommand = determineNextCell.call(this, valueDidChange);
</span><span class="cx"> if (moveCommand.shouldSort && this._sortAfterEditingCallback) {
</span><span class="cx"> this._sortAfterEditingCallback();
</span><del>- delete this._sortAfterEditingCallback;
</del><ins>+ this._sortAfterEditingCallback = null;
</ins><span class="cx"> }
</span><span class="cx"> if (moveCommand.editingNode)
</span><span class="cx"> this._startEditingNodeAtColumnIndex(moveCommand.editingNode, moveCommand.columnIndex);
</span><span class="lines">@@ -334,7 +334,7 @@
</span><span class="cx"> _editingCancelled(element)
</span><span class="cx"> {
</span><span class="cx"> console.assert(this._editingNode.element === element.enclosingNodeOrSelfWithNodeName("tr"));
</span><del>- delete this._editing;
</del><ins>+ this._editing = false;
</ins><span class="cx"> this._editingNode = null;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -516,7 +516,7 @@
</span><span class="cx"> removedColumn["listeners"].uninstall(true);
</span><span class="cx">
</span><span class="cx"> if (removedColumn["disclosure"])
</span><del>- delete this.disclosureColumnIdentifier;
</del><ins>+ this.disclosureColumnIdentifier = undefined;
</ins><span class="cx">
</span><span class="cx"> if (this.sortColumnIdentifier === columnIdentifier)
</span><span class="cx"> this.sortColumnIdentifier = null;
</span><span class="lines">@@ -1391,7 +1391,7 @@
</span><span class="cx"> if (!this._needsRefresh)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- delete this._needsRefresh;
</del><ins>+ this._needsRefresh = false;
</ins><span class="cx">
</span><span class="cx"> this.refresh();
</span><span class="cx"> }
</span><span class="lines">@@ -1551,10 +1551,10 @@
</span><span class="cx">
</span><span class="cx"> if (this._scheduledRefreshIdentifier) {
</span><span class="cx"> cancelAnimationFrame(this._scheduledRefreshIdentifier);
</span><del>- delete this._scheduledRefreshIdentifier;
</del><ins>+ this._scheduledRefreshIdentifier = undefined;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- delete this._needsRefresh;
</del><ins>+ this._needsRefresh = false;
</ins><span class="cx">
</span><span class="cx"> this._element.removeChildren();
</span><span class="cx"> this.createCells();
</span><span class="lines">@@ -1685,7 +1685,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- delete this._shouldRefreshChildren;
</del><ins>+ this._shouldRefreshChildren = false;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (this._element)
</span><span class="lines">@@ -1896,7 +1896,7 @@
</span><span class="cx"> if (this.parent !== this._savedPosition.parent)
</span><span class="cx"> this._savedPosition.parent.insertChild(this, this._savedPosition.index);
</span><span class="cx">
</span><del>- delete this._savedPosition;
</del><ins>+ this._savedPosition = null;
</ins><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsGeneralTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js (190375 => 190376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js 2015-10-01 00:04:10 UTC (rev 190375)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js 2015-10-01 00:08:18 UTC (rev 190376)
</span><span class="lines">@@ -250,7 +250,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (this._boundContextMenuEventHandler) {
</span><span class="cx"> this._listItemNode.removeEventListener("contextmenu", this._boundContextMenuEventHandler);
</span><del>- delete this._boundContextMenuEventHandler;
</del><ins>+ this._boundContextMenuEventHandler = null;
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsResourceTimelineDataGridNodejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js (190375 => 190376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js 2015-10-01 00:04:10 UTC (rev 190375)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js 2015-10-01 00:08:18 UTC (rev 190376)
</span><span class="lines">@@ -127,10 +127,10 @@
</span><span class="cx"> {
</span><span class="cx"> if (this._scheduledRefreshIdentifier) {
</span><span class="cx"> cancelAnimationFrame(this._scheduledRefreshIdentifier);
</span><del>- delete this._scheduledRefreshIdentifier;
</del><ins>+ this._scheduledRefreshIdentifier = undefined;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- delete this._cachedData;
</del><ins>+ this._cachedData = null;
</ins><span class="cx">
</span><span class="cx"> super.refresh();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTreeOutlinejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (190375 => 190376)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2015-10-01 00:04:10 UTC (rev 190375)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2015-10-01 00:08:18 UTC (rev 190376)
</span><span class="lines">@@ -690,7 +690,7 @@
</span><span class="cx">
</span><span class="cx"> _fireDidChange()
</span><span class="cx"> {
</span><del>- delete this._didChangeTimeoutIdentifier;
</del><ins>+ this._didChangeTimeoutIdentifier = undefined;
</ins><span class="cx">
</span><span class="cx"> if (this.treeOutline)
</span><span class="cx"> this.treeOutline._treeElementDidChange(this);
</span><span class="lines">@@ -890,7 +890,7 @@
</span><span class="cx"> for (var i = 0; i < this.children.length; ++i)
</span><span class="cx"> this.children[i]._attach();
</span><span class="cx">
</span><del>- delete this._shouldRefreshChildren;
</del><ins>+ this._shouldRefreshChildren = false;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (this._listItemNode) {
</span></span></pre>
</div>
</div>
</body>
</html>