<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190381] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190381">190381</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-09-30 18:32:26 -0700 (Wed, 30 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Reduce `delete` in Timeline related classes
https://bugs.webkit.org/show_bug.cgi?id=149686
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-09-30
Reviewed by Timothy Hatcher.
* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype.capturingStopped):
* UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
(WebInspector.TimelineDataGrid.prototype._sort):
(WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
* UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.updateLayout):
(WebInspector.TimelineOverview.prototype._handleScrollEvent):
* UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeOutlineScrolled):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridScrolled):
* UserInterface/Views/ProbeSetDataGrid.js:
(WebInspector.ProbeSetDataGrid):
(WebInspector.ProbeSetDataGrid.prototype._teardownData):
Remove an unused member variable as well.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceControllersTimelineManagerjs">trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsProbeSetDataGridjs">trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineDataGridjs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineOverviewjs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTreeOutlineDataGridSynchronizerjs">trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutlineDataGridSynchronizer.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (190380 => 190381)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-10-01 01:29:52 UTC (rev 190380)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-10-01 01:32:26 UTC (rev 190381)
</span><span class="lines">@@ -1,5 +1,30 @@
</span><span class="cx"> 2015-09-30 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Reduce `delete` in Timeline related classes
+ https://bugs.webkit.org/show_bug.cgi?id=149686
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Controllers/TimelineManager.js:
+ (WebInspector.TimelineManager.prototype.capturingStopped):
+ * UserInterface/Views/TimelineDataGrid.js:
+ (WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
+ (WebInspector.TimelineDataGrid.prototype._sort):
+ (WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
+ * UserInterface/Views/TimelineOverview.js:
+ (WebInspector.TimelineOverview.prototype.updateLayout):
+ (WebInspector.TimelineOverview.prototype._handleScrollEvent):
+ * UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
+ (WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeOutlineScrolled):
+ (WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridScrolled):
+
+ * UserInterface/Views/ProbeSetDataGrid.js:
+ (WebInspector.ProbeSetDataGrid):
+ (WebInspector.ProbeSetDataGrid.prototype._teardownData):
+ Remove an unused member variable as well.
+
+2015-09-30 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Thousands of timers fire after switching to JavaScript and Events timeline
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149682
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceControllersTimelineManagerjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js (190380 => 190381)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2015-10-01 01:29:52 UTC (rev 190380)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2015-10-01 01:32:26 UTC (rev 190381)
</span><span class="lines">@@ -161,12 +161,12 @@
</span><span class="cx">
</span><span class="cx"> if (this._stopCapturingTimeout) {
</span><span class="cx"> clearTimeout(this._stopCapturingTimeout);
</span><del>- delete this._stopCapturingTimeout;
</del><ins>+ this._stopCapturingTimeout = undefined;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (this._deadTimeTimeout) {
</span><span class="cx"> clearTimeout(this._deadTimeTimeout);
</span><del>- delete this._deadTimeTimeout;
</del><ins>+ this._deadTimeTimeout = undefined;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> this._isCapturing = false;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsProbeSetDataGridjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js (190380 => 190381)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js 2015-10-01 01:29:52 UTC (rev 190380)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js 2015-10-01 01:32:26 UTC (rev 190381)
</span><span class="lines">@@ -43,6 +43,7 @@
</span><span class="cx"> this.element.classList.add("inline");
</span><span class="cx">
</span><span class="cx"> this._frameNodes = new Map;
</span><ins>+ this._lastUpdatedFrame = null;
</ins><span class="cx"> this._nodesSinceLastNavigation = [];
</span><span class="cx">
</span><span class="cx"> this._listeners = new WebInspector.EventListenerSet(this, "ProbeSetDataGrid instance listeners");
</span><span class="lines">@@ -103,8 +104,7 @@
</span><span class="cx"> this._dataListeners.uninstall(true);
</span><span class="cx"> this.removeChildren();
</span><span class="cx"> this._frameNodes = new Map;
</span><del>- this._separators = new Map;
- delete this._lastUpdatedFrame;
</del><ins>+ this._lastUpdatedFrame = null;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _updateNodeForFrame(frame)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineDataGridjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js (190380 => 190381)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js 2015-10-01 01:29:52 UTC (rev 190380)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js 2015-10-01 01:32:26 UTC (rev 190381)
</span><span class="lines">@@ -194,7 +194,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (this._scheduledDataGridNodeRefreshIdentifier) {
</span><span class="cx"> cancelAnimationFrame(this._scheduledDataGridNodeRefreshIdentifier);
</span><del>- delete this._scheduledDataGridNodeRefreshIdentifier;
</del><ins>+ this._scheduledDataGridNodeRefreshIdentifier = undefined;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!this._dirtyDataGridNodes)
</span><span class="lines">@@ -236,13 +236,13 @@
</span><span class="cx">
</span><span class="cx"> if (dataGridNode === selectedNode) {
</span><span class="cx"> selectedNode.revealAndSelect();
</span><del>- delete this._ignoreSelectionEvent;
</del><ins>+ this._ignoreSelectionEvent = false;
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> this._treeOutlineDataGridSynchronizer.enabled = true;
</span><span class="cx">
</span><del>- delete this._dirtyDataGridNodes;
</del><ins>+ this._dirtyDataGridNodes = null;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _sort()
</span><span class="lines">@@ -300,7 +300,7 @@
</span><span class="cx"> if (selectedNode)
</span><span class="cx"> selectedNode.revealAndSelect();
</span><span class="cx">
</span><del>- delete this._ignoreSelectionEvent;
</del><ins>+ this._ignoreSelectionEvent = false;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _sortComparator(node1, node2)
</span><span class="lines">@@ -403,7 +403,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (this._showPopoverTimeout) {
</span><span class="cx"> clearTimeout(this._showPopoverTimeout);
</span><del>- delete this._showPopoverTimeout;
</del><ins>+ this._showPopoverTimeout = undefined;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (this._popover)
</span><span class="lines">@@ -438,7 +438,7 @@
</span><span class="cx">
</span><span class="cx"> if (this._hidePopoverContentClearTimeout) {
</span><span class="cx"> clearTimeout(this._hidePopoverContentClearTimeout);
</span><del>- delete this._hidePopoverContentClearTimeout;
</del><ins>+ this._hidePopoverContentClearTimeout = undefined;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (updateContent)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineOverviewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js (190380 => 190381)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2015-10-01 01:29:52 UTC (rev 190380)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2015-10-01 01:32:26 UTC (rev 190381)
</span><span class="lines">@@ -313,7 +313,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (this._scheduledLayoutUpdateIdentifier) {
</span><span class="cx"> cancelAnimationFrame(this._scheduledLayoutUpdateIdentifier);
</span><del>- delete this._scheduledLayoutUpdateIdentifier;
</del><ins>+ this._scheduledLayoutUpdateIdentifier = undefined;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Calculate the required width based on the duration and seconds per pixel.
</span><span class="lines">@@ -405,7 +405,7 @@
</span><span class="cx"> _handleScrollEvent(event)
</span><span class="cx"> {
</span><span class="cx"> if (this._ignoreNextScrollEvent) {
</span><del>- delete this._ignoreNextScrollEvent;
</del><ins>+ this._ignoreNextScrollEvent = false;
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -417,7 +417,7 @@
</span><span class="cx"> // Force layout so we can update with the scroll position synchronously.
</span><span class="cx"> this.updateLayoutIfNeeded();
</span><span class="cx">
</span><del>- delete this._dontUpdateScrollLeft;
</del><ins>+ this._dontUpdateScrollLeft = false;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _handleWheelEvent(event)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTreeOutlineDataGridSynchronizerjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutlineDataGridSynchronizer.js (190380 => 190381)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutlineDataGridSynchronizer.js 2015-10-01 01:29:52 UTC (rev 190380)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutlineDataGridSynchronizer.js 2015-10-01 01:32:26 UTC (rev 190381)
</span><span class="lines">@@ -167,7 +167,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (this._ignoreNextTreeOutlineScrollEvent) {
</span><del>- delete this._ignoreNextTreeOutlineScrollEvent;
</del><ins>+ this._ignoreNextTreeOutlineScrollEvent = false;
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -191,7 +191,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (this._ignoreNextDataGridScrollEvent) {
</span><del>- delete this._ignoreNextDataGridScrollEvent;
</del><ins>+ this._ignoreNextDataGridScrollEvent = false;
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>