<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190316] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190316">190316</a></dd>
<dt>Author</dt> <dd>calvaris@igalia.com</dd>
<dt>Date</dt> <dd>2015-09-29 11:08:05 -0700 (Tue, 29 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Streams API] Update tests according to latest spec
https://bugs.webkit.org/show_bug.cgi?id=149628
Reviewed by Darin Adler.
Added checkpoints and updated all tests that don't disrupt the current implementation and the tests that are
passing now.
* streams/reference-implementation/bad-strategies-expected.txt:
* streams/reference-implementation/bad-strategies.html:
* streams/reference-implementation/pipe-to-options.html:
* streams/reference-implementation/pipe-to.html:
* streams/reference-implementation/writable-stream-abort.html:
* streams/reference-implementation/writable-stream.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationbadstrategiesexpectedtxt">trunk/LayoutTests/streams/reference-implementation/bad-strategies-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationbadstrategieshtml">trunk/LayoutTests/streams/reference-implementation/bad-strategies.html</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationpipetooptionshtml">trunk/LayoutTests/streams/reference-implementation/pipe-to-options.html</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationpipetohtml">trunk/LayoutTests/streams/reference-implementation/pipe-to.html</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationwritablestreamaborthtml">trunk/LayoutTests/streams/reference-implementation/writable-stream-abort.html</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationwritablestreamhtml">trunk/LayoutTests/streams/reference-implementation/writable-stream.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (190315 => 190316)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-29 17:53:08 UTC (rev 190315)
+++ trunk/LayoutTests/ChangeLog 2015-09-29 18:08:05 UTC (rev 190316)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-09-29 Xabier Rodriguez Calvar <calvaris@igalia.com>
+
+ [Streams API] Update tests according to latest spec
+ https://bugs.webkit.org/show_bug.cgi?id=149628
+
+ Reviewed by Darin Adler.
+
+ Added checkpoints and updated all tests that don't disrupt the current implementation and the tests that are
+ passing now.
+
+ * streams/reference-implementation/bad-strategies-expected.txt:
+ * streams/reference-implementation/bad-strategies.html:
+ * streams/reference-implementation/pipe-to-options.html:
+ * streams/reference-implementation/pipe-to.html:
+ * streams/reference-implementation/writable-stream-abort.html:
+ * streams/reference-implementation/writable-stream.html:
+
</ins><span class="cx"> 2015-09-29 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win] Test gardening
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationbadstrategiesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/bad-strategies-expected.txt (190315 => 190316)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/bad-strategies-expected.txt 2015-09-29 17:53:08 UTC (rev 190315)
+++ trunk/LayoutTests/streams/reference-implementation/bad-strategies-expected.txt 2015-09-29 18:08:05 UTC (rev 190316)
</span><span class="lines">@@ -3,7 +3,6 @@
</span><span class="cx"> PASS Readable stream: throwing strategy.size method
</span><span class="cx"> PASS Readable stream: throwing strategy.highWaterMark getter
</span><span class="cx"> PASS Readable stream: invalid strategy.highWaterMark
</span><del>-PASS Readable stream: negative strategy.highWaterMark
</del><span class="cx"> PASS Readable stream: invalid strategy.size return value
</span><span class="cx"> FAIL Writable stream: throwing strategy.size getter assert_throws: construction should re-throw the error function "function () {
</span><span class="cx"> new WritableStream({}, {
</span><span class="lines">@@ -16,7 +15,4 @@
</span><span class="cx"> FAIL Writable stream: invalid strategy.highWaterMark assert_throws: construction should throw a RangeError for -1 function "function () {
</span><span class="cx"> new WritableStream({}, {
</span><span class="cx"> ..." threw object "ReferenceError: Can't find variable: WritableStream" ("ReferenceError") expected object "RangeError" ("RangeError")
</span><del>-FAIL Writable stream: negative strategy.highWaterMark assert_throws: construction should throw a RangeError function "function () {
- new WritableStream({}, {
- ..." threw object "ReferenceError: Can't find variable: WritableStream" ("ReferenceError") expected object "RangeError" ("RangeError")
</del><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationbadstrategieshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/bad-strategies.html (190315 => 190316)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/bad-strategies.html 2015-09-29 17:53:08 UTC (rev 190315)
+++ trunk/LayoutTests/streams/reference-implementation/bad-strategies.html 2015-09-29 18:08:05 UTC (rev 190316)
</span><span class="lines">@@ -2,6 +2,8 @@
</span><span class="cx"> <script src='../../resources/testharness.js'></script>
</span><span class="cx"> <script src='../../resources/testharnessreport.js'></script>
</span><span class="cx"> <script>
</span><ins>+// This is updated till ec5ffa0 of the spec.
+
</ins><span class="cx"> test(function() {
</span><span class="cx"> var theError = new Error('a unique string');
</span><span class="cx">
</span><span class="lines">@@ -77,17 +79,6 @@
</span><span class="cx"> }
</span><span class="cx"> }, 'Readable stream: invalid strategy.highWaterMark');
</span><span class="cx">
</span><del>-test(function() {
- assert_throws(new RangeError(), function() {
- new ReadableStream({}, {
- size: function() {
- return 1;
- },
- highWaterMark: -1
- });
- }, 'construction should throw a RangeError');
-}, 'Readable stream: negative strategy.highWaterMark');
-
</del><span class="cx"> var test2 = async_test('Readable stream: invalid strategy.size return value');
</span><span class="cx"> test2.step(function() {
</span><span class="cx"> var numberOfCalls = 0;
</span><span class="lines">@@ -240,15 +231,4 @@
</span><span class="cx"> }, 'construction should throw a TypeError for ' + highWaterMark);
</span><span class="cx"> }
</span><span class="cx"> }, 'Writable stream: invalid strategy.highWaterMark');
</span><del>-
-test(function() {
- assert_throws(new RangeError(), function() {
- new WritableStream({}, {
- size: function() {
- return 1;
- },
- highWaterMark: -1
- });
- }, 'construction should throw a RangeError');
-}, 'Writable stream: negative strategy.highWaterMark');
</del><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationpipetooptionshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/pipe-to-options.html (190315 => 190316)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/pipe-to-options.html 2015-09-29 17:53:08 UTC (rev 190315)
+++ trunk/LayoutTests/streams/reference-implementation/pipe-to-options.html 2015-09-29 18:08:05 UTC (rev 190316)
</span><span class="lines">@@ -3,6 +3,8 @@
</span><span class="cx"> <script src='../../resources/testharnessreport.js'></script>
</span><span class="cx"> <script src='resources/streams-utils.js'></script>
</span><span class="cx"> <script>
</span><ins>+// This is updated till ec5ffa0 of the spec.
+
</ins><span class="cx"> var test1 = async_test('Piping with no options and a destination error');
</span><span class="cx"> test1.step(function() {
</span><span class="cx"> var cancelCalled = false;
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationpipetohtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/pipe-to.html (190315 => 190316)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/pipe-to.html 2015-09-29 17:53:08 UTC (rev 190315)
+++ trunk/LayoutTests/streams/reference-implementation/pipe-to.html 2015-09-29 18:08:05 UTC (rev 190316)
</span><span class="lines">@@ -3,6 +3,8 @@
</span><span class="cx"> <script src='../../resources/testharnessreport.js'></script>
</span><span class="cx"> <script src='resources/streams-utils.js'></script>
</span><span class="cx"> <script>
</span><ins>+// This is updated till ec5ffa0 of the spec.
+
</ins><span class="cx"> var test1 = async_test('Piping from a ReadableStream from which lots of data are readable synchronously');
</span><span class="cx"> test1.step(function() {
</span><span class="cx"> var events = 0;
</span><span class="lines">@@ -513,7 +515,7 @@
</span><span class="cx"> assert_unreached('Unexpected close call');
</span><span class="cx"> },
</span><span class="cx"> abort: function() {
</span><del>- test11.done();
</del><ins>+ test11.done('underlying source abort was called');
</ins><span class="cx"> }
</span><span class="cx"> });
</span><span class="cx"> ws.write('Hello');
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationwritablestreamaborthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/writable-stream-abort.html (190315 => 190316)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/writable-stream-abort.html 2015-09-29 17:53:08 UTC (rev 190315)
+++ trunk/LayoutTests/streams/reference-implementation/writable-stream-abort.html 2015-09-29 18:08:05 UTC (rev 190316)
</span><span class="lines">@@ -3,6 +3,8 @@
</span><span class="cx"> <script src='../../resources/testharnessreport.js'></script>
</span><span class="cx"> <script src='resources/streams-utils.js'></script>
</span><span class="cx"> <script>
</span><ins>+// This is updated till ec5ffa0 of the spec.
+
</ins><span class="cx"> var test1 = async_test('Aborting a WritableStream immediately prevents future writes');
</span><span class="cx"> test1.step(function() {
</span><span class="cx"> var chunks = [];
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationwritablestreamhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/writable-stream.html (190315 => 190316)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/writable-stream.html 2015-09-29 17:53:08 UTC (rev 190315)
+++ trunk/LayoutTests/streams/reference-implementation/writable-stream.html 2015-09-29 18:08:05 UTC (rev 190316)
</span><span class="lines">@@ -3,6 +3,8 @@
</span><span class="cx"> <script src='../../resources/testharnessreport.js'></script>
</span><span class="cx"> <script src='resources/streams-utils.js'></script>
</span><span class="cx"> <script>
</span><ins>+// This is updated till ec5ffa0 of the spec.
+
</ins><span class="cx"> function writeArrayToStream(array, writableStream) {
</span><span class="cx"> array.forEach(function(chunk) { writableStream.write(chunk); })
</span><span class="cx"> return writableStream.close();
</span></span></pre>
</div>
</div>
</body>
</html>