<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190276] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190276">190276</a></dd>
<dt>Author</dt> <dd>ossy@webkit.org</dd>
<dt>Date</dt> <dd>2015-09-28 02:15:49 -0700 (Mon, 28 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>validate-committer-lists -b shouldn't need edituser privileges
https://bugs.webkit.org/show_bug.cgi?id=149519
Reviewed by Darin Adler.
* Scripts/validate-committer-lists:
(CommitterListBugzillaChecker._has_invalid_bugzilla_email):
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries.is_invalid_bugzilla_email):
(BugzillaQueries): Deleted.
(BugzillaQueries.fetch_logins_matching_substring): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptsvalidatecommitterlists">trunk/Tools/Scripts/validate-committer-lists</a></li>
<li><a href="#trunkToolsScriptswebkitpycommonnetbugzillabugzillapy">trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (190275 => 190276)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-09-28 07:49:50 UTC (rev 190275)
+++ trunk/Tools/ChangeLog 2015-09-28 09:15:49 UTC (rev 190276)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-09-28 Csaba Osztrogonác <ossy@webkit.org>
+
+ validate-committer-lists -b shouldn't need edituser privileges
+ https://bugs.webkit.org/show_bug.cgi?id=149519
+
+ Reviewed by Darin Adler.
+
+ * Scripts/validate-committer-lists:
+ (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
+ * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+ (BugzillaQueries.is_invalid_bugzilla_email):
+ (BugzillaQueries): Deleted.
+ (BugzillaQueries.fetch_logins_matching_substring): Deleted.
+
</ins><span class="cx"> 2015-09-26 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed. Gardening: skip media stream tests failing after r190262.
</span></span></pre></div>
<a id="trunkToolsScriptsvalidatecommitterlists"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/validate-committer-lists (190275 => 190276)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/validate-committer-lists 2015-09-28 07:49:50 UTC (rev 190275)
+++ trunk/Tools/Scripts/validate-committer-lists 2015-09-28 09:15:49 UTC (rev 190276)
</span><span class="lines">@@ -253,7 +253,7 @@
</span><span class="cx"> self._bugzilla = Bugzilla()
</span><span class="cx">
</span><span class="cx"> def _has_invalid_bugzilla_email(self, committer):
</span><del>- return not self._bugzilla.queries.fetch_logins_matching_substring(committer.bugzilla_email())
</del><ins>+ return self._bugzilla.queries.is_invalid_bugzilla_email(committer.bugzilla_email())
</ins><span class="cx">
</span><span class="cx"> def print_committers_with_invalid_bugzilla_emails(self, committer_list):
</span><span class="cx"> print # Print a newline before we start hitting bugzilla (it logs about logging in).
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpycommonnetbugzillabugzillapy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (190275 => 190276)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2015-09-28 07:49:50 UTC (rev 190275)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2015-09-28 09:15:49 UTC (rev 190276)
</span><span class="lines">@@ -286,12 +286,11 @@
</span><span class="cx"> # We could pull the EditUsersParser off Bugzilla if needed.
</span><span class="cx"> return EditUsersParser().login_userid_pairs_from_edit_user_results(results_page)
</span><span class="cx">
</span><del>- # FIXME: We should consider adding a BugzillaUser class.
- def fetch_logins_matching_substring(self, search_string):
- pairs = self.fetch_login_userid_pairs_matching_substring(search_string)
- return map(lambda pair: pair[0], pairs)
</del><ins>+ def is_invalid_bugzilla_email(self, search_string):
+ review_queue_url = "request.cgi?action=queue&requester=%s&product=&type=review&requestee=&component=&group=requestee" % urllib.quote(search_string)
+ results_page = self._load_query(review_queue_url)
+ return bool(re.search("did not match anything", results_page.read()))
</ins><span class="cx">
</span><del>-
</del><span class="cx"> class CommitQueueFlag(object):
</span><span class="cx"> mark_for_nothing = 0
</span><span class="cx"> mark_for_commit_queue = 1
</span></span></pre>
</div>
</div>
</body>
</html>