<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190162] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190162">190162</a></dd>
<dt>Author</dt> <dd>calvaris@igalia.com</dd>
<dt>Date</dt> <dd>2015-09-23 04:14:50 -0700 (Wed, 23 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Streams API] Add brand checks tests for writable streams
https://bugs.webkit.org/show_bug.cgi?id=148301
Reviewed by Darin Adler.
* streams/reference-implementation/brand-checks-expected.txt: Added new expectations.
* streams/reference-implementation/brand-checks.html: Added new writable stream tests.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationbrandchecksexpectedtxt">trunk/LayoutTests/streams/reference-implementation/brand-checks-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationbrandcheckshtml">trunk/LayoutTests/streams/reference-implementation/brand-checks.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (190161 => 190162)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-23 11:12:58 UTC (rev 190161)
+++ trunk/LayoutTests/ChangeLog 2015-09-23 11:14:50 UTC (rev 190162)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2015-09-23 Xabier Rodriguez Calvar <calvaris@igalia.com>
</span><span class="cx">
</span><ins>+ [Streams API] Add brand checks tests for writable streams
+ https://bugs.webkit.org/show_bug.cgi?id=148301
+
+ Reviewed by Darin Adler.
+
+ * streams/reference-implementation/brand-checks-expected.txt: Added new expectations.
+ * streams/reference-implementation/brand-checks.html: Added new writable stream tests.
+
+2015-09-23 Xabier Rodriguez Calvar <calvaris@igalia.com>
+
</ins><span class="cx"> [Streams API] bad underlying sinks tests about writable streams
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=148295
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationbrandchecksexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/brand-checks-expected.txt (190161 => 190162)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/brand-checks-expected.txt 2015-09-23 11:12:58 UTC (rev 190161)
+++ trunk/LayoutTests/streams/reference-implementation/brand-checks-expected.txt 2015-09-23 11:14:50 UTC (rev 190162)
</span><span class="lines">@@ -1,7 +1,11 @@
</span><span class="cx">
</span><span class="cx"> PASS Can get the ReadableStreamReader constructor indirectly
</span><span class="cx"> PASS Can get the ReadableStreamController constructor indirectly
</span><ins>+FAIL ReadableStream.prototype.cancel enforces a brand check Can't find variable: WritableStream
+FAIL ReadableStream.prototype.getReader enforces a brand check Can't find variable: WritableStream
</ins><span class="cx"> PASS ReadableStream.prototype.pipeThrough works generically on its this and its arguments
</span><ins>+FAIL ReadableStream.prototype.pipeTo works generically on its this and its arguments Can only call ReadableStream.pipeTo on instances of ReadableStream
+FAIL ReadableStream.prototype.tee enforces a brand check Can't find variable: WritableStream
</ins><span class="cx"> PASS ReadableStreamReader enforces a brand check on its argument
</span><span class="cx"> FAIL ReadableStreamReader.prototype.closed enforces a brand check undefined is not an object (evaluating 'Object.getOwnPropertyDescriptor(obj, getterName).get')
</span><span class="cx"> PASS ReadableStreamReader.prototype.cancel enforces a brand check
</span><span class="lines">@@ -13,6 +17,12 @@
</span><span class="cx"> PASS ReadableStreamController.prototype.close enforces a brand check
</span><span class="cx"> PASS ReadableStreamController.prototype.enqueue enforces a brand check
</span><span class="cx"> PASS ReadableStreamController.prototype.error enforces a brand check
</span><ins>+FAIL WritableStream.prototype.closed enforces a brand check Can't find variable: WritableStream
+FAIL WritableStream.prototype.ready enforces a brand check Can't find variable: WritableStream
+FAIL WritableStream.prototype.state enforces a brand check Can't find variable: WritableStream
+FAIL WritableStream.prototype.abort enforces a brand check Can't find variable: WritableStream
+FAIL WritableStream.prototype.write enforces a brand check Can't find variable: WritableStream
+FAIL WritableStream.prototype.close enforces a brand check Can't find variable: WritableStream
</ins><span class="cx"> PASS ByteLengthQueuingStrategy.prototype.size should work generically on its this and its arguments
</span><span class="cx"> PASS CountQueuingStrategy.prototype.size should work generically on its this and its arguments
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationbrandcheckshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/brand-checks.html (190161 => 190162)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/brand-checks.html 2015-09-23 11:12:58 UTC (rev 190161)
+++ trunk/LayoutTests/streams/reference-implementation/brand-checks.html 2015-09-23 11:14:50 UTC (rev 190162)
</span><span class="lines">@@ -4,6 +4,8 @@
</span><span class="cx"> <script src='resources/streams-utils.js'></script>
</span><span class="cx"> <script src='resources/byte-length-queuing-strategy.js'></script>
</span><span class="cx"> <script>
</span><ins>+// This is updated till https://github.com/whatwg/streams/commit/ec5ffa036308d9f6350d2946560d48cdbf090939
+
</ins><span class="cx"> var ReadableStreamReader;
</span><span class="cx"> var ReadableStreamController;
</span><span class="cx">
</span><span class="lines">@@ -35,6 +37,21 @@
</span><span class="cx"> return new ReadableStream();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+function fakeWritableStream() {
+ return {
+ get closed() { return Promise.resolve(); },
+ get ready() { return Promise.resolve(); },
+ get state() { return 'closed' },
+ abort(reason) { return Promise.resolve(); },
+ close() { return Promise.resolve(); },
+ write(chunk) { return Promise.resolve(); }
+ };
+}
+
+function realWritableStream() {
+ return new WritableStream();
+}
+
</ins><span class="cx"> function fakeReadableStreamReader() {
</span><span class="cx"> return {
</span><span class="cx"> get closed() { return Promise.resolve(); },
</span><span class="lines">@@ -104,13 +121,30 @@
</span><span class="cx"> }));
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+function getterThrows(obj, getterName, target) {
+ var getter = Object.getOwnPropertyDescriptor(obj, getterName).get;
+
+ assert_throws(new TypeError(), function() { getter.call(target); }, getterName + ' should throw a TypeError');
+}
+
</ins><span class="cx"> function methodThrows(obj, methodName, target) {
</span><span class="cx"> var method = obj[methodName];
</span><span class="cx">
</span><span class="cx"> assert_throws(new TypeError(), function() { method.call(target); }, methodName + ' should throw a TypeError');
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+var test1 = async_test('ReadableStream.prototype.cancel enforces a brand check');
+test1.step(function() {
+ methodRejects(test1, ReadableStream.prototype, 'cancel', fakeReadableStream());
+ methodRejects(test1, ReadableStream.prototype, 'cancel', realWritableStream(), true);
+});
+
</ins><span class="cx"> test(function() {
</span><ins>+ methodThrows(ReadableStream.prototype, 'getReader', fakeReadableStream());
+ methodThrows(ReadableStream.prototype, 'getReader', realWritableStream());
+}, 'ReadableStream.prototype.getReader enforces a brand check');
+
+test(function() {
</ins><span class="cx"> var pipeToArguments;
</span><span class="cx"> var thisValue = {
</span><span class="cx"> pipeTo: function() {
</span><span class="lines">@@ -127,25 +161,28 @@
</span><span class="cx"> }, 'ReadableStream.prototype.pipeThrough works generically on its this and its arguments');
</span><span class="cx">
</span><span class="cx"> test(function() {
</span><ins>+ ReadableStream.prototype.pipeTo.call(fakeReadableStream(), fakeWritableStream()); // Check it does not throw.
+}, 'ReadableStream.prototype.pipeTo works generically on its this and its arguments');
+
+test(function() {
+ methodThrows(ReadableStream.prototype, 'tee', fakeReadableStream());
+ methodThrows(ReadableStream.prototype, 'tee', realWritableStream());
+}, 'ReadableStream.prototype.tee enforces a brand check');
+
+test(function() {
</ins><span class="cx"> assert_throws(new TypeError(), function() { new ReadableStreamReader(fakeReadableStream()); }, 'Constructing a ReadableStreamReader should throw');
</span><span class="cx"> }, 'ReadableStreamReader enforces a brand check on its argument');
</span><span class="cx">
</span><del>-var test1 = async_test('ReadableStreamReader.prototype.closed enforces a brand check');
-test1.step(function() {
- getterRejects(test1, ReadableStreamReader.prototype, 'closed', fakeReadableStreamReader());
- getterRejects(test1, ReadableStreamReader.prototype, 'closed', realReadableStream(), true);
-});
-
-var test2 = async_test('ReadableStreamReader.prototype.cancel enforces a brand check');
</del><ins>+var test2 = async_test('ReadableStreamReader.prototype.closed enforces a brand check');
</ins><span class="cx"> test2.step(function() {
</span><del>- methodRejects(test2, ReadableStreamReader.prototype, 'cancel', fakeReadableStreamReader());
- methodRejects(test2, ReadableStreamReader.prototype, 'cancel', realReadableStream(), true);
</del><ins>+ getterRejects(test2, ReadableStreamReader.prototype, 'closed', fakeReadableStreamReader());
+ getterRejects(test2, ReadableStreamReader.prototype, 'closed', realReadableStream(), true);
</ins><span class="cx"> });
</span><span class="cx">
</span><del>-var test3 = async_test('ReadableStreamReader.prototype.read enforces a brand check');
</del><ins>+var test3 = async_test('ReadableStreamReader.prototype.cancel enforces a brand check');
</ins><span class="cx"> test3.step(function() {
</span><del>- methodRejects(test3, ReadableStreamReader.prototype, 'read', fakeReadableStreamReader());
- methodRejects(test3, ReadableStreamReader.prototype, 'read', realReadableStream(), true);
</del><ins>+ methodRejects(test3, ReadableStreamReader.prototype, 'cancel', fakeReadableStreamReader());
+ methodRejects(test3, ReadableStreamReader.prototype, 'cancel', realReadableStream(), true);
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> var test4 = async_test('ReadableStreamReader.prototype.read enforces a brand check');
</span><span class="lines">@@ -154,6 +191,12 @@
</span><span class="cx"> methodRejects(test4, ReadableStreamReader.prototype, 'read', realReadableStream(), true);
</span><span class="cx"> });
</span><span class="cx">
</span><ins>+var test5 = async_test('ReadableStreamReader.prototype.read enforces a brand check');
+test5.step(function() {
+ methodRejects(test5, ReadableStreamReader.prototype, 'read', fakeReadableStreamReader());
+ methodRejects(test5, ReadableStreamReader.prototype, 'read', realReadableStream(), true);
+});
+
</ins><span class="cx"> test(function() {
</span><span class="cx"> methodThrows(ReadableStreamReader.prototype, 'releaseLock', fakeReadableStreamReader());
</span><span class="cx"> methodThrows(ReadableStreamReader.prototype, 'releaseLock', realReadableStream());
</span><span class="lines">@@ -179,7 +222,42 @@
</span><span class="cx"> methodThrows(ReadableStreamController.prototype, 'error', fakeReadableStreamController());
</span><span class="cx"> }, 'ReadableStreamController.prototype.error enforces a brand check');
</span><span class="cx">
</span><ins>+var test6 = async_test('WritableStream.prototype.closed enforces a brand check');
+test6.step(function() {
+ getterRejects(test6, WritableStream.prototype, 'closed', fakeWritableStream());
+ getterRejects(test6, WritableStream.prototype, 'closed', realReadableStream(), true);
+});
+
+var test7 = async_test('WritableStream.prototype.ready enforces a brand check');
+test7.step(function() {
+ getterRejects(test7, WritableStream.prototype, 'ready', fakeWritableStream());
+ getterRejects(test7, WritableStream.prototype, 'ready', realReadableStream(), true);
+});
+
</ins><span class="cx"> test(function() {
</span><ins>+ getterThrows(WritableStream.prototype, 'state', fakeWritableStream());
+ getterThrows(WritableStream.prototype, 'state', realReadableStream());
+}, 'WritableStream.prototype.state enforces a brand check');
+
+var test8 = async_test('WritableStream.prototype.abort enforces a brand check');
+test8.step(function() {
+ methodRejects(test8, WritableStream.prototype, 'abort', fakeWritableStream());
+ methodRejects(test8, WritableStream.prototype, 'abort', realReadableStream(), true);
+});
+
+var test9 = async_test('WritableStream.prototype.write enforces a brand check');
+test9.step(function() {
+ methodRejects(test9, WritableStream.prototype, 'write', fakeWritableStream());
+ methodRejects(test9, WritableStream.prototype, 'write', realReadableStream(), true);
+});
+
+var test10 = async_test('WritableStream.prototype.close enforces a brand check');
+test10.step(function() {
+ methodRejects(test10, WritableStream.prototype, 'close', fakeWritableStream());
+ methodRejects(test10, WritableStream.prototype, 'close', realReadableStream(), true);
+});
+
+test(function() {
</ins><span class="cx"> var thisValue = null;
</span><span class="cx"> var returnValue = { 'returned from': 'byteLength getter' };
</span><span class="cx"> var chunk = {
</span></span></pre>
</div>
</div>
</body>
</html>