<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190159] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190159">190159</a></dd>
<dt>Author</dt> <dd>calvaris@igalia.com</dd>
<dt>Date</dt> <dd>2015-09-23 04:03:08 -0700 (Wed, 23 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Streams API] Add bad strategies writable streams tests
https://bugs.webkit.org/show_bug.cgi?id=148300
Reviewed by Darin Adler.
* streams/reference-implementation/bad-strategies-expected.txt: Added new expectations.
* streams/reference-implementation/bad-strategies.html: Added new writable stream tests.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationbadstrategiesexpectedtxt">trunk/LayoutTests/streams/reference-implementation/bad-strategies-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationbadstrategieshtml">trunk/LayoutTests/streams/reference-implementation/bad-strategies.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (190158 => 190159)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-23 10:04:24 UTC (rev 190158)
+++ trunk/LayoutTests/ChangeLog 2015-09-23 11:03:08 UTC (rev 190159)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2015-09-23 Xabier Rodriguez Calvar <calvaris@igalia.com>
</span><span class="cx">
</span><ins>+ [Streams API] Add bad strategies writable streams tests
+ https://bugs.webkit.org/show_bug.cgi?id=148300
+
+ Reviewed by Darin Adler.
+
+ * streams/reference-implementation/bad-strategies-expected.txt: Added new expectations.
+ * streams/reference-implementation/bad-strategies.html: Added new writable stream tests.
+
+2015-09-23 Xabier Rodriguez Calvar <calvaris@igalia.com>
+
</ins><span class="cx"> [Streams API] Change a const in the tee tests
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=148294
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationbadstrategiesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/bad-strategies-expected.txt (190158 => 190159)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/bad-strategies-expected.txt 2015-09-23 10:04:24 UTC (rev 190158)
+++ trunk/LayoutTests/streams/reference-implementation/bad-strategies-expected.txt 2015-09-23 11:03:08 UTC (rev 190159)
</span><span class="lines">@@ -5,4 +5,18 @@
</span><span class="cx"> PASS Readable stream: invalid strategy.highWaterMark
</span><span class="cx"> PASS Readable stream: negative strategy.highWaterMark
</span><span class="cx"> PASS Readable stream: invalid strategy.size return value
</span><ins>+FAIL Writable stream: throwing strategy.size getter assert_throws: construction should re-throw the error function "function () {
+ new WritableStream({}, {
+ ..." threw object "ReferenceError: Can't find variable: WritableStream" ("ReferenceError") expected object "Error: a unique string" ("Error")
+FAIL Writable stream: throwing strategy.size method Can't find variable: WritableStream
+FAIL Writable stream: invalid strategy.size return value Can't find variable: WritableStream
+FAIL Writable stream: throwing strategy.highWaterMark getter assert_throws: construction should re-throw the error function "function () {
+ new WritableStream({}, {
+ ..." threw object "ReferenceError: Can't find variable: WritableStream" ("ReferenceError") expected object "Error: a unique string" ("Error")
+FAIL Writable stream: invalid strategy.highWaterMark assert_throws: construction should throw a RangeError for -1 function "function () {
+ new WritableStream({}, {
+ ..." threw object "ReferenceError: Can't find variable: WritableStream" ("ReferenceError") expected object "RangeError" ("RangeError")
+FAIL Writable stream: negative strategy.highWaterMark assert_throws: construction should throw a RangeError function "function () {
+ new WritableStream({}, {
+ ..." threw object "ReferenceError: Can't find variable: WritableStream" ("ReferenceError") expected object "RangeError" ("RangeError")
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationbadstrategieshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/reference-implementation/bad-strategies.html (190158 => 190159)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/bad-strategies.html 2015-09-23 10:04:24 UTC (rev 190158)
+++ trunk/LayoutTests/streams/reference-implementation/bad-strategies.html 2015-09-23 11:03:08 UTC (rev 190159)
</span><span class="lines">@@ -122,4 +122,133 @@
</span><span class="cx"> rs.getReader().closed.catch(test2.step_func(catchFunction.bind(this, i)));
</span><span class="cx"> }
</span><span class="cx"> });
</span><ins>+
+test(function() {
+ var theError = new Error('a unique string');
+
+ assert_throws(theError, function() {
+ new WritableStream({}, {
+ get size() {
+ throw theError;
+ },
+ highWaterMark: 5
+ });
+ }, 'construction should re-throw the error');
+}, 'Writable stream: throwing strategy.size getter');
+
+var test3 = async_test('Writable stream: throwing strategy.size method');
+test3.step(function() {
+ var theError = new Error('a unique string');
+ var writeCalled = false;
+ var ws = new WritableStream({ },
+ {
+ size: function() {
+ throw theError;
+ },
+ highWaterMark: 5
+ }
+ ); // Initial construction should not throw.
+
+ ws.write('a').then(
+ test3.step_func(function() { assert_unreached('write should not fulfill'); }),
+ test3.step_func(function(r) {
+ assert_equals(r, theError, 'write should reject with the thrown error');
+ writeCalled = true;
+ })
+ );
+
+ ws.closed.then(
+ test3.step_func(function() { assert_unreached('closed should not fulfill'); }),
+ test3.step_func(function(r) {
+ assert_equals(r, theError, 'closed should reject with the thrown error');
+ assert_true(writeCalled);
+ test3.done();
+ })
+ );
+});
+
+var test4 = async_test('Writable stream: invalid strategy.size return value');
+test4.step(function() {
+ var numberOfCalls = 0;
+ var elements = [NaN, -Infinity, +Infinity, -1];
+ var theError = [];
+ var numberOfCalls = 0;
+ for (var i = 0; i < elements.length; i++) {
+ var ws = new WritableStream({},
+ {
+ size: function() {
+ return elements[i];
+ },
+ highWaterMark: 5
+ });
+
+ var writeFunction = function(i, r) {
+ assert_throws(new RangeError(), function() { throw r; }, 'write should reject with a RangeError for ' + elements[i]);
+ theError[i] = r;
+ };
+ ws.write('a').then(
+ test4.step_func(function() { assert_unreached('write should not fulfill'); }),
+ test4.step_func(writeFunction.bind(this, i))
+ );
+
+ var catchFunction = function(i, e) {
+ assert_equals(e, theError[i], 'closed should reject with the error for ' + elements[i]);
+ if (++numberOfCalls, elements.length) {
+ test4.done();
+ }
+ };
+
+ ws.closed.catch(test4.step_func(catchFunction.bind(this, i)));
+ }
+});
+
+test(function() {
+ var theError = new Error('a unique string');
+
+ assert_throws(theError, function() {
+ new WritableStream({}, {
+ size: function() {
+ return 1;
+ },
+ get highWaterMark() {
+ throw theError;
+ }
+ });
+ }, 'construction should re-throw the error');
+}, 'Writable stream: throwing strategy.highWaterMark getter');
+
+test(function() {
+ for (var highWaterMark of [-1, -Infinity]) {
+ assert_throws(new RangeError(), function() {
+ new WritableStream({}, {
+ size: function() {
+ return 1;
+ },
+ highWaterMark
+ });
+ }, 'construction should throw a RangeError for ' + highWaterMark);
+ }
+
+ for (var highWaterMark of [NaN, 'foo', {}]) {
+ assert_throws(new TypeError(), function() {
+ new WritableStream({}, {
+ size: function() {
+ return 1;
+ },
+ highWaterMark
+ });
+ }, 'construction should throw a TypeError for ' + highWaterMark);
+ }
+}, 'Writable stream: invalid strategy.highWaterMark');
+
+test(function() {
+ assert_throws(new RangeError(), function() {
+ new WritableStream({}, {
+ size: function() {
+ return 1;
+ },
+ highWaterMark: -1
+ });
+ }, 'construction should throw a RangeError');
+}, 'Writable stream: negative strategy.highWaterMark');
</ins><span class="cx"> </script>
</span></span></pre>
</div>
</div>
</body>
</html>