<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190186] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190186">190186</a></dd>
<dt>Author</dt> <dd>sbarati@apple.com</dd>
<dt>Date</dt> <dd>2015-09-23 14:03:30 -0700 (Wed, 23 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Don't use bind() when creating internal AST, instead, pass in "this" parameter to map()
https://bugs.webkit.org/show_bug.cgi?id=149483
Reviewed by Joseph Pecoraro.
* UserInterface/Models/ScriptSyntaxTree.js:
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsScriptSyntaxTreejs">trunk/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (190185 => 190186)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-09-23 20:59:51 UTC (rev 190185)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-09-23 21:03:30 UTC (rev 190186)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2015-09-23 Saam barati <sbarati@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Don't use bind() when creating internal AST, instead, pass in "this" parameter to map()
+ https://bugs.webkit.org/show_bug.cgi?id=149483
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Models/ScriptSyntaxTree.js:
+ (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
+ (WebInspector.ScriptSyntaxTree):
+
+2015-09-23 Saam barati <sbarati@apple.com>
+
</ins><span class="cx"> Web Inspector: Type bubbles missing for computed methods and methods on object literals
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=148562
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsScriptSyntaxTreejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js (190185 => 190186)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js 2015-09-23 20:59:51 UTC (rev 190185)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js 2015-09-23 21:03:30 UTC (rev 190186)
</span><span class="lines">@@ -530,21 +530,21 @@
</span><span class="cx"> case "ArrayExpression":
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.ArrayExpression,
</span><del>- elements: node.elements.map(this._createInternalSyntaxTree.bind(this))
</del><ins>+ elements: node.elements.map(this._createInternalSyntaxTree, this)
</ins><span class="cx"> };
</span><span class="cx"> break;
</span><span class="cx"> case "ArrayPattern":
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.ArrayPattern,
</span><del>- elements: node.elements.map(this._createInternalSyntaxTree.bind(this))
</del><ins>+ elements: node.elements.map(this._createInternalSyntaxTree, this)
</ins><span class="cx"> };
</span><span class="cx"> break;
</span><span class="cx"> case "ArrowFunctionExpression":
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.ArrowFunctionExpression,
</span><span class="cx"> id: this._createInternalSyntaxTree(node.id),
</span><del>- params: node.params.map(this._createInternalSyntaxTree.bind(this)),
- defaults: node.defaults.map(this._createInternalSyntaxTree.bind(this)),
</del><ins>+ params: node.params.map(this._createInternalSyntaxTree, this),
+ defaults: node.defaults.map(this._createInternalSyntaxTree, this),
</ins><span class="cx"> body: this._createInternalSyntaxTree(node.body),
</span><span class="cx"> expression: node.expression, // Boolean indicating if the body a single expression or a block statement.
</span><span class="cx"> typeProfilingReturnDivot: node.range[0]
</span><span class="lines">@@ -568,7 +568,7 @@
</span><span class="cx"> case "BlockStatement":
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.BlockStatement,
</span><del>- body: node.body.map(this._createInternalSyntaxTree.bind(this))
</del><ins>+ body: node.body.map(this._createInternalSyntaxTree, this)
</ins><span class="cx"> };
</span><span class="cx"> break;
</span><span class="cx"> case "BinaryExpression":
</span><span class="lines">@@ -589,7 +589,7 @@
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.CallExpression,
</span><span class="cx"> callee: this._createInternalSyntaxTree(node.callee),
</span><del>- arguments: node.arguments.map(this._createInternalSyntaxTree.bind(this))
</del><ins>+ arguments: node.arguments.map(this._createInternalSyntaxTree, this)
</ins><span class="cx"> };
</span><span class="cx"> break;
</span><span class="cx"> case "CatchClause":
</span><span class="lines">@@ -602,7 +602,7 @@
</span><span class="cx"> case "ClassBody":
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.ClassBody,
</span><del>- body: node.body.map(this._createInternalSyntaxTree.bind(this))
</del><ins>+ body: node.body.map(this._createInternalSyntaxTree, this)
</ins><span class="cx"> };
</span><span class="cx"> break;
</span><span class="cx"> case "ClassDeclaration":
</span><span class="lines">@@ -687,8 +687,8 @@
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.FunctionDeclaration,
</span><span class="cx"> id: this._createInternalSyntaxTree(node.id),
</span><del>- params: node.params.map(this._createInternalSyntaxTree.bind(this)),
- defaults: node.defaults.map(this._createInternalSyntaxTree.bind(this)),
</del><ins>+ params: node.params.map(this._createInternalSyntaxTree, this),
+ defaults: node.defaults.map(this._createInternalSyntaxTree, this),
</ins><span class="cx"> body: this._createInternalSyntaxTree(node.body),
</span><span class="cx"> typeProfilingReturnDivot: node.range[0]
</span><span class="cx"> };
</span><span class="lines">@@ -697,8 +697,8 @@
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.FunctionExpression,
</span><span class="cx"> id: this._createInternalSyntaxTree(node.id),
</span><del>- params: node.params.map(this._createInternalSyntaxTree.bind(this)),
- defaults: node.defaults.map(this._createInternalSyntaxTree.bind(this)),
</del><ins>+ params: node.params.map(this._createInternalSyntaxTree, this),
+ defaults: node.defaults.map(this._createInternalSyntaxTree, this),
</ins><span class="cx"> body: this._createInternalSyntaxTree(node.body),
</span><span class="cx"> typeProfilingReturnDivot: node.range[0] // This may be overridden in the Property AST node.
</span><span class="cx"> };
</span><span class="lines">@@ -770,26 +770,26 @@
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.NewExpression,
</span><span class="cx"> callee: this._createInternalSyntaxTree(node.callee),
</span><del>- arguments: node.arguments.map(this._createInternalSyntaxTree.bind(this))
</del><ins>+ arguments: node.arguments.map(this._createInternalSyntaxTree, this)
</ins><span class="cx"> };
</span><span class="cx"> break;
</span><span class="cx"> case "ObjectExpression":
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.ObjectExpression,
</span><del>- properties: node.properties.map(this._createInternalSyntaxTree.bind(this))
</del><ins>+ properties: node.properties.map(this._createInternalSyntaxTree, this)
</ins><span class="cx"> };
</span><span class="cx"> break;
</span><span class="cx"> case "ObjectPattern":
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.ObjectPattern,
</span><del>- properties: node.properties.map(this._createInternalSyntaxTree.bind(this))
</del><ins>+ properties: node.properties.map(this._createInternalSyntaxTree, this)
</ins><span class="cx"> };
</span><span class="cx"> break;
</span><span class="cx"> case "Program":
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.Program,
</span><span class="cx"> sourceType: node.sourceType,
</span><del>- body: node.body.map(this._createInternalSyntaxTree.bind(this))
</del><ins>+ body: node.body.map(this._createInternalSyntaxTree, this)
</ins><span class="cx"> };
</span><span class="cx"> break;
</span><span class="cx"> case "Property":
</span><span class="lines">@@ -813,7 +813,7 @@
</span><span class="cx"> case "SequenceExpression":
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.SequenceExpression,
</span><del>- expressions: node.expressions.map(this._createInternalSyntaxTree.bind(this))
</del><ins>+ expressions: node.expressions.map(this._createInternalSyntaxTree, this)
</ins><span class="cx"> };
</span><span class="cx"> break;
</span><span class="cx"> case "SpreadElement":
</span><span class="lines">@@ -831,14 +831,14 @@
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.SwitchStatement,
</span><span class="cx"> discriminant: this._createInternalSyntaxTree(node.discriminant),
</span><del>- cases: node.cases.map(this._createInternalSyntaxTree.bind(this))
</del><ins>+ cases: node.cases.map(this._createInternalSyntaxTree, this)
</ins><span class="cx"> };
</span><span class="cx"> break;
</span><span class="cx"> case "SwitchCase":
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.SwitchCase,
</span><span class="cx"> test: this._createInternalSyntaxTree(node.test),
</span><del>- consequent: node.consequent.map(this._createInternalSyntaxTree.bind(this))
</del><ins>+ consequent: node.consequent.map(this._createInternalSyntaxTree, this)
</ins><span class="cx"> };
</span><span class="cx"> break;
</span><span class="cx"> case "TaggedTemplateExpression":
</span><span class="lines">@@ -858,8 +858,8 @@
</span><span class="cx"> case "TemplateLiteral":
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.TemplateLiteral,
</span><del>- quasis: node.quasis.map(this._createInternalSyntaxTree.bind(this)),
- expressions: node.expressions.map(this._createInternalSyntaxTree.bind(this))
</del><ins>+ quasis: node.quasis.map(this._createInternalSyntaxTree, this),
+ expressions: node.expressions.map(this._createInternalSyntaxTree, this)
</ins><span class="cx"> };
</span><span class="cx"> break;
</span><span class="cx"> case "ThisExpression":
</span><span class="lines">@@ -899,7 +899,7 @@
</span><span class="cx"> case "VariableDeclaration":
</span><span class="cx"> result = {
</span><span class="cx"> type: WebInspector.ScriptSyntaxTree.NodeType.VariableDeclaration,
</span><del>- declarations: node.declarations.map(this._createInternalSyntaxTree.bind(this)),
</del><ins>+ declarations: node.declarations.map(this._createInternalSyntaxTree, this),
</ins><span class="cx"> kind: node.kind
</span><span class="cx"> };
</span><span class="cx"> break;
</span></span></pre>
</div>
</div>
</body>
</html>