<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190153] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190153">190153</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-09-22 18:42:03 -0700 (Tue, 22 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Event fired on a detached node does not bubble up
https://bugs.webkit.org/show_bug.cgi?id=149488
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Rebaselined a test now that one more test case passes.
* web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
Source/WebCore:
The bug was caused by an explicit check inside EventPath to match an old Firefox behavior (see <a href="http://trac.webkit.org/projects/webkit/changeset/19897">r19897</a>).
Since Firefox's behavior has changed to match DOM4: https://dom.spec.whatwg.org/#concept-event-dispatch
Fixed the bug by removing the check. The new behavior matches DO4 and behaviors of Firefox and Chrome.
Test: fast/events/event-propagation-in-detached-tree.html
* dom/EventDispatcher.cpp:
(WebCore::EventPath::EventPath):
LayoutTests:
Added a regression test. Also modified and rebaselined mouseout-dead-node.html added in <a href="http://trac.webkit.org/projects/webkit/changeset/19897">r19897</a>
since our new behavior matches that of the latest Firefox as well as Chrome.
* fast/events/event-propagation-in-detached-tree-expected.txt: Added.
* fast/events/event-propagation-in-detached-tree.html: Added.
* fast/events/mouseout-dead-node-expected.txt:
* fast/events/mouseout-dead-node.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventsmouseoutdeadnodeexpectedtxt">trunk/LayoutTests/fast/events/mouseout-dead-node-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsmouseoutdeadnodehtml">trunk/LayoutTests/fast/events/mouseout-dead-node.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomeventsEventTargetdispatchEventexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomEventDispatchercpp">trunk/Source/WebCore/dom/EventDispatcher.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasteventseventpropagationindetachedtreeexpectedtxt">trunk/LayoutTests/fast/events/event-propagation-in-detached-tree-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventseventpropagationindetachedtreehtml">trunk/LayoutTests/fast/events/event-propagation-in-detached-tree.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (190152 => 190153)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-23 01:37:42 UTC (rev 190152)
+++ trunk/LayoutTests/ChangeLog 2015-09-23 01:42:03 UTC (rev 190153)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-09-22 Ryosuke Niwa <rniwa@webkit.org>
+
+ Event fired on a detached node does not bubble up
+ https://bugs.webkit.org/show_bug.cgi?id=149488
+
+ Reviewed by Antti Koivisto.
+
+ Added a regression test. Also modified and rebaselined mouseout-dead-node.html added in r19897
+ since our new behavior matches that of the latest Firefox as well as Chrome.
+
+ * fast/events/event-propagation-in-detached-tree-expected.txt: Added.
+ * fast/events/event-propagation-in-detached-tree.html: Added.
+ * fast/events/mouseout-dead-node-expected.txt:
+ * fast/events/mouseout-dead-node.html:
+
</ins><span class="cx"> 2015-09-22 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Mark http/tests/notifications/events.html flaky again (crash/timeout this time).
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventseventpropagationindetachedtreeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/event-propagation-in-detached-tree-expected.txt (0 => 190153)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/event-propagation-in-detached-tree-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/event-propagation-in-detached-tree-expected.txt 2015-09-23 01:42:03 UTC (rev 190153)
</span><span class="lines">@@ -0,0 +1,25 @@
</span><ins>+Tests dispatching an event that bubbles inside a detached tree. The event should propagate to the ancestors of the target
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+clonedRoot = cloneNode(root)
+clonedTarget = clonedRoot.getElementById("target"); dispatchEventWithLog(clonedTarget);
+PASS clonedRoot instanceof DocumentFragment is true
+PASS log.length is 4
+PASS log[0] is [clonedTarget, clonedTarget]
+PASS log[1] is [clonedTarget.parentNode, clonedTarget]
+PASS log[2] is [clonedTarget.parentNode.parentNode, clonedTarget]
+PASS log[3] is [clonedRoot, clonedTarget]
+PASS clonedRoot.parentNode is null
+
+root.remove(); dispatchEventWithLog(target);
+PASS log.length is 3
+PASS log[0] is [target, target]
+PASS log[1] is [target.parentNode, target]
+PASS log[2] is [root, target]
+PASS root.parentNode is null
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventseventpropagationindetachedtreehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/event-propagation-in-detached-tree.html (0 => 190153)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/event-propagation-in-detached-tree.html (rev 0)
+++ trunk/LayoutTests/fast/events/event-propagation-in-detached-tree.html 2015-09-23 01:42:03 UTC (rev 190153)
</span><span class="lines">@@ -0,0 +1,57 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<div id="root">
+ <span>
+ <span id="target"></span>
+ </span>
+</div>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+
+description('Tests dispatching an event that bubbles inside a detached tree. The event should propagate to the ancestors of the target');
+
+var log;
+
+function dispatchEventWithLog(target) {
+ log = [];
+ for (var node = target; node; node = node.parentNode)
+ node.addEventListener('foo', (function (event) { log.push([this, event.target]); }).bind(node));
+ target.dispatchEvent(new Event("foo", {bubbles: true}));
+}
+
+function cloneNode(node) {
+ range = new Range;
+ range.selectNode(node);
+ return range.cloneContents();
+}
+
+var target = document.getElementById("target");
+var root = document.getElementById("root");
+
+evalAndLog('clonedRoot = cloneNode(root)');
+evalAndLog('clonedTarget = clonedRoot.getElementById("target"); dispatchEventWithLog(clonedTarget);');
+
+shouldBeTrue('clonedRoot instanceof DocumentFragment');
+shouldBe('log.length', '4');
+shouldBe('log[0]', '[clonedTarget, clonedTarget]');
+shouldBe('log[1]', '[clonedTarget.parentNode, clonedTarget]');
+shouldBe('log[2]', '[clonedTarget.parentNode.parentNode, clonedTarget]');
+shouldBe('log[3]', '[clonedRoot, clonedTarget]');
+shouldBeNull('clonedRoot.parentNode');
+
+debug('');
+evalAndLog('root.remove(); dispatchEventWithLog(target);');
+
+shouldBe('log.length', '3');
+shouldBe('log[0]', '[target, target]');
+shouldBe('log[1]', '[target.parentNode, target]');
+shouldBe('log[2]', '[root, target]');
+shouldBeNull('root.parentNode');
+
+var successfullyParsed = true;
+
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventsmouseoutdeadnodeexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/mouseout-dead-node-expected.txt (190152 => 190153)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/mouseout-dead-node-expected.txt 2015-09-23 01:37:42 UTC (rev 190152)
+++ trunk/LayoutTests/fast/events/mouseout-dead-node-expected.txt 2015-09-23 01:42:03 UTC (rev 190153)
</span><span class="lines">@@ -3,8 +3,10 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS mouseout
-PASS mouseout
</del><ins>+PASS mouseout 1
+PASS mouseout 2
+PASS mouseout 3
+PASS mouseout 4
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsmouseoutdeadnodehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/mouseout-dead-node.html (190152 => 190153)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/mouseout-dead-node.html 2015-09-23 01:37:42 UTC (rev 190152)
+++ trunk/LayoutTests/fast/events/mouseout-dead-node.html 2015-09-23 01:42:03 UTC (rev 190153)
</span><span class="lines">@@ -7,16 +7,16 @@
</span><span class="cx"> <p id="description"></p>
</span><span class="cx"> <div id="test-container">
</span><span class="cx"> <div id=d0 style='border:2px solid red'>
</span><del>-<div onmouseout='testFailed("mouseout")' onmouseover='document.getElementById("d0").innerHTML ="you should see PASS below"'>
-<div onmouseout='testFailed("mouseout")'>
-<span id=target1 onmouseout='testPassed("mouseout")' >
</del><ins>+<div onmouseout='testPassed("mouseout 3")' onmouseover='document.getElementById("d0").innerHTML ="you should see PASS below"'>
+<div onmouseout='testPassed("mouseout 2")'>
+<span id=target1 onmouseout='testPassed("mouseout 1")' >
</ins><span class="cx"> mouse over me
</span><span class="cx"> </span>
</span><span class="cx"> </div>
</span><span class="cx"> </div>
</span><span class="cx"> </div>
</span><span class="cx"> <div id=d1 style='border:2px solid blue'>
</span><del>-<div id=target2 onmouseout='testPassed("mouseout")' onmouseover='document.getElementById("d1").innerHTML ="you should see PASS below"' >
</del><ins>+<div id=target2 onmouseout='testPassed("mouseout 4")' onmouseover='document.getElementById("d1").innerHTML ="you should see PASS below"' >
</ins><span class="cx"> mouse over me
</span><span class="cx"> </div>
</span><span class="cx"> </div>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (190152 => 190153)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2015-09-23 01:37:42 UTC (rev 190152)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2015-09-23 01:42:03 UTC (rev 190153)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-09-22 Ryosuke Niwa <rniwa@webkit.org>
+
+ Event fired on a detached node does not bubble up
+ https://bugs.webkit.org/show_bug.cgi?id=149488
+
+ Reviewed by Antti Koivisto.
+
+ Rebaselined a test now that one more test case passes.
+
+ * web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
+
</ins><span class="cx"> 2015-09-22 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Range.surroundContents() should check for partially contained non-Text nodes first
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomeventsEventTargetdispatchEventexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt (190152 => 190153)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt 2015-09-23 01:37:42 UTC (rev 190152)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt 2015-09-23 01:42:03 UTC (rev 190153)
</span><span class="lines">@@ -15,6 +15,6 @@
</span><span class="cx"> PASS If the event's initialized flag is not set, an InvalidStateError must be thrown (UIEvents).
</span><span class="cx"> PASS If the event's dispatch flag is set, an InvalidStateError must be thrown.
</span><span class="cx"> PASS Exceptions from event listeners must not be propagated.
</span><del>-FAIL Event listeners added during dispatch should be called assert_array_equals: lengths differ, expected 2 got 0
</del><ins>+PASS Event listeners added during dispatch should be called
</ins><span class="cx"> PASS Event listeners should be called in order of addition
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (190152 => 190153)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-23 01:37:42 UTC (rev 190152)
+++ trunk/Source/WebCore/ChangeLog 2015-09-23 01:42:03 UTC (rev 190153)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-09-22 Ryosuke Niwa <rniwa@webkit.org>
+
+ Event fired on a detached node does not bubble up
+ https://bugs.webkit.org/show_bug.cgi?id=149488
+
+ Reviewed by Antti Koivisto.
+
+ The bug was caused by an explicit check inside EventPath to match an old Firefox behavior (see r19897).
+ Since Firefox's behavior has changed to match DOM4: https://dom.spec.whatwg.org/#concept-event-dispatch
+
+ Fixed the bug by removing the check. The new behavior matches DO4 and behaviors of Firefox and Chrome.
+
+ Test: fast/events/event-propagation-in-detached-tree.html
+
+ * dom/EventDispatcher.cpp:
+ (WebCore::EventPath::EventPath):
+
</ins><span class="cx"> 2015-09-22 Gyuyoung Kim <gyuyoung.kim@webkit.org>
</span><span class="cx">
</span><span class="cx"> Add a file of pointer-lock to cmake ports
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventDispatchercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EventDispatcher.cpp (190152 => 190153)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EventDispatcher.cpp 2015-09-23 01:37:42 UTC (rev 190152)
+++ trunk/Source/WebCore/dom/EventDispatcher.cpp 2015-09-23 01:42:03 UTC (rev 190153)
</span><span class="lines">@@ -415,7 +415,6 @@
</span><span class="cx">
</span><span class="cx"> EventPath::EventPath(Node& targetNode, Event& event)
</span><span class="cx"> {
</span><del>- bool inDocument = targetNode.inDocument();
</del><span class="cx"> bool isSVGElement = targetNode.isSVGElement();
</span><span class="cx"> bool isMouseOrFocusEvent = event.isMouseEvent() || event.isFocusEvent();
</span><span class="cx"> #if ENABLE(TOUCH_EVENTS) && !PLATFORM(IOS)
</span><span class="lines">@@ -437,8 +436,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> else
</span><span class="cx"> m_path.append(std::make_unique<EventContext>(node, currentTarget, target));
</span><del>- if (!inDocument)
- return;
</del><span class="cx"> if (is<ShadowRoot>(*node))
</span><span class="cx"> break;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>