<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190123] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190123">190123</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-09-22 11:27:26 -0700 (Tue, 22 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>XMLHttpRequest properties should be on the prototype
https://bugs.webkit.org/show_bug.cgi?id=149465
Reviewed by Darin Adler.
Source/WebCore:
Move most XMLHttpRequest properties to the prototype, as per the Web IDL
specification. This should be web-compatible now that properties on the
prototype are configurable after <a href="http://trac.webkit.org/projects/webkit/changeset/190104">r190104</a>.
The 'response' / 'responseText' properties are still incorrectly on the
instance because they are currently using a [CustomGetter] in our IDL
and the bindings generator currently does not move such properties to
the prototype.
Test:
fast/xmlhttprequest/xmlhttprequest-properties-prototype.html
js/dom/xhr-prototype-define-property.html
* bindings/scripts/CodeGeneratorJS.pm:
(InterfaceRequiresAttributesOnInstanceForCompatibility): Deleted.
LayoutTests:
Add layout test to check that XMLHttpRequest properties are on the
prototype and have the right properties (enumerable and configurable).
* fast/xmlhttprequest/xmlhttprequest-properties-prototype-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-properties-prototype.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastxmlhttprequestxmlhttprequestpropertiesprototypeexpectedtxt">trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-properties-prototype-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastxmlhttprequestxmlhttprequestpropertiesprototypehtml">trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-properties-prototype.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (190122 => 190123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-22 17:54:12 UTC (rev 190122)
+++ trunk/LayoutTests/ChangeLog 2015-09-22 18:27:26 UTC (rev 190123)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2015-09-22 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ XMLHttpRequest properties should be on the prototype
+ https://bugs.webkit.org/show_bug.cgi?id=149465
+
+ Reviewed by Darin Adler.
+
+ Add layout test to check that XMLHttpRequest properties are on the
+ prototype and have the right properties (enumerable and configurable).
+
+ * fast/xmlhttprequest/xmlhttprequest-properties-prototype-expected.txt: Added.
+ * fast/xmlhttprequest/xmlhttprequest-properties-prototype.html: Added.
+
+2015-09-22 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Drop support for legacy EntityReference DOM Node type
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149348
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastxmlhttprequestxmlhttprequestpropertiesprototypeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-properties-prototype-expected.txt (0 => 190123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-properties-prototype-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-properties-prototype-expected.txt 2015-09-22 18:27:26 UTC (rev 190123)
</span><span class="lines">@@ -0,0 +1,71 @@
</span><ins>+Checks that XMLHttpRequest's properties are on the prototype and have the right properties
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS xhr.__proto__ is XMLHttpRequest.prototype
+
+* readyState
+PASS xhr.hasOwnProperty(propertyName) is false
+PASS xhr.__proto__.hasOwnProperty(propertyName) is true
+PASS properties.configurable is true
+PASS properties.enumerable is true
+
+* response
+FAIL xhr.hasOwnProperty(propertyName) should be false. Was true.
+FAIL xhr.__proto__.hasOwnProperty(propertyName) should be true. Was false.
+FAIL properties.configurable should be true. Threw exception TypeError: undefined is not an object (evaluating 'properties.configurable')
+FAIL properties.enumerable should be true. Threw exception TypeError: undefined is not an object (evaluating 'properties.enumerable')
+
+* responseText
+FAIL xhr.hasOwnProperty(propertyName) should be false. Was true.
+FAIL xhr.__proto__.hasOwnProperty(propertyName) should be true. Was false.
+FAIL properties.configurable should be true. Threw exception TypeError: undefined is not an object (evaluating 'properties.configurable')
+FAIL properties.enumerable should be true. Threw exception TypeError: undefined is not an object (evaluating 'properties.enumerable')
+
+* responseType
+PASS xhr.hasOwnProperty(propertyName) is false
+PASS xhr.__proto__.hasOwnProperty(propertyName) is true
+PASS properties.configurable is true
+PASS properties.enumerable is true
+
+* responseURL
+PASS xhr.hasOwnProperty(propertyName) is false
+PASS xhr.__proto__.hasOwnProperty(propertyName) is true
+PASS properties.configurable is true
+PASS properties.enumerable is true
+
+* responseXML
+PASS xhr.hasOwnProperty(propertyName) is false
+PASS xhr.__proto__.hasOwnProperty(propertyName) is true
+PASS properties.configurable is true
+PASS properties.enumerable is true
+
+* statusText
+PASS xhr.hasOwnProperty(propertyName) is false
+PASS xhr.__proto__.hasOwnProperty(propertyName) is true
+PASS properties.configurable is true
+PASS properties.enumerable is true
+
+* timeout
+PASS xhr.hasOwnProperty(propertyName) is false
+PASS xhr.__proto__.hasOwnProperty(propertyName) is true
+PASS properties.configurable is true
+PASS properties.enumerable is true
+
+* upload
+PASS xhr.hasOwnProperty(propertyName) is false
+PASS xhr.__proto__.hasOwnProperty(propertyName) is true
+PASS properties.configurable is true
+PASS properties.enumerable is true
+
+* withCredentials
+PASS xhr.hasOwnProperty(propertyName) is false
+PASS xhr.__proto__.hasOwnProperty(propertyName) is true
+PASS properties.configurable is true
+PASS properties.enumerable is true
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastxmlhttprequestxmlhttprequestpropertiesprototypehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-properties-prototype.html (0 => 190123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-properties-prototype.html (rev 0)
+++ trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-properties-prototype.html 2015-09-22 18:27:26 UTC (rev 190123)
</span><span class="lines">@@ -0,0 +1,28 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Checks that XMLHttpRequest's properties are on the prototype and have the right properties");
+
+var xhr = new XMLHttpRequest();
+shouldBe("xhr.__proto__", "XMLHttpRequest.prototype");
+debug("");
+
+function testProperty(propertyName) {
+ debug("* " + propertyName);
+ shouldBeFalse("xhr.hasOwnProperty(propertyName)");
+ shouldBeTrue("xhr.__proto__.hasOwnProperty(propertyName)");
+
+ properties = Object.getOwnPropertyDescriptor(xhr.__proto__, propertyName);
+ shouldBeTrue("properties.configurable");
+ shouldBeTrue("properties.enumerable");
+ debug("");
+}
+
+for (var propertyName of ["readyState", "response", "responseText", "responseType", "responseURL", "responseXML", "statusText", "timeout", "upload", "withCredentials"])
+ testProperty(propertyName);
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (190122 => 190123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-22 17:54:12 UTC (rev 190122)
+++ trunk/Source/WebCore/ChangeLog 2015-09-22 18:27:26 UTC (rev 190123)
</span><span class="lines">@@ -1,5 +1,28 @@
</span><span class="cx"> 2015-09-22 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ XMLHttpRequest properties should be on the prototype
+ https://bugs.webkit.org/show_bug.cgi?id=149465
+
+ Reviewed by Darin Adler.
+
+ Move most XMLHttpRequest properties to the prototype, as per the Web IDL
+ specification. This should be web-compatible now that properties on the
+ prototype are configurable after r190104.
+
+ The 'response' / 'responseText' properties are still incorrectly on the
+ instance because they are currently using a [CustomGetter] in our IDL
+ and the bindings generator currently does not move such properties to
+ the prototype.
+
+ Test:
+ fast/xmlhttprequest/xmlhttprequest-properties-prototype.html
+ js/dom/xhr-prototype-define-property.html
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (InterfaceRequiresAttributesOnInstanceForCompatibility): Deleted.
+
+2015-09-22 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Drop support for legacy EntityReference DOM Node type
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149348
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (190122 => 190123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-09-22 17:54:12 UTC (rev 190122)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-09-22 18:27:26 UTC (rev 190123)
</span><span class="lines">@@ -601,8 +601,6 @@
</span><span class="cx"> return 1 if $interfaceName =~ "Touch";
</span><span class="cx"> return 1 if $interfaceName =~ "Navigator";
</span><span class="cx"> return 1 if $interfaceName =~ "ClientRect";
</span><del>- # FIXME: Once https://bugs.webkit.org/show_bug.cgi?id=134364 is fixed, we can remove this.
- return 1 if $interfaceName =~ "XMLHttpRequest";
</del><span class="cx">
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>