<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[190078] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/190078">190078</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-09-21 13:59:12 -0700 (Mon, 21 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>DOMTokenList.add() / remove() should run the update steps even if tokens were not modified
https://bugs.webkit.org/show_bug.cgi?id=148780
<rdar://problem/22571794>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C DOM test now that more checks are passing.
* web-platform-tests/dom/nodes/MutationObserver-attributes-expected.txt:
Source/WebCore:
DOMTokenList.add() / remove() should run the update steps even if tokens
were not modified, as per the DOM specification:
- https://dom.spec.whatwg.org/#dom-domtokenlist-add
- https://dom.spec.whatwg.org/#dom-domtokenlist-remove
The update steps are specified at:
- https://dom.spec.whatwg.org/#concept-DTL-update
This will have several side effects if the DOMTokenList has an associated
attribute. It will overwrite the attribute value which will:
1. Generate a Mutation event.
2. Possibly change the attribute value as the new value is the "ordered
set serializer for tokens". So it will get rid of extra spaces and
duplicates in the attribute value.
Firefox already behaves according to the specification.
No new tests, already covered by existing tests.
* html/DOMTokenList.cpp:
(WebCore::DOMTokenList::addInternal):
(WebCore::DOMTokenList::removeInternal):
(WebCore::DOMTokenList::remove): Deleted.
LayoutTests:
Update / Rebaseline several classList /relList tests now that our
behavior has changed.
* fast/dom/HTMLElement/class-list-expected.txt:
* fast/dom/HTMLElement/class-list-quirks-expected.txt:
* fast/dom/HTMLElement/script-tests/class-list.js:
* fast/dom/rel-list-expected.txt:
* fast/dom/rel-list.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomHTMLElementclasslistexpectedtxt">trunk/LayoutTests/fast/dom/HTMLElement/class-list-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomHTMLElementclasslistquirksexpectedtxt">trunk/LayoutTests/fast/dom/HTMLElement/class-list-quirks-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomHTMLElementscripttestsclasslistjs">trunk/LayoutTests/fast/dom/HTMLElement/script-tests/class-list.js</a></li>
<li><a href="#trunkLayoutTestsfastdomrellistexpectedtxt">trunk/LayoutTests/fast/dom/rel-list-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomrellisthtml">trunk/LayoutTests/fast/dom/rel-list.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesMutationObserverattributesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/MutationObserver-attributes-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlDOMTokenListcpp">trunk/Source/WebCore/html/DOMTokenList.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (190077 => 190078)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-21 20:57:05 UTC (rev 190077)
+++ trunk/LayoutTests/ChangeLog 2015-09-21 20:59:12 UTC (rev 190078)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-09-21 Chris Dumez <cdumez@apple.com>
+
+ DOMTokenList.add() / remove() should run the update steps even if tokens were not modified
+ https://bugs.webkit.org/show_bug.cgi?id=148780
+ <rdar://problem/22571794>
+
+ Reviewed by Ryosuke Niwa.
+
+ Update / Rebaseline several classList /relList tests now that our
+ behavior has changed.
+
+ * fast/dom/HTMLElement/class-list-expected.txt:
+ * fast/dom/HTMLElement/class-list-quirks-expected.txt:
+ * fast/dom/HTMLElement/script-tests/class-list.js:
+ * fast/dom/rel-list-expected.txt:
+ * fast/dom/rel-list.html:
+
</ins><span class="cx"> 2015-09-21 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Add some tests for shadow DOM rendering
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLElementclasslistexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/HTMLElement/class-list-expected.txt (190077 => 190078)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLElement/class-list-expected.txt 2015-09-21 20:57:05 UTC (rev 190077)
+++ trunk/LayoutTests/fast/dom/HTMLElement/class-list-expected.txt 2015-09-21 20:59:12 UTC (rev 190078)
</span><span class="lines">@@ -11,7 +11,7 @@
</span><span class="cx"> PASS element.classList.length is 2
</span><span class="cx"> PASS element.className is "x"
</span><span class="cx"> PASS element.className is "x"
</span><del>-PASS element.className is "x x"
</del><ins>+PASS element.className is "x"
</ins><span class="cx"> PASS element.className is "y x"
</span><span class="cx"> PASS element.className is ""
</span><span class="cx"> PASS element.className is ""
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLElementclasslistquirksexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/HTMLElement/class-list-quirks-expected.txt (190077 => 190078)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLElement/class-list-quirks-expected.txt 2015-09-21 20:57:05 UTC (rev 190077)
+++ trunk/LayoutTests/fast/dom/HTMLElement/class-list-quirks-expected.txt 2015-09-21 20:59:12 UTC (rev 190078)
</span><span class="lines">@@ -11,7 +11,7 @@
</span><span class="cx"> PASS element.classList.length is 2
</span><span class="cx"> PASS element.className is "x"
</span><span class="cx"> PASS element.className is "x"
</span><del>-PASS element.className is "x x"
</del><ins>+PASS element.className is "x"
</ins><span class="cx"> PASS element.className is "y x"
</span><span class="cx"> PASS element.className is ""
</span><span class="cx"> PASS element.className is ""
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLElementscripttestsclasslistjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/HTMLElement/script-tests/class-list.js (190077 => 190078)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLElement/script-tests/class-list.js 2015-09-21 20:57:05 UTC (rev 190077)
+++ trunk/LayoutTests/fast/dom/HTMLElement/script-tests/class-list.js 2015-09-21 20:59:12 UTC (rev 190078)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> // http://simon.html5.org/test/html/dom/reflecting/DOMTokenList/getting/007.htm
</span><span class="cx"> createElement('x x');
</span><span class="cx"> element.classList.add('x');
</span><del>-shouldBeEqualToString('element.className', 'x x');
</del><ins>+shouldBeEqualToString('element.className', 'x');
</ins><span class="cx">
</span><span class="cx"> // http://simon.html5.org/test/html/dom/reflecting/DOMTokenList/getting/008.htm
</span><span class="cx"> createElement('y');
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomrellistexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/rel-list-expected.txt (190077 => 190078)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/rel-list-expected.txt 2015-09-21 20:57:05 UTC (rev 190077)
+++ trunk/LayoutTests/fast/dom/rel-list-expected.txt 2015-09-21 20:59:12 UTC (rev 190078)
</span><span class="lines">@@ -30,7 +30,7 @@
</span><span class="cx"> PASS element.relList.length is 2
</span><span class="cx"> PASS element.rel is "x"
</span><span class="cx"> PASS element.rel is "x"
</span><del>-PASS element.rel is "x x"
</del><ins>+PASS element.rel is "x"
</ins><span class="cx"> PASS element.rel is "y x"
</span><span class="cx"> PASS element.rel is ""
</span><span class="cx"> PASS element.rel is ""
</span><span class="lines">@@ -153,7 +153,7 @@
</span><span class="cx"> PASS element.relList.length is 2
</span><span class="cx"> PASS element.rel is "x"
</span><span class="cx"> PASS element.rel is "x"
</span><del>-PASS element.rel is "x x"
</del><ins>+PASS element.rel is "x"
</ins><span class="cx"> PASS element.rel is "y x"
</span><span class="cx"> PASS element.rel is ""
</span><span class="cx"> PASS element.rel is ""
</span><span class="lines">@@ -276,7 +276,7 @@
</span><span class="cx"> PASS element.relList.length is 2
</span><span class="cx"> PASS element.rel is "x"
</span><span class="cx"> PASS element.rel is "x"
</span><del>-PASS element.rel is "x x"
</del><ins>+PASS element.rel is "x"
</ins><span class="cx"> PASS element.rel is "y x"
</span><span class="cx"> PASS element.rel is ""
</span><span class="cx"> PASS element.rel is ""
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomrellisthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/rel-list.html (190077 => 190078)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/rel-list.html 2015-09-21 20:57:05 UTC (rev 190077)
+++ trunk/LayoutTests/fast/dom/rel-list.html 2015-09-21 20:59:12 UTC (rev 190078)
</span><span class="lines">@@ -77,7 +77,7 @@
</span><span class="cx">
</span><span class="cx"> createElement('x x');
</span><span class="cx"> element.relList.add('x');
</span><del>- shouldBeEqualToString('element.rel', 'x x');
</del><ins>+ shouldBeEqualToString('element.rel', 'x');
</ins><span class="cx">
</span><span class="cx"> createElement('y');
</span><span class="cx"> element.relList.add('x');
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (190077 => 190078)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2015-09-21 20:57:05 UTC (rev 190077)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2015-09-21 20:59:12 UTC (rev 190078)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2015-09-21 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ DOMTokenList.add() / remove() should run the update steps even if tokens were not modified
+ https://bugs.webkit.org/show_bug.cgi?id=148780
+ <rdar://problem/22571794>
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline W3C DOM test now that more checks are passing.
+
+ * web-platform-tests/dom/nodes/MutationObserver-attributes-expected.txt:
+
+2015-09-21 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Range.cloneContents() / extractContents should throw a HierarchyRequestError when encountering a doctype
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=148770
</span><span class="cx"> <rdar://problem/22570898>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesMutationObserverattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/MutationObserver-attributes-expected.txt (190077 => 190078)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/MutationObserver-attributes-expected.txt 2015-09-21 20:57:05 UTC (rev 190077)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/MutationObserver-attributes-expected.txt 2015-09-21 20:59:12 UTC (rev 190078)
</span><span class="lines">@@ -15,10 +15,10 @@
</span><span class="cx"> PASS attributes Element.classList.add: multiple tokens addition mutation
</span><span class="cx"> PASS attributes Element.classList.add: syntax err/no mutation
</span><span class="cx"> PASS attributes Element.classList.add: invalid character/no mutation
</span><del>-FAIL attributes Element.classList.add: same value mutation assert_equals: mutation records must match expected 2 but got 1
</del><ins>+PASS attributes Element.classList.add: same value mutation
</ins><span class="cx"> PASS attributes Element.classList.remove: single token removal mutation
</span><span class="cx"> PASS attributes Element.classList.remove: multiple tokens removal mutation
</span><del>-FAIL attributes Element.classList.remove: missing token removal mutation assert_equals: mutation records must match expected 2 but got 1
</del><ins>+PASS attributes Element.classList.remove: missing token removal mutation
</ins><span class="cx"> PASS attributes Element.classList.toggle: token removal mutation
</span><span class="cx"> PASS attributes Element.classList.toggle: token addition mutation
</span><span class="cx"> PASS attributes Element.classList.toggle: forced token removal mutation
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (190077 => 190078)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-21 20:57:05 UTC (rev 190077)
+++ trunk/Source/WebCore/ChangeLog 2015-09-21 20:59:12 UTC (rev 190078)
</span><span class="lines">@@ -1,3 +1,35 @@
</span><ins>+2015-09-21 Chris Dumez <cdumez@apple.com>
+
+ DOMTokenList.add() / remove() should run the update steps even if tokens were not modified
+ https://bugs.webkit.org/show_bug.cgi?id=148780
+ <rdar://problem/22571794>
+
+ Reviewed by Ryosuke Niwa.
+
+ DOMTokenList.add() / remove() should run the update steps even if tokens
+ were not modified, as per the DOM specification:
+ - https://dom.spec.whatwg.org/#dom-domtokenlist-add
+ - https://dom.spec.whatwg.org/#dom-domtokenlist-remove
+
+ The update steps are specified at:
+ - https://dom.spec.whatwg.org/#concept-DTL-update
+
+ This will have several side effects if the DOMTokenList has an associated
+ attribute. It will overwrite the attribute value which will:
+ 1. Generate a Mutation event.
+ 2. Possibly change the attribute value as the new value is the "ordered
+ set serializer for tokens". So it will get rid of extra spaces and
+ duplicates in the attribute value.
+
+ Firefox already behaves according to the specification.
+
+ No new tests, already covered by existing tests.
+
+ * html/DOMTokenList.cpp:
+ (WebCore::DOMTokenList::addInternal):
+ (WebCore::DOMTokenList::removeInternal):
+ (WebCore::DOMTokenList::remove): Deleted.
+
</ins><span class="cx"> 2015-09-21 Eric Carlson <eric.carlson@apple.com>
</span><span class="cx">
</span><span class="cx"> [MediaStream] Clean up MediaStream private interfaces
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlDOMTokenListcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/DOMTokenList.cpp (190077 => 190078)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/DOMTokenList.cpp 2015-09-21 20:57:05 UTC (rev 190077)
+++ trunk/Source/WebCore/html/DOMTokenList.cpp 2015-09-21 20:59:12 UTC (rev 190078)
</span><span class="lines">@@ -83,10 +83,9 @@
</span><span class="cx"> uniqueTokens.uncheckedAppend(tokens[i]);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (uniqueTokens.isEmpty())
- return;
</del><ins>+ if (!uniqueTokens.isEmpty())
+ m_tokens.appendVector(uniqueTokens);
</ins><span class="cx">
</span><del>- m_tokens.appendVector(uniqueTokens);
</del><span class="cx"> updateAfterTokenChange();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -105,14 +104,10 @@
</span><span class="cx"> if (!validateTokens(tokens, length, ec))
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- bool didRemoveTokens = false;
- for (size_t i = 0; i < length; ++i) {
- if (m_tokens.removeFirst(tokens[i]))
- didRemoveTokens = true;
- }
</del><ins>+ for (size_t i = 0; i < length; ++i)
+ m_tokens.removeFirst(tokens[i]);
</ins><span class="cx">
</span><del>- if (didRemoveTokens)
- updateAfterTokenChange();
</del><ins>+ updateAfterTokenChange();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void DOMTokenList::remove(const Vector<String>& tokens, ExceptionCode& ec)
</span></span></pre>
</div>
</div>
</body>
</html>