<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189964] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189964">189964</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-09-17 22:06:20 -0700 (Thu, 17 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Remove unused canClearBrowserCookies / canClearBrowserCache protocol methods
https://bugs.webkit.org/show_bug.cgi?id=149307
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-09-17
Reviewed by Brian Burg.
Source/JavaScriptCore:
* inspector/protocol/Network.json:
Remove unused protocol methods.
Source/WebCore:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::canClearBrowserCache): Deleted.
(WebCore::InspectorClient::clearBrowserCache): Deleted.
(WebCore::InspectorClient::canClearBrowserCookies): Deleted.
(WebCore::InspectorClient::clearBrowserCookies): Deleted.
These were unimplemented by any ports.
* inspector/CommandLineAPIHost.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
(WebCore::InspectorResourceAgent::canClearBrowserCache): Deleted.
(WebCore::InspectorResourceAgent::clearBrowserCache): Deleted.
(WebCore::InspectorResourceAgent::canClearBrowserCookies): Deleted.
(WebCore::InspectorResourceAgent::clearBrowserCookies): Deleted.
* inspector/InspectorResourceAgent.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
* inspector/InspectorTimelineAgent.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
Remove uses of InspectorClient where it is no longer needed.
Source/WebInspectorUI:
* UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
* UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
* UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
* Versions/Inspector-iOS-7.0.json:
* Versions/Inspector-iOS-8.0.json:
* Versions/Inspector-iOS-9.0.json:
Retroactively remove the protocol methods as they were unused
in these earlier versions as well.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorprotocolNetworkjson">trunk/Source/JavaScriptCore/inspector/protocol/Network.json</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorCommandLineAPIHostcpp">trunk/Source/WebCore/inspector/CommandLineAPIHost.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorClienth">trunk/Source/WebCore/inspector/InspectorClient.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorControllercpp">trunk/Source/WebCore/inspector/InspectorController.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorResourceAgentcpp">trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorResourceAgenth">trunk/Source/WebCore/inspector/InspectorResourceAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorTimelineAgentcpp">trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorTimelineAgenth">trunk/Source/WebCore/inspector/InspectorTimelineAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorWorkerInspectorControllercpp">trunk/Source/WebCore/inspector/WorkerInspectorController.cpp</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolLegacy70InspectorBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolLegacy80InspectorBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolLegacy90InspectorBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIVersionsInspectoriOS70json">trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json</a></li>
<li><a href="#trunkSourceWebInspectorUIVersionsInspectoriOS80json">trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json</a></li>
<li><a href="#trunkSourceWebInspectorUIVersionsInspectoriOS90json">trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-09-17 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Remove unused canClearBrowserCookies / canClearBrowserCache protocol methods
+ https://bugs.webkit.org/show_bug.cgi?id=149307
+
+ Reviewed by Brian Burg.
+
+ * inspector/protocol/Network.json:
+ Remove unused protocol methods.
+
</ins><span class="cx"> 2015-09-17 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r189938, r189952, and r189956.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorprotocolNetworkjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/protocol/Network.json (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/protocol/Network.json 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/JavaScriptCore/inspector/protocol/Network.json 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -151,28 +151,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "canClearBrowserCache",
- "description": "Tells whether clearing browser cache is supported.",
- "returns": [
- { "name": "result", "type": "boolean", "description": "True if browser cache can be cleared." }
- ]
- },
- {
- "name": "clearBrowserCache",
- "description": "Clears browser cache."
- },
- {
- "name": "canClearBrowserCookies",
- "description": "Tells whether clearing browser cookies is supported.",
- "returns": [
- { "name": "result", "type": "boolean", "description": "True if browser cookies can be cleared." }
- ]
- },
- {
- "name": "clearBrowserCookies",
- "description": "Clears browser cookies."
- },
- {
</del><span class="cx"> "name": "setCacheDisabled",
</span><span class="cx"> "parameters": [
</span><span class="cx"> { "name": "cacheDisabled", "type": "boolean", "description": "Cache disabled state." }
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebCore/ChangeLog 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -1,3 +1,34 @@
</span><ins>+2015-09-17 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Remove unused canClearBrowserCookies / canClearBrowserCache protocol methods
+ https://bugs.webkit.org/show_bug.cgi?id=149307
+
+ Reviewed by Brian Burg.
+
+ * inspector/InspectorClient.h:
+ (WebCore::InspectorClient::canClearBrowserCache): Deleted.
+ (WebCore::InspectorClient::clearBrowserCache): Deleted.
+ (WebCore::InspectorClient::canClearBrowserCookies): Deleted.
+ (WebCore::InspectorClient::clearBrowserCookies): Deleted.
+ These were unimplemented by any ports.
+
+ * inspector/CommandLineAPIHost.cpp:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::InspectorController):
+ * inspector/InspectorResourceAgent.cpp:
+ (WebCore::InspectorResourceAgent::InspectorResourceAgent):
+ (WebCore::InspectorResourceAgent::canClearBrowserCache): Deleted.
+ (WebCore::InspectorResourceAgent::clearBrowserCache): Deleted.
+ (WebCore::InspectorResourceAgent::canClearBrowserCookies): Deleted.
+ (WebCore::InspectorResourceAgent::clearBrowserCookies): Deleted.
+ * inspector/InspectorResourceAgent.h:
+ * inspector/InspectorTimelineAgent.cpp:
+ (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
+ * inspector/InspectorTimelineAgent.h:
+ * inspector/WorkerInspectorController.cpp:
+ (WebCore::WorkerInspectorController::WorkerInspectorController):
+ Remove uses of InspectorClient where it is no longer needed.
+
</ins><span class="cx"> 2015-09-16 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Update features.json for Shadow DOM and Web Components
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorCommandLineAPIHostcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/CommandLineAPIHost.cpp (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/CommandLineAPIHost.cpp 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebCore/inspector/CommandLineAPIHost.cpp 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -36,7 +36,6 @@
</span><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "FrameLoader.h"
</span><span class="cx"> #include "HTMLFrameOwnerElement.h"
</span><del>-#include "InspectorClient.h"
</del><span class="cx"> #include "InspectorDOMAgent.h"
</span><span class="cx"> #include "InspectorDOMStorageAgent.h"
</span><span class="cx"> #include "InspectorDatabaseAgent.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorClient.h (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorClient.h 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebCore/inspector/InspectorClient.h 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -59,11 +59,6 @@
</span><span class="cx"> virtual void showInspectorIndication() { }
</span><span class="cx"> virtual void hideInspectorIndication() { }
</span><span class="cx">
</span><del>- virtual bool canClearBrowserCache() { return false; }
- virtual void clearBrowserCache() { }
- virtual bool canClearBrowserCookies() { return false; }
- virtual void clearBrowserCookies() { }
-
</del><span class="cx"> virtual bool overridesShowPaintRects() const { return false; }
</span><span class="cx"> virtual void setShowPaintRects(bool) { }
</span><span class="cx"> virtual void showPaintRect(const FloatRect&) { }
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorController.cpp (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorController.cpp 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebCore/inspector/InspectorController.cpp 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -149,11 +149,11 @@
</span><span class="cx"> InspectorDOMStorageAgent* domStorageAgent = domStorageAgentPtr.get();
</span><span class="cx"> m_agents.append(WTF::move(domStorageAgentPtr));
</span><span class="cx">
</span><del>- auto timelineAgentPtr = std::make_unique<InspectorTimelineAgent>(pageContext, pageAgent, InspectorTimelineAgent::PageInspector, inspectorClient);
</del><ins>+ auto timelineAgentPtr = std::make_unique<InspectorTimelineAgent>(pageContext, pageAgent, InspectorTimelineAgent::PageInspector);
</ins><span class="cx"> m_timelineAgent = timelineAgentPtr.get();
</span><span class="cx"> m_agents.append(WTF::move(timelineAgentPtr));
</span><span class="cx">
</span><del>- auto resourceAgentPtr = std::make_unique<InspectorResourceAgent>(pageContext, pageAgent, inspectorClient);
</del><ins>+ auto resourceAgentPtr = std::make_unique<InspectorResourceAgent>(pageContext, pageAgent);
</ins><span class="cx"> m_resourceAgent = resourceAgentPtr.get();
</span><span class="cx"> m_agents.append(WTF::move(resourceAgentPtr));
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorResourceAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -44,7 +44,6 @@
</span><span class="cx"> #include "HTTPHeaderMap.h"
</span><span class="cx"> #include "HTTPHeaderNames.h"
</span><span class="cx"> #include "IconController.h"
</span><del>-#include "InspectorClient.h"
</del><span class="cx"> #include "InspectorPageAgent.h"
</span><span class="cx"> #include "InspectorTimelineAgent.h"
</span><span class="cx"> #include "InstrumentingAgents.h"
</span><span class="lines">@@ -162,12 +161,11 @@
</span><span class="cx">
</span><span class="cx"> } // namespace
</span><span class="cx">
</span><del>-InspectorResourceAgent::InspectorResourceAgent(WebAgentContext& context, InspectorPageAgent* pageAgent, InspectorClient* client)
</del><ins>+InspectorResourceAgent::InspectorResourceAgent(WebAgentContext& context, InspectorPageAgent* pageAgent)
</ins><span class="cx"> : InspectorAgentBase(ASCIILiteral("Network"), context)
</span><span class="cx"> , m_frontendDispatcher(std::make_unique<Inspector::NetworkFrontendDispatcher>(context.frontendRouter))
</span><span class="cx"> , m_backendDispatcher(Inspector::NetworkBackendDispatcher::create(context.backendDispatcher, this))
</span><span class="cx"> , m_pageAgent(pageAgent)
</span><del>- , m_client(client)
</del><span class="cx"> , m_resourcesData(std::make_unique<NetworkResourcesData>())
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="lines">@@ -653,26 +651,6 @@
</span><span class="cx"> errorString = ASCIILiteral("No data found for resource with given identifier");
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorResourceAgent::canClearBrowserCache(ErrorString&, bool* result)
-{
- *result = m_client->canClearBrowserCache();
-}
-
-void InspectorResourceAgent::clearBrowserCache(ErrorString&)
-{
- m_client->clearBrowserCache();
-}
-
-void InspectorResourceAgent::canClearBrowserCookies(ErrorString&, bool* result)
-{
- *result = m_client->canClearBrowserCookies();
-}
-
-void InspectorResourceAgent::clearBrowserCookies(ErrorString&)
-{
- m_client->clearBrowserCookies();
-}
-
</del><span class="cx"> void InspectorResourceAgent::setCacheDisabled(ErrorString&, bool cacheDisabled)
</span><span class="cx"> {
</span><span class="cx"> m_cacheDisabled = cacheDisabled;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorResourceAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorResourceAgent.h (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorResourceAgent.h 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebCore/inspector/InspectorResourceAgent.h 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -53,7 +53,6 @@
</span><span class="cx"> class FormData;
</span><span class="cx"> class Frame;
</span><span class="cx"> class HTTPHeaderMap;
</span><del>-class InspectorClient;
</del><span class="cx"> class InspectorPageAgent;
</span><span class="cx"> class NetworkResourcesData;
</span><span class="cx"> class Page;
</span><span class="lines">@@ -75,7 +74,7 @@
</span><span class="cx"> class InspectorResourceAgent final : public InspectorAgentBase, public Inspector::NetworkBackendDispatcherHandler {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- InspectorResourceAgent(WebAgentContext&, InspectorPageAgent*, InspectorClient*);
</del><ins>+ InspectorResourceAgent(WebAgentContext&, InspectorPageAgent*);
</ins><span class="cx"> virtual ~InspectorResourceAgent();
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::FrontendRouter*, Inspector::BackendDispatcher*) override;
</span><span class="lines">@@ -119,10 +118,6 @@
</span><span class="cx"> virtual void disable(ErrorString&) override;
</span><span class="cx"> virtual void setExtraHTTPHeaders(ErrorString&, const Inspector::InspectorObject& headers) override;
</span><span class="cx"> virtual void getResponseBody(ErrorString&, const String& requestId, String* content, bool* base64Encoded) override;
</span><del>- virtual void canClearBrowserCache(ErrorString&, bool*) override;
- virtual void clearBrowserCache(ErrorString&) override;
- virtual void canClearBrowserCookies(ErrorString&, bool*) override;
- virtual void clearBrowserCookies(ErrorString&) override;
</del><span class="cx"> virtual void setCacheDisabled(ErrorString&, bool cacheDisabled) override;
</span><span class="cx"> virtual void loadResource(ErrorString&, const String& frameId, const String& url, Ref<LoadResourceCallback>&&) override;
</span><span class="cx">
</span><span class="lines">@@ -135,8 +130,6 @@
</span><span class="cx"> RefPtr<Inspector::NetworkBackendDispatcher> m_backendDispatcher;
</span><span class="cx"> InspectorPageAgent* m_pageAgent { nullptr };
</span><span class="cx">
</span><del>- InspectorClient* m_client { nullptr };
-
</del><span class="cx"> std::unique_ptr<NetworkResourcesData> m_resourcesData;
</span><span class="cx"> bool m_enabled { false };
</span><span class="cx"> bool m_cacheDisabled { false };
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorTimelineAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -36,7 +36,6 @@
</span><span class="cx"> #include "Event.h"
</span><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "FrameView.h"
</span><del>-#include "InspectorClient.h"
</del><span class="cx"> #include "InspectorInstrumentation.h"
</span><span class="cx"> #include "InspectorPageAgent.h"
</span><span class="cx"> #include "InstrumentingAgents.h"
</span><span class="lines">@@ -722,12 +721,11 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-InspectorTimelineAgent::InspectorTimelineAgent(WebAgentContext& context, InspectorPageAgent* pageAgent, InspectorType type, InspectorClient* client)
</del><ins>+InspectorTimelineAgent::InspectorTimelineAgent(WebAgentContext& context, InspectorPageAgent* pageAgent, InspectorType type)
</ins><span class="cx"> : InspectorAgentBase(ASCIILiteral("Timeline"), context)
</span><span class="cx"> , m_frontendDispatcher(std::make_unique<Inspector::TimelineFrontendDispatcher>(context.frontendRouter))
</span><span class="cx"> , m_backendDispatcher(Inspector::TimelineBackendDispatcher::create(context.backendDispatcher, this))
</span><span class="cx"> , m_pageAgent(pageAgent)
</span><del>- , m_client(client)
</del><span class="cx"> , m_inspectorType(type)
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorTimelineAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.h (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.h 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.h 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -52,7 +52,6 @@
</span><span class="cx"> class Event;
</span><span class="cx"> class FloatQuad;
</span><span class="cx"> class Frame;
</span><del>-class InspectorClient;
</del><span class="cx"> class InspectorPageAgent;
</span><span class="cx"> class IntRect;
</span><span class="cx"> class URL;
</span><span class="lines">@@ -117,7 +116,7 @@
</span><span class="cx"> public:
</span><span class="cx"> enum InspectorType { PageInspector, WorkerInspector };
</span><span class="cx">
</span><del>- InspectorTimelineAgent(WebAgentContext&, InspectorPageAgent*, InspectorType, InspectorClient*);
</del><ins>+ InspectorTimelineAgent(WebAgentContext&, InspectorPageAgent*, InspectorType);
</ins><span class="cx"> virtual ~InspectorTimelineAgent();
</span><span class="cx">
</span><span class="cx"> virtual void didCreateFrontendAndBackend(Inspector::FrontendRouter*, Inspector::BackendDispatcher*) override;
</span><span class="lines">@@ -238,7 +237,6 @@
</span><span class="cx"> InspectorPageAgent* m_pageAgent;
</span><span class="cx">
</span><span class="cx"> PageScriptDebugServer* m_scriptDebugServer { nullptr };
</span><del>- InspectorClient* m_client { nullptr };
</del><span class="cx">
</span><span class="cx"> Vector<TimelineRecordEntry> m_recordStack;
</span><span class="cx"> int m_id { 1 };
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorWorkerInspectorControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/WorkerInspectorController.cpp (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/WorkerInspectorController.cpp 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebCore/inspector/WorkerInspectorController.cpp 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -33,7 +33,6 @@
</span><span class="cx"> #include "WorkerInspectorController.h"
</span><span class="cx">
</span><span class="cx"> #include "CommandLineAPIHost.h"
</span><del>-#include "InspectorClient.h"
</del><span class="cx"> #include "InspectorInstrumentation.h"
</span><span class="cx"> #include "InspectorTimelineAgent.h"
</span><span class="cx"> #include "InstrumentingAgents.h"
</span><span class="lines">@@ -114,7 +113,7 @@
</span><span class="cx"> m_runtimeAgent->setScriptDebugServer(&debuggerAgent->scriptDebugServer());
</span><span class="cx"> m_agents.append(WTF::move(debuggerAgent));
</span><span class="cx">
</span><del>- m_agents.append(std::make_unique<InspectorTimelineAgent>(workerContext, nullptr, InspectorTimelineAgent::WorkerInspector, nullptr));
</del><ins>+ m_agents.append(std::make_unique<InspectorTimelineAgent>(workerContext, nullptr, InspectorTimelineAgent::WorkerInspector));
</ins><span class="cx"> m_agents.append(WTF::move(consoleAgent));
</span><span class="cx">
</span><span class="cx"> if (CommandLineAPIHost* commandLineAPIHost = m_injectedScriptManager->commandLineAPIHost()) {
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2015-09-17 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Remove unused canClearBrowserCookies / canClearBrowserCache protocol methods
+ https://bugs.webkit.org/show_bug.cgi?id=149307
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
+ * Versions/Inspector-iOS-7.0.json:
+ * Versions/Inspector-iOS-8.0.json:
+ * Versions/Inspector-iOS-9.0.json:
+ Retroactively remove the protocol methods as they were unused
+ in these earlier versions as well.
+
+2015-09-17 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> REGRESSION: Web Inspector: Double clicking on an attribute second time doesn't work
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149259
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolLegacy70InspectorBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -129,10 +129,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("Network.disable", [], []);
</span><span class="cx"> InspectorBackend.registerCommand("Network.setExtraHTTPHeaders", [{"name": "headers", "type": "object", "optional": false}], []);
</span><span class="cx"> InspectorBackend.registerCommand("Network.getResponseBody", [{"name": "requestId", "type": "string", "optional": false}], ["body", "base64Encoded"]);
</span><del>-InspectorBackend.registerCommand("Network.canClearBrowserCache", [], ["result"]);
-InspectorBackend.registerCommand("Network.clearBrowserCache", [], []);
-InspectorBackend.registerCommand("Network.canClearBrowserCookies", [], ["result"]);
-InspectorBackend.registerCommand("Network.clearBrowserCookies", [], []);
</del><span class="cx"> InspectorBackend.registerCommand("Network.setCacheDisabled", [{"name": "cacheDisabled", "type": "boolean", "optional": false}], []);
</span><span class="cx"> InspectorBackend.activateDomain("Network");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolLegacy80InspectorBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -290,10 +290,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("Network.disable", [], []);
</span><span class="cx"> InspectorBackend.registerCommand("Network.setExtraHTTPHeaders", [{"name": "headers", "type": "object", "optional": false}], []);
</span><span class="cx"> InspectorBackend.registerCommand("Network.getResponseBody", [{"name": "requestId", "type": "string", "optional": false}], ["body", "base64Encoded"]);
</span><del>-InspectorBackend.registerCommand("Network.canClearBrowserCache", [], ["result"]);
-InspectorBackend.registerCommand("Network.clearBrowserCache", [], []);
-InspectorBackend.registerCommand("Network.canClearBrowserCookies", [], ["result"]);
-InspectorBackend.registerCommand("Network.clearBrowserCookies", [], []);
</del><span class="cx"> InspectorBackend.registerCommand("Network.setCacheDisabled", [{"name": "cacheDisabled", "type": "boolean", "optional": false}], []);
</span><span class="cx"> InspectorBackend.registerCommand("Network.loadResource", [{"name": "frameId", "type": "string", "optional": false}, {"name": "url", "type": "string", "optional": false}], ["content", "mimeType", "status"]);
</span><span class="cx"> InspectorBackend.activateDomain("Network", "web");
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolLegacy90InspectorBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -258,10 +258,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("Network.disable", [], []);
</span><span class="cx"> InspectorBackend.registerCommand("Network.setExtraHTTPHeaders", [{"name": "headers", "type": "object", "optional": false}], []);
</span><span class="cx"> InspectorBackend.registerCommand("Network.getResponseBody", [{"name": "requestId", "type": "string", "optional": false}], ["body", "base64Encoded"]);
</span><del>-InspectorBackend.registerCommand("Network.canClearBrowserCache", [], ["result"]);
-InspectorBackend.registerCommand("Network.clearBrowserCache", [], []);
-InspectorBackend.registerCommand("Network.canClearBrowserCookies", [], ["result"]);
-InspectorBackend.registerCommand("Network.clearBrowserCookies", [], []);
</del><span class="cx"> InspectorBackend.registerCommand("Network.setCacheDisabled", [{"name": "cacheDisabled", "type": "boolean", "optional": false}], []);
</span><span class="cx"> InspectorBackend.registerCommand("Network.loadResource", [{"name": "frameId", "type": "string", "optional": false}, {"name": "url", "type": "string", "optional": false}], ["content", "mimeType", "status"]);
</span><span class="cx"> InspectorBackend.activateDomain("Network", "web");
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIVersionsInspectoriOS70json"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -815,28 +815,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "canClearBrowserCache",
- "description": "Tells whether clearing browser cache is supported.",
- "returns": [
- { "name": "result", "type": "boolean", "description": "True if browser cache can be cleared." }
- ]
- },
- {
- "name": "clearBrowserCache",
- "description": "Clears browser cache."
- },
- {
- "name": "canClearBrowserCookies",
- "description": "Tells whether clearing browser cookies is supported.",
- "returns": [
- { "name": "result", "type": "boolean", "description": "True if browser cookies can be cleared." }
- ]
- },
- {
- "name": "clearBrowserCookies",
- "description": "Clears browser cookies."
- },
- {
</del><span class="cx"> "name": "setCacheDisabled",
</span><span class="cx"> "parameters": [
</span><span class="cx"> { "name": "cacheDisabled", "type": "boolean", "description": "Cache disabled state." }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIVersionsInspectoriOS80json"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -2448,28 +2448,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "canClearBrowserCache",
- "description": "Tells whether clearing browser cache is supported.",
- "returns": [
- { "name": "result", "type": "boolean", "description": "True if browser cache can be cleared." }
- ]
- },
- {
- "name": "clearBrowserCache",
- "description": "Clears browser cache."
- },
- {
- "name": "canClearBrowserCookies",
- "description": "Tells whether clearing browser cookies is supported.",
- "returns": [
- { "name": "result", "type": "boolean", "description": "True if browser cookies can be cleared." }
- ]
- },
- {
- "name": "clearBrowserCookies",
- "description": "Clears browser cookies."
- },
- {
</del><span class="cx"> "name": "setCacheDisabled",
</span><span class="cx"> "parameters": [
</span><span class="cx"> { "name": "cacheDisabled", "type": "boolean", "description": "Cache disabled state." }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIVersionsInspectoriOS90json"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json (189963 => 189964)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json 2015-09-18 04:48:19 UTC (rev 189963)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json 2015-09-18 05:06:20 UTC (rev 189964)
</span><span class="lines">@@ -2186,28 +2186,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "canClearBrowserCache",
- "description": "Tells whether clearing browser cache is supported.",
- "returns": [
- { "name": "result", "type": "boolean", "description": "True if browser cache can be cleared." }
- ]
- },
- {
- "name": "clearBrowserCache",
- "description": "Clears browser cache."
- },
- {
- "name": "canClearBrowserCookies",
- "description": "Tells whether clearing browser cookies is supported.",
- "returns": [
- { "name": "result", "type": "boolean", "description": "True if browser cookies can be cleared." }
- ]
- },
- {
- "name": "clearBrowserCookies",
- "description": "Clears browser cookies."
- },
- {
</del><span class="cx"> "name": "setCacheDisabled",
</span><span class="cx"> "parameters": [
</span><span class="cx"> { "name": "cacheDisabled", "type": "boolean", "description": "Cache disabled state." }
</span></span></pre>
</div>
</div>
</body>
</html>