<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189893] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189893">189893</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-09-16 18:24:58 -0700 (Wed, 16 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>LayoutTests/imported/w3c:
Element's attribute NS API should treat defined undefined namespace as null
https://bugs.webkit.org/show_bug.cgi?id=149238
<rdar://problem/22562204>
Reviewed by Ryosuke Niwa.
Rebaseline W3C DOM test that one more check is passing.
* web-platform-tests/dom/nodes/attributes-expected.txt:
Source/WebCore:
Element's attribute NS API should defined treat undefined namespace as null
https://bugs.webkit.org/show_bug.cgi?id=149238
<rdar://problem/22562204>
Reviewed by Ryosuke Niwa.
Element's attribute NS API should treat defined undefined namespace as null
instead of converting it to the "undefined" String. This is because the
namespace parameter is a nullable String as per the DOM spec:
- https://dom.spec.whatwg.org/#element
The attribute is nullable and WebIDL says undefined should be converted
to null for nullable parameters:
- https://heycam.github.io/webidl/#es-nullable-type (step 3)
Firefox follows the specification.
No new tests, already covered by existing test.
* dom/Element.idl:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesattributesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/attributes-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomElementidl">trunk/Source/WebCore/dom/Element.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (189892 => 189893)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2015-09-17 01:23:20 UTC (rev 189892)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2015-09-17 01:24:58 UTC (rev 189893)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-09-16 Chris Dumez <cdumez@apple.com>
+
+ Element's attribute NS API should treat defined undefined namespace as null
+ https://bugs.webkit.org/show_bug.cgi?id=149238
+ <rdar://problem/22562204>
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline W3C DOM test that one more check is passing.
+
+ * web-platform-tests/dom/nodes/attributes-expected.txt:
+
</ins><span class="cx"> 2015-09-15 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Document.createElement(localName) does not handle correctly missing or null parameter
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/attributes-expected.txt (189892 => 189893)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/attributes-expected.txt 2015-09-17 01:23:20 UTC (rev 189892)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/attributes-expected.txt 2015-09-17 01:24:58 UTC (rev 189893)
</span><span class="lines">@@ -33,7 +33,7 @@
</span><span class="cx"> PASS Only lowercase attributes are returned on HTML elements (mixed case attribute)
</span><span class="cx"> PASS First set attribute is returned with mapped attribute set first
</span><span class="cx"> PASS First set attribute is returned with mapped attribute set later
</span><del>-FAIL Non-HTML element with upper-case attribute assert_equals: el.hasAttributeNS(undefined) expected true but got false
</del><ins>+PASS Non-HTML element with upper-case attribute
</ins><span class="cx"> PASS Attribute with prefix in local name
</span><span class="cx"> PASS Attribute loses its owner when removed
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (189892 => 189893)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-17 01:23:20 UTC (rev 189892)
+++ trunk/Source/WebCore/ChangeLog 2015-09-17 01:24:58 UTC (rev 189893)
</span><span class="lines">@@ -1,5 +1,28 @@
</span><span class="cx"> 2015-09-16 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Element's attribute NS API should defined treat undefined namespace as null
+ https://bugs.webkit.org/show_bug.cgi?id=149238
+ <rdar://problem/22562204>
+
+ Reviewed by Ryosuke Niwa.
+
+ Element's attribute NS API should treat defined undefined namespace as null
+ instead of converting it to the "undefined" String. This is because the
+ namespace parameter is a nullable String as per the DOM spec:
+ - https://dom.spec.whatwg.org/#element
+
+ The attribute is nullable and WebIDL says undefined should be converted
+ to null for nullable parameters:
+ - https://heycam.github.io/webidl/#es-nullable-type (step 3)
+
+ Firefox follows the specification.
+
+ No new tests, already covered by existing test.
+
+ * dom/Element.idl:
+
+2015-09-16 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Possible small iOS PLT regression from r189537
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149232
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.idl (189892 => 189893)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.idl 2015-09-17 01:23:20 UTC (rev 189892)
+++ trunk/Source/WebCore/dom/Element.idl 2015-09-17 01:24:58 UTC (rev 189893)
</span><span class="lines">@@ -49,12 +49,12 @@
</span><span class="cx">
</span><span class="cx"> // DOM Level 2 Core
</span><span class="cx">
</span><del>- [ObjCLegacyUnnamedParameters, TreatReturnedNullStringAs=Null] DOMString getAttributeNS([TreatNullAs=NullString,Default=Undefined] optional DOMString namespaceURI,
</del><ins>+ [ObjCLegacyUnnamedParameters, TreatReturnedNullStringAs=Null] DOMString getAttributeNS([TreatNullAs=NullString, TreatUndefinedAs=NullString, Default=Undefined] optional DOMString namespaceURI,
</ins><span class="cx"> [Default=Undefined] optional DOMString localName);
</span><del>- [ObjCLegacyUnnamedParameters, RaisesException] void setAttributeNS([TreatNullAs=NullString,Default=Undefined] optional DOMString namespaceURI,
</del><ins>+ [ObjCLegacyUnnamedParameters, RaisesException] void setAttributeNS([TreatNullAs=NullString, TreatUndefinedAs=NullString, Default=Undefined] optional DOMString namespaceURI,
</ins><span class="cx"> [Default=Undefined] optional DOMString qualifiedName,
</span><span class="cx"> [Default=Undefined] optional DOMString value);
</span><del>- [ObjCLegacyUnnamedParameters] void removeAttributeNS([TreatNullAs=NullString] DOMString namespaceURI,
</del><ins>+ [ObjCLegacyUnnamedParameters] void removeAttributeNS([TreatNullAs=NullString, TreatUndefinedAs=NullString] DOMString namespaceURI,
</ins><span class="cx"> DOMString localName);
</span><span class="cx">
</span><span class="cx"> #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
</span><span class="lines">@@ -62,11 +62,11 @@
</span><span class="cx"> #else
</span><span class="cx"> HTMLCollection getElementsByTagNameNS([TreatNullAs=NullString,Default=Undefined] optional DOMString namespaceURI, [Default=Undefined] optional DOMString localName);
</span><span class="cx"> #endif
</span><del>- [ObjCLegacyUnnamedParameters] Attr getAttributeNodeNS([TreatNullAs=NullString,Default=Undefined] optional DOMString namespaceURI,
</del><ins>+ [ObjCLegacyUnnamedParameters] Attr getAttributeNodeNS([TreatNullAs=NullString, TreatUndefinedAs=NullString, Default=Undefined] optional DOMString namespaceURI,
</ins><span class="cx"> [Default=Undefined] optional DOMString localName);
</span><span class="cx"> [RaisesException] Attr setAttributeNodeNS([Default=Undefined] optional Attr newAttr);
</span><span class="cx"> boolean hasAttribute(DOMString name);
</span><del>- [ObjCLegacyUnnamedParameters] boolean hasAttributeNS([TreatNullAs=NullString,Default=Undefined] optional DOMString namespaceURI,
</del><ins>+ [ObjCLegacyUnnamedParameters] boolean hasAttributeNS([TreatNullAs=NullString, TreatUndefinedAs=NullString, Default=Undefined] optional DOMString namespaceURI,
</ins><span class="cx"> [Default=Undefined] optional DOMString localName);
</span><span class="cx">
</span><span class="cx"> readonly attribute CSSStyleDeclaration style;
</span></span></pre>
</div>
</div>
</body>
</html>