<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189873] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189873">189873</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-09-16 10:46:24 -0700 (Wed, 16 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add initial support for [Unforgeable] IDL extended attribute
https://bugs.webkit.org/show_bug.cgi?id=149147
Reviewed by Darin Adler.
Source/WebCore:
Add initial support for [Unforgeable] IDL extended attribute:
https://heycam.github.io/webidl/#Unforgeable
In particular, attributes marked as unforgeable are now:
- on the instance rather than the prototype
- non-configurable. WebKit does not match the Web IDL specification
and most properties are currently non-configurable already. However,
I added an extra check for [Unforgeable] so that unforgeable
attributes stay unconfigurable if we later decide to match the spec
and mark properties as configurable.
Operation marked as unforgeable are now non-configurable. However, this
patch does not move them from the prototype to the instance yet. This
needs to be addressed in a follow-up patch as this is a larger change.
This patch also drops support for the undocumented
[OperationsNotDeletable] IDL extended attribute. It is no longer needed
now that we support [Unforgeable] and still support [NotDeletable] for
operations.
Test: fast/dom/unforgeable-attributes.html
* Modules/plugins/QuickTimePluginReplacement.idl:
Drop [OperationsNotDeletable] on the interface and mark the only
operation on this interface as [NotDeletable]. There is no behavior
change but this allows us to drop support for a non-standard and
undocumented IDL extended attribute.
* bindings/scripts/CodeGeneratorJS.pm:
(AttributeShouldBeOnInstance):
(GenerateAttributesHashTable):
(GenerateImplementation):
Add initial support for [Unforgeable] IDL extended attribute.
* bindings/scripts/IDLAttributes.txt:
Add [Unforgeable]. Drop [OperationsNotDeletable].
* crypto/CryptoKeyPair.idl:
Drop [OperationsNotDeletable] on the interface as this interface has
no operations.
* dom/Document.idl:
* page/DOMWindow.idl:
* page/Location.idl:
Mark attributes / interfaces as [Unforgeable] as per the latest HTML
specification:
https://html.spec.whatwg.org/multipage/dom.html#document
https://html.spec.whatwg.org/multipage/browsers.html#window
https://html.spec.whatwg.org/multipage/browsers.html#the-location-interface
LayoutTests:
New test that verifies that well-known [Unforgeable] attributes
are on the instance rather than the prototype and that they are
non-configurable.
* fast/dom/unforgeable-attributes-expected.txt: Added.
* fast/dom/unforgeable-attributes.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestshttptestssecuritycrossframeaccessenumerationexpectedtxt">trunk/LayoutTests/http/tests/security/cross-frame-access-enumeration-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulespluginsQuickTimePluginReplacementidl">trunk/Source/WebCore/Modules/plugins/QuickTimePluginReplacement.idl</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsIDLAttributestxt">trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt</a></li>
<li><a href="#trunkSourceWebCorecryptoCryptoKeyPairidl">trunk/Source/WebCore/crypto/CryptoKeyPair.idl</a></li>
<li><a href="#trunkSourceWebCoredomDocumentidl">trunk/Source/WebCore/dom/Document.idl</a></li>
<li><a href="#trunkSourceWebCorepageDOMWindowidl">trunk/Source/WebCore/page/DOMWindow.idl</a></li>
<li><a href="#trunkSourceWebCorepageLocationidl">trunk/Source/WebCore/page/Location.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomunforgeableattributesexpectedtxt">trunk/LayoutTests/fast/dom/unforgeable-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomunforgeableattributeshtml">trunk/LayoutTests/fast/dom/unforgeable-attributes.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (189872 => 189873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-16 17:38:30 UTC (rev 189872)
+++ trunk/LayoutTests/ChangeLog 2015-09-16 17:46:24 UTC (rev 189873)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-09-16 Chris Dumez <cdumez@apple.com>
+
+ Add initial support for [Unforgeable] IDL extended attribute
+ https://bugs.webkit.org/show_bug.cgi?id=149147
+
+ Reviewed by Darin Adler.
+
+ New test that verifies that well-known [Unforgeable] attributes
+ are on the instance rather than the prototype and that they are
+ non-configurable.
+
+ * fast/dom/unforgeable-attributes-expected.txt: Added.
+ * fast/dom/unforgeable-attributes.html: Added.
+
</ins><span class="cx"> 2015-09-16 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Simple line layout: Glitch selecting long text.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomunforgeableattributesexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/unforgeable-attributes-expected.txt (0 => 189873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/unforgeable-attributes-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/unforgeable-attributes-expected.txt 2015-09-16 17:46:24 UTC (rev 189873)
</span><span class="lines">@@ -0,0 +1,107 @@
</span><ins>+Checks that [Unforgeable] attributes are non-configurable and on the instance rather than the prototype.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Event.isTrusted
+FAIL Unsupported property.
+
+Document.location
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change access mechanism for an unconfigurable property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+
+Window.window
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change value of a readonly property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+
+Window.document
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change value of a readonly property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+
+Window.location
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change access mechanism for an unconfigurable property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+
+Window.top
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change access mechanism for an unconfigurable property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+
+Location.ancestorOrigins
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change access mechanism for an unconfigurable property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+
+Location.href
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change access mechanism for an unconfigurable property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+
+Location.origin
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change access mechanism for an unconfigurable property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+
+Location.protocol
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change access mechanism for an unconfigurable property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+
+Location.username
+FAIL Unsupported property.
+
+Location.password
+FAIL Unsupported property.
+
+Location.host
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change access mechanism for an unconfigurable property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+
+Location.hostname
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change access mechanism for an unconfigurable property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+
+Location.port
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change access mechanism for an unconfigurable property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+
+Location.pathname
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change access mechanism for an unconfigurable property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+
+Location.search
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change access mechanism for an unconfigurable property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+
+Location.hash
+PASS testObject.hasOwnProperty(testPropertyName) is true
+PASS testObject.__proto__.hasOwnProperty(testPropertyName) is false
+PASS Object.defineProperty(testObject, testPropertyName, { value: 'test' }) threw exception TypeError: Attempting to change access mechanism for an unconfigurable property..
+PASS Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomunforgeableattributeshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/unforgeable-attributes.html (0 => 189873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/unforgeable-attributes.html (rev 0)
+++ trunk/LayoutTests/fast/dom/unforgeable-attributes.html 2015-09-16 17:46:24 UTC (rev 189873)
</span><span class="lines">@@ -0,0 +1,49 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Checks that [Unforgeable] attributes are non-configurable and on the instance rather than the prototype.");
+
+function testProperty(object, propertyName)
+{
+ testObject = object;
+ testPropertyName = propertyName;
+
+ if (testObject[propertyName] === undefined) {
+ testFailed("Unsupported property.");
+ return;
+ }
+
+ shouldBeTrue("testObject.hasOwnProperty(testPropertyName)");
+ shouldBeFalse("testObject.__proto__.hasOwnProperty(testPropertyName)");
+ shouldThrow("Object.defineProperty(testObject, testPropertyName, { value: 'test' })");
+ shouldBeFalse("Object.getOwnPropertyDescriptor(testObject, testPropertyName).configurable");
+}
+
+// DOM specification.
+debug("Event.isTrusted");
+var event = new Event("test");
+testProperty(event, "isTrusted");
+
+// HTML specification.
+debug("");
+debug("Document.location");
+testProperty(document, "location");
+
+for (var property of ["window", "document", "location", "top"]) {
+ debug("");
+ debug("Window." + property);
+ testProperty(window, property);
+}
+
+for (var property of ["ancestorOrigins", "href", "origin", "protocol", "username", "password", "host", "hostname", "port", "pathname", "search", "hash"]) {
+ debug("");
+ debug("Location." + property);
+ testProperty(window.location, property);
+}
+
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestshttptestssecuritycrossframeaccessenumerationexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/security/cross-frame-access-enumeration-expected.txt (189872 => 189873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/security/cross-frame-access-enumeration-expected.txt 2015-09-16 17:38:30 UTC (rev 189872)
+++ trunk/LayoutTests/http/tests/security/cross-frame-access-enumeration-expected.txt 2015-09-16 17:46:24 UTC (rev 189873)
</span><span class="lines">@@ -8,8 +8,6 @@
</span><span class="cx"> CONSOLE MESSAGE: line 75: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
</span><span class="cx"> CONSOLE MESSAGE: line 82: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
</span><span class="cx"> CONSOLE MESSAGE: line 29: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
</span><del>-CONSOLE MESSAGE: line 29: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
-CONSOLE MESSAGE: line 29: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
</del><span class="cx"> CONSOLE MESSAGE: line 102: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
</span><span class="cx"> CONSOLE MESSAGE: line 109: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
</span><span class="cx"> This tests that variable names can't be enumerated cross domain (see http://bugs.webkit.org/show_bug.cgi?id=16387)
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (189872 => 189873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-16 17:38:30 UTC (rev 189872)
+++ trunk/Source/WebCore/ChangeLog 2015-09-16 17:46:24 UTC (rev 189873)
</span><span class="lines">@@ -1,3 +1,60 @@
</span><ins>+2015-09-16 Chris Dumez <cdumez@apple.com>
+
+ Add initial support for [Unforgeable] IDL extended attribute
+ https://bugs.webkit.org/show_bug.cgi?id=149147
+
+ Reviewed by Darin Adler.
+
+ Add initial support for [Unforgeable] IDL extended attribute:
+ https://heycam.github.io/webidl/#Unforgeable
+
+ In particular, attributes marked as unforgeable are now:
+ - on the instance rather than the prototype
+ - non-configurable. WebKit does not match the Web IDL specification
+ and most properties are currently non-configurable already. However,
+ I added an extra check for [Unforgeable] so that unforgeable
+ attributes stay unconfigurable if we later decide to match the spec
+ and mark properties as configurable.
+
+ Operation marked as unforgeable are now non-configurable. However, this
+ patch does not move them from the prototype to the instance yet. This
+ needs to be addressed in a follow-up patch as this is a larger change.
+
+ This patch also drops support for the undocumented
+ [OperationsNotDeletable] IDL extended attribute. It is no longer needed
+ now that we support [Unforgeable] and still support [NotDeletable] for
+ operations.
+
+ Test: fast/dom/unforgeable-attributes.html
+
+ * Modules/plugins/QuickTimePluginReplacement.idl:
+ Drop [OperationsNotDeletable] on the interface and mark the only
+ operation on this interface as [NotDeletable]. There is no behavior
+ change but this allows us to drop support for a non-standard and
+ undocumented IDL extended attribute.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (AttributeShouldBeOnInstance):
+ (GenerateAttributesHashTable):
+ (GenerateImplementation):
+ Add initial support for [Unforgeable] IDL extended attribute.
+
+ * bindings/scripts/IDLAttributes.txt:
+ Add [Unforgeable]. Drop [OperationsNotDeletable].
+
+ * crypto/CryptoKeyPair.idl:
+ Drop [OperationsNotDeletable] on the interface as this interface has
+ no operations.
+
+ * dom/Document.idl:
+ * page/DOMWindow.idl:
+ * page/Location.idl:
+ Mark attributes / interfaces as [Unforgeable] as per the latest HTML
+ specification:
+ https://html.spec.whatwg.org/multipage/dom.html#document
+ https://html.spec.whatwg.org/multipage/browsers.html#window
+ https://html.spec.whatwg.org/multipage/browsers.html#the-location-interface
+
</ins><span class="cx"> 2015-09-16 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Simple line layout: Glitch selecting long text.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulespluginsQuickTimePluginReplacementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/plugins/QuickTimePluginReplacement.idl (189872 => 189873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/plugins/QuickTimePluginReplacement.idl 2015-09-16 17:38:30 UTC (rev 189872)
+++ trunk/Source/WebCore/Modules/plugins/QuickTimePluginReplacement.idl 2015-09-16 17:46:24 UTC (rev 189873)
</span><span class="lines">@@ -25,12 +25,11 @@
</span><span class="cx">
</span><span class="cx"> [
</span><span class="cx"> NoInterfaceObject,
</span><del>- OperationsNotDeletable,
</del><span class="cx"> JSGenerateToJSObject,
</span><span class="cx"> ] interface QuickTimePluginReplacement {
</span><span class="cx"> readonly attribute unsigned long long movieSize;
</span><span class="cx"> [CustomGetter] readonly attribute any timedMetaData;
</span><span class="cx"> [CustomGetter] readonly attribute any accessLog;
</span><span class="cx"> [CustomGetter] readonly attribute any errorLog;
</span><del>- void postEvent(DOMString eventName);
</del><ins>+ [NotDeletable] void postEvent(DOMString eventName);
</ins><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (189872 => 189873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-09-16 17:38:30 UTC (rev 189872)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-09-16 17:46:24 UTC (rev 189873)
</span><span class="lines">@@ -673,6 +673,10 @@
</span><span class="cx"> return 1 if HasCustomGetter($attribute->signature->extendedAttributes);
</span><span class="cx"> return 1 if HasCustomSetter($attribute->signature->extendedAttributes);
</span><span class="cx">
</span><ins>+ # [Unforgeable] attributes should be on the instance.
+ # https://heycam.github.io/webidl/#Unforgeable
+ return 1 if $attribute->signature->extendedAttributes->{"Unforgeable"} || $interface->extendedAttributes->{"Unforgeable"};
+
</ins><span class="cx"> # FIXME: Length is a tricky attribute to handle correctly as it is frequently tied to
</span><span class="cx"> # objects which also have magic named attributes that can end up being named "length"
</span><span class="cx"> # and so interfere with lookup ordering. I'm not sure what the correct solution is
</span><span class="lines">@@ -1335,7 +1339,13 @@
</span><span class="cx"> # As per Web IDL specification, constructor properties on the ECMAScript global object should be
</span><span class="cx"> # configurable and should not be enumerable.
</span><span class="cx"> my $is_global_constructor = $attribute->signature->type =~ /Constructor$/;
</span><del>- push(@specials, "DontDelete") unless ($attribute->signature->extendedAttributes->{"Deletable"} || $is_global_constructor);
</del><ins>+
+ # FIXME: Attributes should be configurable unless [Unforgeable] is specified.
+ # https://heycam.github.io/webidl/#es-attributes
+ push(@specials, "DontDelete") if (!$attribute->signature->extendedAttributes->{"Deletable"} && !$is_global_constructor)
+ || $attribute->signature->extendedAttributes->{"Unforgeable"}
+ || $interface->extendedAttributes->{"Unforgeable"};
+
</ins><span class="cx"> push(@specials, "DontEnum") if ($attribute->signature->extendedAttributes->{"NotEnumerable"} || $is_global_constructor);
</span><span class="cx"> push(@specials, "ReadOnly") if IsReadonly($attribute);
</span><span class="cx"> push(@specials, "CustomAccessor") unless $is_global_constructor;
</span><span class="lines">@@ -1911,8 +1921,7 @@
</span><span class="cx"> push(@hashValue2, $functionLength);
</span><span class="cx">
</span><span class="cx"> my @specials = ();
</span><del>- push(@specials, "DontDelete") if $interface->extendedAttributes->{"OperationsNotDeletable"}
- || $function->signature->extendedAttributes->{"NotDeletable"};
</del><ins>+ push(@specials, "DontDelete") if $function->signature->extendedAttributes->{"NotDeletable"};
</ins><span class="cx"> push(@specials, "DontEnum") if $function->signature->extendedAttributes->{"NotEnumerable"};
</span><span class="cx"> push(@specials, "JSC::Function");
</span><span class="cx"> my $special = (@specials > 0) ? join(" | ", @specials) : "0";
</span><span class="lines">@@ -1988,8 +1997,9 @@
</span><span class="cx"> push(@hashValue2, $functionLength);
</span><span class="cx">
</span><span class="cx"> my @specials = ();
</span><del>- push(@specials, "DontDelete") if $interface->extendedAttributes->{"OperationsNotDeletable"}
- || $function->signature->extendedAttributes->{"NotDeletable"};
</del><ins>+ push(@specials, "DontDelete") if $function->signature->extendedAttributes->{"NotDeletable"}
+ || $function->signature->extendedAttributes->{"Unforgeable"}
+ || $interface->extendedAttributes->{"Unforgeable"};
</ins><span class="cx"> push(@specials, "DontEnum") if $function->signature->extendedAttributes->{"NotEnumerable"};
</span><span class="cx"> push(@specials, "JSC::Function");
</span><span class="cx"> my $special = (@specials > 0) ? join(" | ", @specials) : "0";
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsIDLAttributestxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (189872 => 189873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2015-09-16 17:38:30 UTC (rev 189872)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2015-09-16 17:46:24 UTC (rev 189873)
</span><span class="lines">@@ -99,7 +99,6 @@
</span><span class="cx"> ObjCPolymorphic
</span><span class="cx"> ObjCProtocol
</span><span class="cx"> ObjCUseDefaultView
</span><del>-OperationsNotDeletable
</del><span class="cx"> OverrideBuiltins
</span><span class="cx"> PassContext
</span><span class="cx"> RaisesException
</span><span class="lines">@@ -119,6 +118,7 @@
</span><span class="cx"> TreatUndefinedAs=NullString
</span><span class="cx"> TypedArray=*
</span><span class="cx"> URL
</span><ins>+Unforgeable
</ins><span class="cx"> WindowEventHandler
</span><span class="cx">
</span><span class="cx"> # PLATFORM(IOS)
</span></span></pre></div>
<a id="trunkSourceWebCorecryptoCryptoKeyPairidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/crypto/CryptoKeyPair.idl (189872 => 189873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/crypto/CryptoKeyPair.idl 2015-09-16 17:38:30 UTC (rev 189872)
+++ trunk/Source/WebCore/crypto/CryptoKeyPair.idl 2015-09-16 17:46:24 UTC (rev 189873)
</span><span class="lines">@@ -28,8 +28,7 @@
</span><span class="cx"> ImplementationLacksVTable,
</span><span class="cx"> InterfaceName=KeyPair,
</span><span class="cx"> JSCustomMarkFunction,
</span><del>- NoInterfaceObject,
- OperationsNotDeletable
</del><ins>+ NoInterfaceObject
</ins><span class="cx"> ] interface CryptoKeyPair {
</span><span class="cx"> readonly attribute CryptoKey publicKey;
</span><span class="cx"> readonly attribute CryptoKey privateKey;
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.idl (189872 => 189873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.idl 2015-09-16 17:38:30 UTC (rev 189872)
+++ trunk/Source/WebCore/dom/Document.idl 2015-09-16 17:46:24 UTC (rev 189873)
</span><span class="lines">@@ -170,7 +170,7 @@
</span><span class="cx"> NodeList getElementsByName([Default=Undefined,AtomicString] optional DOMString elementName);
</span><span class="cx">
</span><span class="cx"> #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
</span><del>- [Custom] attribute Location location;
</del><ins>+ [Custom, Unforgeable] attribute Location location;
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> // IE extensions
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMWindowidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMWindow.idl (189872 => 189873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMWindow.idl 2015-09-16 17:38:30 UTC (rev 189872)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2015-09-16 17:46:24 UTC (rev 189873)
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx"> [Replaceable] readonly attribute Navigator navigator;
</span><span class="cx"> [Replaceable] readonly attribute Navigator clientInformation;
</span><span class="cx"> readonly attribute Crypto crypto;
</span><del>- [DoNotCheckSecurity, CustomSetter] attribute Location location;
</del><ins>+ [DoNotCheckSecurity, CustomSetter, Unforgeable] attribute Location location;
</ins><span class="cx"> [Replaceable, CustomGetter] readonly attribute Event event;
</span><span class="cx">
</span><span class="cx"> DOMSelection getSelection();
</span><span class="lines">@@ -125,15 +125,15 @@
</span><span class="cx">
</span><span class="cx"> // Self referential attributes
</span><span class="cx"> [Replaceable, DoNotCheckSecurityOnGetter] readonly attribute DOMWindow self;
</span><del>- [DoNotCheckSecurity] readonly attribute DOMWindow window;
</del><ins>+ [DoNotCheckSecurity, Unforgeable] readonly attribute DOMWindow window;
</ins><span class="cx"> [Replaceable, DoNotCheckSecurityOnGetter] readonly attribute DOMWindow frames;
</span><span class="cx">
</span><span class="cx"> [Replaceable, DoNotCheckSecurityOnGetter] readonly attribute DOMWindow opener;
</span><span class="cx"> [Replaceable, DoNotCheckSecurityOnGetter] readonly attribute DOMWindow parent;
</span><del>- [DoNotCheckSecurityOnGetter] readonly attribute DOMWindow top;
</del><ins>+ [DoNotCheckSecurityOnGetter, Unforgeable] readonly attribute DOMWindow top;
</ins><span class="cx">
</span><span class="cx"> // DOM Level 2 AbstractView Interface
</span><del>- readonly attribute Document document;
</del><ins>+ [Unforgeable] readonly attribute Document document;
</ins><span class="cx">
</span><span class="cx"> // CSSOM View Module
</span><span class="cx"> MediaQueryList matchMedia(DOMString query);
</span></span></pre></div>
<a id="trunkSourceWebCorepageLocationidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Location.idl (189872 => 189873)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Location.idl 2015-09-16 17:38:30 UTC (rev 189872)
+++ trunk/Source/WebCore/page/Location.idl 2015-09-16 17:46:24 UTC (rev 189873)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> JSCustomDefineOwnProperty,
</span><span class="cx"> JSCustomNamedGetterOnPrototype,
</span><span class="cx"> JSCustomDefineOwnPropertyOnPrototype,
</span><del>- OperationsNotDeletable
</del><ins>+ Unforgeable
</ins><span class="cx"> ] interface Location {
</span><span class="cx"> [DoNotCheckSecurityOnSetter, CustomSetter] attribute DOMString href;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>