<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189895] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189895">189895</a></dd>
<dt>Author</dt> <dd>gyuyoung.kim@webkit.org</dd>
<dt>Date</dt> <dd>2015-09-16 20:00:30 -0700 (Wed, 16 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove all uses of PassRefPtr in WebCore/bindings
https://bugs.webkit.org/show_bug.cgi?id=149207
Reviewed by Darin Adler.
If RefPtr<>&& argument is passed to new variable or other function, we use copyRef() or WTF::move().
copyRef() should be used when the argument continues to be used in following code. If it is final use
inside function, we have to use WTF::move().
* bridge/NP_jsobject.cpp:
* bridge/NP_jsobject.h:
* bridge/c/CRuntimeObject.cpp:
(JSC::Bindings::CRuntimeObject::CRuntimeObject):
* bridge/c/CRuntimeObject.h:
(JSC::Bindings::CRuntimeObject::create):
* bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::CInstance):
* bridge/c/c_instance.h:
(JSC::Bindings::CInstance::create):
* bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Array::Array):
(JSC::Bindings::Instance::Instance):
* bridge/jsc/BridgeJSC.h:
* bridge/objc/ObjCRuntimeObject.h:
(JSC::Bindings::ObjCRuntimeObject::create):
* bridge/objc/ObjCRuntimeObject.mm:
(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
* bridge/objc/WebScriptObjectProtocol.h:
* bridge/objc/objc_instance.h:
* bridge/objc/objc_instance.mm:
(ObjcInstance::ObjcInstance):
(ObjcInstance::create):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcArray::ObjcArray):
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::RuntimeObject):
* bridge/runtime_object.h:
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::create):
* bridge/runtime_root.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebridgeNP_jsobjectcpp">trunk/Source/WebCore/bridge/NP_jsobject.cpp</a></li>
<li><a href="#trunkSourceWebCorebridgeNP_jsobjecth">trunk/Source/WebCore/bridge/NP_jsobject.h</a></li>
<li><a href="#trunkSourceWebCorebridgecCRuntimeObjectcpp">trunk/Source/WebCore/bridge/c/CRuntimeObject.cpp</a></li>
<li><a href="#trunkSourceWebCorebridgecCRuntimeObjecth">trunk/Source/WebCore/bridge/c/CRuntimeObject.h</a></li>
<li><a href="#trunkSourceWebCorebridgecc_instancecpp">trunk/Source/WebCore/bridge/c/c_instance.cpp</a></li>
<li><a href="#trunkSourceWebCorebridgecc_instanceh">trunk/Source/WebCore/bridge/c/c_instance.h</a></li>
<li><a href="#trunkSourceWebCorebridgejscBridgeJSCcpp">trunk/Source/WebCore/bridge/jsc/BridgeJSC.cpp</a></li>
<li><a href="#trunkSourceWebCorebridgejscBridgeJSCh">trunk/Source/WebCore/bridge/jsc/BridgeJSC.h</a></li>
<li><a href="#trunkSourceWebCorebridgeobjcObjCRuntimeObjecth">trunk/Source/WebCore/bridge/objc/ObjCRuntimeObject.h</a></li>
<li><a href="#trunkSourceWebCorebridgeobjcObjCRuntimeObjectmm">trunk/Source/WebCore/bridge/objc/ObjCRuntimeObject.mm</a></li>
<li><a href="#trunkSourceWebCorebridgeobjcWebScriptObjectProtocolh">trunk/Source/WebCore/bridge/objc/WebScriptObjectProtocol.h</a></li>
<li><a href="#trunkSourceWebCorebridgeobjcobjc_instanceh">trunk/Source/WebCore/bridge/objc/objc_instance.h</a></li>
<li><a href="#trunkSourceWebCorebridgeobjcobjc_instancemm">trunk/Source/WebCore/bridge/objc/objc_instance.mm</a></li>
<li><a href="#trunkSourceWebCorebridgeobjcobjc_runtimeh">trunk/Source/WebCore/bridge/objc/objc_runtime.h</a></li>
<li><a href="#trunkSourceWebCorebridgeobjcobjc_runtimemm">trunk/Source/WebCore/bridge/objc/objc_runtime.mm</a></li>
<li><a href="#trunkSourceWebCorebridgeruntime_objectcpp">trunk/Source/WebCore/bridge/runtime_object.cpp</a></li>
<li><a href="#trunkSourceWebCorebridgeruntime_objecth">trunk/Source/WebCore/bridge/runtime_object.h</a></li>
<li><a href="#trunkSourceWebCorebridgeruntime_rootcpp">trunk/Source/WebCore/bridge/runtime_root.cpp</a></li>
<li><a href="#trunkSourceWebCorebridgeruntime_rooth">trunk/Source/WebCore/bridge/runtime_root.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/ChangeLog 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -1,3 +1,47 @@
</span><ins>+2015-09-16 Gyuyoung Kim <gyuyoung.kim@webkit.org>
+
+ Remove all uses of PassRefPtr in WebCore/bindings
+ https://bugs.webkit.org/show_bug.cgi?id=149207
+
+ Reviewed by Darin Adler.
+
+ If RefPtr<>&& argument is passed to new variable or other function, we use copyRef() or WTF::move().
+ copyRef() should be used when the argument continues to be used in following code. If it is final use
+ inside function, we have to use WTF::move().
+
+ * bridge/NP_jsobject.cpp:
+ * bridge/NP_jsobject.h:
+ * bridge/c/CRuntimeObject.cpp:
+ (JSC::Bindings::CRuntimeObject::CRuntimeObject):
+ * bridge/c/CRuntimeObject.h:
+ (JSC::Bindings::CRuntimeObject::create):
+ * bridge/c/c_instance.cpp:
+ (JSC::Bindings::CInstance::CInstance):
+ * bridge/c/c_instance.h:
+ (JSC::Bindings::CInstance::create):
+ * bridge/jsc/BridgeJSC.cpp:
+ (JSC::Bindings::Array::Array):
+ (JSC::Bindings::Instance::Instance):
+ * bridge/jsc/BridgeJSC.h:
+ * bridge/objc/ObjCRuntimeObject.h:
+ (JSC::Bindings::ObjCRuntimeObject::create):
+ * bridge/objc/ObjCRuntimeObject.mm:
+ (JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
+ * bridge/objc/WebScriptObjectProtocol.h:
+ * bridge/objc/objc_instance.h:
+ * bridge/objc/objc_instance.mm:
+ (ObjcInstance::ObjcInstance):
+ (ObjcInstance::create):
+ * bridge/objc/objc_runtime.h:
+ * bridge/objc/objc_runtime.mm:
+ (JSC::Bindings::ObjcArray::ObjcArray):
+ * bridge/runtime_object.cpp:
+ (JSC::Bindings::RuntimeObject::RuntimeObject):
+ * bridge/runtime_object.h:
+ * bridge/runtime_root.cpp:
+ (JSC::Bindings::RootObject::create):
+ * bridge/runtime_root.h:
+
</ins><span class="cx"> 2015-09-16 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Element's attribute NS API should defined treat undefined namespace as null
</span></span></pre></div>
<a id="trunkSourceWebCorebridgeNP_jsobjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/NP_jsobject.cpp (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/NP_jsobject.cpp 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/NP_jsobject.cpp 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -141,7 +141,7 @@
</span><span class="cx"> NPClass* NPScriptObjectClass = &javascriptClass;
</span><span class="cx"> static NPClass* NPNoScriptObjectClass = &noScriptClass;
</span><span class="cx">
</span><del>-NPObject* _NPN_CreateScriptObject(NPP npp, JSObject* imp, PassRefPtr<RootObject> rootObject)
</del><ins>+NPObject* _NPN_CreateScriptObject(NPP npp, JSObject* imp, RefPtr<RootObject>&& rootObject)
</ins><span class="cx"> {
</span><span class="cx"> if (NPObject* object = objectMap().get(rootObject.get(), imp))
</span><span class="cx"> return _NPN_RetainObject(object);
</span></span></pre></div>
<a id="trunkSourceWebCorebridgeNP_jsobjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/NP_jsobject.h (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/NP_jsobject.h 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/NP_jsobject.h 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> JSC::Bindings::RootObject* rootObject;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-NPObject* _NPN_CreateScriptObject(NPP npp, JSC::JSObject*, PassRefPtr<JSC::Bindings::RootObject> rootObject);
</del><ins>+NPObject* _NPN_CreateScriptObject(NPP, JSC::JSObject*, RefPtr<JSC::Bindings::RootObject>&&);
</ins><span class="cx"> NPObject* _NPN_CreateNoScriptObject(void);
</span><span class="cx">
</span><span class="cx"> #endif // ENABLE(NETSCAPE_PLUGIN_API)
</span></span></pre></div>
<a id="trunkSourceWebCorebridgecCRuntimeObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/c/CRuntimeObject.cpp (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/c/CRuntimeObject.cpp 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/c/CRuntimeObject.cpp 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -37,8 +37,8 @@
</span><span class="cx">
</span><span class="cx"> const ClassInfo CRuntimeObject::s_info = { "CRuntimeObject", &RuntimeObject::s_info, 0, CREATE_METHOD_TABLE(CRuntimeObject) };
</span><span class="cx">
</span><del>-CRuntimeObject::CRuntimeObject(VM& vm, Structure* structure, PassRefPtr<CInstance> instance)
- : RuntimeObject(vm, structure, instance)
</del><ins>+CRuntimeObject::CRuntimeObject(VM& vm, Structure* structure, RefPtr<CInstance>&& instance)
+ : RuntimeObject(vm, structure, WTF::move(instance))
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebridgecCRuntimeObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/c/CRuntimeObject.h (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/c/CRuntimeObject.h 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/c/CRuntimeObject.h 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -44,9 +44,9 @@
</span><span class="cx"> public:
</span><span class="cx"> typedef RuntimeObject Base;
</span><span class="cx">
</span><del>- static CRuntimeObject* create(VM& vm, Structure* structure, PassRefPtr<CInstance> instance)
</del><ins>+ static CRuntimeObject* create(VM& vm, Structure* structure, RefPtr<CInstance>&& instance)
</ins><span class="cx"> {
</span><del>- CRuntimeObject* object = new (NotNull, allocateCell<CRuntimeObject>(vm.heap)) CRuntimeObject(vm, structure, instance);
</del><ins>+ CRuntimeObject* object = new (NotNull, allocateCell<CRuntimeObject>(vm.heap)) CRuntimeObject(vm, structure, WTF::move(instance));
</ins><span class="cx"> object->finishCreation(vm);
</span><span class="cx"> return object;
</span><span class="cx"> }
</span><span class="lines">@@ -61,7 +61,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- CRuntimeObject(VM&, Structure*, PassRefPtr<CInstance>);
</del><ins>+ CRuntimeObject(VM&, Structure*, RefPtr<CInstance>&&);
</ins><span class="cx"> void finishCreation(VM&);
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebridgecc_instancecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/c/c_instance.cpp (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/c/c_instance.cpp 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/c/c_instance.cpp 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -78,8 +78,8 @@
</span><span class="cx"> globalExceptionString() = String();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-CInstance::CInstance(NPObject* o, PassRefPtr<RootObject> rootObject)
- : Instance(rootObject)
</del><ins>+CInstance::CInstance(NPObject* o, RefPtr<RootObject>&& rootObject)
+ : Instance(WTF::move(rootObject))
</ins><span class="cx"> {
</span><span class="cx"> _object = _NPN_RetainObject(o);
</span><span class="cx"> _class = 0;
</span></span></pre></div>
<a id="trunkSourceWebCorebridgecc_instanceh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/c/c_instance.h (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/c/c_instance.h 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/c/c_instance.h 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -30,7 +30,6 @@
</span><span class="cx">
</span><span class="cx"> #include "BridgeJSC.h"
</span><span class="cx"> #include "runtime_root.h"
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/text/WTFString.h>
</span><span class="cx">
</span><span class="cx"> typedef struct NPObject NPObject;
</span><span class="lines">@@ -43,9 +42,9 @@
</span><span class="cx">
</span><span class="cx"> class CInstance : public Instance {
</span><span class="cx"> public:
</span><del>- static Ref<CInstance> create(NPObject* object, PassRefPtr<RootObject> rootObject)
</del><ins>+ static Ref<CInstance> create(NPObject* object, RefPtr<RootObject>&& rootObject)
</ins><span class="cx"> {
</span><del>- return adoptRef(*new CInstance(object, rootObject));
</del><ins>+ return adoptRef(*new CInstance(object, WTF::move(rootObject)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static void setGlobalException(String);
</span><span class="lines">@@ -75,7 +74,7 @@
</span><span class="cx"> NPObject *getObject() const { return _object; }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- CInstance(NPObject*, PassRefPtr<RootObject>);
</del><ins>+ CInstance(NPObject*, RefPtr<RootObject>&&);
</ins><span class="cx">
</span><span class="cx"> virtual RuntimeObject* newRuntimeObject(ExecState*) override;
</span><span class="cx"> bool toJSPrimitive(ExecState*, const char*, JSValue&) const;
</span></span></pre></div>
<a id="trunkSourceWebCorebridgejscBridgeJSCcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/jsc/BridgeJSC.cpp (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/jsc/BridgeJSC.cpp 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/jsc/BridgeJSC.cpp 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -38,8 +38,8 @@
</span><span class="cx">
</span><span class="cx"> namespace Bindings {
</span><span class="cx">
</span><del>-Array::Array(PassRefPtr<RootObject> rootObject)
- : m_rootObject(rootObject)
</del><ins>+Array::Array(RefPtr<RootObject>&& rootObject)
+ : m_rootObject(WTF::move(rootObject))
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(m_rootObject);
</span><span class="cx"> }
</span><span class="lines">@@ -48,8 +48,8 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Instance::Instance(PassRefPtr<RootObject> rootObject)
- : m_rootObject(rootObject)
</del><ins>+Instance::Instance(RefPtr<RootObject>&& rootObject)
+ : m_rootObject(WTF::move(rootObject))
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(m_rootObject);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebridgejscBridgeJSCh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/jsc/BridgeJSC.h (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/jsc/BridgeJSC.h 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/jsc/BridgeJSC.h 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -70,7 +70,7 @@
</span><span class="cx">
</span><span class="cx"> class Instance : public RefCounted<Instance> {
</span><span class="cx"> public:
</span><del>- WEBCORE_EXPORT Instance(PassRefPtr<RootObject>);
</del><ins>+ WEBCORE_EXPORT Instance(RefPtr<RootObject>&&);
</ins><span class="cx">
</span><span class="cx"> // These functions are called before and after the main entry points into
</span><span class="cx"> // the native implementations. They can be used to establish and cleanup
</span><span class="lines">@@ -121,7 +121,7 @@
</span><span class="cx"> class Array {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(Array);
</span><span class="cx"> public:
</span><del>- Array(PassRefPtr<RootObject>);
</del><ins>+ explicit Array(RefPtr<RootObject>&&);
</ins><span class="cx"> virtual ~Array();
</span><span class="cx">
</span><span class="cx"> virtual void setValueAt(ExecState*, unsigned index, JSValue) const = 0;
</span></span></pre></div>
<a id="trunkSourceWebCorebridgeobjcObjCRuntimeObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/objc/ObjCRuntimeObject.h (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/objc/ObjCRuntimeObject.h 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/objc/ObjCRuntimeObject.h 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -37,9 +37,9 @@
</span><span class="cx"> public:
</span><span class="cx"> typedef RuntimeObject Base;
</span><span class="cx">
</span><del>- static ObjCRuntimeObject* create(VM& vm, Structure* structure, PassRefPtr<ObjcInstance> inst)
</del><ins>+ static ObjCRuntimeObject* create(VM& vm, Structure* structure, RefPtr<ObjcInstance>&& inst)
</ins><span class="cx"> {
</span><del>- ObjCRuntimeObject* object = new (NotNull, allocateCell<ObjCRuntimeObject>(vm.heap)) ObjCRuntimeObject(vm, structure, inst);
</del><ins>+ ObjCRuntimeObject* object = new (NotNull, allocateCell<ObjCRuntimeObject>(vm.heap)) ObjCRuntimeObject(vm, structure, WTF::move(inst));
</ins><span class="cx"> object->finishCreation(vm);
</span><span class="cx"> return object;
</span><span class="cx"> }
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- ObjCRuntimeObject(VM&, Structure*, PassRefPtr<ObjcInstance>);
</del><ins>+ ObjCRuntimeObject(VM&, Structure*, RefPtr<ObjcInstance>&&);
</ins><span class="cx"> void finishCreation(VM&);
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebridgeobjcObjCRuntimeObjectmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/objc/ObjCRuntimeObject.mm (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/objc/ObjCRuntimeObject.mm 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/objc/ObjCRuntimeObject.mm 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx">
</span><span class="cx"> const ClassInfo ObjCRuntimeObject::s_info = { "ObjCRuntimeObject", &RuntimeObject::s_info, 0, CREATE_METHOD_TABLE(ObjCRuntimeObject) };
</span><span class="cx">
</span><del>-ObjCRuntimeObject::ObjCRuntimeObject(VM& vm, Structure* structure, PassRefPtr<ObjcInstance> instance)
</del><ins>+ObjCRuntimeObject::ObjCRuntimeObject(VM& vm, Structure* structure, RefPtr<ObjcInstance>&& instance)
</ins><span class="cx"> : RuntimeObject(vm, structure, instance)
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebridgeobjcWebScriptObjectProtocolh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/objc/WebScriptObjectProtocol.h (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/objc/WebScriptObjectProtocol.h 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/objc/WebScriptObjectProtocol.h 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> + (BOOL)isKeyExcludedFromWebScript:(const char *)name;
</span><span class="cx">
</span><span class="cx"> + (id)_convertValueToObjcValue:(JSC::JSValue)value originRootObject:(JSC::Bindings::RootObject*)originRootObject rootObject:(JSC::Bindings::RootObject*)rootObject;
</span><del>-- (id)_initWithJSObject:(JSC::JSObject*)imp originRootObject:(PassRefPtr<JSC::Bindings::RootObject>)originRootObject rootObject:(PassRefPtr<JSC::Bindings::RootObject>)rootObject;
</del><ins>+- (id)_initWithJSObject:(JSC::JSObject*)imp originRootObject:(RefPtr<JSC::Bindings::RootObject>&&)originRootObject rootObject:(RefPtr<JSC::Bindings::RootObject>&&)rootObject;
</ins><span class="cx"> - (JSC::JSObject *)_imp;
</span><span class="cx"> @end
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebridgeobjcobjc_instanceh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/objc/objc_instance.h (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/objc/objc_instance.h 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/objc/objc_instance.h 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -37,7 +37,7 @@
</span><span class="cx">
</span><span class="cx"> class ObjcInstance : public Instance {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<ObjcInstance> create(ObjectStructPtr, PassRefPtr<RootObject>);
</del><ins>+ static RefPtr<ObjcInstance> create(ObjectStructPtr, RefPtr<RootObject>&&);
</ins><span class="cx"> virtual ~ObjcInstance();
</span><span class="cx">
</span><span class="cx"> static void setGlobalException(NSString*, JSGlobalObject* exceptionEnvironment = 0); // A null exceptionEnvironment means the exception should propogate to any execution environment.
</span><span class="lines">@@ -70,7 +70,7 @@
</span><span class="cx"> friend class ObjcField;
</span><span class="cx"> static void moveGlobalExceptionToExecState(ExecState*);
</span><span class="cx">
</span><del>- ObjcInstance(ObjectStructPtr, PassRefPtr<RootObject>);
</del><ins>+ ObjcInstance(ObjectStructPtr, RefPtr<RootObject>&&);
</ins><span class="cx">
</span><span class="cx"> virtual RuntimeObject* newRuntimeObject(ExecState*);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebridgeobjcobjc_instancemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/objc/objc_instance.mm (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/objc/objc_instance.mm 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/objc/objc_instance.mm 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -101,8 +101,8 @@
</span><span class="cx"> s_exceptionEnvironment = 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-ObjcInstance::ObjcInstance(id instance, PassRefPtr<RootObject> rootObject)
- : Instance(rootObject)
</del><ins>+ObjcInstance::ObjcInstance(id instance, RefPtr<RootObject>&& rootObject)
+ : Instance(WTF::move(rootObject))
</ins><span class="cx"> , _instance(instance)
</span><span class="cx"> , _class(0)
</span><span class="cx"> , _pool(0)
</span><span class="lines">@@ -110,15 +110,15 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<ObjcInstance> ObjcInstance::create(id instance, PassRefPtr<RootObject> rootObject)
</del><ins>+RefPtr<ObjcInstance> ObjcInstance::create(id instance, RefPtr<RootObject>&& rootObject)
</ins><span class="cx"> {
</span><span class="cx"> if (!s_instanceWrapperCache)
</span><span class="cx"> s_instanceWrapperCache = createInstanceWrapperCache();
</span><span class="cx"> if (void* existingWrapper = NSMapGet(s_instanceWrapperCache, instance))
</span><span class="cx"> return static_cast<ObjcInstance*>(existingWrapper);
</span><del>- RefPtr<ObjcInstance> wrapper = adoptRef(new ObjcInstance(instance, rootObject));
</del><ins>+ RefPtr<ObjcInstance> wrapper = adoptRef(new ObjcInstance(instance, WTF::move(rootObject)));
</ins><span class="cx"> NSMapInsert(s_instanceWrapperCache, instance, wrapper.get());
</span><del>- return wrapper.release();
</del><ins>+ return wrapper;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ObjcInstance::~ObjcInstance()
</span></span></pre></div>
<a id="trunkSourceWebCorebridgeobjcobjc_runtimeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/objc/objc_runtime.h (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/objc/objc_runtime.h 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/objc/objc_runtime.h 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx">
</span><span class="cx"> class ObjcArray : public Array {
</span><span class="cx"> public:
</span><del>- ObjcArray(ObjectStructPtr, PassRefPtr<RootObject>);
</del><ins>+ ObjcArray(ObjectStructPtr, RefPtr<RootObject>&&);
</ins><span class="cx">
</span><span class="cx"> virtual void setValueAt(ExecState *exec, unsigned int index, JSValue aValue) const;
</span><span class="cx"> virtual JSValue valueAt(ExecState *exec, unsigned int index) const;
</span></span></pre></div>
<a id="trunkSourceWebCorebridgeobjcobjc_runtimemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/objc/objc_runtime.mm (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/objc/objc_runtime.mm 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/objc/objc_runtime.mm 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -146,8 +146,8 @@
</span><span class="cx">
</span><span class="cx"> // ---------------------- ObjcArray ----------------------
</span><span class="cx">
</span><del>-ObjcArray::ObjcArray(ObjectStructPtr a, PassRefPtr<RootObject> rootObject)
- : Array(rootObject)
</del><ins>+ObjcArray::ObjcArray(ObjectStructPtr a, RefPtr<RootObject>&& rootObject)
+ : Array(WTF::move(rootObject))
</ins><span class="cx"> , _array(a)
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebridgeruntime_objectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/runtime_object.cpp (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/runtime_object.cpp 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/runtime_object.cpp 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -37,9 +37,9 @@
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT const ClassInfo RuntimeObject::s_info = { "RuntimeObject", &Base::s_info, 0, CREATE_METHOD_TABLE(RuntimeObject) };
</span><span class="cx">
</span><del>-RuntimeObject::RuntimeObject(VM& vm, Structure* structure, PassRefPtr<Instance> instance)
</del><ins>+RuntimeObject::RuntimeObject(VM& vm, Structure* structure, RefPtr<Instance>&& instance)
</ins><span class="cx"> : JSDestructibleObject(vm, structure)
</span><del>- , m_instance(instance)
</del><ins>+ , m_instance(WTF::move(instance))
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebridgeruntime_objecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/runtime_object.h (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/runtime_object.h 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/runtime_object.h 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -37,9 +37,9 @@
</span><span class="cx"> typedef JSDestructibleObject Base;
</span><span class="cx"> static const unsigned StructureFlags = Base::StructureFlags | OverridesGetOwnPropertySlot | OverridesGetPropertyNames | TypeOfShouldCallGetCallData;
</span><span class="cx">
</span><del>- static RuntimeObject* create(VM& vm, Structure* structure, PassRefPtr<Instance> instance)
</del><ins>+ static RuntimeObject* create(VM& vm, Structure* structure, RefPtr<Instance>&& instance)
</ins><span class="cx"> {
</span><del>- RuntimeObject* object = new (NotNull, allocateCell<RuntimeObject>(vm.heap)) RuntimeObject(vm, structure, instance);
</del><ins>+ RuntimeObject* object = new (NotNull, allocateCell<RuntimeObject>(vm.heap)) RuntimeObject(vm, structure, WTF::move(instance));
</ins><span class="cx"> object->finishCreation(vm);
</span><span class="cx"> return object;
</span><span class="cx"> }
</span><span class="lines">@@ -74,7 +74,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- RuntimeObject(VM&, Structure*, PassRefPtr<Instance>);
</del><ins>+ RuntimeObject(VM&, Structure*, RefPtr<Instance>&&);
</ins><span class="cx"> void finishCreation(VM&);
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCorebridgeruntime_rootcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/runtime_root.cpp (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/runtime_root.cpp 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/runtime_root.cpp 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -80,9 +80,9 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<RootObject> RootObject::create(const void* nativeHandle, JSGlobalObject* globalObject)
</del><ins>+Ref<RootObject> RootObject::create(const void* nativeHandle, JSGlobalObject* globalObject)
</ins><span class="cx"> {
</span><del>- return adoptRef(new RootObject(nativeHandle, globalObject));
</del><ins>+ return adoptRef(*new RootObject(nativeHandle, globalObject));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RootObject::RootObject(const void* nativeHandle, JSGlobalObject* globalObject)
</span></span></pre></div>
<a id="trunkSourceWebCorebridgeruntime_rooth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bridge/runtime_root.h (189894 => 189895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bridge/runtime_root.h 2015-09-17 01:35:33 UTC (rev 189894)
+++ trunk/Source/WebCore/bridge/runtime_root.h 2015-09-17 03:00:30 UTC (rev 189895)
</span><span class="lines">@@ -33,7 +33,6 @@
</span><span class="cx"> #include <wtf/HashCountedSet.h>
</span><span class="cx"> #include <wtf/HashSet.h>
</span><span class="cx"> #include <wtf/Noncopyable.h>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx">
</span><span class="cx"> namespace JSC {
</span><span class="lines">@@ -57,7 +56,7 @@
</span><span class="cx"> public:
</span><span class="cx"> WEBCORE_EXPORT virtual ~RootObject();
</span><span class="cx">
</span><del>- static PassRefPtr<RootObject> create(const void* nativeHandle, JSGlobalObject*);
</del><ins>+ static Ref<RootObject> create(const void* nativeHandle, JSGlobalObject*);
</ins><span class="cx">
</span><span class="cx"> bool isValid() { return m_isValid; }
</span><span class="cx"> void invalidate();
</span></span></pre>
</div>
</div>
</body>
</html>