<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189902] branches/safari-601.1.46-branch</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189902">189902</a></dd>
<dt>Author</dt> <dd>bshafiei@apple.com</dd>
<dt>Date</dt> <dd>2015-09-16 21:40:25 -0700 (Wed, 16 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merged <a href="http://trac.webkit.org/projects/webkit/changeset/189862">r189862</a>. rdar://problem/22710613</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari601146branchLayoutTestsChangeLog">branches/safari-601.1.46-branch/LayoutTests/ChangeLog</a></li>
<li><a href="#branchessafari601146branchSourceWebCoreChangeLog">branches/safari-601.1.46-branch/Source/WebCore/ChangeLog</a></li>
<li><a href="#branchessafari601146branchSourceWebCoreaccessibilityAccessibilityObjectcpp">branches/safari-601.1.46-branch/Source/WebCore/accessibility/AccessibilityObject.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#branchessafari601146branchLayoutTestsaccessibilityaxvaluewithsearchexpectedtxt">branches/safari-601.1.46-branch/LayoutTests/accessibility/ax-value-with-search-expected.txt</a></li>
<li><a href="#branchessafari601146branchLayoutTestsaccessibilityaxvaluewithsearchhtml">branches/safari-601.1.46-branch/LayoutTests/accessibility/ax-value-with-search.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari601146branchLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-601.1.46-branch/LayoutTests/ChangeLog (189901 => 189902)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-09-17 04:27:46 UTC (rev 189901)
+++ branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-09-17 04:40:25 UTC (rev 189902)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-09-16 Babak Shafiei <bshafiei@apple.com>
+
+ Merge r189862.
+
+ 2015-09-16 Chris Fleizach <cfleizach@apple.com>
+
+ AX: No VO typing feedback in some text fields
+ https://bugs.webkit.org/show_bug.cgi?id=149177
+
+ Reviewed by Mario Sanchez Prada.
+
+ * accessibility/ax-value-with-search-expected.txt: Added.
+ * accessibility/ax-value-with-search.html: Added.
+
</ins><span class="cx"> 2015-09-10 Babak Shafiei <bshafiei@apple.com>
</span><span class="cx">
</span><span class="cx"> Merge r189469.
</span></span></pre></div>
<a id="branchessafari601146branchLayoutTestsaccessibilityaxvaluewithsearchexpectedtxtfromrev189862trunkLayoutTestsaccessibilityaxvaluewithsearchexpectedtxt"></a>
<div class="copfile"><h4>Copied: branches/safari-601.1.46-branch/LayoutTests/accessibility/ax-value-with-search-expected.txt (from rev 189862, trunk/LayoutTests/accessibility/ax-value-with-search-expected.txt) (0 => 189902)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601.1.46-branch/LayoutTests/accessibility/ax-value-with-search-expected.txt (rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/accessibility/ax-value-with-search-expected.txt 2015-09-17 04:40:25 UTC (rev 189902)
</span><span class="lines">@@ -0,0 +1,12 @@
</span><ins>+
+This tests that a search field is returns its accessibilityValue correctly.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS search.stringValue is 'AXValue: hello'
+PASS search.stringValue is 'AXValue: test'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="branchessafari601146branchLayoutTestsaccessibilityaxvaluewithsearchhtmlfromrev189862trunkLayoutTestsaccessibilityaxvaluewithsearchhtml"></a>
<div class="copfile"><h4>Copied: branches/safari-601.1.46-branch/LayoutTests/accessibility/ax-value-with-search.html (from rev 189862, trunk/LayoutTests/accessibility/ax-value-with-search.html) (0 => 189902)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601.1.46-branch/LayoutTests/accessibility/ax-value-with-search.html (rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/accessibility/ax-value-with-search.html 2015-09-17 04:40:25 UTC (rev 189902)
</span><span class="lines">@@ -0,0 +1,29 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+
+<input type="search" value="hello" id="search">
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests that a search field is returns its accessibilityValue correctly.");
+
+ if (window.accessibilityController) {
+
+ var search = accessibilityController.accessibleElementById("search");
+ shouldBe("search.stringValue", "'AXValue: hello'");
+ document.getElementById('search').value = 'test';
+ shouldBe("search.stringValue", "'AXValue: test'");
+ }
+
+</script>
+
+<script src="../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="branchessafari601146branchSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (189901 => 189902)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog 2015-09-17 04:27:46 UTC (rev 189901)
+++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog 2015-09-17 04:40:25 UTC (rev 189902)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2015-09-16 Babak Shafiei <bshafiei@apple.com>
+
+ Merge r189862.
+
+ 2015-09-16 Chris Fleizach <cfleizach@apple.com>
+
+ AX: No VoiceOver typing feedback in some search fields
+ https://bugs.webkit.org/show_bug.cgi?id=149177
+
+ Reviewed by Mario Sanchez Prada.
+
+ If SearchFieldRole is not marked as a TextControl, it does not end up returning the accessibilityValue,
+ which is needed to output the right text to VoiceOver.
+
+ Test: accessibility/ax-value-with-search.html
+
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::isTextControl):
+
</ins><span class="cx"> 2015-09-10 Babak Shafiei <bshafiei@apple.com>
</span><span class="cx">
</span><span class="cx"> Merge r189469.
</span></span></pre></div>
<a id="branchessafari601146branchSourceWebCoreaccessibilityAccessibilityObjectcpp"></a>
<div class="modfile"><h4>Modified: branches/safari-601.1.46-branch/Source/WebCore/accessibility/AccessibilityObject.cpp (189901 => 189902)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-601.1.46-branch/Source/WebCore/accessibility/AccessibilityObject.cpp 2015-09-17 04:27:46 UTC (rev 189901)
+++ branches/safari-601.1.46-branch/Source/WebCore/accessibility/AccessibilityObject.cpp 2015-09-17 04:40:25 UTC (rev 189902)
</span><span class="lines">@@ -376,9 +376,10 @@
</span><span class="cx"> bool AccessibilityObject::isTextControl() const
</span><span class="cx"> {
</span><span class="cx"> switch (roleValue()) {
</span><ins>+ case ComboBoxRole:
+ case SearchFieldRole:
</ins><span class="cx"> case TextAreaRole:
</span><span class="cx"> case TextFieldRole:
</span><del>- case ComboBoxRole:
</del><span class="cx"> return true;
</span><span class="cx"> default:
</span><span class="cx"> return false;
</span></span></pre>
</div>
</div>
</body>
</html>