<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189827] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189827">189827</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-09-15 15:10:54 -0700 (Tue, 15 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>new Event() without parameter should throw
https://bugs.webkit.org/show_bug.cgi?id=149146
<rdar://problem/22565070>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that a new check is passing.
* web-platform-tests/dom/events/Event-constructors-expected.txt:
Source/WebCore:
new Event() without parameter should throw because the type parameter
is mandatory as per the specification:
https://dom.spec.whatwg.org/#interface-event
Both Firefox and Chrome throw in this case. However, WebKit was
creating an event whose type is the string "undefined". This patch
aligns our behavior with the specification and other major browsers.
No new tests, already covered by existing test.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomconstructedobjectsprototypesexpectedtxt">trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomeventsEventconstructorsexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-constructors-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestEventConstructorcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsfastdomconstructedobjectsprototypesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt (189826 => 189827)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt 2015-09-15 21:50:18 UTC (rev 189826)
+++ trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt 2015-09-15 22:10:54 UTC (rev 189827)
</span><span class="lines">@@ -9,10 +9,6 @@
</span><span class="cx"> PASS (new inner.MediaController()).constructor.isInner is true
</span><span class="cx"> PASS (new inner.Option()).isInner is true
</span><span class="cx"> PASS (new inner.Option()).constructor.isInner is true
</span><del>-PASS (new inner.OverflowEvent()).isInner is true
-PASS (new inner.OverflowEvent()).constructor.isInner is true
-PASS (new inner.ProgressEvent()).isInner is true
-PASS (new inner.ProgressEvent()).constructor.isInner is true
</del><span class="cx"> PASS (new inner.URL('about:blank')).isInner is true
</span><span class="cx"> PASS (new inner.URL('about:blank')).constructor.isInner is true
</span><span class="cx"> PASS (new inner.XMLHttpRequest()).isInner is true
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (189826 => 189827)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2015-09-15 21:50:18 UTC (rev 189826)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2015-09-15 22:10:54 UTC (rev 189827)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2015-09-15 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ new Event() without parameter should throw
+ https://bugs.webkit.org/show_bug.cgi?id=149146
+ <rdar://problem/22565070>
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline W3C test now that a new check is passing.
+
+ * web-platform-tests/dom/events/Event-constructors-expected.txt:
+
+2015-09-15 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Element.getAttributeNS() should return null if the attribute does not exist
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149180
</span><span class="cx"> <rdar://problem/22561011>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomeventsEventconstructorsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-constructors-expected.txt (189826 => 189827)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-constructors-expected.txt 2015-09-15 21:50:18 UTC (rev 189826)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-constructors-expected.txt 2015-09-15 22:10:54 UTC (rev 189827)
</span><span class="lines">@@ -1,7 +1,5 @@
</span><span class="cx">
</span><del>-FAIL Event constructors assert_throws: function "function () {
- new Event()
- }" did not throw
</del><ins>+PASS Event constructors
</ins><span class="cx"> PASS Event constructors 1
</span><span class="cx"> FAIL Event constructors 2 assert_equals: expected (boolean) false but got (undefined) undefined
</span><span class="cx"> FAIL Event constructors 3 assert_equals: expected (boolean) false but got (undefined) undefined
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (189826 => 189827)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-15 21:50:18 UTC (rev 189826)
+++ trunk/Source/WebCore/ChangeLog 2015-09-15 22:10:54 UTC (rev 189827)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2015-09-15 Chris Dumez <cdumez@apple.com>
+
+ new Event() without parameter should throw
+ https://bugs.webkit.org/show_bug.cgi?id=149146
+ <rdar://problem/22565070>
+
+ Reviewed by Ryosuke Niwa.
+
+ new Event() without parameter should throw because the type parameter
+ is mandatory as per the specification:
+ https://dom.spec.whatwg.org/#interface-event
+
+ Both Firefox and Chrome throw in this case. However, WebKit was
+ creating an event whose type is the string "undefined". This patch
+ aligns our behavior with the specification and other major browsers.
+
+ No new tests, already covered by existing test.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateConstructorDefinition):
+ * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
+ (WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):
+
</ins><span class="cx"> 2015-09-15 Carlos Alberto Lopez Perez <clopez@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Build failure with ACCELERATED_2D_CANVAS when cairo-gl has built with OpenGLESv2 support only.
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (189826 => 189827)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-09-15 21:50:18 UTC (rev 189826)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-09-15 22:10:54 UTC (rev 189827)
</span><span class="lines">@@ -4656,6 +4656,9 @@
</span><span class="cx"> if (!executionContext)
</span><span class="cx"> return throwVMError(exec, createReferenceError(exec, "Constructor associated execution context is unavailable"));
</span><span class="cx">
</span><ins>+ if (UNLIKELY(exec->argumentCount() < 1))
+ return throwVMError(exec, createNotEnoughArgumentsError(exec));
+
</ins><span class="cx"> AtomicString eventType = exec->argument(0).toString(exec)->toAtomicString(exec);
</span><span class="cx"> if (UNLIKELY(exec->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestEventConstructorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp (189826 => 189827)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp 2015-09-15 21:50:18 UTC (rev 189826)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp 2015-09-15 22:10:54 UTC (rev 189827)
</span><span class="lines">@@ -96,6 +96,9 @@
</span><span class="cx"> if (!executionContext)
</span><span class="cx"> return throwVMError(exec, createReferenceError(exec, "Constructor associated execution context is unavailable"));
</span><span class="cx">
</span><ins>+ if (UNLIKELY(exec->argumentCount() < 1))
+ return throwVMError(exec, createNotEnoughArgumentsError(exec));
+
</ins><span class="cx"> AtomicString eventType = exec->argument(0).toString(exec)->toAtomicString(exec);
</span><span class="cx"> if (UNLIKELY(exec->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span></span></pre>
</div>
</div>
</body>
</html>