<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189688] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189688">189688</a></dd>
<dt>Author</dt> <dd>calvaris@igalia.com</dd>
<dt>Date</dt> <dd>2015-09-14 00:56:27 -0700 (Mon, 14 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Streams API] Add tests about abort on writable streams
https://bugs.webkit.org/show_bug.cgi?id=148298
Reviewed by Darin Adler.
* streams/reference-implementation/writable-stream-abort-expected.txt: Added.
* streams/reference-implementation/writable-stream-abort.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationwritablestreamabortexpectedtxt">trunk/LayoutTests/streams/reference-implementation/writable-stream-abort-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationwritablestreamaborthtml">trunk/LayoutTests/streams/reference-implementation/writable-stream-abort.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (189687 => 189688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-14 07:55:00 UTC (rev 189687)
+++ trunk/LayoutTests/ChangeLog 2015-09-14 07:56:27 UTC (rev 189688)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2015-09-14 Xabier Rodriguez Calvar <calvaris@igalia.com>
</span><span class="cx">
</span><ins>+ [Streams API] Add tests about abort on writable streams
+ https://bugs.webkit.org/show_bug.cgi?id=148298
+
+ Reviewed by Darin Adler.
+
+ * streams/reference-implementation/writable-stream-abort-expected.txt: Added.
+ * streams/reference-implementation/writable-stream-abort.html: Added.
+
+2015-09-14 Xabier Rodriguez Calvar <calvaris@igalia.com>
+
</ins><span class="cx"> [Streams API] Add general writable streams tests
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=148299
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationwritablestreamabortexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/streams/reference-implementation/writable-stream-abort-expected.txt (0 => 189688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/writable-stream-abort-expected.txt (rev 0)
+++ trunk/LayoutTests/streams/reference-implementation/writable-stream-abort-expected.txt 2015-09-14 07:56:27 UTC (rev 189688)
</span><span class="lines">@@ -0,0 +1,14 @@
</span><ins>+
+FAIL Aborting a WritableStream immediately prevents future writes Can't find variable: WritableStream
+FAIL Aborting a WritableStream prevents further writes after any that are in progress Can't find variable: WritableStream
+FAIL Fulfillment value of ws.abort() call must be undefined even if the underlying sink returns a non-undefined value Can't find variable: WritableStream
+FAIL WritableStream if sink's abort throws, the promise returned by ws.abort() rejects Can't find variable: WritableStream
+FAIL Aborting a WritableStream passes through the given reason Can't find variable: WritableStream
+FAIL Aborting a WritableStream puts it in an errored state, with stored error equal to the abort reason Can't find variable: WritableStream
+FAIL Aborting a WritableStream causes any outstanding ready promises to be fulfilled immediately Can't find variable: WritableStream
+FAIL Aborting a WritableStream causes any outstanding write() promises to be rejected with the abort reason Can't find variable: WritableStream
+FAIL Closing but then immediately aborting a WritableStream causes the stream to error Can't find variable: WritableStream
+FAIL Closing a WritableStream and aborting it while it closes causes the stream to error Can't find variable: WritableStream
+FAIL Aborting a WritableStream after it is closed is a no-op Can't find variable: WritableStream
+FAIL WritableStream should call underlying sink's close if no abort is supplied Can't find variable: WritableStream
+
</ins></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationwritablestreamaborthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/streams/reference-implementation/writable-stream-abort.html (0 => 189688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/writable-stream-abort.html (rev 0)
+++ trunk/LayoutTests/streams/reference-implementation/writable-stream-abort.html 2015-09-14 07:56:27 UTC (rev 189688)
</span><span class="lines">@@ -0,0 +1,262 @@
</span><ins>+<!DOCTYPE html>
+<script src='../../resources/testharness.js'></script>
+<script src='../../resources/testharnessreport.js'></script>
+<script src='resources/streams-utils.js'></script>
+<script>
+var test1 = async_test('Aborting a WritableStream immediately prevents future writes');
+test1.step(function() {
+ var chunks = [];
+ var ws = new WritableStream({
+ write: function(chunk) {
+ chunks.push(chunk);
+ }
+ });
+
+ setTimeout(test1.step_func(function() {
+ ws.abort();
+ ws.write(1);
+ ws.write(2);
+ assert_array_equals(chunks, [], 'no chunks are written');
+ test1.done();
+ }), 0);
+});
+
+var test2 = async_test('Aborting a WritableStream prevents further writes after any that are in progress');
+test2.step(function() {
+ var chunks = [];
+ var ws = new WritableStream({
+ write: function(chunk) {
+ chunks.push(chunk);
+ return new Promise(test2.step_func(function(resolve) { setTimeout(test2.step_func(function() { resolve(); }), 200); }));
+ }
+ });
+
+ setTimeout(test2.step_func(function() {
+ ws.write(1);
+ ws.write(2);
+ ws.write(3);
+ ws.abort();
+ ws.write(4);
+ ws.write(5);
+
+ setTimeout(test2.step_func(function () {
+ assert_array_equals(chunks, [1], 'only the single in-progress chunk gets written');
+ test2.done();
+ }), 500);
+ }), 0);
+});
+
+var test3 = async_test('Fulfillment value of ws.abort() call must be undefined even if the underlying sink returns a non-undefined value');
+test3.step(function() {
+ var ws = new WritableStream({
+ abort: function() {
+ return 'Hello';
+ }
+ });
+
+ var abortPromise = ws.abort('a');
+ abortPromise.then(test3.step_func(function(value) {
+ assert_equals(value, undefined, 'fulfillment value must be undefined');
+ test3.done();
+ })).catch(test3.step_func(function() { assert_unreached('abortPromise is rejected'); }));
+});
+
+var test4 = async_test('WritableStream if sink\'s abort throws, the promise returned by ws.abort() rejects');
+test4.step(function() {
+ var errorInSinkAbort = new Error('Sorry, it just wasn\'t meant to be.');
+ var ws = new WritableStream({
+ abort: function() {
+ throw errorInSinkAbort;
+ }
+ });
+
+ var abortPromise = ws.abort(undefined);
+ abortPromise.then(
+ test4.step_func(function() { assert_unreached('abortPromise is fulfilled unexpectedly'); }),
+ test4.step_func(function(r) {
+ assert_equals(r, errorInSinkAbort, 'rejection reason of abortPromise must be errorInSinkAbort');
+ test4.done();
+ })
+ );
+});
+
+test(function() {
+ var recordedReason;
+ var ws = new WritableStream({
+ abort: function(reason) {
+ recordedReason = reason;
+ }
+ });
+
+ var passedReason = new Error('Sorry, it just wasn\'t meant to be.');
+ ws.abort(passedReason);
+
+ assert_equals(recordedReason, passedReason);
+}, 'Aborting a WritableStream passes through the given reason');
+
+var test5 = async_test('Aborting a WritableStream puts it in an errored state, with stored error equal to the abort reason');
+test5.step(function() {
+ var events = 0;
+ var recordedReason;
+ var ws = new WritableStream();
+
+ var passedReason = new Error('Sorry, it just wasn\'t meant to be.');
+ ws.abort(passedReason);
+
+ assert_equals(ws.state, 'errored', 'state should be errored');
+
+ ws.write().then(
+ test5.step_func(function() { assert_unreached('writing should not succeed'); }),
+ test5.step_func(function(r) {
+ assert_equals(r, passedReason, 'writing should reject with the given reason');
+ assert_equals(++events, 1);
+ })
+ );
+
+ ws.close().then(
+ test5.step_func(function() { assert_unreached('closing should not succeed'); }),
+ test5.step_func(function(r) {
+ assert_equals(r, passedReason, 'closing should reject with the given reason');
+ assert_equals(++events, 2);
+ })
+ );
+
+ ws.abort().then(
+ test5.step_func(function() { assert_unreached('aborting a second time should not succeed'); }),
+ test5.step_func(function(r) {
+ assert_equals(r, passedReason, 'aborting a second time should reject with the given reason');
+ assert_equals(++events, 3);
+ })
+ );
+
+ ws.closed.then(
+ test5.step_func(function() { assert_unreached('closed promise should not be fulfilled'); }),
+ test5.step_func(function(r) {
+ assert_equals(r, passedReason, 'closed promise should be rejected with the given reason');
+ assert_equals(++events, 4);
+ test5.done();
+ })
+ );
+});
+
+var test6 = async_test('Aborting a WritableStream causes any outstanding ready promises to be fulfilled immediately');
+test6.step(function() {
+ var writeCalled = false;
+ var recordedReason;
+ var ws = new WritableStream({
+ write: function(chunk) {
+ writeCalled = true;
+ return new Promise(test6.step_func(function() { })); // forever-pending, so normally .ready would not fulfill.
+ }
+ });
+ ws.write('a');
+ assert_equals(ws.state, 'waiting', 'state should be waiting');
+
+ ws.ready.then(test6.step_func(function() {
+ assert_equals(ws.state, 'errored', 'state should now be errored');
+ assert_false(writeCalled);
+ test6.done();
+ }));
+
+ var passedReason = new Error('Sorry, it just wasn\'t meant to be.');
+ ws.abort(passedReason);
+});
+
+var test7 = async_test('Aborting a WritableStream causes any outstanding write() promises to be rejected with the abort reason');
+test7.step(function() {
+ var ws = new WritableStream();
+
+ ws.write('a').then(
+ test7.step_func(function() { assert_unreached('writing should not succeed'); }),
+ test7.step_func(function(r) {
+ assert_equals(r, passedReason, 'writing should reject with the given reason');
+ test7.done();
+ })
+ );
+
+ var passedReason = new Error('Sorry, it just wasn\'t meant to be.');
+ ws.abort(passedReason);
+});
+
+var test8 = async_test('Closing but then immediately aborting a WritableStream causes the stream to error');
+test8.step(function() {
+ var ws = new WritableStream();
+
+ ws.close();
+
+ var passedReason = new Error('Sorry, it just wasn\'t meant to be.');
+ ws.abort(passedReason);
+
+ assert_equals(ws.state, 'errored');
+
+ ws.closed.then(
+ test8.step_func(function() { assert_unreached('the stream should not close successfully'); }),
+ test8.step_func(function(r) {
+ assert_equals(r, passedReason, 'the stream should be errored with the given reason');
+ test8.done();
+ })
+ );
+});
+
+var test9 = async_test('Closing a WritableStream and aborting it while it closes causes the stream to error');
+test9.step(function() {
+ var ws = new WritableStream({
+ close: function() {
+ return new Promise(test9.step_func(function() { })); // forever-pending
+ }
+ });
+
+ ws.close();
+
+ var passedReason = new Error('Sorry, it just wasn\'t meant to be.');
+
+ setTimeout(test9.step_func(function() {
+ assert_equals(ws.state, 'closing');
+
+ ws.abort(passedReason);
+
+ assert_equals(ws.state, 'errored');
+ }), 200);
+
+ ws.closed.then(
+ test9.step_func(function() { assert_unreached('the stream should not close successfully'); }),
+ test9.step_func(function(r) {
+ assert_equals(r, passedReason, 'the stream should be errored with the given reason');
+ test9.done();
+ })
+ );
+});
+
+var test10 = async_test('Aborting a WritableStream after it is closed is a no-op');
+test10.step(function() {
+ var ws = new WritableStream();
+
+ ws.close();
+
+ setTimeout(test10.step_func(function() {
+ assert_equals(ws.state, 'closed');
+
+ ws.abort().then(
+ test10.step_func(function(v) {
+ assert_equals(v, undefined, 'abort promise should fulfill with undefined');
+ test10.done();
+ }),
+ test10.step_func(assert_unreached)
+ );
+
+ assert_equals(ws.state, 'closed', 'state stays closed');
+ }), 0);
+});
+
+var test11 = async_test('WritableStream should call underlying sink\'s close if no abort is supplied');
+test11.step(function() {
+ var ws = new WritableStream({
+ close: function() {
+ assert_equals(arguments.length, 0, 'close() was called (with no arguments)');
+ test11.done();
+ }
+ });
+
+ ws.abort();
+});
+</script>
</ins></span></pre>
</div>
</div>
</body>
</html>