<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189721] releases/WebKitGTK/webkit-2.10</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189721">189721</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-09-14 05:48:44 -0700 (Mon, 14 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/189060">r189060</a> - Page does not update when <link> media attribute changes to no longer apply to page
https://bugs.webkit.org/show_bug.cgi?id=148392
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/css/link-media-attr.html
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseAttribute):
When the media attribute changes, recalculate styles if the link is not disabled.
LayoutTests:
* fast/css/link-media-attr-expected.txt: Added.
* fast/css/link-media-attr.html: Added.
Add a test to verify that styles change after a link's media attribute changes.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit210SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit210SourceWebCorehtmlHTMLLinkElementcpp">releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLLinkElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestsfastcsslinkmediaattrexpectedtxt">releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/link-media-attr-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestsfastcsslinkmediaattrhtml">releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/link-media-attr.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit210LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog (189720 => 189721)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog        2015-09-14 12:47:35 UTC (rev 189720)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog        2015-09-14 12:48:44 UTC (rev 189721)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-08-27 Joseph Pecoraro <pecoraro@apple.com>
+
+ Page does not update when <link> media attribute changes to no longer apply to page
+ https://bugs.webkit.org/show_bug.cgi?id=148392
+
+ Reviewed by Antti Koivisto.
+
+ * fast/css/link-media-attr-expected.txt: Added.
+ * fast/css/link-media-attr.html: Added.
+ Add a test to verify that styles change after a link's media attribute changes.
+
</ins><span class="cx"> 2015-08-27 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Simple line layout: Text jumps sometimes on naughty strings page
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit210LayoutTestsfastcsslinkmediaattrexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/link-media-attr-expected.txt (0 => 189721)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/link-media-attr-expected.txt         (rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/link-media-attr-expected.txt        2015-09-14 12:48:44 UTC (rev 189721)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+Modifying the media attribute of a link element to apply / unapply to the page should recalc styles
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS link.media is "print"
+PASS link.disabled is false
+PASS getComputedStyle(target).color is "rgb(0, 0, 0)"
+link.media = "screen"
+PASS link.media is "screen"
+PASS link.disabled is false
+PASS getComputedStyle(target).color is "rgb(255, 0, 0)"
+link.media = "screen,screen"
+PASS link.media is "screen,screen"
+PASS link.disabled is false
+PASS getComputedStyle(target).color is "rgb(255, 0, 0)"
+link.media = "print"
+PASS link.media is "print"
+PASS link.disabled is false
+PASS getComputedStyle(target).color is "rgb(0, 0, 0)"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit210LayoutTestsfastcsslinkmediaattrhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/link-media-attr.html (0 => 189721)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/link-media-attr.html         (rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/fast/css/link-media-attr.html        2015-09-14 12:48:44 UTC (rev 189721)
</span><span class="lines">@@ -0,0 +1,43 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<link id="link" rel="stylesheet" href="data:text/css,#target{color:red}" media="print">
+<script src="../../resources/js-test-pre.js"></script>
+</head>
+<body>
+<span id="target"></span>
+<script>
+description("Modifying the media attribute of a link element to apply / unapply to the page should recalc styles");
+
+window.jsTestIsAsync = true;
+
+link = document.getElementById("link");
+target = document.getElementById("target");
+
+window.addEventListener("load", function() {
+ shouldBeEqualToString("link.media", "print");
+ shouldBeFalse("link.disabled");
+ shouldBeEqualToString("getComputedStyle(target).color", "rgb(0, 0, 0)");
+
+ evalAndLog('link.media = "screen"');
+ shouldBeEqualToString("link.media", "screen");
+ shouldBeFalse("link.disabled");
+ shouldBeEqualToString("getComputedStyle(target).color", "rgb(255, 0, 0)");
+
+ evalAndLog('link.media = "screen,screen"');
+ shouldBeEqualToString("link.media", "screen,screen");
+ shouldBeFalse("link.disabled");
+ shouldBeEqualToString("getComputedStyle(target).color", "rgb(255, 0, 0)");
+
+ evalAndLog('link.media = "print"');
+ shouldBeEqualToString("link.media", "print");
+ shouldBeFalse("link.disabled");
+ shouldBeEqualToString("getComputedStyle(target).color", "rgb(0, 0, 0)");
+
+ finishJSTest();
+});
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit210SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (189720 => 189721)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog        2015-09-14 12:47:35 UTC (rev 189720)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog        2015-09-14 12:48:44 UTC (rev 189721)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-08-27 Joseph Pecoraro <pecoraro@apple.com>
+
+ Page does not update when <link> media attribute changes to no longer apply to page
+ https://bugs.webkit.org/show_bug.cgi?id=148392
+
+ Reviewed by Antti Koivisto.
+
+ Test: fast/css/link-media-attr.html
+
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::parseAttribute):
+ When the media attribute changes, recalculate styles if the link is not disabled.
+
</ins><span class="cx"> 2015-08-27 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Simple line layout: Text jumps sometimes on naughty strings page
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit210SourceWebCorehtmlHTMLLinkElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLLinkElement.cpp (189720 => 189721)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLLinkElement.cpp        2015-09-14 12:47:35 UTC (rev 189720)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLLinkElement.cpp        2015-09-14 12:48:44 UTC (rev 189721)
</span><span class="lines">@@ -166,6 +166,8 @@
</span><span class="cx"> if (name == mediaAttr) {
</span><span class="cx"> m_media = value.string().lower();
</span><span class="cx"> process();
</span><ins>+ if (m_sheet && !isDisabled())
+ document().styleResolverChanged(DeferRecalcStyle);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> if (name == disabledAttr) {
</span></span></pre>
</div>
</div>
</body>
</html>