<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189686] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189686">189686</a></dd>
<dt>Author</dt> <dd>calvaris@igalia.com</dd>
<dt>Date</dt> <dd>2015-09-14 00:53:04 -0700 (Mon, 14 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Streams API] Add general writable streams tests
https://bugs.webkit.org/show_bug.cgi?id=148299
Reviewed by Darin Adler.
* streams/reference-implementation/writable-stream-expected.txt: Added.
* streams/reference-implementation/writable-stream.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationwritablestreamexpectedtxt">trunk/LayoutTests/streams/reference-implementation/writable-stream-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstreamsreferenceimplementationwritablestreamhtml">trunk/LayoutTests/streams/reference-implementation/writable-stream.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (189685 => 189686)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-14 07:51:37 UTC (rev 189685)
+++ trunk/LayoutTests/ChangeLog 2015-09-14 07:53:04 UTC (rev 189686)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-09-14 Xabier Rodriguez Calvar <calvaris@igalia.com>
+
+ [Streams API] Add general writable streams tests
+ https://bugs.webkit.org/show_bug.cgi?id=148299
+
+ Reviewed by Darin Adler.
+
+ * streams/reference-implementation/writable-stream-expected.txt: Added.
+ * streams/reference-implementation/writable-stream.html: Added.
+
</ins><span class="cx"> 2015-09-14 ChangSeok Oh <changseok.oh@collabora.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Layout Test media/video-volume-slider.html is flaky
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationwritablestreamexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/streams/reference-implementation/writable-stream-expected.txt (0 => 189686)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/writable-stream-expected.txt (rev 0)
+++ trunk/LayoutTests/streams/reference-implementation/writable-stream-expected.txt 2015-09-14 07:53:04 UTC (rev 189686)
</span><span class="lines">@@ -0,0 +1,14 @@
</span><ins>+
+FAIL error argument is given to start method Can't find variable: WritableStream
+FAIL Underlying sink's write won't be called until start finishes Can't find variable: WritableStream
+FAIL Underlying sink's close won't be called until start finishes Can't find variable: WritableStream
+FAIL Fulfillment value of ws.close() call must be undefined even if the underlying sink returns a non-undefined value Can't find variable: WritableStream
+FAIL Underlying sink's write or close are never invoked if start throws assert_equals: expected object "Error: horrible things" but got object "ReferenceError: Can't find variable: WritableStream"
+FAIL Underlying sink's write or close are never invoked if the promise returned by start is rejected Can't find variable: WritableStream
+FAIL WritableStream can be constructed with no arguments Can't find variable: WritableStream
+FAIL WritableStream instances have the correct methods and properties Can't find variable: WritableStream
+FAIL WritableStream with simple input, processed asynchronously Can't find variable: WritableStream
+FAIL WritableStream with simple input, processed synchronously Can't find variable: WritableStream
+FAIL WritableStream is writable and ready fulfills immediately if the strategy does not apply backpressure Can't find variable: WritableStream
+FAIL Fulfillment value of ws.write() call must be undefined even if the underlying sink returns a non-undefined ovalue Can't find variable: WritableStream
+
</ins></span></pre></div>
<a id="trunkLayoutTestsstreamsreferenceimplementationwritablestreamhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/streams/reference-implementation/writable-stream.html (0 => 189686)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/reference-implementation/writable-stream.html (rev 0)
+++ trunk/LayoutTests/streams/reference-implementation/writable-stream.html 2015-09-14 07:53:04 UTC (rev 189686)
</span><span class="lines">@@ -0,0 +1,254 @@
</span><ins>+<!DOCTYPE html>
+<script src='../../resources/testharness.js'></script>
+<script src='../../resources/testharnessreport.js'></script>
+<script src='resources/streams-utils.js'></script>
+<script>
+function writeArrayToStream(array, writableStream) {
+ array.forEach(function(chunk) { writableStream.write(chunk); })
+ return writableStream.close();
+}
+
+var test1 = async_test('error argument is given to start method');
+test1.step(function() {
+ var error;
+ var ws = new WritableStream({
+ start: function(error_) {
+ error = error_;
+ }
+ });
+
+ // Now error the stream after its construction.
+ var passedError = new Error('horrible things');
+ error(passedError);
+ assert_equals(ws.state, 'errored');
+ ws.closed.catch(test1.step_func(function(r) {
+ assert_equals(r, passedError);
+ test1.done();
+ }));
+});
+
+var test2 = async_test('Underlying sink\'s write won\'t be called until start finishes');
+test2.step(function() {
+ var expectWriteCall = false;
+
+ var resolveStartPromise;
+ var ws = new WritableStream({
+ start: function() {
+ return new Promise(test2.step_func(function(resolve) { resolveStartPromise = resolve; }));
+ },
+ write: function(chunk) {
+ if (expectWriteCall) {
+ assert_equals(chunk, 'a');
+ test2.done();
+ } else {
+ assert_unreached('Unexpected write call');
+ }
+ },
+ close: function() {
+ assert_unreached('Unexpected close call');
+ }
+ });
+
+ ws.write('a');
+ assert_equals(ws.state, 'waiting', 'writable stream should be waiting, not ' + ws.state);
+
+ // Wait and see that write won't be called.
+ setTimeout(test2.step_func(function() {
+ expectWriteCall = true;
+ resolveStartPromise();
+ }), 200);
+});
+
+var test3 = async_test('Underlying sink\'s close won\'t be called until start finishes');
+test3.step(function() {
+ var expectCloseCall = false;
+
+ var resolveStartPromise;
+ var ws = new WritableStream({
+ start: function() {
+ return new Promise(test3.step_func(function(resolve, reject) { resolveStartPromise = resolve; }));
+ },
+ write: function(chunk) {
+ assert_unreached('Unexpected write call');
+ },
+ close: function() {
+ if (expectCloseCall) {
+ test3.done();
+ } else {
+ assert_unreached('Unexpected close call');
+ }
+ }
+ });
+ ws.close('a');
+ assert_equals(ws.state, 'closing');
+
+ // Wait and see that write won't be called.
+ setTimeout(test3.step_func(function() {
+ expectCloseCall = true;
+ resolveStartPromise();
+ }), 200);
+});
+
+var test4 = async_test('Fulfillment value of ws.close() call must be undefined even if the underlying sink returns a non-undefined value');
+test4.step(function() {
+ var ws = new WritableStream({
+ close: function() {
+ return 'Hello';
+ }
+ });
+
+ var closePromise = ws.close('a');
+ closePromise.then(test4.step_func(function(value) {
+ assert_equals(value, undefined, 'fulfillment value must be undefined');
+ test4.done();
+ })).catch(test4.step_func(function() {
+ assert_unreached('closePromise is rejected');
+ }));
+});
+
+var test5 = async_test('Underlying sink\'s write or close are never invoked if start throws');
+test5.step(function() {
+ var passedError = new Error('horrible things');
+
+ try {
+ var ws = new WritableStream({
+ start: function() {
+ throw passedError;
+ },
+ write: function(chunk) {
+ assert_unreached('Unexpected write call');
+ },
+ close: function() {
+ assert_unreached('Unexpected close call');
+ }
+ });
+ } catch (e) {
+ assert_equals(e, passedError);
+ test5.done();
+ }
+ assert_unreached('Constructor didn\'t throw');
+});
+
+var test6 = async_test('Underlying sink\'s write or close are never invoked if the promise returned by start is rejected');
+test6.step(function() {
+ var ws = new WritableStream({
+ start: function() {
+ return Promise.reject();
+ },
+ write: function(chunk) {
+ assert_unreached('Unexpected write call');
+ },
+ close: function() {
+ assert_unreached('Unexpected close call');
+ }
+ });
+
+ // Wait and see that write or close won't be called.
+ setTimeout(test6.step_func(function() {
+ test6.done();
+ }), 500);
+});
+
+test(function() {
+ new WritableStream() // WritableStream constructed with no errors.
+}, 'WritableStream can be constructed with no arguments');
+
+test(function() {
+ var ws = new WritableStream();
+
+ assert_equals(typeof ws.write, 'function', 'has a write method');
+ assert_equals(typeof ws.abort, 'function', 'has an abort method');
+ assert_equals(typeof ws.close, 'function', 'has a close method');
+
+ assert_equals(ws.state, 'writable', 'state starts out writable');
+
+ assert_true('ready' in ws, 'has a ready property');
+ assert_true('then' in ws.ready, 'ready property is a thenable');
+ assert_true('closed' in ws, 'has a closed property');
+ assert_true('then' in ws.closed, 'closed property is thenable');
+}, 'WritableStream instances have the correct methods and properties');
+
+var test7 = async_test('WritableStream with simple input, processed asynchronously');
+test7.step(function() {
+ var storage;
+ var ws = new WritableStream({
+ start: function() {
+ storage = [];
+ },
+
+ write: function(chunk) {
+ return new Promise(test7.step_func(function(resolve) {
+ setTimeout(test7.step_func(function() {
+ storage.push(chunk);
+ resolve();
+ }), 0);
+ }));
+ },
+
+ close: function() {
+ return new Promise(test7.step_func(function(resolve) { setTimeout(test7.step_func(resolve), 0); }));
+ }
+ });
+
+ var input = [1, 2, 3, 4, 5];
+ writeArrayToStream(input, ws).then(
+ test7.step_func(function() {
+ assert_array_equals(storage, input, 'correct data was relayed to underlying sink');
+ test7.done();
+ }),
+ test7.step_func(function(r) { assert_unreached(r); })
+ );
+});
+
+var test8 = async_test('WritableStream with simple input, processed synchronously');
+test8.step(function() {
+ var storage;
+ var ws = new WritableStream({
+ start: function() {
+ storage = [];
+ },
+
+ write: function(chunk) {
+ storage.push(chunk);
+ },
+ });
+
+ var input = [1, 2, 3, 4, 5];
+ writeArrayToStream(input, ws).then(
+ test8.step_func(function() {
+ assert_array_equals(storage, input, 'correct data was relayed to underlying sink');
+ test8.done();
+ }),
+ test8.step_func(function(r) { assert_unreached(r); })
+ );
+});
+
+var test9 = async_test('WritableStream is writable and ready fulfills immediately if the strategy does not apply backpressure');
+test9.step(function() {
+ var ws = new WritableStream({}, {
+ highWaterMark: Infinity,
+ size() { return 0; }
+ });
+
+ assert_equals(ws.state, 'writable');
+
+ ws.ready.then(test9.step_func(function() {
+ test9.done('ready promise was fulfilled');
+ }));
+});
+
+var test10 = async_test('Fulfillment value of ws.write() call must be undefined even if the underlying sink returns a non-undefined ovalue');
+test10.step(function() {
+ var ws = new WritableStream({
+ write: function() {
+ return 'Hello';
+ }
+ });
+
+ var writePromise = ws.write('a');
+ writePromise.then(test10.step_func(function(value) {
+ assert_equals(value, undefined, 'fulfillment value must be undefined');
+ test10.done();
+ })).catch(test10.step_func(function() { assert_unreached('writePromise is rejected'); }));
+});
+</script>
</ins></span></pre>
</div>
</div>
</body>
</html>