<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189690] releases/WebKitGTK/webkit-2.10</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189690">189690</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-09-14 01:05:24 -0700 (Mon, 14 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/188672">r188672</a> - Select validation does not correctly work when handling change event
https://bugs.webkit.org/show_bug.cgi?id=145869
Reviewed by Dean Jackson.
Source/WebCore:
When selecting an option in a <select> with validation that also has an onchange listener, calling
checkValidity() for the select within the onchange handler would produce incorrect results and (on
a debug build) crash at an assertion. This is because the change events were being dispatched before
form validity was updated. Making the validation step come before the change event dispatch fixes
this issue.
Test: fast/forms/onchange-select-check-validity.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectOption): Update validity before dispatching change events.
LayoutTests:
Tests that checkValidity() returns correct results from within the onchange handler of a
<select> when the validity of the selected option changes.
* fast/forms/onchange-select-check-validity-expected.txt: Added.
* fast/forms/onchange-select-check-validity.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit210SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit210SourceWebCorehtmlHTMLSelectElementcpp">releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLSelectElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestsfastformsonchangeselectcheckvalidityexpectedtxt">releases/WebKitGTK/webkit-2.10/LayoutTests/fast/forms/onchange-select-check-validity-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit210LayoutTestsfastformsonchangeselectcheckvalidityhtml">releases/WebKitGTK/webkit-2.10/LayoutTests/fast/forms/onchange-select-check-validity.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit210LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog (189689 => 189690)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog 2015-09-14 07:59:48 UTC (rev 189689)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog 2015-09-14 08:05:24 UTC (rev 189690)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-08-19 Wenson Hsieh <wenson_hsieh@apple.com>
+
+ Select validation does not correctly work when handling change event
+ https://bugs.webkit.org/show_bug.cgi?id=145869
+
+ Reviewed by Dean Jackson.
+
+ Tests that checkValidity() returns correct results from within the onchange handler of a
+ <select> when the validity of the selected option changes.
+
+ * fast/forms/onchange-select-check-validity-expected.txt: Added.
+ * fast/forms/onchange-select-check-validity.html: Added.
+
</ins><span class="cx"> 2015-08-19 Jinyoung Hur <hur.ims@navercorp.com>
</span><span class="cx">
</span><span class="cx"> GraphicsContext3D::activeTexture should not be called with zero-based index
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit210LayoutTestsfastformsonchangeselectcheckvalidityexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.10/LayoutTests/fast/forms/onchange-select-check-validity-expected.txt (0 => 189690)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/fast/forms/onchange-select-check-validity-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/fast/forms/onchange-select-check-validity-expected.txt 2015-09-14 08:05:24 UTC (rev 189690)
</span><span class="lines">@@ -0,0 +1,4 @@
</span><ins>+
+The select's validity was initially false
+The select's validity was changed to true
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit210LayoutTestsfastformsonchangeselectcheckvalidityhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.10/LayoutTests/fast/forms/onchange-select-check-validity.html (0 => 189690)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/LayoutTests/fast/forms/onchange-select-check-validity.html (rev 0)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/fast/forms/onchange-select-check-validity.html 2015-09-14 08:05:24 UTC (rev 189690)
</span><span class="lines">@@ -0,0 +1,37 @@
</span><ins>+<html>
+<head>
+<script>
+ function log(message) {
+ document.getElementById("console").appendChild(document.createTextNode(message + "\n"));
+ }
+
+ function setupTest() {
+ var isValid = null;
+ var select = document.getElementById("validated-select");
+ select.focus();
+ function showFormValidity() {
+ isValid = select.checkValidity();
+ }
+ showFormValidity();
+ select.addEventListener("change", showFormValidity);
+
+ if (window.testRunner) {
+ testRunner.dumpAsText();
+ log("The select's validity was initially " + isValid);
+ eventSender.keyDown("1");
+ log("The select's validity was changed to " + isValid);
+ }
+ }
+</script>
+</head>
+
+<body onload="setupTest()">
+<form>
+<select name="validated-select" required="required" id="validated-select">
+ <option value="" selected="selected">Select a value</option>
+ <option value="1">1</option>
+</select>
+</form>
+<pre id="console"></pre>
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit210SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (189689 => 189690)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog 2015-09-14 07:59:48 UTC (rev 189689)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog 2015-09-14 08:05:24 UTC (rev 189690)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-08-19 Wenson Hsieh <wenson_hsieh@apple.com>
+
+ Select validation does not correctly work when handling change event
+ https://bugs.webkit.org/show_bug.cgi?id=145869
+
+ Reviewed by Dean Jackson.
+
+ When selecting an option in a <select> with validation that also has an onchange listener, calling
+ checkValidity() for the select within the onchange handler would produce incorrect results and (on
+ a debug build) crash at an assertion. This is because the change events were being dispatched before
+ form validity was updated. Making the validation step come before the change event dispatch fixes
+ this issue.
+
+ Test: fast/forms/onchange-select-check-validity.html
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::selectOption): Update validity before dispatching change events.
+
</ins><span class="cx"> 2015-08-19 Jinyoung Hur <hur.ims@navercorp.com>
</span><span class="cx">
</span><span class="cx"> GraphicsContext3D::activeTexture should not be called with zero-based index
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit210SourceWebCorehtmlHTMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLSelectElement.cpp (189689 => 189690)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLSelectElement.cpp 2015-09-14 07:59:48 UTC (rev 189689)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/html/HTMLSelectElement.cpp 2015-09-14 08:05:24 UTC (rev 189690)
</span><span class="lines">@@ -899,6 +899,7 @@
</span><span class="cx">
</span><span class="cx"> scrollToSelection();
</span><span class="cx">
</span><ins>+ updateValidity();
</ins><span class="cx"> if (usesMenuList()) {
</span><span class="cx"> m_isProcessingUserDrivenChange = flags & UserDriven;
</span><span class="cx"> if (flags & DispatchChangeEvent)
</span><span class="lines">@@ -910,8 +911,6 @@
</span><span class="cx"> downcast<RenderListBox>(*renderer).selectionChanged();
</span><span class="cx"> }
</span><span class="cx"> }
</span><del>-
- updateValidity();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> int HTMLSelectElement::optionToListIndex(int optionIndex) const
</span></span></pre>
</div>
</div>
</body>
</html>