<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189675] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189675">189675</a></dd>
<dt>Author</dt> <dd>gyuyoung.kim@webkit.org</dd>
<dt>Date</dt> <dd>2015-09-13 19:36:37 -0700 (Sun, 13 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove all uses of PassRefPtr in crypto, storage, and history
https://bugs.webkit.org/show_bug.cgi?id=149091
Reviewed by Andreas Kling.
Source/WebCore:
* crypto/CryptoKeyPair.cpp:
(WebCore::CryptoKeyPair::CryptoKeyPair):
* crypto/CryptoKeyPair.h:
(WebCore::CryptoKeyPair::create):
* crypto/SubtleCrypto.h:
(WebCore::SubtleCrypto::create):
* crypto/gnutls/CryptoKeyRSAGnuTLS.cpp:
(WebCore::CryptoKeyRSA::create):
* crypto/keys/CryptoKeyAES.cpp:
(WebCore::CryptoKeyAES::generate):
* crypto/keys/CryptoKeyAES.h:
* crypto/keys/CryptoKeyHMAC.cpp:
(WebCore::CryptoKeyHMAC::generate):
* crypto/keys/CryptoKeyHMAC.h:
* crypto/keys/CryptoKeyRSA.h:
* crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::CryptoKeyRSA::create):
* history/BackForwardController.cpp:
(WebCore::BackForwardController::BackForwardController):
* history/BackForwardController.h:
* history/HistoryItem.cpp:
(WebCore::HistoryItem::setStateObject):
(WebCore::HistoryItem::setFormData):
* history/HistoryItem.h:
(WebCore::HistoryItem::stateObject):
* loader/EmptyClients.cpp:
* page/Page.cpp:
(WebCore::Page::Page):
* storage/Storage.cpp:
(WebCore::Storage::create):
(WebCore::Storage::Storage):
* storage/Storage.h:
* storage/StorageArea.h:
* storage/StorageMap.cpp:
(WebCore::StorageMap::copy):
(WebCore::StorageMap::setItem):
(WebCore::StorageMap::setItemIgnoringQuota):
(WebCore::StorageMap::removeItem):
* storage/StorageMap.h:
* storage/StorageNamespace.h:
Source/WebKit:
* Storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::storageArea):
* Storage/StorageNamespaceImpl.h:
Source/WebKit2:
* WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::storageArea):
* WebProcess/Storage/StorageNamespaceImpl.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecryptoCryptoKeyPaircpp">trunk/Source/WebCore/crypto/CryptoKeyPair.cpp</a></li>
<li><a href="#trunkSourceWebCorecryptoCryptoKeyPairh">trunk/Source/WebCore/crypto/CryptoKeyPair.h</a></li>
<li><a href="#trunkSourceWebCorecryptoSubtleCryptoh">trunk/Source/WebCore/crypto/SubtleCrypto.h</a></li>
<li><a href="#trunkSourceWebCorecryptognutlsCryptoKeyRSAGnuTLScpp">trunk/Source/WebCore/crypto/gnutls/CryptoKeyRSAGnuTLS.cpp</a></li>
<li><a href="#trunkSourceWebCorecryptokeysCryptoKeyAEScpp">trunk/Source/WebCore/crypto/keys/CryptoKeyAES.cpp</a></li>
<li><a href="#trunkSourceWebCorecryptokeysCryptoKeyAESh">trunk/Source/WebCore/crypto/keys/CryptoKeyAES.h</a></li>
<li><a href="#trunkSourceWebCorecryptokeysCryptoKeyHMACcpp">trunk/Source/WebCore/crypto/keys/CryptoKeyHMAC.cpp</a></li>
<li><a href="#trunkSourceWebCorecryptokeysCryptoKeyHMACh">trunk/Source/WebCore/crypto/keys/CryptoKeyHMAC.h</a></li>
<li><a href="#trunkSourceWebCorecryptokeysCryptoKeyRSAh">trunk/Source/WebCore/crypto/keys/CryptoKeyRSA.h</a></li>
<li><a href="#trunkSourceWebCorecryptomacCryptoKeyRSAMaccpp">trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp</a></li>
<li><a href="#trunkSourceWebCorehistoryBackForwardControllercpp">trunk/Source/WebCore/history/BackForwardController.cpp</a></li>
<li><a href="#trunkSourceWebCorehistoryBackForwardControllerh">trunk/Source/WebCore/history/BackForwardController.h</a></li>
<li><a href="#trunkSourceWebCorehistoryHistoryItemcpp">trunk/Source/WebCore/history/HistoryItem.cpp</a></li>
<li><a href="#trunkSourceWebCorehistoryHistoryItemh">trunk/Source/WebCore/history/HistoryItem.h</a></li>
<li><a href="#trunkSourceWebCoreloaderEmptyClientscpp">trunk/Source/WebCore/loader/EmptyClients.cpp</a></li>
<li><a href="#trunkSourceWebCorepagePagecpp">trunk/Source/WebCore/page/Page.cpp</a></li>
<li><a href="#trunkSourceWebCorestorageStoragecpp">trunk/Source/WebCore/storage/Storage.cpp</a></li>
<li><a href="#trunkSourceWebCorestorageStorageh">trunk/Source/WebCore/storage/Storage.h</a></li>
<li><a href="#trunkSourceWebCorestorageStorageAreah">trunk/Source/WebCore/storage/StorageArea.h</a></li>
<li><a href="#trunkSourceWebCorestorageStorageMapcpp">trunk/Source/WebCore/storage/StorageMap.cpp</a></li>
<li><a href="#trunkSourceWebCorestorageStorageMaph">trunk/Source/WebCore/storage/StorageMap.h</a></li>
<li><a href="#trunkSourceWebCorestorageStorageNamespaceh">trunk/Source/WebCore/storage/StorageNamespace.h</a></li>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitStorageStorageNamespaceImplcpp">trunk/Source/WebKit/Storage/StorageNamespaceImpl.cpp</a></li>
<li><a href="#trunkSourceWebKitStorageStorageNamespaceImplh">trunk/Source/WebKit/Storage/StorageNamespaceImpl.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessStorageStorageNamespaceImplcpp">trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessStorageStorageNamespaceImplh">trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/ChangeLog 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -1,3 +1,51 @@
</span><ins>+2015-09-13 Gyuyoung Kim <gyuyoung.kim@webkit.org>
+
+ Remove all uses of PassRefPtr in crypto, storage, and history
+ https://bugs.webkit.org/show_bug.cgi?id=149091
+
+ Reviewed by Andreas Kling.
+
+ * crypto/CryptoKeyPair.cpp:
+ (WebCore::CryptoKeyPair::CryptoKeyPair):
+ * crypto/CryptoKeyPair.h:
+ (WebCore::CryptoKeyPair::create):
+ * crypto/SubtleCrypto.h:
+ (WebCore::SubtleCrypto::create):
+ * crypto/gnutls/CryptoKeyRSAGnuTLS.cpp:
+ (WebCore::CryptoKeyRSA::create):
+ * crypto/keys/CryptoKeyAES.cpp:
+ (WebCore::CryptoKeyAES::generate):
+ * crypto/keys/CryptoKeyAES.h:
+ * crypto/keys/CryptoKeyHMAC.cpp:
+ (WebCore::CryptoKeyHMAC::generate):
+ * crypto/keys/CryptoKeyHMAC.h:
+ * crypto/keys/CryptoKeyRSA.h:
+ * crypto/mac/CryptoKeyRSAMac.cpp:
+ (WebCore::CryptoKeyRSA::create):
+ * history/BackForwardController.cpp:
+ (WebCore::BackForwardController::BackForwardController):
+ * history/BackForwardController.h:
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::setStateObject):
+ (WebCore::HistoryItem::setFormData):
+ * history/HistoryItem.h:
+ (WebCore::HistoryItem::stateObject):
+ * loader/EmptyClients.cpp:
+ * page/Page.cpp:
+ (WebCore::Page::Page):
+ * storage/Storage.cpp:
+ (WebCore::Storage::create):
+ (WebCore::Storage::Storage):
+ * storage/Storage.h:
+ * storage/StorageArea.h:
+ * storage/StorageMap.cpp:
+ (WebCore::StorageMap::copy):
+ (WebCore::StorageMap::setItem):
+ (WebCore::StorageMap::setItemIgnoringQuota):
+ (WebCore::StorageMap::removeItem):
+ * storage/StorageMap.h:
+ * storage/StorageNamespace.h:
+
</ins><span class="cx"> 2015-09-12 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> window.EventTarget should exist
</span></span></pre></div>
<a id="trunkSourceWebCorecryptoCryptoKeyPaircpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/crypto/CryptoKeyPair.cpp (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/crypto/CryptoKeyPair.cpp 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/crypto/CryptoKeyPair.cpp 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -30,9 +30,9 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-CryptoKeyPair::CryptoKeyPair(PassRefPtr<CryptoKey> publicKey, PassRefPtr<CryptoKey> privateKey)
- : m_publicKey(publicKey)
- , m_privateKey(privateKey)
</del><ins>+CryptoKeyPair::CryptoKeyPair(RefPtr<CryptoKey>&& publicKey, RefPtr<CryptoKey>&& privateKey)
+ : m_publicKey(WTF::move(publicKey))
+ , m_privateKey(WTF::move(privateKey))
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecryptoCryptoKeyPairh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/crypto/CryptoKeyPair.h (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/crypto/CryptoKeyPair.h 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/crypto/CryptoKeyPair.h 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -27,7 +27,6 @@
</span><span class="cx"> #define CryptoKeyPair_h
</span><span class="cx">
</span><span class="cx"> #include "CryptoKey.h"
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx"> #include <wtf/RefPtr.h>
</span><span class="cx">
</span><span class="lines">@@ -37,9 +36,9 @@
</span><span class="cx">
</span><span class="cx"> class CryptoKeyPair : public RefCounted<CryptoKeyPair> {
</span><span class="cx"> public:
</span><del>- static Ref<CryptoKeyPair> create(PassRefPtr<CryptoKey> publicKey, PassRefPtr<CryptoKey> privateKey)
</del><ins>+ static Ref<CryptoKeyPair> create(RefPtr<CryptoKey>&& publicKey, RefPtr<CryptoKey>&& privateKey)
</ins><span class="cx"> {
</span><del>- return adoptRef(*new CryptoKeyPair(publicKey, privateKey));
</del><ins>+ return adoptRef(*new CryptoKeyPair(WTF::move(publicKey), WTF::move(privateKey)));
</ins><span class="cx"> }
</span><span class="cx"> ~CryptoKeyPair();
</span><span class="cx">
</span><span class="lines">@@ -47,7 +46,7 @@
</span><span class="cx"> CryptoKey* privateKey() { return m_privateKey.get(); }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- CryptoKeyPair(PassRefPtr<CryptoKey> publicKey, PassRefPtr<CryptoKey> privateKey);
</del><ins>+ CryptoKeyPair(RefPtr<CryptoKey>&& publicKey, RefPtr<CryptoKey>&& privateKey);
</ins><span class="cx">
</span><span class="cx"> RefPtr<CryptoKey> m_publicKey;
</span><span class="cx"> RefPtr<CryptoKey> m_privateKey;
</span></span></pre></div>
<a id="trunkSourceWebCorecryptoSubtleCryptoh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/crypto/SubtleCrypto.h (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/crypto/SubtleCrypto.h 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/crypto/SubtleCrypto.h 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -26,9 +26,9 @@
</span><span class="cx"> #ifndef SubtleCrypto_h
</span><span class="cx"> #define SubtleCrypto_h
</span><span class="cx">
</span><del>-#include "ContextDestructionObserver.h"
-#include <wtf/PassRefPtr.h>
</del><ins>+#include "ContextDestructionObserver.h"
</ins><span class="cx"> #include <wtf/RefCounted.h>
</span><ins>+#include <wtf/RefPtr.h>
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(SUBTLE_CRYPTO)
</span><span class="cx">
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx">
</span><span class="cx"> class SubtleCrypto : public ContextDestructionObserver, public RefCounted<SubtleCrypto> {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<SubtleCrypto> create(Document& document) { return adoptRef(new SubtleCrypto(document)); }
</del><ins>+ static Ref<SubtleCrypto> create(Document& document) { return adoptRef(*new SubtleCrypto(document)); }
</ins><span class="cx">
</span><span class="cx"> Document* document() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecryptognutlsCryptoKeyRSAGnuTLScpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/crypto/gnutls/CryptoKeyRSAGnuTLS.cpp (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/crypto/gnutls/CryptoKeyRSAGnuTLS.cpp 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/crypto/gnutls/CryptoKeyRSAGnuTLS.cpp 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> notImplemented();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<CryptoKeyRSA> CryptoKeyRSA::create(CryptoAlgorithmIdentifier identifier, const CryptoKeyDataRSAComponents& keyData, bool extractable, CryptoKeyUsage usage)
</del><ins>+RefPtr<CryptoKeyRSA> CryptoKeyRSA::create(CryptoAlgorithmIdentifier identifier, const CryptoKeyDataRSAComponents& keyData, bool extractable, CryptoKeyUsage usage)
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> UNUSED_PARAM(identifier);
</span></span></pre></div>
<a id="trunkSourceWebCorecryptokeysCryptoKeyAEScpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/crypto/keys/CryptoKeyAES.cpp (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/crypto/keys/CryptoKeyAES.cpp 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/crypto/keys/CryptoKeyAES.cpp 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx"> || algorithm == CryptoAlgorithmIdentifier::AES_KW;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<CryptoKeyAES> CryptoKeyAES::generate(CryptoAlgorithmIdentifier algorithm, size_t lengthBits, bool extractable, CryptoKeyUsage usages)
</del><ins>+RefPtr<CryptoKeyAES> CryptoKeyAES::generate(CryptoAlgorithmIdentifier algorithm, size_t lengthBits, bool extractable, CryptoKeyUsage usages)
</ins><span class="cx"> {
</span><span class="cx"> if (lengthBits % 8)
</span><span class="cx"> return nullptr;
</span></span></pre></div>
<a id="trunkSourceWebCorecryptokeysCryptoKeyAESh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/crypto/keys/CryptoKeyAES.h (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/crypto/keys/CryptoKeyAES.h 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/crypto/keys/CryptoKeyAES.h 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx">
</span><span class="cx"> static bool isValidAESAlgorithm(CryptoAlgorithmIdentifier);
</span><span class="cx">
</span><del>- static PassRefPtr<CryptoKeyAES> generate(CryptoAlgorithmIdentifier, size_t lengthBits, bool extractable, CryptoKeyUsage);
</del><ins>+ static RefPtr<CryptoKeyAES> generate(CryptoAlgorithmIdentifier, size_t lengthBits, bool extractable, CryptoKeyUsage);
</ins><span class="cx">
</span><span class="cx"> virtual CryptoKeyClass keyClass() const override { return CryptoKeyClass::AES; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecryptokeysCryptoKeyHMACcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/crypto/keys/CryptoKeyHMAC.cpp (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/crypto/keys/CryptoKeyHMAC.cpp 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/crypto/keys/CryptoKeyHMAC.cpp 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<CryptoKeyHMAC> CryptoKeyHMAC::generate(size_t lengthBytes, CryptoAlgorithmIdentifier hash, bool extractable, CryptoKeyUsage usages)
</del><ins>+RefPtr<CryptoKeyHMAC> CryptoKeyHMAC::generate(size_t lengthBytes, CryptoAlgorithmIdentifier hash, bool extractable, CryptoKeyUsage usages)
</ins><span class="cx"> {
</span><span class="cx"> if (!lengthBytes) {
</span><span class="cx"> switch (hash) {
</span></span></pre></div>
<a id="trunkSourceWebCorecryptokeysCryptoKeyHMACh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/crypto/keys/CryptoKeyHMAC.h (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/crypto/keys/CryptoKeyHMAC.h 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/crypto/keys/CryptoKeyHMAC.h 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> virtual ~CryptoKeyHMAC();
</span><span class="cx">
</span><span class="cx"> // If lengthBytes is 0, a recommended length is used, which is the size of the associated hash function's block size.
</span><del>- static PassRefPtr<CryptoKeyHMAC> generate(size_t lengthBytes, CryptoAlgorithmIdentifier hash, bool extractable, CryptoKeyUsage);
</del><ins>+ static RefPtr<CryptoKeyHMAC> generate(size_t lengthBytes, CryptoAlgorithmIdentifier hash, bool extractable, CryptoKeyUsage);
</ins><span class="cx">
</span><span class="cx"> virtual CryptoKeyClass keyClass() const override { return CryptoKeyClass::HMAC; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecryptokeysCryptoKeyRSAh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/crypto/keys/CryptoKeyRSA.h (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/crypto/keys/CryptoKeyRSA.h 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/crypto/keys/CryptoKeyRSA.h 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> {
</span><span class="cx"> return adoptRef(*new CryptoKeyRSA(identifier, type, platformKey, extractable, usage));
</span><span class="cx"> }
</span><del>- static PassRefPtr<CryptoKeyRSA> create(CryptoAlgorithmIdentifier, const CryptoKeyDataRSAComponents&, bool extractable, CryptoKeyUsage);
</del><ins>+ static RefPtr<CryptoKeyRSA> create(CryptoAlgorithmIdentifier, const CryptoKeyDataRSAComponents&, bool extractable, CryptoKeyUsage);
</ins><span class="cx"> virtual ~CryptoKeyRSA();
</span><span class="cx">
</span><span class="cx"> void restrictToHash(CryptoAlgorithmIdentifier);
</span></span></pre></div>
<a id="trunkSourceWebCorecryptomacCryptoKeyRSAMaccpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -103,7 +103,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<CryptoKeyRSA> CryptoKeyRSA::create(CryptoAlgorithmIdentifier identifier, const CryptoKeyDataRSAComponents& keyData, bool extractable, CryptoKeyUsage usage)
</del><ins>+RefPtr<CryptoKeyRSA> CryptoKeyRSA::create(CryptoAlgorithmIdentifier identifier, const CryptoKeyDataRSAComponents& keyData, bool extractable, CryptoKeyUsage usage)
</ins><span class="cx"> {
</span><span class="cx"> if (keyData.type() == CryptoKeyDataRSAComponents::Type::Private && !keyData.hasAdditionalPrivateKeyParameters()) {
</span><span class="cx"> // <rdar://problem/15452324> tracks adding support.
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryBackForwardControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/BackForwardController.cpp (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/BackForwardController.cpp 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/history/BackForwardController.cpp 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -32,9 +32,9 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-BackForwardController::BackForwardController(Page& page, PassRefPtr<BackForwardClient> client)
</del><ins>+BackForwardController::BackForwardController(Page& page, RefPtr<BackForwardClient>&& client)
</ins><span class="cx"> : m_page(page)
</span><del>- , m_client(client)
</del><ins>+ , m_client(WTF::move(client))
</ins><span class="cx"> {
</span><span class="cx"> if (!m_client)
</span><span class="cx"> m_client = BackForwardList::create(&page);
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryBackForwardControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/BackForwardController.h (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/BackForwardController.h 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/history/BackForwardController.h 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx"> class BackForwardController {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(BackForwardController); WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- BackForwardController(Page&, PassRefPtr<BackForwardClient>);
</del><ins>+ BackForwardController(Page&, RefPtr<BackForwardClient>&&);
</ins><span class="cx"> ~BackForwardController();
</span><span class="cx">
</span><span class="cx"> BackForwardClient* client() const { return m_client.get(); }
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryHistoryItemcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/HistoryItem.cpp (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/HistoryItem.cpp 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/history/HistoryItem.cpp 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -371,9 +371,9 @@
</span><span class="cx"> m_isTargetItem = flag;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HistoryItem::setStateObject(PassRefPtr<SerializedScriptValue> object)
</del><ins>+void HistoryItem::setStateObject(RefPtr<SerializedScriptValue>&& object)
</ins><span class="cx"> {
</span><del>- m_stateObject = object;
</del><ins>+ m_stateObject = WTF::move(object);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HistoryItem::addChildItem(Ref<HistoryItem>&& child)
</span><span class="lines">@@ -539,9 +539,9 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HistoryItem::setFormData(PassRefPtr<FormData> formData)
</del><ins>+void HistoryItem::setFormData(RefPtr<FormData>&& formData)
</ins><span class="cx"> {
</span><del>- m_formData = formData;
</del><ins>+ m_formData = WTF::move(formData);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HistoryItem::setFormContentType(const String& formContentType)
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryHistoryItemh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/HistoryItem.h (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/HistoryItem.h 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/history/HistoryItem.h 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -130,8 +130,8 @@
</span><span class="cx"> WEBCORE_EXPORT void setTitle(const String&);
</span><span class="cx"> WEBCORE_EXPORT void setIsTargetItem(bool);
</span><span class="cx">
</span><del>- WEBCORE_EXPORT void setStateObject(PassRefPtr<SerializedScriptValue>);
- PassRefPtr<SerializedScriptValue> stateObject() const { return m_stateObject; }
</del><ins>+ WEBCORE_EXPORT void setStateObject(RefPtr<SerializedScriptValue>&&);
+ RefPtr<SerializedScriptValue> stateObject() const { return m_stateObject; }
</ins><span class="cx">
</span><span class="cx"> void setItemSequenceNumber(long long number) { m_itemSequenceNumber = number; }
</span><span class="cx"> long long itemSequenceNumber() const { return m_itemSequenceNumber; }
</span><span class="lines">@@ -140,7 +140,7 @@
</span><span class="cx"> long long documentSequenceNumber() const { return m_documentSequenceNumber; }
</span><span class="cx">
</span><span class="cx"> void setFormInfoFromRequest(const ResourceRequest&);
</span><del>- WEBCORE_EXPORT void setFormData(PassRefPtr<FormData>);
</del><ins>+ WEBCORE_EXPORT void setFormData(RefPtr<FormData>&&);
</ins><span class="cx"> WEBCORE_EXPORT void setFormContentType(const String&);
</span><span class="cx">
</span><span class="cx"> void setLastVisitWasFailure(bool wasFailure) { m_lastVisitWasFailure = wasFailure; }
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderEmptyClientscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/EmptyClients.cpp (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/EmptyClients.cpp 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/loader/EmptyClients.cpp 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -67,7 +67,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> struct EmptyStorageNamespace final : public StorageNamespace {
</span><del>- virtual RefPtr<StorageArea> storageArea(PassRefPtr<SecurityOrigin>) override { return adoptRef(new EmptyStorageArea); }
</del><ins>+ virtual RefPtr<StorageArea> storageArea(RefPtr<SecurityOrigin>&&) override { return adoptRef(new EmptyStorageArea); }
</ins><span class="cx"> virtual RefPtr<StorageNamespace> copy(Page*) override { return adoptRef(new EmptyStorageNamespace); }
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepagePagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Page.cpp (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Page.cpp 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/page/Page.cpp 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -157,7 +157,7 @@
</span><span class="cx"> #endif
</span><span class="cx"> , m_settings(Settings::create(this))
</span><span class="cx"> , m_progress(std::make_unique<ProgressTracker>(*pageConfiguration.progressTrackerClient))
</span><del>- , m_backForwardController(std::make_unique<BackForwardController>(*this, pageConfiguration.backForwardClient))
</del><ins>+ , m_backForwardController(std::make_unique<BackForwardController>(*this, WTF::move(pageConfiguration.backForwardClient)))
</ins><span class="cx"> , m_mainFrame(MainFrame::create(*this, pageConfiguration))
</span><span class="cx"> , m_theme(RenderTheme::themeForPage(this))
</span><span class="cx"> , m_editorClient(*pageConfiguration.editorClient)
</span></span></pre></div>
<a id="trunkSourceWebCorestorageStoragecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/storage/Storage.cpp (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/storage/Storage.cpp 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/storage/Storage.cpp 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -33,19 +33,18 @@
</span><span class="cx"> #include "SchemeRegistry.h"
</span><span class="cx"> #include "Settings.h"
</span><span class="cx"> #include "StorageArea.h"
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/text/WTFString.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-Ref<Storage> Storage::create(Frame* frame, PassRefPtr<StorageArea> storageArea)
</del><ins>+Ref<Storage> Storage::create(Frame* frame, RefPtr<StorageArea>&& storageArea)
</ins><span class="cx"> {
</span><del>- return adoptRef(*new Storage(frame, storageArea));
</del><ins>+ return adoptRef(*new Storage(frame, WTF::move(storageArea)));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-Storage::Storage(Frame* frame, PassRefPtr<StorageArea> storageArea)
</del><ins>+Storage::Storage(Frame* frame, RefPtr<StorageArea>&& storageArea)
</ins><span class="cx"> : DOMWindowProperty(frame)
</span><del>- , m_storageArea(storageArea)
</del><ins>+ , m_storageArea(WTF::move(storageArea))
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(m_frame);
</span><span class="cx"> ASSERT(m_storageArea);
</span></span></pre></div>
<a id="trunkSourceWebCorestorageStorageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/storage/Storage.h (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/storage/Storage.h 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/storage/Storage.h 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx">
</span><span class="cx"> class Storage : public ScriptWrappable, public RefCounted<Storage>, public DOMWindowProperty {
</span><span class="cx"> public:
</span><del>- static Ref<Storage> create(Frame*, PassRefPtr<StorageArea>);
</del><ins>+ static Ref<Storage> create(Frame*, RefPtr<StorageArea>&&);
</ins><span class="cx"> ~Storage();
</span><span class="cx">
</span><span class="cx"> unsigned length(ExceptionCode&) const;
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> StorageArea& area() const { return *m_storageArea; }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- Storage(Frame*, PassRefPtr<StorageArea>);
</del><ins>+ Storage(Frame*, RefPtr<StorageArea>&&);
</ins><span class="cx">
</span><span class="cx"> bool isDisabledByPrivateBrowsing() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorestorageStorageAreah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/storage/StorageArea.h (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/storage/StorageArea.h 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/storage/StorageArea.h 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -27,7 +27,6 @@
</span><span class="cx"> #define StorageArea_h
</span><span class="cx">
</span><span class="cx"> #include <wtf/Forward.h>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx"> #include <wtf/text/WTFString.h>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorestorageStorageMapcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/storage/StorageMap.cpp (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/storage/StorageMap.cpp 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/storage/StorageMap.cpp 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -43,12 +43,12 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<StorageMap> StorageMap::copy()
</del><ins>+Ref<StorageMap> StorageMap::copy()
</ins><span class="cx"> {
</span><del>- RefPtr<StorageMap> newMap = create(m_quotaSize);
</del><ins>+ Ref<StorageMap> newMap = create(m_quotaSize);
</ins><span class="cx"> newMap->m_map = m_map;
</span><span class="cx"> newMap->m_currentLength = m_currentLength;
</span><del>- return newMap.release();
</del><ins>+ return newMap;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void StorageMap::invalidateIterator()
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx"> return m_map.get(key);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<StorageMap> StorageMap::setItem(const String& key, const String& value, String& oldValue, bool& quotaException)
</del><ins>+RefPtr<StorageMap> StorageMap::setItem(const String& key, const String& value, String& oldValue, bool& quotaException)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(!value.isNull());
</span><span class="cx"> quotaException = false;
</span><span class="lines">@@ -109,7 +109,7 @@
</span><span class="cx"> if (refCount() > 1) {
</span><span class="cx"> RefPtr<StorageMap> newStorageMap = copy();
</span><span class="cx"> newStorageMap->setItem(key, value, oldValue, quotaException);
</span><del>- return newStorageMap.release();
</del><ins>+ return newStorageMap;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Quota tracking. This is done in a couple of steps to keep the overflow tracking simple.
</span><span class="lines">@@ -129,7 +129,7 @@
</span><span class="cx"> bool overQuota = newLength > m_quotaSize / sizeof(UChar);
</span><span class="cx"> if (m_quotaSize != noQuota && (overflow || overQuota)) {
</span><span class="cx"> quotaException = true;
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx"> m_currentLength = newLength;
</span><span class="cx">
</span><span class="lines">@@ -139,10 +139,10 @@
</span><span class="cx">
</span><span class="cx"> invalidateIterator();
</span><span class="cx">
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<StorageMap> StorageMap::setItemIgnoringQuota(const String& key, const String& value)
</del><ins>+RefPtr<StorageMap> StorageMap::setItemIgnoringQuota(const String& key, const String& value)
</ins><span class="cx"> {
</span><span class="cx"> TemporaryChange<unsigned> quotaSizeChange(m_quotaSize, noQuota);
</span><span class="cx">
</span><span class="lines">@@ -152,17 +152,17 @@
</span><span class="cx"> RefPtr<StorageMap> map = setItem(key, value, oldValue, quotaException);
</span><span class="cx"> ASSERT(!quotaException);
</span><span class="cx">
</span><del>- return map.release();
</del><ins>+ return map;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<StorageMap> StorageMap::removeItem(const String& key, String& oldValue)
</del><ins>+RefPtr<StorageMap> StorageMap::removeItem(const String& key, String& oldValue)
</ins><span class="cx"> {
</span><span class="cx"> // Implement copy-on-write semantics here. We're guaranteed that the only refs of StorageMaps belong to Storage objects
</span><span class="cx"> // so if more than one Storage object refs this map, copy it before mutating it.
</span><span class="cx"> if (refCount() > 1) {
</span><span class="cx"> RefPtr<StorageMap> newStorage = copy();
</span><span class="cx"> newStorage->removeItem(key, oldValue);
</span><del>- return newStorage.release();
</del><ins>+ return newStorage;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> oldValue = m_map.take(key);
</span><span class="lines">@@ -174,7 +174,7 @@
</span><span class="cx"> ASSERT(m_currentLength - oldValue.length() <= m_currentLength);
</span><span class="cx"> m_currentLength -= oldValue.length();
</span><span class="cx">
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool StorageMap::contains(const String& key) const
</span></span></pre></div>
<a id="trunkSourceWebCorestorageStorageMaph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/storage/StorageMap.h (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/storage/StorageMap.h 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/storage/StorageMap.h 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -27,7 +27,6 @@
</span><span class="cx"> #define StorageMap_h
</span><span class="cx">
</span><span class="cx"> #include <wtf/HashMap.h>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx"> #include <wtf/text/StringHash.h>
</span><span class="cx"> #include <wtf/text/WTFString.h>
</span><span class="lines">@@ -42,9 +41,9 @@
</span><span class="cx"> WEBCORE_EXPORT unsigned length() const;
</span><span class="cx"> WEBCORE_EXPORT String key(unsigned index);
</span><span class="cx"> WEBCORE_EXPORT String getItem(const String&) const;
</span><del>- WEBCORE_EXPORT PassRefPtr<StorageMap> setItem(const String& key, const String& value, String& oldValue, bool& quotaException);
- WEBCORE_EXPORT PassRefPtr<StorageMap> setItemIgnoringQuota(const String& key, const String& value);
- WEBCORE_EXPORT PassRefPtr<StorageMap> removeItem(const String&, String& oldValue);
</del><ins>+ WEBCORE_EXPORT RefPtr<StorageMap> setItem(const String& key, const String& value, String& oldValue, bool& quotaException);
+ WEBCORE_EXPORT RefPtr<StorageMap> setItemIgnoringQuota(const String& key, const String& value);
+ WEBCORE_EXPORT RefPtr<StorageMap> removeItem(const String&, String& oldValue);
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT bool contains(const String& key) const;
</span><span class="cx">
</span><span class="lines">@@ -57,7 +56,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> explicit StorageMap(unsigned quota);
</span><del>- PassRefPtr<StorageMap> copy();
</del><ins>+ Ref<StorageMap> copy();
</ins><span class="cx"> void invalidateIterator();
</span><span class="cx"> void setIteratorToIndex(unsigned);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorestorageStorageNamespaceh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/storage/StorageNamespace.h (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/storage/StorageNamespace.h 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/storage/StorageNamespace.h 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -27,7 +27,6 @@
</span><span class="cx"> #define StorageNamespace_h
</span><span class="cx">
</span><span class="cx"> #include <wtf/Forward.h>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="lines">@@ -40,7 +39,7 @@
</span><span class="cx"> class StorageNamespace : public RefCounted<StorageNamespace> {
</span><span class="cx"> public:
</span><span class="cx"> virtual ~StorageNamespace() { }
</span><del>- virtual RefPtr<StorageArea> storageArea(PassRefPtr<SecurityOrigin>) = 0;
</del><ins>+ virtual RefPtr<StorageArea> storageArea(RefPtr<SecurityOrigin>&&) = 0;
</ins><span class="cx"> virtual RefPtr<StorageNamespace> copy(Page* newPage) = 0;
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebKit/ChangeLog 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-09-13 Gyuyoung Kim <gyuyoung.kim@webkit.org>
+
+ Remove all uses of PassRefPtr in crypto, storage, and history
+ https://bugs.webkit.org/show_bug.cgi?id=149091
+
+ Reviewed by Andreas Kling.
+
+ * Storage/StorageNamespaceImpl.cpp:
+ (WebCore::StorageNamespaceImpl::storageArea):
+ * Storage/StorageNamespaceImpl.h:
+
</ins><span class="cx"> 2015-08-27 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Isolate Source directories in CMake build
</span></span></pre></div>
<a id="trunkSourceWebKitStorageStorageNamespaceImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/Storage/StorageNamespaceImpl.cpp (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/Storage/StorageNamespaceImpl.cpp 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebKit/Storage/StorageNamespaceImpl.cpp 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -99,18 +99,17 @@
</span><span class="cx"> return newNamespace;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<StorageArea> StorageNamespaceImpl::storageArea(PassRefPtr<SecurityOrigin> prpOrigin)
</del><ins>+RefPtr<StorageArea> StorageNamespaceImpl::storageArea(RefPtr<SecurityOrigin>&& origin)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(isMainThread());
</span><span class="cx"> ASSERT(!m_isShutdown);
</span><span class="cx">
</span><del>- RefPtr<SecurityOrigin> origin = prpOrigin;
</del><span class="cx"> RefPtr<StorageAreaImpl> storageArea;
</span><span class="cx"> if ((storageArea = m_storageAreaMap.get(origin)))
</span><span class="cx"> return storageArea;
</span><span class="cx">
</span><del>- storageArea = StorageAreaImpl::create(m_storageType, origin, m_syncManager, m_quota);
- m_storageAreaMap.set(origin.release(), storageArea);
</del><ins>+ storageArea = StorageAreaImpl::create(m_storageType, origin.copyRef(), m_syncManager, m_quota);
+ m_storageAreaMap.set(WTF::move(origin), storageArea);
</ins><span class="cx"> return storageArea;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitStorageStorageNamespaceImplh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/Storage/StorageNamespaceImpl.h (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/Storage/StorageNamespaceImpl.h 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebKit/Storage/StorageNamespaceImpl.h 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -57,7 +57,7 @@
</span><span class="cx"> private:
</span><span class="cx"> StorageNamespaceImpl(StorageType, const String& path, unsigned quota);
</span><span class="cx">
</span><del>- virtual RefPtr<StorageArea> storageArea(PassRefPtr<SecurityOrigin>) override;
</del><ins>+ virtual RefPtr<StorageArea> storageArea(RefPtr<SecurityOrigin>&&) override;
</ins><span class="cx"> virtual RefPtr<StorageNamespace> copy(Page* newPage) override;
</span><span class="cx">
</span><span class="cx"> typedef HashMap<RefPtr<SecurityOrigin>, RefPtr<StorageAreaImpl>> StorageAreaMap;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebKit2/ChangeLog 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-09-13 Gyuyoung Kim <gyuyoung.kim@webkit.org>
+
+ Remove all uses of PassRefPtr in crypto, storage, and history
+ https://bugs.webkit.org/show_bug.cgi?id=149091
+
+ Reviewed by Andreas Kling.
+
+ * WebProcess/Storage/StorageNamespaceImpl.cpp:
+ (WebKit::StorageNamespaceImpl::storageArea):
+ * WebProcess/Storage/StorageNamespaceImpl.h:
+
</ins><span class="cx"> 2015-09-13 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> Define HAVE_LINK_PREVIEW in WebKit2
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessStorageStorageNamespaceImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx"> m_storageAreaMaps.remove(&map.securityOrigin());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<StorageArea> StorageNamespaceImpl::storageArea(PassRefPtr<SecurityOrigin> securityOrigin)
</del><ins>+RefPtr<StorageArea> StorageNamespaceImpl::storageArea(RefPtr<SecurityOrigin>&& securityOrigin)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<StorageAreaMap> map;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessStorageStorageNamespaceImplh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.h (189674 => 189675)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.h 2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.h 2015-09-14 02:36:37 UTC (rev 189675)
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx"> private:
</span><span class="cx"> explicit StorageNamespaceImpl(WebCore::StorageType, uint64_t storageNamespaceID, WebCore::SecurityOrigin* topLevelOrigin, unsigned quotaInBytes);
</span><span class="cx">
</span><del>- virtual RefPtr<WebCore::StorageArea> storageArea(PassRefPtr<WebCore::SecurityOrigin>) override;
</del><ins>+ virtual RefPtr<WebCore::StorageArea> storageArea(RefPtr<WebCore::SecurityOrigin>&&) override;
</ins><span class="cx"> virtual RefPtr<WebCore::StorageNamespace> copy(WebCore::Page*) override;
</span><span class="cx">
</span><span class="cx"> const WebCore::StorageType m_storageType;
</span></span></pre>
</div>
</div>
</body>
</html>