<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189660] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189660">189660</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-09-12 14:52:25 -0700 (Sat, 12 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>window.EventTarget should exist
https://bugs.webkit.org/show_bug.cgi?id=149085
<rdar://problem/22546774>
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
* web-platform-tests/dom/interface-objects-expected.txt:
* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Drop [NoInterfaceObject] for the EventTarget interface to match Chrome,
Firefox and the specification:
https://dom.spec.whatwg.org/#interface-eventtarget
No new tests, already covered by existing tests.
* dom/EventTarget.idl:
LayoutTests:
Update / rebaseline existing test as window.EventTarget now exists.
* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomdomconstructorsexpectedtxt">trunk/LayoutTests/fast/dom/dom-constructors-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomdomconstructorshtml">trunk/LayoutTests/fast/dom/dom-constructors.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdominterfaceobjectsexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interface-objects-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformefljsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkjsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacjsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacmavericksjsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacyosemitejsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformwinjsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomEventTargetidl">trunk/Source/WebCore/dom/EventTarget.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/ChangeLog 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2015-09-12 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ window.EventTarget should exist
+ https://bugs.webkit.org/show_bug.cgi?id=149085
+ <rdar://problem/22546774>
+
+ Reviewed by Sam Weinig.
+
+ Update / rebaseline existing test as window.EventTarget now exists.
+
+ * fast/dom/dom-constructors-expected.txt:
+ * fast/dom/dom-constructors.html:
+
+2015-09-12 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> ChildNode.replaceWith() without argument should replace the node with an empty DocumentFragment
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149073
</span><span class="cx"> <rdar://problem/22547801>
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomdomconstructorsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/dom-constructors-expected.txt (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/dom-constructors-expected.txt 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/fast/dom/dom-constructors-expected.txt 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -10,6 +10,7 @@
</span><span class="cx"> PASS TryAllocate('Element') is 'exception'
</span><span class="cx"> PASS TryAllocate('Entity') is 'exception'
</span><span class="cx"> PASS TryAllocate('EntityReference') is 'exception'
</span><ins>+PASS TryAllocate('EventTarget') is 'exception'
</ins><span class="cx"> PASS TryAllocate('HTMLDocument') is 'exception'
</span><span class="cx"> PASS TryAllocate('Node') is 'exception'
</span><span class="cx"> PASS TryAllocate('ProcessingInstruction') is 'exception'
</span><span class="lines">@@ -120,7 +121,6 @@
</span><span class="cx"> PASS TryAllocate('EventTargetNode') is 'no constructor'
</span><span class="cx"> PASS TryAllocate('UndetectableHTMLCollection') is 'no constructor'
</span><span class="cx"> PASS TryAllocate('XPathNSResolver') is 'no constructor'
</span><del>-PASS TryAllocate('EventTarget') is 'no constructor'
</del><span class="cx"> PASS TryAllocate('EventListener') is 'no constructor'
</span><span class="cx"> PASS TryAllocate('NPObject') is 'no constructor'
</span><span class="cx"> PASS TryAllocate('Comment') is '[object Comment]'
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomdomconstructorshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/dom-constructors.html (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/dom-constructors.html 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/fast/dom/dom-constructors.html 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -20,6 +20,7 @@
</span><span class="cx"> 'Element',
</span><span class="cx"> 'Entity',
</span><span class="cx"> 'EntityReference',
</span><ins>+ 'EventTarget',
</ins><span class="cx"> 'HTMLDocument',
</span><span class="cx"> 'Node',
</span><span class="cx"> 'ProcessingInstruction',
</span><span class="lines">@@ -146,7 +147,7 @@
</span><span class="cx"> // These objects should have no constructor.
</span><span class="cx"> var objects_no_constructor = [
</span><span class="cx"> 'EventTargetNode', 'UndetectableHTMLCollection',
</span><del>- 'XPathNSResolver', 'EventTarget', 'EventListener', 'NPObject'
</del><ins>+ 'XPathNSResolver', 'EventListener', 'NPObject'
</ins><span class="cx"> ];
</span><span class="cx">
</span><span class="cx"> // These objects should have a working constructor, but their constructed
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -1,5 +1,19 @@
</span><span class="cx"> 2015-09-12 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ window.EventTarget should exist
+ https://bugs.webkit.org/show_bug.cgi?id=149085
+ <rdar://problem/22546774>
+
+ Reviewed by Sam Weinig.
+
+ Rebaseline several W3C tests now that more checks are passing.
+
+ * web-platform-tests/dom/interface-objects-expected.txt:
+ * web-platform-tests/dom/interfaces-expected.txt:
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2015-09-12 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> ChildNode.replaceWith() without argument should replace the node with an empty DocumentFragment
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149073
</span><span class="cx"> <rdar://problem/22547801>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdominterfaceobjectsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interface-objects-expected.txt (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interface-objects-expected.txt 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interface-objects-expected.txt 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -2,7 +2,7 @@
</span><span class="cx"> PASS Interface objects properties should not be Enumerable
</span><span class="cx"> PASS Should be able to delete Event.
</span><span class="cx"> PASS Should be able to delete CustomEvent.
</span><del>-FAIL Should be able to delete EventTarget. assert_true: Interface should exist. expected true got false
</del><ins>+PASS Should be able to delete EventTarget.
</ins><span class="cx"> PASS Should be able to delete Node.
</span><span class="cx"> PASS Should be able to delete Document.
</span><span class="cx"> PASS Should be able to delete DOMImplementation.
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -226,13 +226,15 @@
</span><span class="cx"> FAIL Event interface: calling initEvent(DOMString,boolean,boolean) on new CustomEvent("foo") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</span><span class="cx"> [native code]
</span><span class="cx"> }" did not throw
</span><del>-FAIL EventTarget interface: existence and properties of interface object assert_own_property: self does not have own property "EventTarget" expected property "EventTarget" missing
-FAIL EventTarget interface object length assert_own_property: self does not have own property "EventTarget" expected property "EventTarget" missing
-FAIL EventTarget interface: existence and properties of interface prototype object assert_own_property: self does not have own property "EventTarget" expected property "EventTarget" missing
-FAIL EventTarget interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "EventTarget" expected property "EventTarget" missing
-FAIL EventTarget interface: operation addEventListener(DOMString,EventListener,boolean) assert_own_property: self does not have own property "EventTarget" expected property "EventTarget" missing
-FAIL EventTarget interface: operation removeEventListener(DOMString,EventListener,boolean) assert_own_property: self does not have own property "EventTarget" expected property "EventTarget" missing
-FAIL EventTarget interface: operation dispatchEvent(Event) assert_own_property: self does not have own property "EventTarget" expected property "EventTarget" missing
</del><ins>+FAIL EventTarget interface: existence and properties of interface object assert_equals: prototype of self's property "EventTarget" is not Function.prototype expected (function) function "function () {
+ [native code]
+}" but got (object) object "[object Object]"
+PASS EventTarget interface object length
+PASS EventTarget interface: existence and properties of interface prototype object
+FAIL EventTarget interface: existence and properties of interface prototype object's "constructor" property assert_true: EventTarget.prototype.constructor is not writable expected true got false
+PASS EventTarget interface: operation addEventListener(DOMString,EventListener,boolean)
+PASS EventTarget interface: operation removeEventListener(DOMString,EventListener,boolean)
+PASS EventTarget interface: operation dispatchEvent(Event)
</ins><span class="cx"> FAIL NodeList interface: existence and properties of interface object assert_equals: prototype of self's property "NodeList" is not Function.prototype expected (function) function "function () {
</span><span class="cx"> [native code]
</span><span class="cx"> }" but got (object) object "[object Object]"
</span><span class="lines">@@ -312,7 +314,7 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" but got (object) object "[object Object]"
</span><span class="cx"> PASS Node interface object length
</span><del>-FAIL Node interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
</del><ins>+FAIL Node interface: existence and properties of interface prototype object assert_equals: prototype of Node.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
</ins><span class="cx"> FAIL Node interface: existence and properties of interface prototype object's "constructor" property assert_true: Node.prototype.constructor is not writable expected true got false
</span><span class="cx"> PASS Node interface: constant ELEMENT_NODE on interface object
</span><span class="cx"> PASS Node interface: constant ELEMENT_NODE on interface prototype object
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -3528,7 +3528,7 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" but got (object) object "[object Object]"
</span><span class="cx"> PASS MediaController interface object length
</span><del>-FAIL MediaController interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
</del><ins>+FAIL MediaController interface: existence and properties of interface prototype object assert_equals: prototype of MediaController.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
</ins><span class="cx"> FAIL MediaController interface: existence and properties of interface prototype object's "constructor" property assert_true: MediaController.prototype.constructor is not writable expected true got false
</span><span class="cx"> FAIL MediaController interface: attribute readyState assert_true: The prototype object must have a property "readyState" expected true got false
</span><span class="cx"> FAIL MediaController interface: attribute buffered assert_throws: getting property on prototype object must throw TypeError function "function () {
</span><span class="lines">@@ -3626,7 +3626,7 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" but got (object) object "[object Object]"
</span><span class="cx"> PASS TextTrackList interface object length
</span><del>-FAIL TextTrackList interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
</del><ins>+FAIL TextTrackList interface: existence and properties of interface prototype object assert_equals: prototype of TextTrackList.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
</ins><span class="cx"> FAIL TextTrackList interface: existence and properties of interface prototype object's "constructor" property assert_own_property: TextTrackList.prototype does not have own property "constructor" expected property "constructor" missing
</span><span class="cx"> FAIL TextTrackList interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
</span><span class="cx"> PASS TextTrackList interface: operation getTrackById(DOMString)
</span><span class="lines">@@ -3655,7 +3655,7 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" but got (object) object "[object Object]"
</span><span class="cx"> PASS TextTrack interface object length
</span><del>-FAIL TextTrack interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
</del><ins>+FAIL TextTrack interface: existence and properties of interface prototype object assert_equals: prototype of TextTrack.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
</ins><span class="cx"> FAIL TextTrack interface: existence and properties of interface prototype object's "constructor" property assert_true: TextTrack.prototype.constructor is not writable expected true got false
</span><span class="cx"> FAIL TextTrack interface: attribute kind assert_true: The prototype object must have a property "kind" expected true got false
</span><span class="cx"> FAIL TextTrack interface: attribute label assert_throws: getting property on prototype object must throw TypeError function "function () {
</span><span class="lines">@@ -3724,7 +3724,7 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" but got (object) object "[object Object]"
</span><span class="cx"> FAIL TextTrackCue interface object length assert_equals: wrong value for TextTrackCue.length expected 0 but got 3
</span><del>-FAIL TextTrackCue interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
</del><ins>+FAIL TextTrackCue interface: existence and properties of interface prototype object assert_equals: prototype of TextTrackCue.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
</ins><span class="cx"> FAIL TextTrackCue interface: existence and properties of interface prototype object's "constructor" property assert_true: TextTrackCue.prototype.constructor is not writable expected true got false
</span><span class="cx"> FAIL TextTrackCue interface: attribute track assert_throws: getting property on prototype object must throw TypeError function "function () {
</span><span class="cx"> [native code]
</span><span class="lines">@@ -5654,7 +5654,7 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" but got (object) object "[object Object]"
</span><span class="cx"> PASS Window interface object length
</span><del>-FAIL Window interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
</del><ins>+FAIL Window interface: existence and properties of interface prototype object assert_equals: prototype of Window.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
</ins><span class="cx"> FAIL Window interface: existence and properties of interface prototype object's "constructor" property assert_own_property: Window.prototype does not have own property "constructor" expected property "constructor" missing
</span><span class="cx"> FAIL Window interface: attribute self assert_true: The prototype object must have a property "self" expected true got false
</span><span class="cx"> FAIL Window interface: attribute name assert_true: The prototype object must have a property "name" expected true got false
</span><span class="lines">@@ -6256,7 +6256,7 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" but got (object) object "[object Object]"
</span><span class="cx"> PASS EventSource interface object length
</span><del>-FAIL EventSource interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
</del><ins>+FAIL EventSource interface: existence and properties of interface prototype object assert_equals: prototype of EventSource.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
</ins><span class="cx"> FAIL EventSource interface: existence and properties of interface prototype object's "constructor" property assert_true: EventSource.prototype.constructor is not writable expected true got false
</span><span class="cx"> FAIL EventSource interface: attribute url assert_throws: getting property on prototype object must throw TypeError function "function () {
</span><span class="cx"> [native code]
</span><span class="lines">@@ -6287,7 +6287,7 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" but got (object) object "[object Object]"
</span><span class="cx"> PASS WebSocket interface object length
</span><del>-FAIL WebSocket interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
</del><ins>+FAIL WebSocket interface: existence and properties of interface prototype object assert_equals: prototype of WebSocket.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
</ins><span class="cx"> FAIL WebSocket interface: existence and properties of interface prototype object's "constructor" property assert_true: WebSocket.prototype.constructor is not writable expected true got false
</span><span class="cx"> FAIL WebSocket interface: attribute url assert_throws: getting property on prototype object must throw TypeError function "function () {
</span><span class="cx"> [native code]
</span><span class="lines">@@ -6363,7 +6363,7 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" but got (object) object "[object Object]"
</span><span class="cx"> PASS MessagePort interface object length
</span><del>-FAIL MessagePort interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
</del><ins>+FAIL MessagePort interface: existence and properties of interface prototype object assert_equals: prototype of MessagePort.prototype is not EventTarget.prototype expected object "[object EventTargetPrototype]" but got object "[object Object]"
</ins><span class="cx"> FAIL MessagePort interface: existence and properties of interface prototype object's "constructor" property assert_true: MessagePort.prototype.constructor is not writable expected true got false
</span><span class="cx"> PASS MessagePort interface: operation postMessage(any,[object Object])
</span><span class="cx"> PASS MessagePort interface: operation start()
</span><span class="lines">@@ -6426,7 +6426,7 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" but got (object) object "[object Object]"
</span><span class="cx"> PASS Worker interface object length
</span><del>-FAIL Worker interface: existence and properties of interface prototype object assert_own_property: should inherit from EventTarget, but self has no such property expected property "EventTarget" missing
</del><ins>+PASS Worker interface: existence and properties of interface prototype object
</ins><span class="cx"> FAIL Worker interface: existence and properties of interface prototype object's "constructor" property assert_true: Worker.prototype.constructor is not writable expected true got false
</span><span class="cx"> PASS Worker interface: operation terminate()
</span><span class="cx"> PASS Worker interface: operation postMessage(any,[object Object])
</span></span></pre></div>
<a id="trunkLayoutTestsplatformefljsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -343,6 +343,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').value is EventTarget
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').value is File
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkjsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -348,6 +348,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').value is EventTarget
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').value is File
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacjsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -338,6 +338,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').value is EventTarget
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').value is File
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacmavericksjsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -338,6 +338,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').value is EventTarget
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').value is File
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacyosemitejsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -338,6 +338,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').value is EventTarget
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').value is File
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwinjsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -268,6 +268,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'EventSource').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').value is EventTarget
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'EventTarget').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').value is File
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'File').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/Source/WebCore/ChangeLog 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-09-12 Chris Dumez <cdumez@apple.com>
+
+ window.EventTarget should exist
+ https://bugs.webkit.org/show_bug.cgi?id=149085
+ <rdar://problem/22546774>
+
+ Reviewed by Sam Weinig.
+
+ Drop [NoInterfaceObject] for the EventTarget interface to match Chrome,
+ Firefox and the specification:
+ https://dom.spec.whatwg.org/#interface-eventtarget
+
+ No new tests, already covered by existing tests.
+
+ * dom/EventTarget.idl:
+
</ins><span class="cx"> 2015-09-12 Brian Burg <bburg@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: disambiguate inspected/frontend controllers and pages in backend code
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventTargetidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EventTarget.idl (189659 => 189660)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EventTarget.idl 2015-09-12 21:49:59 UTC (rev 189659)
+++ trunk/Source/WebCore/dom/EventTarget.idl 2015-09-12 21:52:25 UTC (rev 189660)
</span><span class="lines">@@ -20,7 +20,6 @@
</span><span class="cx">
</span><span class="cx"> // Introduced in DOM Level 2:
</span><span class="cx"> [
</span><del>- NoInterfaceObject,
</del><span class="cx"> ObjCProtocol,
</span><span class="cx"> CPPPureInterface,
</span><span class="cx"> CustomToJSObject,
</span></span></pre>
</div>
</div>
</body>
</html>