<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189618] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189618">189618</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-09-11 07:51:32 -0700 (Fri, 11 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Element.tagName should be upper-case for HTML elements in HTML documents
https://bugs.webkit.org/show_bug.cgi?id=148843
<rdar://problem/22559081>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
* web-platform-tests/dom/nodes/Document-createElementNS-expected.txt:
* web-platform-tests/dom/nodes/Element-tagName-expected.txt:
* web-platform-tests/dom/nodes/Node-nodeName-expected.txt:
* web-platform-tests/html/semantics/tabular-data/the-table-element/table-insertRow-expected.txt:
Source/WebCore:
Element.tagName should be upper-case for HTML elements in HTML documents,
as per the DOM specification:
https://dom.spec.whatwg.org/#dom-element-tagname
Previously, WebKit would fail to upper-case the tagname if the element's
tag had a prefix. This patch corrects this. This aligns our behavior with
Firefox, Chrome and IE.
No new tests, already covered by existing tests.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::nodeName):
LayoutTests:
Update / rebaseline test now that our behavior has changed.
* fast/dom/Node/initial-values-expected.txt:
* fast/dom/Node/script-tests/initial-values.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomNodeinitialvaluesexpectedtxt">trunk/LayoutTests/fast/dom/Node/initial-values-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomNodescripttestsinitialvaluesjs">trunk/LayoutTests/fast/dom/Node/script-tests/initial-values.js</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesDocumentcreateElementNSexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElementNS-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesElementtagNameexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-tagName-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesNodenodeNameexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-nodeName-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetableelementtableinsertRowexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/table-insertRow-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLElementcpp">trunk/Source/WebCore/html/HTMLElement.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (189617 => 189618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-11 14:50:37 UTC (rev 189617)
+++ trunk/LayoutTests/ChangeLog 2015-09-11 14:51:32 UTC (rev 189618)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2015-09-11 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Element.tagName should be upper-case for HTML elements in HTML documents
+ https://bugs.webkit.org/show_bug.cgi?id=148843
+ <rdar://problem/22559081>
+
+ Reviewed by Ryosuke Niwa.
+
+ Update / rebaseline test now that our behavior has changed.
+
+ * fast/dom/Node/initial-values-expected.txt:
+ * fast/dom/Node/script-tests/initial-values.js:
+
+2015-09-11 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> document.body = "text" should throw a TypeError, not a HierarchyRequestError
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149057
</span><span class="cx"> <rdar://problem/22567157>
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomNodeinitialvaluesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Node/initial-values-expected.txt (189617 => 189618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Node/initial-values-expected.txt 2015-09-11 14:50:37 UTC (rev 189617)
+++ trunk/LayoutTests/fast/dom/Node/initial-values-expected.txt 2015-09-11 14:51:32 UTC (rev 189618)
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx"> PASS element.nodeValue is null
</span><span class="cx"> PASS element.attributes.toString() is '[object NamedNodeMap]'
</span><span class="cx"> Prefixed element creation using createElementNS on an HTML doc:
</span><del>-PASS element.nodeName is 'html:pre'
</del><ins>+PASS element.nodeName is 'HTML:PRE'
</ins><span class="cx"> PASS element.localName is 'pre'
</span><span class="cx"> PASS element.namespaceURI is 'http://www.w3.org/1999/xhtml'
</span><span class="cx"> PASS element.prefix is 'html'
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomNodescripttestsinitialvaluesjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Node/script-tests/initial-values.js (189617 => 189618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Node/script-tests/initial-values.js 2015-09-11 14:50:37 UTC (rev 189617)
+++ trunk/LayoutTests/fast/dom/Node/script-tests/initial-values.js 2015-09-11 14:51:32 UTC (rev 189618)
</span><span class="lines">@@ -101,7 +101,7 @@
</span><span class="cx">
</span><span class="cx"> debug("Prefixed element creation using createElementNS on an HTML doc:")
</span><span class="cx"> element = document.createElementNS("http://www.w3.org/1999/xhtml", "html:pre");
</span><del>-shouldBe("element.nodeName", "'html:pre'");
</del><ins>+shouldBe("element.nodeName", "'HTML:PRE'");
</ins><span class="cx"> shouldBe("element.localName", "'pre'");
</span><span class="cx"> shouldBe("element.namespaceURI", "'http://www.w3.org/1999/xhtml'");
</span><span class="cx"> shouldBe("element.prefix", "'html'");
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (189617 => 189618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2015-09-11 14:50:37 UTC (rev 189617)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2015-09-11 14:51:32 UTC (rev 189618)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2015-09-11 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Element.tagName should be upper-case for HTML elements in HTML documents
+ https://bugs.webkit.org/show_bug.cgi?id=148843
+ <rdar://problem/22559081>
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline several W3C tests now that more checks are passing.
+
+ * web-platform-tests/dom/nodes/Document-createElementNS-expected.txt:
+ * web-platform-tests/dom/nodes/Element-tagName-expected.txt:
+ * web-platform-tests/dom/nodes/Node-nodeName-expected.txt:
+ * web-platform-tests/html/semantics/tabular-data/the-table-element/table-insertRow-expected.txt:
+
+2015-09-11 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> document.body = "text" should throw a TypeError, not a HierarchyRequestError
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149057
</span><span class="cx"> <rdar://problem/22567157>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesDocumentcreateElementNSexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElementNS-expected.txt (189617 => 189618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElementNS-expected.txt 2015-09-11 14:50:37 UTC (rev 189617)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElementNS-expected.txt 2015-09-11 14:51:32 UTC (rev 189618)
</span><span class="lines">@@ -172,11 +172,11 @@
</span><span class="cx"> FAIL createElementNS test 169: "foo:",null,null InvalidCharacterError: DOM Exception 5
</span><span class="cx"> PASS createElementNS test 170: "foo:","","INVALID_CHARACTER_ERR"
</span><span class="cx"> PASS Lower-case HTML element without a prefix
</span><del>-FAIL Lower-case HTML element with a prefix assert_equals: expected "HTML:SPAN" but got "html:span"
</del><ins>+PASS Lower-case HTML element with a prefix
</ins><span class="cx"> PASS Lower-case non-HTML element without a prefix
</span><span class="cx"> PASS Lower-case non-HTML element with a prefix
</span><span class="cx"> PASS Upper-case HTML element without a prefix
</span><del>-FAIL Upper-case HTML element with a prefix assert_equals: expected "HTML:SPAN" but got "html:SPAN"
</del><ins>+PASS Upper-case HTML element with a prefix
</ins><span class="cx"> PASS Upper-case non-HTML element without a prefix
</span><span class="cx"> PASS Upper-case non-HTML element with a prefix
</span><span class="cx"> PASS null namespace
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesElementtagNameexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-tagName-expected.txt (189617 => 189618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-tagName-expected.txt 2015-09-11 14:50:37 UTC (rev 189617)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-tagName-expected.txt 2015-09-11 14:51:32 UTC (rev 189618)
</span><span class="lines">@@ -1,7 +1,7 @@
</span><span class="cx">
</span><del>-FAIL tagName should upper-case for HTML elements in HTML documents. assert_equals: expected "X:B" but got "x:b"
</del><ins>+PASS tagName should upper-case for HTML elements in HTML documents.
</ins><span class="cx"> PASS tagName should not upper-case for SVG elements in HTML documents.
</span><span class="cx"> PASS tagName should be updated when changing ownerDocument
</span><span class="cx"> PASS tagName should be updated when changing ownerDocument (createDocument without prefix)
</span><del>-FAIL tagName should be updated when changing ownerDocument (createDocument with prefix) assert_equals: tagName should be uppercase in HTML expected "FOO:DIV" but got "foo:div"
</del><ins>+PASS tagName should be updated when changing ownerDocument (createDocument with prefix)
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesNodenodeNameexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-nodeName-expected.txt (189617 => 189618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-nodeName-expected.txt 2015-09-11 14:50:37 UTC (rev 189617)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-nodeName-expected.txt 2015-09-11 14:51:32 UTC (rev 189618)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx">
</span><del>-FAIL For Element nodes, nodeName should return the same as tagName. assert_equals: expected "X:B" but got "x:b"
</del><ins>+PASS For Element nodes, nodeName should return the same as tagName.
</ins><span class="cx"> PASS For Text nodes, nodeName should return "#text".
</span><span class="cx"> PASS For Comment nodes, nodeName should return "#comment".
</span><span class="cx"> PASS For Document nodes, nodeName should return "#document".
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetableelementtableinsertRowexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/table-insertRow-expected.txt (189617 => 189618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/table-insertRow-expected.txt 2015-09-11 14:50:37 UTC (rev 189617)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/table-insertRow-expected.txt 2015-09-11 14:51:32 UTC (rev 189618)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx">
</span><del>-FAIL insertRow should not copy prefixes assert_equals: Parent tag name should be HTML:TABLE expected "HTML:TABLE" but got "html:table"
</del><ins>+PASS insertRow should not copy prefixes
</ins><span class="cx"> PASS insertRow should insert into a tbody, not into a thead, if table.rows is empty
</span><span class="cx"> PASS insertRow should insert into a tbody, not into a tfoot, if table.rows is empty
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (189617 => 189618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-11 14:50:37 UTC (rev 189617)
+++ trunk/Source/WebCore/ChangeLog 2015-09-11 14:51:32 UTC (rev 189618)
</span><span class="lines">@@ -1,5 +1,26 @@
</span><span class="cx"> 2015-09-11 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Element.tagName should be upper-case for HTML elements in HTML documents
+ https://bugs.webkit.org/show_bug.cgi?id=148843
+ <rdar://problem/22559081>
+
+ Reviewed by Ryosuke Niwa.
+
+ Element.tagName should be upper-case for HTML elements in HTML documents,
+ as per the DOM specification:
+ https://dom.spec.whatwg.org/#dom-element-tagname
+
+ Previously, WebKit would fail to upper-case the tagname if the element's
+ tag had a prefix. This patch corrects this. This aligns our behavior with
+ Firefox, Chrome and IE.
+
+ No new tests, already covered by existing tests.
+
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::nodeName):
+
+2015-09-11 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> document.body = "text" should throw a TypeError, not a HierarchyRequestError
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=149057
</span><span class="cx"> <rdar://problem/22567157>
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLElement.cpp (189617 => 189618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLElement.cpp 2015-09-11 14:50:37 UTC (rev 189617)
+++ trunk/Source/WebCore/html/HTMLElement.cpp 2015-09-11 14:51:32 UTC (rev 189618)
</span><span class="lines">@@ -75,9 +75,11 @@
</span><span class="cx"> {
</span><span class="cx"> // FIXME: Would be nice to have an atomicstring lookup based off uppercase
</span><span class="cx"> // chars that does not have to copy the string on a hit in the hash.
</span><del>- // FIXME: We should have a way to detect XHTML elements and replace the hasPrefix() check with it.
- if (document().isHTMLDocument() && !tagQName().hasPrefix())
- return tagQName().localNameUpper();
</del><ins>+ if (document().isHTMLDocument()) {
+ if (!tagQName().hasPrefix())
+ return tagQName().localNameUpper();
+ return Element::nodeName().upper();
+ }
</ins><span class="cx"> return Element::nodeName();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>