<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189595] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189595">189595</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2015-09-10 15:59:08 -0700 (Thu, 10 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
https://bugs.webkit.org/show_bug.cgi?id=142929
Reviewed by Brent Fulgham.
Tools:
Silence the logging. We'll track fixing the root cause in Radar.
* Scripts/webkitpy/port/mac.py:
(MacPort.stderr_patterns_to_strip): Added a FIXME.
* Scripts/webkitpy/port/win.py:
(WinPort.logging_patterns_to_strip): Added.
LayoutTests:
* platform/win/TestExpectations: Unskip some newly added tests that are affected.
We still skip the whole media directory - updating the results and unskipping those
tests would be a separate project.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformwinTestExpectations">trunk/LayoutTests/platform/win/TestExpectations</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpyportmacpy">trunk/Tools/Scripts/webkitpy/port/mac.py</a></li>
<li><a href="#trunkToolsScriptswebkitpyportwinpy">trunk/Tools/Scripts/webkitpy/port/win.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (189594 => 189595)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-10 22:15:46 UTC (rev 189594)
+++ trunk/LayoutTests/ChangeLog 2015-09-10 22:59:08 UTC (rev 189595)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-09-10 Alexey Proskuryakov <ap@apple.com>
+
+ Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
+ https://bugs.webkit.org/show_bug.cgi?id=142929
+
+ Reviewed by Brent Fulgham.
+
+ * platform/win/TestExpectations: Unskip some newly added tests that are affected.
+ We still skip the whole media directory - updating the results and unskipping those
+ tests would be a separate project.
+
</ins><span class="cx"> 2015-09-10 David Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><span class="cx"> [New Block-Inside-Inline Model] Self-collapsing block check needs to account for anonymous inline blocks
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwinTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/win/TestExpectations (189594 => 189595)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/TestExpectations 2015-09-10 22:15:46 UTC (rev 189594)
+++ trunk/LayoutTests/platform/win/TestExpectations 2015-09-10 22:59:08 UTC (rev 189595)
</span><span class="lines">@@ -726,8 +726,6 @@
</span><span class="cx">
</span><span class="cx"> # Sensitive to load timing or PHP behavior
</span><span class="cx"> webkit.org/b/44873 http/tests/css/css-image-loading.html [ Skip ]
</span><del>-webkit.org/b/149007 http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html [ Pass Failure ]
-http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html [ Pass Failure ] # Flaky
</del><span class="cx">
</span><span class="cx"> # Assertion failure in replaySavedEvents http://webkit.org/b/21796
</span><span class="cx"> webkit.org/b/21796 fast/events/dragging-mouse-moves.html [ Skip ]
</span><span class="lines">@@ -752,15 +750,13 @@
</span><span class="cx"> ################################################################################
</span><span class="cx"> # Deactivate all media tests on Apple Windows due to <rdar://problem/18681688> generating
</span><span class="cx"> # spam logging output that causes tests to fail. Will re-enable once this is fixed.
</span><ins>+# FIXME: We now filter out the logging, so many of the tests can likely be re-enabled.
</ins><span class="cx"> media [ Skip ]
</span><span class="cx"> fast/media [ Skip ]
</span><span class="cx"> http/tests/media [ Skip ]
</span><span class="cx">
</span><span class="cx"> fast/layers/video-layer.html [ Skip ] # Skip until video control changes are done.
</span><span class="cx">
</span><del>-# "AQMEIOManager::FindIOUnit: error -1" errors in tests output.
-webkit.org/b/148903 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ [ Skip ]
-
</del><span class="cx"> # Assertion failures
</span><span class="cx"> webkit.org/b/48910 [ Debug ] http/tests/media/pdf-served-as-pdf.html [ Skip ] # Crashing
</span><span class="cx"> webkit.org/b/48910 http/tests/media/video-cancel-load.html [ Skip ] # Crashing
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (189594 => 189595)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-09-10 22:15:46 UTC (rev 189594)
+++ trunk/Tools/ChangeLog 2015-09-10 22:59:08 UTC (rev 189595)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-09-10 Alexey Proskuryakov <ap@apple.com>
+
+ Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
+ https://bugs.webkit.org/show_bug.cgi?id=142929
+
+ Reviewed by Brent Fulgham.
+
+ Silence the logging. We'll track fixing the root cause in Radar.
+
+ * Scripts/webkitpy/port/mac.py:
+ (MacPort.stderr_patterns_to_strip): Added a FIXME.
+
+ * Scripts/webkitpy/port/win.py:
+ (WinPort.logging_patterns_to_strip): Added.
+
</ins><span class="cx"> 2015-09-09 Andy Estes <aestes@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpyportmacpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/port/mac.py (189594 => 189595)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/port/mac.py 2015-09-10 22:15:46 UTC (rev 189594)
+++ trunk/Tools/Scripts/webkitpy/port/mac.py 2015-09-10 22:59:08 UTC (rev 189595)
</span><span class="lines">@@ -312,6 +312,7 @@
</span><span class="cx">
</span><span class="cx"> def stderr_patterns_to_strip(self):
</span><span class="cx"> worthless_patterns = []
</span><ins>+ # FIXME: We still get CoreMedia stderr logging that doesn't match the below lines. 'defaults write com.apple.coremedia fig_notes 0' may work better for silencing them all, however running tests shouldn't change user's defaults.
</ins><span class="cx"> worthless_patterns.append((re.compile('.*(Fig|fig|itemasync|vt|mv_|PullParamSetSPS|ccrp_|client).* signalled err=.*\n'), ''))
</span><span class="cx"> worthless_patterns.append((re.compile('.*<<<< FigFilePlayer >>>>.*\n'), ''))
</span><span class="cx"> worthless_patterns.append((re.compile('.*<<<< FigFile >>>>.*\n'), ''))
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpyportwinpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/port/win.py (189594 => 189595)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/port/win.py 2015-09-10 22:15:46 UTC (rev 189594)
+++ trunk/Tools/Scripts/webkitpy/port/win.py 2015-09-10 22:59:08 UTC (rev 189595)
</span><span class="lines">@@ -328,3 +328,7 @@
</span><span class="cx"> pass
</span><span class="cx">
</span><span class="cx"> return system_pid
</span><ins>+
+ def logging_patterns_to_strip(self):
+ # rdar://problem/18681688
+ return [(re.compile('AQMEIOManager::FindIOUnit: error \-1\n'), '')]
</ins></span></pre>
</div>
</div>
</body>
</html>