<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189576] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189576">189576</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-09-10 11:02:15 -0700 (Thu, 10 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Node.appendChild(null) / replaceChild(null, null) / removeChild(null) / insertBefore(null, ref) should throw a TypeError
https://bugs.webkit.org/show_bug.cgi?id=148971
<rdar://problem/22560883>
<rdar://problem/22559225>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C tests now that more checks are passing.
* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/dom/nodes/Node-appendChild-expected.txt:
* web-platform-tests/dom/nodes/Node-insertBefore-expected.txt:
* web-platform-tests/dom/nodes/Node-removeChild-expected.txt:
* web-platform-tests/dom/nodes/Node-replaceChild-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Node.appendChild(null) / replaceChild(null, null) / removeChild(null)
and insertBefore(null, ref) should throw a TypeError instead of a
NotFoundError, as per the specification:
https://dom.spec.whatwg.org/#node
The parameters are not nullable so the Web IDL specification says
we should throw a TypeError in this case.
This patch moves the null-checking from ContainerNode to the methods
on Node. The null-checking is supposed to be done by the bindings code
but our generator currently does not support this so we do the null
checking as close to the bindings as possible. The bindings code is
calling the methods on Node. This also makes sure we throw a TypeError
for null-argument when the Node is not a ContainerNode. For e.g.
Text.appendChild(null) should throw a TypeError too.
The methods on ContainerNode now take references insteaad of pointer
parameters now that the null-checking is done at the call site in
Node. This lead to a lot of code update as those methods are used
a lot throughout the code base.
No new tests, already covered by pre-existing layout tests.
Source/WebKit/mac:
ContainerNode::appendChild() now takes a Ref<Node>&& parameter so we
need to update the call site.
* WebView/WebFrame.mm:
(-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
Source/WebKit2:
ContainerNode::appendChild() now takes a Ref<Node>&& parameter so we
need to update the call sites.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::PDFPlugin):
* WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::attach):
(WebKit::PDFPluginAnnotation::~PDFPluginAnnotation):
* WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
(WebKit::PDFPluginChoiceAnnotation::createAnnotationElement):
LayoutTests:
Update / rebaseline tests now that we throw a different exception type.
* fast/dom/Document/replaceChild-null-oldChild-expected.txt:
* fast/dom/Document/script-tests/replaceChild-null-oldChild.js:
* fast/dom/Node/fragment-mutation-expected.txt:
* fast/dom/Node/fragment-mutation.html:
* fast/dom/incompatible-operations-expected.txt:
* fast/dom/incompatible-operations.html:
* fast/dom/move-nodes-across-documents.html:
* fast/dom/processing-instruction-appendChild-exceptions-expected.txt:
* fast/dom/processing-instruction-appendChild-exceptions.xhtml:
* fast/dom/setter-type-enforcement-expected.txt:
* fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
* fast/inspector-support/uncaught-dom8-exception.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomDocumentreplaceChildnulloldChildexpectedtxt">trunk/LayoutTests/fast/dom/Document/replaceChild-null-oldChild-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomDocumentscripttestsreplaceChildnulloldChildjs">trunk/LayoutTests/fast/dom/Document/script-tests/replaceChild-null-oldChild.js</a></li>
<li><a href="#trunkLayoutTestsfastdomNodefragmentmutationexpectedtxt">trunk/LayoutTests/fast/dom/Node/fragment-mutation-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomNodefragmentmutationhtml">trunk/LayoutTests/fast/dom/Node/fragment-mutation.html</a></li>
<li><a href="#trunkLayoutTestsfastdomincompatibleoperationsexpectedtxt">trunk/LayoutTests/fast/dom/incompatible-operations-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomincompatibleoperationshtml">trunk/LayoutTests/fast/dom/incompatible-operations.html</a></li>
<li><a href="#trunkLayoutTestsfastdommovenodesacrossdocumentshtml">trunk/LayoutTests/fast/dom/move-nodes-across-documents.html</a></li>
<li><a href="#trunkLayoutTestsfastdomprocessinginstructionappendChildexceptionsexpectedtxt">trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomprocessinginstructionappendChildexceptionsxhtml">trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml</a></li>
<li><a href="#trunkLayoutTestsfastdomtimerclearintervalinhandlerandgenerateerrorexpectedtxt">trunk/LayoutTests/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsremovetargetwithshadowindragexpectedtxt">trunk/LayoutTests/fast/events/remove-target-with-shadow-in-drag-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastinspectorsupportuncaughtdom8exceptionhtml">trunk/LayoutTests/fast/inspector-support/uncaught-dom8-exception.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesNodeappendChildexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-appendChild-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesNodeinsertBeforeexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-insertBefore-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesNoderemoveChildexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-removeChild-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesNodereplaceChildexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-replaceChild-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsdomdotnodebaseexceptionexpectedtxt">trunk/LayoutTests/js/dom/dot-node-base-exception-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsdomscripttestsdotnodebaseexceptionjs">trunk/LayoutTests/js/dom/script-tests/dot-node-base-exception.js</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulespluginsYouTubePluginReplacementcpp">trunk/Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsobjcDOMHTMLmm">trunk/Source/WebCore/bindings/objc/DOMHTML.mm</a></li>
<li><a href="#trunkSourceWebCoredomAttrcpp">trunk/Source/WebCore/dom/Attr.cpp</a></li>
<li><a href="#trunkSourceWebCoredomAttrh">trunk/Source/WebCore/dom/Attr.h</a></li>
<li><a href="#trunkSourceWebCoredomCDATASectioncpp">trunk/Source/WebCore/dom/CDATASection.cpp</a></li>
<li><a href="#trunkSourceWebCoredomCDATASectionh">trunk/Source/WebCore/dom/CDATASection.h</a></li>
<li><a href="#trunkSourceWebCoredomCommentcpp">trunk/Source/WebCore/dom/Comment.cpp</a></li>
<li><a href="#trunkSourceWebCoredomCommenth">trunk/Source/WebCore/dom/Comment.h</a></li>
<li><a href="#trunkSourceWebCoredomContainerNodecpp">trunk/Source/WebCore/dom/ContainerNode.cpp</a></li>
<li><a href="#trunkSourceWebCoredomContainerNodeh">trunk/Source/WebCore/dom/ContainerNode.h</a></li>
<li><a href="#trunkSourceWebCoredomDOMImplementationcpp">trunk/Source/WebCore/dom/DOMImplementation.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/Document.h</a></li>
<li><a href="#trunkSourceWebCoredomDocumentFragmentcpp">trunk/Source/WebCore/dom/DocumentFragment.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumentFragmenth">trunk/Source/WebCore/dom/DocumentFragment.h</a></li>
<li><a href="#trunkSourceWebCoredomDocumentTypecpp">trunk/Source/WebCore/dom/DocumentType.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumentTypeh">trunk/Source/WebCore/dom/DocumentType.h</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCoredomElementh">trunk/Source/WebCore/dom/Element.h</a></li>
<li><a href="#trunkSourceWebCoredomEntityReferencecpp">trunk/Source/WebCore/dom/EntityReference.cpp</a></li>
<li><a href="#trunkSourceWebCoredomEntityReferenceh">trunk/Source/WebCore/dom/EntityReference.h</a></li>
<li><a href="#trunkSourceWebCoredomNodecpp">trunk/Source/WebCore/dom/Node.cpp</a></li>
<li><a href="#trunkSourceWebCoredomNodeh">trunk/Source/WebCore/dom/Node.h</a></li>
<li><a href="#trunkSourceWebCoredomProcessingInstructioncpp">trunk/Source/WebCore/dom/ProcessingInstruction.cpp</a></li>
<li><a href="#trunkSourceWebCoredomProcessingInstructionh">trunk/Source/WebCore/dom/ProcessingInstruction.h</a></li>
<li><a href="#trunkSourceWebCoredomRangecpp">trunk/Source/WebCore/dom/Range.cpp</a></li>
<li><a href="#trunkSourceWebCoredomShadowRootcpp">trunk/Source/WebCore/dom/ShadowRoot.cpp</a></li>
<li><a href="#trunkSourceWebCoredomShadowRooth">trunk/Source/WebCore/dom/ShadowRoot.h</a></li>
<li><a href="#trunkSourceWebCoredomTextcpp">trunk/Source/WebCore/dom/Text.cpp</a></li>
<li><a href="#trunkSourceWebCoredomTexth">trunk/Source/WebCore/dom/Text.h</a></li>
<li><a href="#trunkSourceWebCoreeditingAppendNodeCommandcpp">trunk/Source/WebCore/editing/AppendNodeCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingAppendNodeCommandh">trunk/Source/WebCore/editing/AppendNodeCommand.h</a></li>
<li><a href="#trunkSourceWebCoreeditingCompositeEditCommandcpp">trunk/Source/WebCore/editing/CompositeEditCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingDeleteSelectionCommandcpp">trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingEditorcpp">trunk/Source/WebCore/editing/Editor.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingEditorCommandcpp">trunk/Source/WebCore/editing/EditorCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingInsertLineBreakCommandcpp">trunk/Source/WebCore/editing/InsertLineBreakCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingInsertNodeBeforeCommandcpp">trunk/Source/WebCore/editing/InsertNodeBeforeCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingInsertParagraphSeparatorCommandcpp">trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingMergeIdenticalElementsCommandcpp">trunk/Source/WebCore/editing/MergeIdenticalElementsCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingRemoveNodeCommandcpp">trunk/Source/WebCore/editing/RemoveNodeCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingRemoveNodeCommandh">trunk/Source/WebCore/editing/RemoveNodeCommand.h</a></li>
<li><a href="#trunkSourceWebCoreeditingReplaceNodeWithSpanCommandcpp">trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingReplaceSelectionCommandcpp">trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingSplitElementCommandcpp">trunk/Source/WebCore/editing/SplitElementCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingSplitTextNodeCommandcpp">trunk/Source/WebCore/editing/SplitTextNodeCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingWrapContentsInDummySpanCommandcpp">trunk/Source/WebCore/editing/WrapContentsInDummySpanCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingcocoaEditorCocoamm">trunk/Source/WebCore/editing/cocoa/EditorCocoa.mm</a></li>
<li><a href="#trunkSourceWebCoreeditinghtmleditingcpp">trunk/Source/WebCore/editing/htmlediting.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditinghtmleditingh">trunk/Source/WebCore/editing/htmlediting.h</a></li>
<li><a href="#trunkSourceWebCoreeditingiosEditorIOSmm">trunk/Source/WebCore/editing/ios/EditorIOS.mm</a></li>
<li><a href="#trunkSourceWebCoreeditingmacEditorMacmm">trunk/Source/WebCore/editing/mac/EditorMac.mm</a></li>
<li><a href="#trunkSourceWebCoreeditingmarkupcpp">trunk/Source/WebCore/editing/markup.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingmarkuph">trunk/Source/WebCore/editing/markup.h</a></li>
<li><a href="#trunkSourceWebCorehtmlBaseChooserOnlyDateAndTimeInputTypecpp">trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlColorInputTypecpp">trunk/Source/WebCore/html/ColorInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlFTPDirectoryDocumentcpp">trunk/Source/WebCore/html/FTPDirectoryDocument.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLDetailsElementcpp">trunk/Source/WebCore/html/HTMLDetailsElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLElementcpp">trunk/Source/WebCore/html/HTMLElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLElementh">trunk/Source/WebCore/html/HTMLElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLImageElementcpp">trunk/Source/WebCore/html/HTMLImageElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLKeygenElementcpp">trunk/Source/WebCore/html/HTMLKeygenElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMeterElementcpp">trunk/Source/WebCore/html/HTMLMeterElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOptionElementcpp">trunk/Source/WebCore/html/HTMLOptionElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLProgressElementcpp">trunk/Source/WebCore/html/HTMLProgressElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLScriptElementcpp">trunk/Source/WebCore/html/HTMLScriptElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLScriptElementh">trunk/Source/WebCore/html/HTMLScriptElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSelectElementcpp">trunk/Source/WebCore/html/HTMLSelectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableElementcpp">trunk/Source/WebCore/html/HTMLTableElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableElementh">trunk/Source/WebCore/html/HTMLTableElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableRowElementcpp">trunk/Source/WebCore/html/HTMLTableRowElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableRowElementh">trunk/Source/WebCore/html/HTMLTableRowElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableSectionElementcpp">trunk/Source/WebCore/html/HTMLTableSectionElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTemplateElementcpp">trunk/Source/WebCore/html/HTMLTemplateElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTemplateElementh">trunk/Source/WebCore/html/HTMLTemplateElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTextAreaElementcpp">trunk/Source/WebCore/html/HTMLTextAreaElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlImageDocumentcpp">trunk/Source/WebCore/html/ImageDocument.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlMediaDocumentcpp">trunk/Source/WebCore/html/MediaDocument.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlPluginDocumentcpp">trunk/Source/WebCore/html/PluginDocument.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlRangeInputTypecpp">trunk/Source/WebCore/html/RangeInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlSearchInputTypecpp">trunk/Source/WebCore/html/SearchInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlTextFieldInputTypecpp">trunk/Source/WebCore/html/TextFieldInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlValidationMessagecpp">trunk/Source/WebCore/html/ValidationMessage.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowMediaControlElementscpp">trunk/Source/WebCore/html/shadow/MediaControlElements.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowMediaControlscpp">trunk/Source/WebCore/html/shadow/MediaControls.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowMediaControlsApplecpp">trunk/Source/WebCore/html/shadow/MediaControlsApple.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowSliderThumbElementcpp">trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowSliderThumbElementh">trunk/Source/WebCore/html/shadow/SliderThumbElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowmacImageControlsRootElementMaccpp">trunk/Source/WebCore/html/shadow/mac/ImageControlsRootElementMac.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackVTTCuecpp">trunk/Source/WebCore/html/track/VTTCue.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackVTTRegioncpp">trunk/Source/WebCore/html/track/VTTRegion.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackVTTRegionh">trunk/Source/WebCore/html/track/VTTRegion.h</a></li>
<li><a href="#trunkSourceWebCorehtmltrackWebVTTElementcpp">trunk/Source/WebCore/html/track/WebVTTElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackWebVTTElementh">trunk/Source/WebCore/html/track/WebVTTElement.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorCSSAgentcpp">trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDragControllercpp">trunk/Source/WebCore/page/DragController.cpp</a></li>
<li><a href="#trunkSourceWebCorepageiosFrameIOSmm">trunk/Source/WebCore/page/ios/FrameIOS.mm</a></li>
<li><a href="#trunkSourceWebCoresvgSVGScriptElementcpp">trunk/Source/WebCore/svg/SVGScriptElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGScriptElementh">trunk/Source/WebCore/svg/SVGScriptElement.h</a></li>
<li><a href="#trunkSourceWebCoresvgSVGUseElementcpp">trunk/Source/WebCore/svg/SVGUseElement.cpp</a></li>
<li><a href="#trunkSourceWebCorexmlXMLTreeViewercpp">trunk/Source/WebCore/xml/XMLTreeViewer.cpp</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebFramemm">trunk/Source/WebKit/mac/WebView/WebFrame.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebHTMLViewmm">trunk/Source/WebKit/mac/WebView/WebHTMLView.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessPluginsPDFPDFPluginmm">trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessPluginsPDFPDFPluginAnnotationmm">trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessPluginsPDFPDFPluginChoiceAnnotationmm">trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/ChangeLog 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2015-09-10 Chris Dumez <cdumez@apple.com>
+
+ Node.appendChild(null) / replaceChild(null, null) / removeChild(null) / insertBefore(null, ref) should throw a TypeError
+ https://bugs.webkit.org/show_bug.cgi?id=148971
+ <rdar://problem/22560883>
+ <rdar://problem/22559225>
+
+ Reviewed by Ryosuke Niwa.
+
+ Update / rebaseline tests now that we throw a different exception type.
+
+ * fast/dom/Document/replaceChild-null-oldChild-expected.txt:
+ * fast/dom/Document/script-tests/replaceChild-null-oldChild.js:
+ * fast/dom/Node/fragment-mutation-expected.txt:
+ * fast/dom/Node/fragment-mutation.html:
+ * fast/dom/incompatible-operations-expected.txt:
+ * fast/dom/incompatible-operations.html:
+ * fast/dom/move-nodes-across-documents.html:
+ * fast/dom/processing-instruction-appendChild-exceptions-expected.txt:
+ * fast/dom/processing-instruction-appendChild-exceptions.xhtml:
+ * fast/dom/setter-type-enforcement-expected.txt:
+ * fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
+ * fast/inspector-support/uncaught-dom8-exception.html:
+
</ins><span class="cx"> 2015-09-10 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> Mark some more W3C IDB tests as flaky.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomDocumentreplaceChildnulloldChildexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Document/replaceChild-null-oldChild-expected.txt (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Document/replaceChild-null-oldChild-expected.txt 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/fast/dom/Document/replaceChild-null-oldChild-expected.txt 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS document.replaceChild(document.firstChild, null) threw exception Error: NotFoundError: DOM Exception 8.
</del><ins>+PASS document.replaceChild(document.firstChild, null) threw exception TypeError: Type error.
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomDocumentscripttestsreplaceChildnulloldChildjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Document/script-tests/replaceChild-null-oldChild.js (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Document/script-tests/replaceChild-null-oldChild.js 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/fast/dom/Document/script-tests/replaceChild-null-oldChild.js 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -1,3 +1,3 @@
</span><span class="cx"> description('Test behavior of Document.replaceChild() when oldChild is null.');
</span><span class="cx">
</span><del>-shouldThrow('document.replaceChild(document.firstChild, null)', '"Error: NotFoundError: DOM Exception 8"');
</del><ins>+shouldThrow('document.replaceChild(document.firstChild, null)', '"TypeError: Type error"');
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomNodefragmentmutationexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Node/fragment-mutation-expected.txt (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Node/fragment-mutation-expected.txt 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/fast/dom/Node/fragment-mutation-expected.txt 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -2,12 +2,12 @@
</span><span class="cx">
</span><span class="cx"> Inserting an element in front of the next item in fragment should not affect the result: PASS
</span><span class="cx"> Appending an element at the end of the fragment should not affect the result: PASS
</span><del>-Continually re-appending removed element to the fragment should eventually throw NOT_FOUND_ERR: PASS
</del><ins>+Continually re-appending removed element to the fragment should eventually throw a TypeError: PASS
</ins><span class="cx">
</span><span class="cx"> This test creates a fragment containing three elements: "B", "U", and "P", attempts to insertBefore this fragment and studies effects of mutation events on the fragment.
</span><span class="cx">
</span><span class="cx"> Inserting an element in front of the next item in fragment should not affect the result: PASS
</span><span class="cx"> Appending an element at the end of the fragment should not affect the result: PASS
</span><del>-Continually re-appending removed element to the fragment should eventually throw NOT_FOUND_ERR: PASS
</del><ins>+Continually re-appending removed element to the fragment should eventually throw a TypeError: PASS
</ins><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomNodefragmentmutationhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Node/fragment-mutation.html (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Node/fragment-mutation.html 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/fast/dom/Node/fragment-mutation.html 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -36,15 +36,15 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function expectException(code)
</del><ins>+function expectTypeError()
</ins><span class="cx"> {
</span><span class="cx"> return function(stash, exception) {
</span><span class="cx"> if (!exception)
</span><del>- return "FAIL, expected exception with code " + code + ". The resulting fragment was: \"" + produceNodeNameString(stash) + "\".";
</del><ins>+ return "FAIL, expected TypeError. The resulting fragment was: \"" + produceNodeNameString(stash) + "\".";
</ins><span class="cx">
</span><del>- if (code == exception.code)
</del><ins>+ if (exception.name = "TypeError")
</ins><span class="cx"> return "PASS";
</span><del>- return "FAIL, expected exception code: " + code + ", was: " + exception + ".";
</del><ins>+ return "FAIL, expected TypeError, was: " + exception.name + ".";
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -119,10 +119,10 @@
</span><span class="cx"> frag.appendChild(extra);
</span><span class="cx"> }, expectNodes("BUP"));
</span><span class="cx">
</span><del>- testFragment(method, "Continually re-appending removed element to the fragment should eventually throw NOT_FOUND_ERR", function(evt, frag, stash)
</del><ins>+ testFragment(method, "Continually re-appending removed element to the fragment should eventually throw a TypeError", function(evt, frag, stash)
</ins><span class="cx"> {
</span><span class="cx"> stash.insertBefore(frag.lastChild, stash.firstChild);
</span><del>- }, expectException(8), true);
</del><ins>+ }, expectTypeError(), true);
</ins><span class="cx"> printLog(methodName);
</span><span class="cx"> }
</span><span class="cx"> function runTests()
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomincompatibleoperationsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/incompatible-operations-expected.txt (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/incompatible-operations-expected.txt 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/fast/dom/incompatible-operations-expected.txt 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -3,9 +3,9 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS aNode.appendChild(aDOMImplementation) threw exception Error: NotFoundError: DOM Exception 8.
-PASS aNode.appendChild('knort') threw exception Error: NotFoundError: DOM Exception 8.
-PASS aNode.appendChild(void 0) threw exception Error: NotFoundError: DOM Exception 8.
</del><ins>+PASS aNode.appendChild(aDOMImplementation) threw exception TypeError: Type error.
+PASS aNode.appendChild('knort') threw exception TypeError: Type error.
+PASS aNode.appendChild(void 0) threw exception TypeError: Type error.
</ins><span class="cx"> PASS aNode.isSameNode(aDOMImplementation) is false
</span><span class="cx"> PASS aNode.isSameNode('foo') is false
</span><span class="cx"> PASS aNode.isSameNode(void 0) is false
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomincompatibleoperationshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/incompatible-operations.html (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/incompatible-operations.html 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/fast/dom/incompatible-operations.html 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -28,11 +28,11 @@
</span><span class="cx"> var aSecondNode = document.createElement("div");
</span><span class="cx"> aNode.appendChild(aSecondNode);
</span><span class="cx">
</span><del>-shouldThrow("aNode.appendChild(aDOMImplementation)", "'Error: NotFoundError: DOM Exception 8'");
</del><ins>+shouldThrow("aNode.appendChild(aDOMImplementation)", "'TypeError: Type error'");
</ins><span class="cx">
</span><del>-shouldThrow("aNode.appendChild('knort')", "'Error: NotFoundError: DOM Exception 8'");
</del><ins>+shouldThrow("aNode.appendChild('knort')", "'TypeError: Type error'");
</ins><span class="cx">
</span><del>-shouldThrow("aNode.appendChild(void 0)", "'Error: NotFoundError: DOM Exception 8'");
</del><ins>+shouldThrow("aNode.appendChild(void 0)", "'TypeError: Type error'");
</ins><span class="cx">
</span><span class="cx"> shouldBeFalse("aNode.isSameNode(aDOMImplementation)");
</span><span class="cx"> shouldBeFalse("aNode.isSameNode('foo')");
</span></span></pre></div>
<a id="trunkLayoutTestsfastdommovenodesacrossdocumentshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/move-nodes-across-documents.html (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/move-nodes-across-documents.html 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/fast/dom/move-nodes-across-documents.html 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -179,7 +179,7 @@
</span><span class="cx"> runTest(function() {
</span><span class="cx"> iframeDoc.appendChild(document.doctype);
</span><span class="cx"> console.log(document.doctype);
</span><del>- }, 'NotFoundError');
</del><ins>+ }, 'TypeError');
</ins><span class="cx">
</span><span class="cx"> // When setting a boundary of the range in a different
</span><span class="cx"> // document, the call should succeed and the range should be collapsed.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomprocessinginstructionappendChildexceptionsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions-expected.txt (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions-expected.txt 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions-expected.txt 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS pi.appendChild(null) threw exception Error: HierarchyRequestError: DOM Exception 3.
</del><ins>+PASS pi.appendChild(null) threw exception TypeError: Type error.
</ins><span class="cx"> PASS pi.appendChild(div) threw exception Error: HierarchyRequestError: DOM Exception 3.
</span><span class="cx"> PASS pi.appendChild(textNode) threw exception Error: HierarchyRequestError: DOM Exception 3.
</span><span class="cx"> PASS successfullyParsed is true
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomprocessinginstructionappendChildexceptionsxhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -5,7 +5,7 @@
</span><span class="cx"> <![CDATA[
</span><span class="cx"> description("Test that appropriate exceptions are thrown when adding children to a ProcessingInstruction.");
</span><span class="cx"> var pi = document.createProcessingInstruction('target', 'data');
</span><del>-shouldThrow("pi.appendChild(null)", "'Error: HierarchyRequestError: DOM Exception 3'");
</del><ins>+shouldThrow("pi.appendChild(null)", "'TypeError: Type error'");
</ins><span class="cx"> var div = document.createElement('div');
</span><span class="cx"> shouldThrow("pi.appendChild(div)", "'Error: HierarchyRequestError: DOM Exception 3'");
</span><span class="cx"> var textNode = document.createTextNode('sometext');
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomtimerclearintervalinhandlerandgenerateerrorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -1,2 +1,2 @@
</span><del>-CONSOLE MESSAGE: line 10: NotFoundError: DOM Exception 8: An attempt was made to reference a Node in a context where it does not exist.
</del><ins>+CONSOLE MESSAGE: line 10: TypeError: Type error
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsremovetargetwithshadowindragexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/remove-target-with-shadow-in-drag-expected.txt (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/remove-target-with-shadow-in-drag-expected.txt 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/fast/events/remove-target-with-shadow-in-drag-expected.txt 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -1,3 +1,3 @@
</span><del>-CONSOLE MESSAGE: line 34: NotFoundError: DOM Exception 8: An attempt was made to reference a Node in a context where it does not exist.
-CONSOLE MESSAGE: line 34: NotFoundError: DOM Exception 8: An attempt was made to reference a Node in a context where it does not exist.
</del><ins>+CONSOLE MESSAGE: line 34: TypeError: Type error
+CONSOLE MESSAGE: line 34: TypeError: Type error
</ins><span class="cx"> PASS. DRT didn't crash.
</span></span></pre></div>
<a id="trunkLayoutTestsfastinspectorsupportuncaughtdom8exceptionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/inspector-support/uncaught-dom8-exception.html (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/inspector-support/uncaught-dom8-exception.html 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/fast/inspector-support/uncaught-dom8-exception.html 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -6,7 +6,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.dumpAsText();
</span><del>- document.appendChild();
</del><ins>+ document.body.removeAttributeNode(document.createAttribute("doesNotExist"));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2015-09-10 Chris Dumez <cdumez@apple.com>
+
+ Node.appendChild(null) / replaceChild(null, null) / removeChild(null) / insertBefore(null, ref) should throw a TypeError
+ https://bugs.webkit.org/show_bug.cgi?id=148971
+ <rdar://problem/22560883>
+ <rdar://problem/22559225>
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline W3C tests now that more checks are passing.
+
+ * web-platform-tests/dom/interfaces-expected.txt:
+ * web-platform-tests/dom/nodes/Node-appendChild-expected.txt:
+ * web-platform-tests/dom/nodes/Node-insertBefore-expected.txt:
+ * web-platform-tests/dom/nodes/Node-removeChild-expected.txt:
+ * web-platform-tests/dom/nodes/Node-replaceChild-expected.txt:
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
</ins><span class="cx"> 2015-09-09 Dewei Zhu <dewei_zhu@apple.com>
</span><span class="cx">
</span><span class="cx"> Document.characterSet should return "UTF-8" by default.
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -634,21 +634,15 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" did not throw
</span><span class="cx"> PASS Node interface: xmlDoc must inherit property "insertBefore" with the proper type (40)
</span><del>-FAIL Node interface: calling insertBefore(Node,Node) on xmlDoc with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</del><ins>+FAIL Node interface: calling insertBefore(Node,Node) on xmlDoc with too few arguments must throw TypeError assert_throws: Called with 1 arguments function "function () {
</ins><span class="cx"> [native code]
</span><del>-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+}" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</ins><span class="cx"> PASS Node interface: xmlDoc must inherit property "appendChild" with the proper type (41)
</span><del>-FAIL Node interface: calling appendChild(Node) on xmlDoc with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling appendChild(Node) on xmlDoc with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: xmlDoc must inherit property "replaceChild" with the proper type (42)
</span><del>-FAIL Node interface: calling replaceChild(Node,Node) on xmlDoc with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" did not throw
</del><ins>+PASS Node interface: calling replaceChild(Node,Node) on xmlDoc with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: xmlDoc must inherit property "removeChild" with the proper type (43)
</span><del>-FAIL Node interface: calling removeChild(Node) on xmlDoc with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling removeChild(Node) on xmlDoc with too few arguments must throw TypeError
</ins><span class="cx"> PASS EventTarget interface: xmlDoc must inherit property "addEventListener" with the proper type (0)
</span><span class="cx"> FAIL EventTarget interface: calling addEventListener(DOMString,EventListener,boolean) on xmlDoc with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</span><span class="cx"> [native code]
</span><span class="lines">@@ -793,21 +787,15 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" did not throw
</span><span class="cx"> PASS Node interface: document.createDocumentFragment() must inherit property "insertBefore" with the proper type (40)
</span><del>-FAIL Node interface: calling insertBefore(Node,Node) on document.createDocumentFragment() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</del><ins>+FAIL Node interface: calling insertBefore(Node,Node) on document.createDocumentFragment() with too few arguments must throw TypeError assert_throws: Called with 1 arguments function "function () {
</ins><span class="cx"> [native code]
</span><del>-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+}" did not throw
</ins><span class="cx"> PASS Node interface: document.createDocumentFragment() must inherit property "appendChild" with the proper type (41)
</span><del>-FAIL Node interface: calling appendChild(Node) on document.createDocumentFragment() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling appendChild(Node) on document.createDocumentFragment() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createDocumentFragment() must inherit property "replaceChild" with the proper type (42)
</span><del>-FAIL Node interface: calling replaceChild(Node,Node) on document.createDocumentFragment() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" did not throw
</del><ins>+PASS Node interface: calling replaceChild(Node,Node) on document.createDocumentFragment() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createDocumentFragment() must inherit property "removeChild" with the proper type (43)
</span><del>-FAIL Node interface: calling removeChild(Node) on document.createDocumentFragment() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling removeChild(Node) on document.createDocumentFragment() with too few arguments must throw TypeError
</ins><span class="cx"> PASS EventTarget interface: document.createDocumentFragment() must inherit property "addEventListener" with the proper type (0)
</span><span class="cx"> FAIL EventTarget interface: calling addEventListener(DOMString,EventListener,boolean) on document.createDocumentFragment() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</span><span class="cx"> [native code]
</span><span class="lines">@@ -915,21 +903,15 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" did not throw
</span><span class="cx"> PASS Node interface: document.doctype must inherit property "insertBefore" with the proper type (40)
</span><del>-FAIL Node interface: calling insertBefore(Node,Node) on document.doctype with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</del><ins>+FAIL Node interface: calling insertBefore(Node,Node) on document.doctype with too few arguments must throw TypeError assert_throws: Called with 1 arguments function "function () {
</ins><span class="cx"> [native code]
</span><span class="cx"> }" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</span><span class="cx"> PASS Node interface: document.doctype must inherit property "appendChild" with the proper type (41)
</span><del>-FAIL Node interface: calling appendChild(Node) on document.doctype with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling appendChild(Node) on document.doctype with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.doctype must inherit property "replaceChild" with the proper type (42)
</span><del>-FAIL Node interface: calling replaceChild(Node,Node) on document.doctype with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling replaceChild(Node,Node) on document.doctype with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.doctype must inherit property "removeChild" with the proper type (43)
</span><del>-FAIL Node interface: calling removeChild(Node) on document.doctype with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling removeChild(Node) on document.doctype with too few arguments must throw TypeError
</ins><span class="cx"> PASS EventTarget interface: document.doctype must inherit property "addEventListener" with the proper type (0)
</span><span class="cx"> FAIL EventTarget interface: calling addEventListener(DOMString,EventListener,boolean) on document.doctype with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</span><span class="cx"> [native code]
</span><span class="lines">@@ -1187,21 +1169,15 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" did not throw
</span><span class="cx"> PASS Node interface: element must inherit property "insertBefore" with the proper type (40)
</span><del>-FAIL Node interface: calling insertBefore(Node,Node) on element with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</del><ins>+FAIL Node interface: calling insertBefore(Node,Node) on element with too few arguments must throw TypeError assert_throws: Called with 1 arguments function "function () {
</ins><span class="cx"> [native code]
</span><del>-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+}" did not throw
</ins><span class="cx"> PASS Node interface: element must inherit property "appendChild" with the proper type (41)
</span><del>-FAIL Node interface: calling appendChild(Node) on element with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling appendChild(Node) on element with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: element must inherit property "replaceChild" with the proper type (42)
</span><del>-FAIL Node interface: calling replaceChild(Node,Node) on element with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" did not throw
</del><ins>+PASS Node interface: calling replaceChild(Node,Node) on element with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: element must inherit property "removeChild" with the proper type (43)
</span><del>-FAIL Node interface: calling removeChild(Node) on element with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling removeChild(Node) on element with too few arguments must throw TypeError
</ins><span class="cx"> PASS EventTarget interface: element must inherit property "addEventListener" with the proper type (0)
</span><span class="cx"> FAIL EventTarget interface: calling addEventListener(DOMString,EventListener,boolean) on element with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</span><span class="cx"> [native code]
</span><span class="lines">@@ -1409,21 +1385,15 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" did not throw
</span><span class="cx"> PASS Node interface: document.createTextNode("abc") must inherit property "insertBefore" with the proper type (40)
</span><del>-FAIL Node interface: calling insertBefore(Node,Node) on document.createTextNode("abc") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</del><ins>+FAIL Node interface: calling insertBefore(Node,Node) on document.createTextNode("abc") with too few arguments must throw TypeError assert_throws: Called with 1 arguments function "function () {
</ins><span class="cx"> [native code]
</span><span class="cx"> }" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</span><span class="cx"> PASS Node interface: document.createTextNode("abc") must inherit property "appendChild" with the proper type (41)
</span><del>-FAIL Node interface: calling appendChild(Node) on document.createTextNode("abc") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling appendChild(Node) on document.createTextNode("abc") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createTextNode("abc") must inherit property "replaceChild" with the proper type (42)
</span><del>-FAIL Node interface: calling replaceChild(Node,Node) on document.createTextNode("abc") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling replaceChild(Node,Node) on document.createTextNode("abc") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createTextNode("abc") must inherit property "removeChild" with the proper type (43)
</span><del>-FAIL Node interface: calling removeChild(Node) on document.createTextNode("abc") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling removeChild(Node) on document.createTextNode("abc") with too few arguments must throw TypeError
</ins><span class="cx"> PASS EventTarget interface: document.createTextNode("abc") must inherit property "addEventListener" with the proper type (0)
</span><span class="cx"> FAIL EventTarget interface: calling addEventListener(DOMString,EventListener,boolean) on document.createTextNode("abc") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</span><span class="cx"> [native code]
</span><span class="lines">@@ -1543,21 +1513,15 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" did not throw
</span><span class="cx"> PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must inherit property "insertBefore" with the proper type (40)
</span><del>-FAIL Node interface: calling insertBefore(Node,Node) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</del><ins>+FAIL Node interface: calling insertBefore(Node,Node) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError assert_throws: Called with 1 arguments function "function () {
</ins><span class="cx"> [native code]
</span><span class="cx"> }" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</span><span class="cx"> PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must inherit property "appendChild" with the proper type (41)
</span><del>-FAIL Node interface: calling appendChild(Node) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling appendChild(Node) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must inherit property "replaceChild" with the proper type (42)
</span><del>-FAIL Node interface: calling replaceChild(Node,Node) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling replaceChild(Node,Node) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must inherit property "removeChild" with the proper type (43)
</span><del>-FAIL Node interface: calling removeChild(Node) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling removeChild(Node) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError
</ins><span class="cx"> PASS EventTarget interface: xmlDoc.createProcessingInstruction("abc", "def") must inherit property "addEventListener" with the proper type (0)
</span><span class="cx"> FAIL EventTarget interface: calling addEventListener(DOMString,EventListener,boolean) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</span><span class="cx"> [native code]
</span><span class="lines">@@ -1673,21 +1637,15 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" did not throw
</span><span class="cx"> PASS Node interface: document.createComment("abc") must inherit property "insertBefore" with the proper type (40)
</span><del>-FAIL Node interface: calling insertBefore(Node,Node) on document.createComment("abc") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</del><ins>+FAIL Node interface: calling insertBefore(Node,Node) on document.createComment("abc") with too few arguments must throw TypeError assert_throws: Called with 1 arguments function "function () {
</ins><span class="cx"> [native code]
</span><span class="cx"> }" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</span><span class="cx"> PASS Node interface: document.createComment("abc") must inherit property "appendChild" with the proper type (41)
</span><del>-FAIL Node interface: calling appendChild(Node) on document.createComment("abc") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling appendChild(Node) on document.createComment("abc") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createComment("abc") must inherit property "replaceChild" with the proper type (42)
</span><del>-FAIL Node interface: calling replaceChild(Node,Node) on document.createComment("abc") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling replaceChild(Node,Node) on document.createComment("abc") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createComment("abc") must inherit property "removeChild" with the proper type (43)
</span><del>-FAIL Node interface: calling removeChild(Node) on document.createComment("abc") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling removeChild(Node) on document.createComment("abc") with too few arguments must throw TypeError
</ins><span class="cx"> PASS EventTarget interface: document.createComment("abc") must inherit property "addEventListener" with the proper type (0)
</span><span class="cx"> FAIL EventTarget interface: calling addEventListener(DOMString,EventListener,boolean) on document.createComment("abc") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</span><span class="cx"> [native code]
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesNodeappendChildexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-appendChild-expected.txt (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-appendChild-expected.txt 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-appendChild-expected.txt 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -1,12 +1,12 @@
</span><span class="cx">
</span><span class="cx">
</span><del>-FAIL WebIDL tests assert_throws: function "function () { document.body.appendChild(null) }" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS WebIDL tests
</ins><span class="cx"> PASS Appending to a leaf node.
</span><del>-FAIL Appending null to a text node assert_throws: function "function () { node.appendChild(null) }" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Appending null to a text node
</ins><span class="cx"> PASS Appending to a text node
</span><del>-FAIL Appending null to a comment assert_throws: function "function () { node.appendChild(null) }" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Appending null to a comment
</ins><span class="cx"> PASS Appending to a comment
</span><del>-FAIL Appending null to a doctype assert_throws: function "function () { node.appendChild(null) }" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Appending null to a doctype
</ins><span class="cx"> PASS Appending to a doctype
</span><span class="cx"> PASS Appending a document
</span><span class="cx"> PASS Adopting an orphan
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesNodeinsertBeforeexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-insertBefore-expected.txt (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-insertBefore-expected.txt 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-insertBefore-expected.txt 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -1,12 +1,12 @@
</span><span class="cx">
</span><del>-FAIL Calling insertBefore with a non-Node first argument must throw TypeError. assert_throws: function "function () { document.body.insertBefore(null, null) }" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
-FAIL Calling insertBefore with a non-Node first argument on a leaf node DocumentType must throw TypeError. assert_throws: function "function () { node.insertBefore(null, null) }" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Calling insertBefore with a non-Node first argument must throw TypeError.
+PASS Calling insertBefore with a non-Node first argument on a leaf node DocumentType must throw TypeError.
</ins><span class="cx"> PASS Calling insertBefore an a leaf node DocumentType must throw HIERARCHY_REQUEST_ERR.
</span><del>-FAIL Calling insertBefore with a non-Node first argument on a leaf node Text must throw TypeError. assert_throws: function "function () { node.insertBefore(null, null) }" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Calling insertBefore with a non-Node first argument on a leaf node Text must throw TypeError.
</ins><span class="cx"> PASS Calling insertBefore an a leaf node Text must throw HIERARCHY_REQUEST_ERR.
</span><del>-FAIL Calling insertBefore with a non-Node first argument on a leaf node Comment must throw TypeError. assert_throws: function "function () { node.insertBefore(null, null) }" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Calling insertBefore with a non-Node first argument on a leaf node Comment must throw TypeError.
</ins><span class="cx"> PASS Calling insertBefore an a leaf node Comment must throw HIERARCHY_REQUEST_ERR.
</span><del>-FAIL Calling insertBefore with a non-Node first argument on a leaf node ProcessingInstruction must throw TypeError. assert_throws: function "function () { node.insertBefore(null, null) }" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Calling insertBefore with a non-Node first argument on a leaf node ProcessingInstruction must throw TypeError.
</ins><span class="cx"> PASS Calling insertBefore an a leaf node ProcessingInstruction must throw HIERARCHY_REQUEST_ERR.
</span><span class="cx"> PASS Calling insertBefore with an inclusive ancestor of the context object must throw HIERARCHY_REQUEST_ERR.
</span><span class="cx"> PASS Calling insertBefore with a reference child whose parent is not the context node must throw a NotFoundError.
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesNoderemoveChildexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-removeChild-expected.txt (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-removeChild-expected.txt 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-removeChild-expected.txt 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -27,5 +27,5 @@
</span><span class="cx"> PASS Passing a detached comment from a synthetic document to removeChild should not affect it.
</span><span class="cx"> PASS Passing a non-detached comment from a synthetic document to removeChild should not affect it.
</span><span class="cx"> PASS Calling removeChild on a comment from a synthetic document with no children should throw NOT_FOUND_ERR.
</span><del>-FAIL Passing a value that is not a Node reference to removeChild should throw TypeError. assert_throws: function "function () { document.body.removeChild(null) }" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Passing a value that is not a Node reference to removeChild should throw TypeError.
</ins><span class="cx"> b
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesNodereplaceChildexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-replaceChild-expected.txt (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-replaceChild-expected.txt 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-replaceChild-expected.txt 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -1,7 +1,5 @@
</span><span class="cx">
</span><del>-FAIL Passing null to replaceChild should throw a TypeError. assert_throws: function "function () {
- a.replaceChild(null, null);
- }" did not throw
</del><ins>+PASS Passing null to replaceChild should throw a TypeError.
</ins><span class="cx"> FAIL If child's parent is not the context node, a NotFoundError exception should be thrown assert_throws: function "function () {
</span><span class="cx"> a.replaceChild(a, c);
</span><span class="cx"> }" threw object "Error: HierarchyRequestError: DOM Exception 3" that is not a DOMException NotFoundError: property "code" is equal to 3, expected 8
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -1225,21 +1225,15 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" did not throw
</span><span class="cx"> PASS Node interface: iframe.contentDocument must inherit property "insertBefore" with the proper type (40)
</span><del>-FAIL Node interface: calling insertBefore(Node,Node) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</del><ins>+FAIL Node interface: calling insertBefore(Node,Node) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 1 arguments function "function () {
</ins><span class="cx"> [native code]
</span><del>-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+}" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</ins><span class="cx"> PASS Node interface: iframe.contentDocument must inherit property "appendChild" with the proper type (41)
</span><del>-FAIL Node interface: calling appendChild(Node) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling appendChild(Node) on iframe.contentDocument with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: iframe.contentDocument must inherit property "replaceChild" with the proper type (42)
</span><del>-FAIL Node interface: calling replaceChild(Node,Node) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" did not throw
</del><ins>+PASS Node interface: calling replaceChild(Node,Node) on iframe.contentDocument with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: iframe.contentDocument must inherit property "removeChild" with the proper type (43)
</span><del>-FAIL Node interface: calling removeChild(Node) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling removeChild(Node) on iframe.contentDocument with too few arguments must throw TypeError
</ins><span class="cx"> PASS EventTarget interface: iframe.contentDocument must inherit property "addEventListener" with the proper type (0)
</span><span class="cx"> FAIL EventTarget interface: calling addEventListener(DOMString,EventListener,boolean) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</span><span class="cx"> [native code]
</span><span class="lines">@@ -1551,21 +1545,15 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" did not throw
</span><span class="cx"> PASS Node interface: document.implementation.createDocument(null, "", null) must inherit property "insertBefore" with the proper type (40)
</span><del>-FAIL Node interface: calling insertBefore(Node,Node) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</del><ins>+FAIL Node interface: calling insertBefore(Node,Node) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 1 arguments function "function () {
</ins><span class="cx"> [native code]
</span><del>-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+}" threw object "Error: HierarchyRequestError: DOM Exception 3" ("HierarchyRequestError") expected object "TypeError" ("TypeError")
</ins><span class="cx"> PASS Node interface: document.implementation.createDocument(null, "", null) must inherit property "appendChild" with the proper type (41)
</span><del>-FAIL Node interface: calling appendChild(Node) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling appendChild(Node) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.implementation.createDocument(null, "", null) must inherit property "replaceChild" with the proper type (42)
</span><del>-FAIL Node interface: calling replaceChild(Node,Node) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" did not throw
</del><ins>+PASS Node interface: calling replaceChild(Node,Node) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.implementation.createDocument(null, "", null) must inherit property "removeChild" with the proper type (43)
</span><del>-FAIL Node interface: calling removeChild(Node) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling removeChild(Node) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</ins><span class="cx"> PASS EventTarget interface: document.implementation.createDocument(null, "", null) must inherit property "addEventListener" with the proper type (0)
</span><span class="cx"> FAIL EventTarget interface: calling addEventListener(DOMString,EventListener,boolean) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</span><span class="cx"> [native code]
</span><span class="lines">@@ -2171,21 +2159,15 @@
</span><span class="cx"> [native code]
</span><span class="cx"> }" did not throw
</span><span class="cx"> PASS Node interface: document.createElement("noscript") must inherit property "insertBefore" with the proper type (40)
</span><del>-FAIL Node interface: calling insertBefore(Node,Node) on document.createElement("noscript") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</del><ins>+FAIL Node interface: calling insertBefore(Node,Node) on document.createElement("noscript") with too few arguments must throw TypeError assert_throws: Called with 1 arguments function "function () {
</ins><span class="cx"> [native code]
</span><del>-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+}" did not throw
</ins><span class="cx"> PASS Node interface: document.createElement("noscript") must inherit property "appendChild" with the proper type (41)
</span><del>-FAIL Node interface: calling appendChild(Node) on document.createElement("noscript") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling appendChild(Node) on document.createElement("noscript") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createElement("noscript") must inherit property "replaceChild" with the proper type (42)
</span><del>-FAIL Node interface: calling replaceChild(Node,Node) on document.createElement("noscript") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" did not throw
</del><ins>+PASS Node interface: calling replaceChild(Node,Node) on document.createElement("noscript") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createElement("noscript") must inherit property "removeChild" with the proper type (43)
</span><del>-FAIL Node interface: calling removeChild(Node) on document.createElement("noscript") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- [native code]
-}" threw object "Error: NotFoundError: DOM Exception 8" ("NotFoundError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Node interface: calling removeChild(Node) on document.createElement("noscript") with too few arguments must throw TypeError
</ins><span class="cx"> PASS EventTarget interface: document.createElement("noscript") must inherit property "addEventListener" with the proper type (0)
</span><span class="cx"> FAIL EventTarget interface: calling addEventListener(DOMString,EventListener,boolean) on document.createElement("noscript") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
</span><span class="cx"> [native code]
</span></span></pre></div>
<a id="trunkLayoutTestsjsdomdotnodebaseexceptionexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/dom/dot-node-base-exception-expected.txt (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/dom/dot-node-base-exception-expected.txt 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/js/dom/dot-node-base-exception-expected.txt 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS (document.appendChild()).foobar() threw exception Error: NotFoundError: DOM Exception 8.
</del><ins>+PASS (document.appendChild()).foobar() threw exception TypeError: Type error.
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsjsdomscripttestsdotnodebaseexceptionjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/dom/script-tests/dot-node-base-exception.js (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/dom/script-tests/dot-node-base-exception.js 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/LayoutTests/js/dom/script-tests/dot-node-base-exception.js 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -3,4 +3,4 @@
</span><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> // Should be a DOM exception, not just some "TypeError: Null value".
</span><del>-shouldThrow('(document.appendChild()).foobar()', '"Error: NotFoundError: DOM Exception 8"');
</del><ins>+shouldThrow('(document.appendChild()).foobar()', '"TypeError: Type error"');
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/ChangeLog 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -1,3 +1,35 @@
</span><ins>+2015-09-10 Chris Dumez <cdumez@apple.com>
+
+ Node.appendChild(null) / replaceChild(null, null) / removeChild(null) / insertBefore(null, ref) should throw a TypeError
+ https://bugs.webkit.org/show_bug.cgi?id=148971
+ <rdar://problem/22560883>
+ <rdar://problem/22559225>
+
+ Reviewed by Ryosuke Niwa.
+
+ Node.appendChild(null) / replaceChild(null, null) / removeChild(null)
+ and insertBefore(null, ref) should throw a TypeError instead of a
+ NotFoundError, as per the specification:
+ https://dom.spec.whatwg.org/#node
+
+ The parameters are not nullable so the Web IDL specification says
+ we should throw a TypeError in this case.
+
+ This patch moves the null-checking from ContainerNode to the methods
+ on Node. The null-checking is supposed to be done by the bindings code
+ but our generator currently does not support this so we do the null
+ checking as close to the bindings as possible. The bindings code is
+ calling the methods on Node. This also makes sure we throw a TypeError
+ for null-argument when the Node is not a ContainerNode. For e.g.
+ Text.appendChild(null) should throw a TypeError too.
+
+ The methods on ContainerNode now take references insteaad of pointer
+ parameters now that the null-checking is done at the call site in
+ Node. This lead to a lot of code update as those methods are used
+ a lot throughout the code base.
+
+ No new tests, already covered by pre-existing layout tests.
+
</ins><span class="cx"> 2015-09-10 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> Write a test to ensure we don't regress processing of tasks when page defers loading
</span></span></pre></div>
<a id="trunkSourceWebCoreModulespluginsYouTubePluginReplacementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -81,9 +81,9 @@
</span><span class="cx"> {
</span><span class="cx"> m_embedShadowElement = YouTubeEmbedShadowElement::create(m_parentElement->document());
</span><span class="cx">
</span><del>- root->appendChild(m_embedShadowElement.get());
</del><ins>+ root->appendChild(*m_embedShadowElement);
</ins><span class="cx">
</span><del>- RefPtr<HTMLIFrameElement> iframeElement = HTMLIFrameElement::create(HTMLNames::iframeTag, m_parentElement->document());
</del><ins>+ Ref<HTMLIFrameElement> iframeElement = HTMLIFrameElement::create(HTMLNames::iframeTag, m_parentElement->document());
</ins><span class="cx"> if (m_attributes.contains("width"))
</span><span class="cx"> iframeElement->setAttribute(HTMLNames::widthAttr, AtomicString("100%", AtomicString::ConstructFromLiteral));
</span><span class="cx">
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx">
</span><span class="cx"> // Disable frame flattening for this iframe.
</span><span class="cx"> iframeElement->setAttribute(HTMLNames::scrollingAttr, AtomicString("no", AtomicString::ConstructFromLiteral));
</span><del>- m_embedShadowElement->appendChild(iframeElement);
</del><ins>+ m_embedShadowElement->appendChild(WTF::move(iframeElement));
</ins><span class="cx">
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsobjcDOMHTMLmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/objc/DOMHTML.mm (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/objc/DOMHTML.mm 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/bindings/objc/DOMHTML.mm 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -152,7 +152,7 @@
</span><span class="cx"> - (DOMDocumentFragment *)createDocumentFragmentWithText:(NSString *)text
</span><span class="cx"> {
</span><span class="cx"> // FIXME: Since this is not a contextual fragment, it won't handle whitespace properly.
</span><del>- return kit(createFragmentFromText(core(self)->createRange(), text).get());
</del><ins>+ return kit(createFragmentFromText(core(self)->createRange(), text).ptr());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> @end
</span></span></pre></div>
<a id="trunkSourceWebCoredomAttrcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Attr.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Attr.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/Attr.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -138,11 +138,11 @@
</span><span class="cx"> setValue(v, ec);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Node> Attr::cloneNodeInternal(Document& targetDocument, CloningOperation)
</del><ins>+Ref<Node> Attr::cloneNodeInternal(Document& targetDocument, CloningOperation)
</ins><span class="cx"> {
</span><del>- RefPtr<Attr> clone = adoptRef(new Attr(targetDocument, qualifiedName(), value()));
- cloneChildNodes(clone.get());
- return clone.release();
</del><ins>+ Ref<Attr> clone = adoptRef(*new Attr(targetDocument, qualifiedName(), value()));
+ cloneChildNodes(clone);
+ return WTF::move(clone);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // DOM Section 1.1.1
</span></span></pre></div>
<a id="trunkSourceWebCoredomAttrh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Attr.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Attr.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/Attr.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -80,7 +80,7 @@
</span><span class="cx">
</span><span class="cx"> virtual String nodeValue() const override { return value(); }
</span><span class="cx"> virtual void setNodeValue(const String&, ExceptionCode&) override;
</span><del>- virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) override;
</del><ins>+ virtual Ref<Node> cloneNodeInternal(Document&, CloningOperation) override;
</ins><span class="cx">
</span><span class="cx"> virtual bool isAttributeNode() const override { return true; }
</span><span class="cx"> virtual bool childTypeAllowed(NodeType) const override;
</span></span></pre></div>
<a id="trunkSourceWebCoredomCDATASectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/CDATASection.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/CDATASection.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/CDATASection.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx"> return CDATA_SECTION_NODE;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Node> CDATASection::cloneNodeInternal(Document& targetDocument, CloningOperation)
</del><ins>+Ref<Node> CDATASection::cloneNodeInternal(Document& targetDocument, CloningOperation)
</ins><span class="cx"> {
</span><span class="cx"> return create(targetDocument, data());
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomCDATASectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/CDATASection.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/CDATASection.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/CDATASection.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx">
</span><span class="cx"> virtual String nodeName() const override;
</span><span class="cx"> virtual NodeType nodeType() const override;
</span><del>- virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) override;
</del><ins>+ virtual Ref<Node> cloneNodeInternal(Document&, CloningOperation) override;
</ins><span class="cx"> virtual bool childTypeAllowed(NodeType) const override;
</span><span class="cx"> virtual Ref<Text> virtualCreate(const String&) override;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoredomCommentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Comment.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Comment.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/Comment.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx"> return COMMENT_NODE;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Node> Comment::cloneNodeInternal(Document& targetDocument, CloningOperation)
</del><ins>+Ref<Node> Comment::cloneNodeInternal(Document& targetDocument, CloningOperation)
</ins><span class="cx"> {
</span><span class="cx"> return create(targetDocument, data());
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomCommenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Comment.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Comment.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/Comment.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx">
</span><span class="cx"> virtual String nodeName() const override;
</span><span class="cx"> virtual NodeType nodeType() const override;
</span><del>- virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) override;
</del><ins>+ virtual Ref<Node> cloneNodeInternal(Document&, CloningOperation) override;
</ins><span class="cx"> virtual bool childTypeAllowed(NodeType) const override;
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomContainerNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ContainerNode.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx"> if (!is<DocumentFragment>(node)) {
</span><span class="cx"> nodes.append(node);
</span><span class="cx"> if (ContainerNode* oldParent = node.parentNode())
</span><del>- oldParent->removeChild(&node, ec);
</del><ins>+ oldParent->removeChild(node, ec);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -146,13 +146,13 @@
</span><span class="cx"> removeDetachedChildren();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static inline bool isChildTypeAllowed(ContainerNode* newParent, Node* child)
</del><ins>+static inline bool isChildTypeAllowed(ContainerNode& newParent, Node& child)
</ins><span class="cx"> {
</span><del>- if (!child->isDocumentFragment())
- return newParent->childTypeAllowed(child->nodeType());
</del><ins>+ if (!child.isDocumentFragment())
+ return newParent.childTypeAllowed(child.nodeType());
</ins><span class="cx">
</span><del>- for (Node* node = child->firstChild(); node; node = node->nextSibling()) {
- if (!newParent->childTypeAllowed(node->nodeType()))
</del><ins>+ for (Node* node = child.firstChild(); node; node = node->nextSibling()) {
+ if (!newParent.childTypeAllowed(node->nodeType()))
</ins><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx"> return true;
</span><span class="lines">@@ -169,23 +169,19 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static inline bool containsConsideringHostElements(const Node* newChild, const Node* newParent)
</del><ins>+static inline bool containsConsideringHostElements(const Node& newChild, const Node& newParent)
</ins><span class="cx"> {
</span><del>- return (newParent->isInShadowTree() || isInTemplateContent(newParent))
- ? newChild->containsIncludingHostElements(newParent)
- : newChild->contains(newParent);
</del><ins>+ return (newParent.isInShadowTree() || isInTemplateContent(&newParent))
+ ? newChild.containsIncludingHostElements(&newParent)
+ : newChild.contains(&newParent);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-static inline ExceptionCode checkAcceptChild(ContainerNode* newParent, Node* newChild, Node* oldChild)
</del><ins>+static inline ExceptionCode checkAcceptChild(ContainerNode& newParent, Node& newChild, Node* oldChild)
</ins><span class="cx"> {
</span><del>- // Not mentioned in spec: throw NOT_FOUND_ERR if newChild is null
- if (!newChild)
- return NOT_FOUND_ERR;
-
</del><span class="cx"> // Use common case fast path if possible.
</span><del>- if ((newChild->isElementNode() || newChild->isTextNode()) && newParent->isElementNode()) {
- ASSERT(!newParent->isReadOnlyNode());
- ASSERT(!newParent->isDocumentTypeNode());
</del><ins>+ if ((newChild.isElementNode() || newChild.isTextNode()) && newParent.isElementNode()) {
+ ASSERT(!newParent.isReadOnlyNode());
+ ASSERT(!newParent.isDocumentTypeNode());
</ins><span class="cx"> ASSERT(isChildTypeAllowed(newParent, newChild));
</span><span class="cx"> if (containsConsideringHostElements(newChild, newParent))
</span><span class="cx"> return HIERARCHY_REQUEST_ERR;
</span><span class="lines">@@ -193,17 +189,17 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // This should never happen, but also protect release builds from tree corruption.
</span><del>- ASSERT(!newChild->isPseudoElement());
- if (newChild->isPseudoElement())
</del><ins>+ ASSERT(!newChild.isPseudoElement());
+ if (newChild.isPseudoElement())
</ins><span class="cx"> return HIERARCHY_REQUEST_ERR;
</span><span class="cx">
</span><del>- if (newParent->isReadOnlyNode())
</del><ins>+ if (newParent.isReadOnlyNode())
</ins><span class="cx"> return NO_MODIFICATION_ALLOWED_ERR;
</span><span class="cx"> if (containsConsideringHostElements(newChild, newParent))
</span><span class="cx"> return HIERARCHY_REQUEST_ERR;
</span><span class="cx">
</span><del>- if (oldChild && is<Document>(*newParent)) {
- if (!downcast<Document>(*newParent).canReplaceChild(newChild, oldChild))
</del><ins>+ if (oldChild && is<Document>(newParent)) {
+ if (!downcast<Document>(newParent).canReplaceChild(newChild, *oldChild))
</ins><span class="cx"> return HIERARCHY_REQUEST_ERR;
</span><span class="cx"> } else if (!isChildTypeAllowed(newParent, newChild))
</span><span class="cx"> return HIERARCHY_REQUEST_ERR;
</span><span class="lines">@@ -211,12 +207,12 @@
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static inline bool checkAcceptChildGuaranteedNodeTypes(ContainerNode* newParent, Node* newChild, ExceptionCode& ec)
</del><ins>+static inline bool checkAcceptChildGuaranteedNodeTypes(ContainerNode& newParent, Node& newChild, ExceptionCode& ec)
</ins><span class="cx"> {
</span><del>- ASSERT(!newParent->isReadOnlyNode());
- ASSERT(!newParent->isDocumentTypeNode());
</del><ins>+ ASSERT(!newParent.isReadOnlyNode());
+ ASSERT(!newParent.isDocumentTypeNode());
</ins><span class="cx"> ASSERT(isChildTypeAllowed(newParent, newChild));
</span><del>- if (newChild->contains(newParent)) {
</del><ins>+ if (newChild.contains(&newParent)) {
</ins><span class="cx"> ec = HIERARCHY_REQUEST_ERR;
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="lines">@@ -224,25 +220,19 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static inline bool checkAddChild(ContainerNode* newParent, Node* newChild, ExceptionCode& ec)
</del><ins>+static inline bool checkAddChild(ContainerNode& newParent, Node& newChild, ExceptionCode& ec)
</ins><span class="cx"> {
</span><del>- ec = checkAcceptChild(newParent, newChild, 0);
- if (ec)
- return false;
-
- return true;
</del><ins>+ ec = checkAcceptChild(newParent, newChild, nullptr);
+ return !ec;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-static inline bool checkReplaceChild(ContainerNode* newParent, Node* newChild, Node* oldChild, ExceptionCode& ec)
</del><ins>+static inline bool checkReplaceChild(ContainerNode& newParent, Node& newChild, Node& oldChild, ExceptionCode& ec)
</ins><span class="cx"> {
</span><del>- ec = checkAcceptChild(newParent, newChild, oldChild);
- if (ec)
- return false;
-
- return true;
</del><ins>+ ec = checkAcceptChild(newParent, newChild, &oldChild);
+ return !ec;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-bool ContainerNode::insertBefore(PassRefPtr<Node> newChild, Node* refChild, ExceptionCode& ec)
</del><ins>+bool ContainerNode::insertBefore(Ref<Node>&& newChild, Node* refChild, ExceptionCode& ec)
</ins><span class="cx"> {
</span><span class="cx"> // Check that this node is not "floating".
</span><span class="cx"> // If it is, it can be deleted as a side effect of sending mutation events.
</span><span class="lines">@@ -254,10 +244,10 @@
</span><span class="cx">
</span><span class="cx"> // insertBefore(node, 0) is equivalent to appendChild(node)
</span><span class="cx"> if (!refChild)
</span><del>- return appendChild(newChild, ec);
</del><ins>+ return appendChild(WTF::move(newChild), ec);
</ins><span class="cx">
</span><span class="cx"> // Make sure adding the new child is OK.
</span><del>- if (!checkAddChild(this, newChild.get(), ec))
</del><ins>+ if (!checkAddChild(*this, newChild, ec))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> // NOT_FOUND_ERR: Raised if refChild is not a child of this node
</span><span class="lines">@@ -266,20 +256,20 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (refChild->previousSibling() == newChild || refChild == newChild) // nothing to do
</del><ins>+ if (refChild->previousSibling() == newChild.ptr() || refChild == newChild.ptr()) // nothing to do
</ins><span class="cx"> return true;
</span><span class="cx">
</span><span class="cx"> Ref<Node> next(*refChild);
</span><span class="cx">
</span><span class="cx"> NodeVector targets;
</span><del>- collectChildrenAndRemoveFromOldParent(*newChild.get(), targets, ec);
</del><ins>+ collectChildrenAndRemoveFromOldParent(newChild, targets, ec);
</ins><span class="cx"> if (ec)
</span><span class="cx"> return false;
</span><span class="cx"> if (targets.isEmpty())
</span><span class="cx"> return true;
</span><span class="cx">
</span><span class="cx"> // We need this extra check because collectChildrenAndRemoveFromOldParent() can fire mutation events.
</span><del>- if (!checkAcceptChildGuaranteedNodeTypes(this, newChild.get(), ec))
</del><ins>+ if (!checkAcceptChildGuaranteedNodeTypes(*this, newChild, ec))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> InspectorInstrumentation::willInsertDOMNode(document(), *this);
</span><span class="lines">@@ -390,7 +380,7 @@
</span><span class="cx"> newChild->setNeedsStyleRecalc(ReconstructRenderTree);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool ContainerNode::replaceChild(PassRefPtr<Node> newChild, Node* oldChild, ExceptionCode& ec)
</del><ins>+bool ContainerNode::replaceChild(Ref<Node>&& newChild, Node& oldChild, ExceptionCode& ec)
</ins><span class="cx"> {
</span><span class="cx"> // Check that this node is not "floating".
</span><span class="cx"> // If it is, it can be deleted as a side effect of sending mutation events.
</span><span class="lines">@@ -400,48 +390,43 @@
</span><span class="cx">
</span><span class="cx"> ec = 0;
</span><span class="cx">
</span><del>- if (oldChild == newChild) // nothing to do
</del><ins>+ if (&oldChild == newChild.ptr()) // nothing to do
</ins><span class="cx"> return true;
</span><span class="cx">
</span><del>- if (!oldChild) {
- ec = NOT_FOUND_ERR;
- return false;
- }
-
</del><span class="cx"> // Make sure replacing the old child with the new is ok
</span><del>- if (!checkReplaceChild(this, newChild.get(), oldChild, ec))
</del><ins>+ if (!checkReplaceChild(*this, newChild, oldChild, ec))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> // NOT_FOUND_ERR: Raised if oldChild is not a child of this node.
</span><del>- if (oldChild->parentNode() != this) {
</del><ins>+ if (oldChild.parentNode() != this) {
</ins><span class="cx"> ec = NOT_FOUND_ERR;
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ChildListMutationScope mutation(*this);
</span><span class="cx">
</span><del>- RefPtr<Node> next = oldChild->nextSibling();
</del><ins>+ RefPtr<Node> next = oldChild.nextSibling();
</ins><span class="cx">
</span><span class="cx"> // Remove the node we're replacing
</span><del>- Ref<Node> removedChild(*oldChild);
</del><ins>+ Ref<Node> removedChild(oldChild);
</ins><span class="cx"> removeChild(oldChild, ec);
</span><span class="cx"> if (ec)
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- if (next && (next->previousSibling() == newChild || next == newChild)) // nothing to do
</del><ins>+ if (next && (next->previousSibling() == newChild.ptr() || next == newChild.ptr())) // nothing to do
</ins><span class="cx"> return true;
</span><span class="cx">
</span><span class="cx"> // Does this one more time because removeChild() fires a MutationEvent.
</span><del>- if (!checkReplaceChild(this, newChild.get(), oldChild, ec))
</del><ins>+ if (!checkReplaceChild(*this, newChild, oldChild, ec))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> NodeVector targets;
</span><del>- collectChildrenAndRemoveFromOldParent(*newChild.get(), targets, ec);
</del><ins>+ collectChildrenAndRemoveFromOldParent(newChild, targets, ec);
</ins><span class="cx"> if (ec)
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> // Does this yet another check because collectChildrenAndRemoveFromOldParent() fires a MutationEvent.
</span><del>- if (!checkReplaceChild(this, newChild.get(), oldChild, ec))
</del><ins>+ if (!checkReplaceChild(*this, newChild, oldChild, ec))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> InspectorInstrumentation::willInsertDOMNode(document(), *this);
</span><span class="lines">@@ -515,7 +500,7 @@
</span><span class="cx"> disconnectSubframesIfNeeded(*this, RootAndDescendants);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool ContainerNode::removeChild(Node* oldChild, ExceptionCode& ec)
</del><ins>+bool ContainerNode::removeChild(Node& oldChild, ExceptionCode& ec)
</ins><span class="cx"> {
</span><span class="cx"> // Check that this node is not "floating".
</span><span class="cx"> // If it is, it can be deleted as a side effect of sending mutation events.
</span><span class="lines">@@ -532,12 +517,12 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // NOT_FOUND_ERR: Raised if oldChild is not a child of this node.
</span><del>- if (!oldChild || oldChild->parentNode() != this) {
</del><ins>+ if (oldChild.parentNode() != this) {
</ins><span class="cx"> ec = NOT_FOUND_ERR;
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- Ref<Node> child(*oldChild);
</del><ins>+ Ref<Node> child(oldChild);
</ins><span class="cx">
</span><span class="cx"> document().removeFocusedNodeOfSubtree(child.ptr());
</span><span class="cx">
</span><span class="lines">@@ -670,7 +655,7 @@
</span><span class="cx"> dispatchSubtreeModifiedEvent();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool ContainerNode::appendChild(PassRefPtr<Node> newChild, ExceptionCode& ec)
</del><ins>+bool ContainerNode::appendChild(Ref<Node>&& newChild, ExceptionCode& ec)
</ins><span class="cx"> {
</span><span class="cx"> Ref<ContainerNode> protect(*this);
</span><span class="cx">
</span><span class="lines">@@ -681,14 +666,14 @@
</span><span class="cx"> ec = 0;
</span><span class="cx">
</span><span class="cx"> // Make sure adding the new child is ok
</span><del>- if (!checkAddChild(this, newChild.get(), ec))
</del><ins>+ if (!checkAddChild(*this, newChild, ec))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><del>- if (newChild == m_lastChild) // nothing to do
- return newChild;
</del><ins>+ if (newChild.ptr() == m_lastChild) // nothing to do
+ return true;
</ins><span class="cx">
</span><span class="cx"> NodeVector targets;
</span><del>- collectChildrenAndRemoveFromOldParent(*newChild.get(), targets, ec);
</del><ins>+ collectChildrenAndRemoveFromOldParent(newChild, targets, ec);
</ins><span class="cx"> if (ec)
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="lines">@@ -696,7 +681,7 @@
</span><span class="cx"> return true;
</span><span class="cx">
</span><span class="cx"> // We need this extra check because collectChildrenAndRemoveFromOldParent() can fire mutation events.
</span><del>- if (!checkAcceptChildGuaranteedNodeTypes(this, newChild.get(), ec))
</del><ins>+ if (!checkAcceptChildGuaranteedNodeTypes(*this, newChild, ec))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> InspectorInstrumentation::willInsertDOMNode(document(), *this);
</span><span class="lines">@@ -759,16 +744,16 @@
</span><span class="cx"> invalidateNodeListAndCollectionCachesInAncestors();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ContainerNode::cloneChildNodes(ContainerNode* clone)
</del><ins>+void ContainerNode::cloneChildNodes(ContainerNode& clone)
</ins><span class="cx"> {
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- Document& targetDocument = clone->document();
</del><ins>+ Document& targetDocument = clone.document();
</ins><span class="cx"> for (Node* child = firstChild(); child && !ec; child = child->nextSibling()) {
</span><del>- RefPtr<Node> clonedChild = child->cloneNodeInternal(targetDocument, CloningOperation::SelfWithTemplateContent);
- clone->appendChild(clonedChild, ec);
</del><ins>+ Ref<Node> clonedChild = child->cloneNodeInternal(targetDocument, CloningOperation::SelfWithTemplateContent);
+ clone.appendChild(clonedChild.copyRef(), ec);
</ins><span class="cx">
</span><del>- if (!ec && is<ContainerNode>(child))
- downcast<ContainerNode>(child)->cloneChildNodes(downcast<ContainerNode>(clonedChild.get()));
</del><ins>+ if (!ec && is<ContainerNode>(*child))
+ downcast<ContainerNode>(*child).cloneChildNodes(downcast<ContainerNode>(clonedChild.get()));
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -947,7 +932,7 @@
</span><span class="cx"> if (ec || !node)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- appendChild(node.release(), ec);
</del><ins>+ appendChild(node.releaseNonNull(), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ContainerNode::prepend(Vector<NodeOrString>&& nodeOrStringVector, ExceptionCode& ec)
</span><span class="lines">@@ -956,7 +941,7 @@
</span><span class="cx"> if (ec || !node)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- insertBefore(node.release(), firstChild(), ec);
</del><ins>+ insertBefore(node.releaseNonNull(), firstChild(), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> HTMLCollection* ContainerNode::cachedHTMLCollection(CollectionType type)
</span></span></pre></div>
<a id="trunkSourceWebCoredomContainerNodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ContainerNode.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ContainerNode.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/ContainerNode.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -102,10 +102,10 @@
</span><span class="cx"> WEBCORE_EXPORT unsigned countChildNodes() const;
</span><span class="cx"> WEBCORE_EXPORT Node* traverseToChildAt(unsigned) const;
</span><span class="cx">
</span><del>- bool insertBefore(PassRefPtr<Node> newChild, Node* refChild, ExceptionCode& = ASSERT_NO_EXCEPTION);
- bool replaceChild(PassRefPtr<Node> newChild, Node* oldChild, ExceptionCode& = ASSERT_NO_EXCEPTION);
- WEBCORE_EXPORT bool removeChild(Node* child, ExceptionCode& = ASSERT_NO_EXCEPTION);
- WEBCORE_EXPORT bool appendChild(PassRefPtr<Node> newChild, ExceptionCode& = ASSERT_NO_EXCEPTION);
</del><ins>+ bool insertBefore(Ref<Node>&& newChild, Node* refChild, ExceptionCode& = ASSERT_NO_EXCEPTION);
+ bool replaceChild(Ref<Node>&& newChild, Node& oldChild, ExceptionCode& = ASSERT_NO_EXCEPTION);
+ WEBCORE_EXPORT bool removeChild(Node& child, ExceptionCode& = ASSERT_NO_EXCEPTION);
+ WEBCORE_EXPORT bool appendChild(Ref<Node>&& newChild, ExceptionCode& = ASSERT_NO_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> // These methods are only used during parsing.
</span><span class="cx"> // They don't send DOM mutation events or handle reparenting.
</span><span class="lines">@@ -117,7 +117,7 @@
</span><span class="cx"> void removeChildren();
</span><span class="cx"> void takeAllChildrenFrom(ContainerNode*);
</span><span class="cx">
</span><del>- void cloneChildNodes(ContainerNode* clone);
</del><ins>+ void cloneChildNodes(ContainerNode& clone);
</ins><span class="cx">
</span><span class="cx"> enum ChildChangeType { ElementInserted, ElementRemoved, TextInserted, TextRemoved, TextChanged, AllChildrenRemoved, NonContentsChildChanged };
</span><span class="cx"> enum ChildChangeSource { ChildChangeSourceParser, ChildChangeSourceAPI };
</span></span></pre></div>
<a id="trunkSourceWebCoredomDOMImplementationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DOMImplementation.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DOMImplementation.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/DOMImplementation.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -231,9 +231,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (doctype)
</span><del>- doc->appendChild(doctype);
</del><ins>+ doc->appendChild(*doctype);
</ins><span class="cx"> if (documentElement)
</span><del>- doc->appendChild(documentElement.release());
</del><ins>+ doc->appendChild(documentElement.releaseNonNull());
</ins><span class="cx">
</span><span class="cx"> return doc;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/Document.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -1009,7 +1009,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> if (source->parentNode()) {
</span><del>- source->parentNode()->removeChild(source.get(), ec);
</del><ins>+ source->parentNode()->removeChild(*source, ec);
</ins><span class="cx"> if (ec)
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="lines">@@ -1547,7 +1547,7 @@
</span><span class="cx"> if (!headElement)
</span><span class="cx"> return;
</span><span class="cx"> m_titleElement = createElement(titleTag, false);
</span><del>- headElement->appendChild(m_titleElement, ASSERT_NO_EXCEPTION);
</del><ins>+ headElement->appendChild(*m_titleElement, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // The DOM API has no method of specifying direction, so assume LTR.
</span><span class="lines">@@ -2518,11 +2518,10 @@
</span><span class="cx"> newBody = downcast<HTMLElement>(node.get());
</span><span class="cx"> }
</span><span class="cx">
</span><del>- HTMLElement* b = bodyOrFrameset();
- if (!b)
- documentElement()->appendChild(newBody.release(), ec);
</del><ins>+ if (auto* body = bodyOrFrameset())
+ documentElement()->replaceChild(newBody.releaseNonNull(), *body, ec);
</ins><span class="cx"> else
</span><del>- documentElement()->replaceChild(newBody.release(), b, ec);
</del><ins>+ documentElement()->appendChild(newBody.releaseNonNull(), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> HTMLHeadElement* Document::head()
</span><span class="lines">@@ -3326,22 +3325,18 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool Document::canReplaceChild(Node* newChild, Node* oldChild)
</del><ins>+bool Document::canReplaceChild(Node& newChild, Node& oldChild)
</ins><span class="cx"> {
</span><del>- if (!oldChild)
- // ContainerNode::replaceChild will raise a NOT_FOUND_ERR.
</del><ins>+ if (oldChild.nodeType() == newChild.nodeType())
</ins><span class="cx"> return true;
</span><span class="cx">
</span><del>- if (oldChild->nodeType() == newChild->nodeType())
- return true;
-
</del><span class="cx"> int numDoctypes = 0;
</span><span class="cx"> int numElements = 0;
</span><span class="cx">
</span><span class="cx"> // First, check how many doctypes and elements we have, not counting
</span><span class="cx"> // the child we're about to remove.
</span><span class="cx"> for (Node* c = firstChild(); c; c = c->nextSibling()) {
</span><del>- if (c == oldChild)
</del><ins>+ if (c == &oldChild)
</ins><span class="cx"> continue;
</span><span class="cx">
</span><span class="cx"> switch (c->nodeType()) {
</span><span class="lines">@@ -3357,8 +3352,8 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Then, see how many doctypes and elements might be added by the new child.
</span><del>- if (newChild->isDocumentFragment()) {
- for (Node* c = newChild->firstChild(); c; c = c->nextSibling()) {
</del><ins>+ if (newChild.isDocumentFragment()) {
+ for (Node* c = newChild.firstChild(); c; c = c->nextSibling()) {
</ins><span class="cx"> switch (c->nodeType()) {
</span><span class="cx"> case ATTRIBUTE_NODE:
</span><span class="cx"> case CDATA_SECTION_NODE:
</span><span class="lines">@@ -3381,7 +3376,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> } else {
</span><del>- switch (newChild->nodeType()) {
</del><ins>+ switch (newChild.nodeType()) {
</ins><span class="cx"> case ATTRIBUTE_NODE:
</span><span class="cx"> case CDATA_SECTION_NODE:
</span><span class="cx"> case DOCUMENT_FRAGMENT_NODE:
</span><span class="lines">@@ -3409,7 +3404,7 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Node> Document::cloneNodeInternal(Document&, CloningOperation type)
</del><ins>+Ref<Node> Document::cloneNodeInternal(Document&, CloningOperation type)
</ins><span class="cx"> {
</span><span class="cx"> Ref<Document> clone = cloneDocumentWithoutChildren();
</span><span class="cx"> clone->cloneDataFromDocument(*this);
</span><span class="lines">@@ -3418,7 +3413,7 @@
</span><span class="cx"> case CloningOperation::SelfWithTemplateContent:
</span><span class="cx"> break;
</span><span class="cx"> case CloningOperation::Everything:
</span><del>- cloneChildNodes(clone.ptr());
</del><ins>+ cloneChildNodes(clone);
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> return WTF::move(clone);
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/Document.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -746,7 +746,7 @@
</span><span class="cx"> void nodeChildrenWillBeRemoved(ContainerNode&);
</span><span class="cx"> // nodeWillBeRemoved is only safe when removing one node at a time.
</span><span class="cx"> void nodeWillBeRemoved(Node&);
</span><del>- bool canReplaceChild(Node* newChild, Node* oldChild);
</del><ins>+ bool canReplaceChild(Node& newChild, Node& oldChild);
</ins><span class="cx">
</span><span class="cx"> void textInserted(Node*, unsigned offset, unsigned length);
</span><span class="cx"> void textRemoved(Node*, unsigned offset, unsigned length);
</span><span class="lines">@@ -1310,7 +1310,7 @@
</span><span class="cx"> virtual String nodeName() const override final;
</span><span class="cx"> virtual NodeType nodeType() const override final;
</span><span class="cx"> virtual bool childTypeAllowed(NodeType) const override final;
</span><del>- virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) override final;
</del><ins>+ virtual Ref<Node> cloneNodeInternal(Document&, CloningOperation) override final;
</ins><span class="cx"> void cloneDataFromDocument(const Document&);
</span><span class="cx">
</span><span class="cx"> virtual void refScriptExecutionContext() override final { ref(); }
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentFragmentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DocumentFragment.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DocumentFragment.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/DocumentFragment.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -67,18 +67,18 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Node> DocumentFragment::cloneNodeInternal(Document& targetDocument, CloningOperation type)
</del><ins>+Ref<Node> DocumentFragment::cloneNodeInternal(Document& targetDocument, CloningOperation type)
</ins><span class="cx"> {
</span><del>- RefPtr<DocumentFragment> clone = create(targetDocument);
</del><ins>+ Ref<DocumentFragment> clone = create(targetDocument);
</ins><span class="cx"> switch (type) {
</span><span class="cx"> case CloningOperation::OnlySelf:
</span><span class="cx"> case CloningOperation::SelfWithTemplateContent:
</span><span class="cx"> break;
</span><span class="cx"> case CloningOperation::Everything:
</span><del>- cloneChildNodes(clone.get());
</del><ins>+ cloneChildNodes(clone);
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><del>- return clone;
</del><ins>+ return WTF::move(clone);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void DocumentFragment::parseHTML(const String& source, Element* contextElement, ParserContentPolicy parserContentPolicy)
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentFragmenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DocumentFragment.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DocumentFragment.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/DocumentFragment.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> virtual NodeType nodeType() const override final;
</span><del>- virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) override;
</del><ins>+ virtual Ref<Node> cloneNodeInternal(Document&, CloningOperation) override;
</ins><span class="cx"> virtual bool childTypeAllowed(NodeType) const override;
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DocumentType.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DocumentType.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/DocumentType.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx"> return DOCUMENT_TYPE_NODE;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Node> DocumentType::cloneNodeInternal(Document& documentTarget, CloningOperation)
</del><ins>+Ref<Node> DocumentType::cloneNodeInternal(Document& documentTarget, CloningOperation)
</ins><span class="cx"> {
</span><span class="cx"> return create(documentTarget, m_name, m_publicId, m_systemId);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DocumentType.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DocumentType.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/DocumentType.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx"> virtual URL baseURI() const override;
</span><span class="cx"> virtual String nodeName() const override;
</span><span class="cx"> virtual NodeType nodeType() const override;
</span><del>- virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) override;
</del><ins>+ virtual Ref<Node> cloneNodeInternal(Document&, CloningOperation) override;
</ins><span class="cx">
</span><span class="cx"> String m_name;
</span><span class="cx"> String m_publicId;
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/Element.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -312,38 +312,37 @@
</span><span class="cx"> EventDispatcher::dispatchSimulatedClick(this, underlyingEvent, eventOptions, visualOptions);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Node> Element::cloneNodeInternal(Document& targetDocument, CloningOperation type)
</del><ins>+Ref<Node> Element::cloneNodeInternal(Document& targetDocument, CloningOperation type)
</ins><span class="cx"> {
</span><span class="cx"> switch (type) {
</span><span class="cx"> case CloningOperation::OnlySelf:
</span><span class="cx"> case CloningOperation::SelfWithTemplateContent:
</span><span class="cx"> return cloneElementWithoutChildren(targetDocument);
</span><span class="cx"> case CloningOperation::Everything:
</span><del>- return cloneElementWithChildren(targetDocument);
</del><ins>+ break;
</ins><span class="cx"> }
</span><del>- ASSERT_NOT_REACHED();
- return nullptr;
</del><ins>+ return cloneElementWithChildren(targetDocument);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Element> Element::cloneElementWithChildren(Document& targetDocument)
</del><ins>+Ref<Element> Element::cloneElementWithChildren(Document& targetDocument)
</ins><span class="cx"> {
</span><del>- RefPtr<Element> clone = cloneElementWithoutChildren(targetDocument);
- cloneChildNodes(clone.get());
- return clone.release();
</del><ins>+ Ref<Element> clone = cloneElementWithoutChildren(targetDocument);
+ cloneChildNodes(clone);
+ return clone;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Element> Element::cloneElementWithoutChildren(Document& targetDocument)
</del><ins>+Ref<Element> Element::cloneElementWithoutChildren(Document& targetDocument)
</ins><span class="cx"> {
</span><del>- RefPtr<Element> clone = cloneElementWithoutAttributesAndChildren(targetDocument);
</del><ins>+ Ref<Element> clone = cloneElementWithoutAttributesAndChildren(targetDocument);
</ins><span class="cx"> // This will catch HTML elements in the wrong namespace that are not correctly copied.
</span><span class="cx"> // This is a sanity check as HTML overloads some of the DOM methods.
</span><span class="cx"> ASSERT(isHTMLElement() == clone->isHTMLElement());
</span><span class="cx">
</span><span class="cx"> clone->cloneDataFromElement(*this);
</span><del>- return clone.release();
</del><ins>+ return clone;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Element> Element::cloneElementWithoutAttributesAndChildren(Document& targetDocument)
</del><ins>+Ref<Element> Element::cloneElementWithoutAttributesAndChildren(Document& targetDocument)
</ins><span class="cx"> {
</span><span class="cx"> return targetDocument.createElement(tagQName(), false);
</span><span class="cx"> }
</span><span class="lines">@@ -2319,7 +2318,7 @@
</span><span class="cx"> if (ec)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- parent->replaceChild(fragment.release(), this, ec);
</del><ins>+ parent->replaceChild(fragment.releaseNonNull(), *this, ec);
</ins><span class="cx"> RefPtr<Node> node = next ? next->previousSibling() : nullptr;
</span><span class="cx"> if (!ec && is<Text>(node.get()))
</span><span class="cx"> mergeWithNextTextNode(downcast<Text>(*node), ec);
</span><span class="lines">@@ -2338,7 +2337,7 @@
</span><span class="cx"> container = downcast<HTMLTemplateElement>(*this).content();
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- replaceChildrenWithFragment(*container, fragment.release(), ec);
</del><ins>+ replaceChildrenWithFragment(*container, fragment.releaseNonNull(), ec);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/Element.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -201,8 +201,8 @@
</span><span class="cx">
</span><span class="cx"> virtual String nodeName() const override;
</span><span class="cx">
</span><del>- RefPtr<Element> cloneElementWithChildren(Document&);
- RefPtr<Element> cloneElementWithoutChildren(Document&);
</del><ins>+ Ref<Element> cloneElementWithChildren(Document&);
+ Ref<Element> cloneElementWithoutChildren(Document&);
</ins><span class="cx">
</span><span class="cx"> void normalizeAttributes();
</span><span class="cx"> String nodeNamePreservingCase() const;
</span><span class="lines">@@ -563,8 +563,8 @@
</span><span class="cx">
</span><span class="cx"> // cloneNode is private so that non-virtual cloneElementWithChildren and cloneElementWithoutChildren
</span><span class="cx"> // are used instead.
</span><del>- virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) override;
- virtual RefPtr<Element> cloneElementWithoutAttributesAndChildren(Document&);
</del><ins>+ virtual Ref<Node> cloneNodeInternal(Document&, CloningOperation) override;
+ virtual Ref<Element> cloneElementWithoutAttributesAndChildren(Document&);
</ins><span class="cx">
</span><span class="cx"> void addShadowRoot(Ref<ShadowRoot>&&);
</span><span class="cx"> void removeShadowRoot();
</span></span></pre></div>
<a id="trunkSourceWebCoredomEntityReferencecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EntityReference.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EntityReference.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/EntityReference.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx"> return ENTITY_REFERENCE_NODE;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Node> EntityReference::cloneNodeInternal(Document& targetDocument, CloningOperation)
</del><ins>+Ref<Node> EntityReference::cloneNodeInternal(Document& targetDocument, CloningOperation)
</ins><span class="cx"> {
</span><span class="cx"> return create(targetDocument, m_entityName);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomEntityReferenceh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EntityReference.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EntityReference.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/EntityReference.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx">
</span><span class="cx"> virtual String nodeName() const override;
</span><span class="cx"> virtual NodeType nodeType() const override;
</span><del>- virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) override;
</del><ins>+ virtual Ref<Node> cloneNodeInternal(Document&, CloningOperation) override;
</ins><span class="cx">
</span><span class="cx"> String m_entityName;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/Node.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -429,38 +429,54 @@
</span><span class="cx">
</span><span class="cx"> bool Node::insertBefore(PassRefPtr<Node> newChild, Node* refChild, ExceptionCode& ec)
</span><span class="cx"> {
</span><ins>+ if (!newChild) {
+ ec = TypeError;
+ return false;
+ }
</ins><span class="cx"> if (!is<ContainerNode>(*this)) {
</span><span class="cx"> ec = HIERARCHY_REQUEST_ERR;
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><del>- return downcast<ContainerNode>(*this).insertBefore(newChild, refChild, ec);
</del><ins>+ return downcast<ContainerNode>(*this).insertBefore(*newChild, refChild, ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool Node::replaceChild(PassRefPtr<Node> newChild, Node* oldChild, ExceptionCode& ec)
</span><span class="cx"> {
</span><ins>+ if (!newChild || !oldChild) {
+ ec = TypeError;
+ return false;
+ }
</ins><span class="cx"> if (!is<ContainerNode>(*this)) {
</span><span class="cx"> ec = HIERARCHY_REQUEST_ERR;
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><del>- return downcast<ContainerNode>(*this).replaceChild(newChild, oldChild, ec);
</del><ins>+ return downcast<ContainerNode>(*this).replaceChild(*newChild, *oldChild, ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool Node::removeChild(Node* oldChild, ExceptionCode& ec)
</span><span class="cx"> {
</span><ins>+ if (!oldChild) {
+ ec = TypeError;
+ return false;
+ }
</ins><span class="cx"> if (!is<ContainerNode>(*this)) {
</span><span class="cx"> ec = NOT_FOUND_ERR;
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><del>- return downcast<ContainerNode>(*this).removeChild(oldChild, ec);
</del><ins>+ return downcast<ContainerNode>(*this).removeChild(*oldChild, ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool Node::appendChild(PassRefPtr<Node> newChild, ExceptionCode& ec)
</span><span class="cx"> {
</span><ins>+ if (!newChild) {
+ ec = TypeError;
+ return false;
+ }
</ins><span class="cx"> if (!is<ContainerNode>(*this)) {
</span><span class="cx"> ec = HIERARCHY_REQUEST_ERR;
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><del>- return downcast<ContainerNode>(*this).appendChild(newChild, ec);
</del><ins>+ return downcast<ContainerNode>(*this).appendChild(*newChild, ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static HashSet<RefPtr<Node>> nodeSetPreTransformedFromNodeOrStringVector(const Vector<NodeOrString>& nodeOrStringVector)
</span><span class="lines">@@ -515,7 +531,7 @@
</span><span class="cx"> else
</span><span class="cx"> viablePreviousSibling = parent->firstChild();
</span><span class="cx">
</span><del>- parent->insertBefore(node.release(), viablePreviousSibling.get(), ec);
</del><ins>+ parent->insertBefore(node.releaseNonNull(), viablePreviousSibling.get(), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Node::after(Vector<NodeOrString>&& nodeOrStringVector, ExceptionCode& ec)
</span><span class="lines">@@ -531,7 +547,7 @@
</span><span class="cx"> if (ec || !node)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- parent->insertBefore(node.release(), viableNextSibling.get(), ec);
</del><ins>+ parent->insertBefore(node.releaseNonNull(), viableNextSibling.get(), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Node::replaceWith(Vector<NodeOrString>&& nodeOrStringVector, ExceptionCode& ec)
</span><span class="lines">@@ -548,15 +564,15 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (parentNode() == parent)
</span><del>- parent->replaceChild(node.release(), this, ec);
</del><ins>+ parent->replaceChild(node.releaseNonNull(), *this, ec);
</ins><span class="cx"> else
</span><del>- parent->insertBefore(node.release(), viableNextSibling.get(), ec);
</del><ins>+ parent->insertBefore(node.releaseNonNull(), viableNextSibling.get(), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Node::remove(ExceptionCode& ec)
</span><span class="cx"> {
</span><span class="cx"> if (ContainerNode* parent = parentNode())
</span><del>- parent->removeChild(this, ec);
</del><ins>+ parent->removeChild(*this, ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Node::normalize()
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/Node.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -201,8 +201,8 @@
</span><span class="cx"> SelfWithTemplateContent,
</span><span class="cx"> Everything,
</span><span class="cx"> };
</span><del>- virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) = 0;
- RefPtr<Node> cloneNode(bool deep) { return cloneNodeInternal(document(), deep ? CloningOperation::Everything : CloningOperation::OnlySelf); }
</del><ins>+ virtual Ref<Node> cloneNodeInternal(Document&, CloningOperation) = 0;
+ Ref<Node> cloneNode(bool deep) { return cloneNodeInternal(document(), deep ? CloningOperation::Everything : CloningOperation::OnlySelf); }
</ins><span class="cx">
</span><span class="cx"> virtual const AtomicString& localName() const;
</span><span class="cx"> virtual const AtomicString& namespaceURI() const;
</span></span></pre></div>
<a id="trunkSourceWebCoredomProcessingInstructioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ProcessingInstruction.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ProcessingInstruction.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/ProcessingInstruction.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -79,7 +79,7 @@
</span><span class="cx"> return PROCESSING_INSTRUCTION_NODE;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Node> ProcessingInstruction::cloneNodeInternal(Document& targetDocument, CloningOperation)
</del><ins>+Ref<Node> ProcessingInstruction::cloneNodeInternal(Document& targetDocument, CloningOperation)
</ins><span class="cx"> {
</span><span class="cx"> // FIXME: Is it a problem that this does not copy m_localHref?
</span><span class="cx"> // What about other data members?
</span></span></pre></div>
<a id="trunkSourceWebCoredomProcessingInstructionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ProcessingInstruction.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ProcessingInstruction.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/ProcessingInstruction.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx">
</span><span class="cx"> virtual String nodeName() const override;
</span><span class="cx"> virtual NodeType nodeType() const override;
</span><del>- virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) override;
</del><ins>+ virtual Ref<Node> cloneNodeInternal(Document&, CloningOperation) override;
</ins><span class="cx">
</span><span class="cx"> virtual InsertionNotificationRequest insertedInto(ContainerNode&) override;
</span><span class="cx"> virtual void removedFrom(ContainerNode&) override;
</span></span></pre></div>
<a id="trunkSourceWebCoredomRangecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Range.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Range.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/Range.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -665,7 +665,7 @@
</span><span class="cx"> // (or just delete the stuff in between)
</span><span class="cx">
</span><span class="cx"> if ((action == Extract || action == Clone) && leftContents)
</span><del>- fragment->appendChild(leftContents, ec);
</del><ins>+ fragment->appendChild(*leftContents, ec);
</ins><span class="cx">
</span><span class="cx"> if (processStart) {
</span><span class="cx"> NodeVector nodes;
</span><span class="lines">@@ -675,7 +675,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ((action == Extract || action == Clone) && rightContents)
</span><del>- fragment->appendChild(rightContents, ec);
</del><ins>+ fragment->appendChild(*rightContents, ec);
</ins><span class="cx">
</span><span class="cx"> return fragment;
</span><span class="cx"> }
</span><span class="lines">@@ -702,7 +702,7 @@
</span><span class="cx"> endOffset = std::min(endOffset, static_cast<CharacterData*>(container)->length());
</span><span class="cx"> startOffset = std::min(startOffset, endOffset);
</span><span class="cx"> if (action == Extract || action == Clone) {
</span><del>- RefPtr<CharacterData> c = static_pointer_cast<CharacterData>(container->cloneNode(true));
</del><ins>+ RefPtr<CharacterData> c = static_cast<CharacterData*>(container->cloneNode(true).ptr());
</ins><span class="cx"> deleteCharacterData(c, startOffset, endOffset, ec);
</span><span class="cx"> if (fragment) {
</span><span class="cx"> result = fragment;
</span><span class="lines">@@ -717,7 +717,7 @@
</span><span class="cx"> endOffset = std::min(endOffset, static_cast<ProcessingInstruction*>(container)->data().length());
</span><span class="cx"> startOffset = std::min(startOffset, endOffset);
</span><span class="cx"> if (action == Extract || action == Clone) {
</span><del>- RefPtr<ProcessingInstruction> c = static_pointer_cast<ProcessingInstruction>(container->cloneNode(true));
</del><ins>+ RefPtr<ProcessingInstruction> c = static_cast<ProcessingInstruction*>(container->cloneNode(true).ptr());
</ins><span class="cx"> c->setData(c->data().substring(startOffset, endOffset - startOffset), ec);
</span><span class="cx"> if (fragment) {
</span><span class="cx"> result = fragment;
</span><span class="lines">@@ -935,7 +935,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> container = &startContainer();
</span><del>- container->parentNode()->insertBefore(newNode.release(), newText.get(), ec);
</del><ins>+ container->parentNode()->insertBefore(newNode.releaseNonNull(), newText.get(), ec);
</ins><span class="cx"> if (ec)
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -1303,7 +1303,7 @@
</span><span class="cx">
</span><span class="cx"> ec = 0;
</span><span class="cx"> while (Node* n = newParent->firstChild()) {
</span><del>- downcast<ContainerNode>(*newParent).removeChild(n, ec);
</del><ins>+ downcast<ContainerNode>(*newParent).removeChild(*n, ec);
</ins><span class="cx"> if (ec)
</span><span class="cx"> return;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomShadowRootcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ShadowRoot.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ShadowRoot.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/ShadowRoot.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -92,7 +92,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (RefPtr<DocumentFragment> fragment = createFragmentForInnerOuterHTML(markup, host(), AllowScriptingContent, ec))
</span><del>- replaceChildrenWithFragment(*this, fragment.release(), ec);
</del><ins>+ replaceChildrenWithFragment(*this, fragment.releaseNonNull(), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool ShadowRoot::childTypeAllowed(NodeType type) const
</span><span class="lines">@@ -131,9 +131,10 @@
</span><span class="cx"> invalidateDistribution();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Node> ShadowRoot::cloneNodeInternal(Document&, CloningOperation)
</del><ins>+Ref<Node> ShadowRoot::cloneNodeInternal(Document&, CloningOperation)
</ins><span class="cx"> {
</span><del>- return nullptr; // ShadowRoots should never be cloned.
</del><ins>+ RELEASE_ASSERT_NOT_REACHED();
+ return *static_cast<Node*>(nullptr); // ShadowRoots should never be cloned.
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ShadowRoot::removeAllEventListeners()
</span></span></pre></div>
<a id="trunkSourceWebCoredomShadowRooth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ShadowRoot.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ShadowRoot.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/ShadowRoot.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx"> virtual bool childTypeAllowed(NodeType) const override;
</span><span class="cx"> virtual void childrenChanged(const ChildChange&) override;
</span><span class="cx">
</span><del>- virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) override;
</del><ins>+ virtual Ref<Node> cloneNodeInternal(Document&, CloningOperation) override;
</ins><span class="cx">
</span><span class="cx"> // FIXME: This shouldn't happen. https://bugs.webkit.org/show_bug.cgi?id=88834
</span><span class="cx"> bool isOrphan() const { return !m_host; }
</span></span></pre></div>
<a id="trunkSourceWebCoredomTextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Text.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Text.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/Text.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx"> dispatchModifiedEvent(oldStr);
</span><span class="cx">
</span><span class="cx"> if (parentNode())
</span><del>- parentNode()->insertBefore(newText.ptr(), nextSibling(), ec);
</del><ins>+ parentNode()->insertBefore(newText.copyRef(), nextSibling(), ec);
</ins><span class="cx"> if (ec)
</span><span class="cx"> return 0;
</span><span class="cx">
</span><span class="lines">@@ -132,28 +132,28 @@
</span><span class="cx"> RefPtr<Text> protectedThis(this); // Mutation event handlers could cause our last ref to go away
</span><span class="cx"> RefPtr<ContainerNode> parent = parentNode(); // Protect against mutation handlers moving this node during traversal
</span><span class="cx"> for (RefPtr<Node> n = startText; n && n != this && n->isTextNode() && n->parentNode() == parent;) {
</span><del>- RefPtr<Node> nodeToRemove(n.release());
</del><ins>+ Ref<Node> nodeToRemove(n.releaseNonNull());
</ins><span class="cx"> n = nodeToRemove->nextSibling();
</span><del>- parent->removeChild(nodeToRemove.get(), IGNORE_EXCEPTION);
</del><ins>+ parent->removeChild(WTF::move(nodeToRemove), IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (this != endText) {
</span><span class="cx"> Node* onePastEndText = endText->nextSibling();
</span><span class="cx"> for (RefPtr<Node> n = nextSibling(); n && n != onePastEndText && n->isTextNode() && n->parentNode() == parent;) {
</span><del>- RefPtr<Node> nodeToRemove(n.release());
</del><ins>+ Ref<Node> nodeToRemove(n.releaseNonNull());
</ins><span class="cx"> n = nodeToRemove->nextSibling();
</span><del>- parent->removeChild(nodeToRemove.get(), IGNORE_EXCEPTION);
</del><ins>+ parent->removeChild(WTF::move(nodeToRemove), IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (newText.isEmpty()) {
</span><span class="cx"> if (parent && parentNode() == parent)
</span><del>- parent->removeChild(this, IGNORE_EXCEPTION);
- return 0;
</del><ins>+ parent->removeChild(*this, IGNORE_EXCEPTION);
+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> setData(newText, IGNORE_EXCEPTION);
</span><del>- return protectedThis.release();
</del><ins>+ return protectedThis;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String Text::nodeName() const
</span><span class="lines">@@ -166,7 +166,7 @@
</span><span class="cx"> return TEXT_NODE;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Node> Text::cloneNodeInternal(Document& targetDocument, CloningOperation)
</del><ins>+Ref<Node> Text::cloneNodeInternal(Document& targetDocument, CloningOperation)
</ins><span class="cx"> {
</span><span class="cx"> return create(targetDocument, data());
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomTexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Text.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Text.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/dom/Text.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx"> private:
</span><span class="cx"> virtual String nodeName() const override;
</span><span class="cx"> virtual NodeType nodeType() const override;
</span><del>- virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) override;
</del><ins>+ virtual Ref<Node> cloneNodeInternal(Document&, CloningOperation) override;
</ins><span class="cx"> virtual bool childTypeAllowed(NodeType) const override;
</span><span class="cx">
</span><span class="cx"> virtual Ref<Text> virtualCreate(const String&);
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingAppendNodeCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/AppendNodeCommand.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/AppendNodeCommand.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/AppendNodeCommand.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -35,13 +35,12 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-AppendNodeCommand::AppendNodeCommand(PassRefPtr<ContainerNode> parent, PassRefPtr<Node> node, EditAction editingAction)
</del><ins>+AppendNodeCommand::AppendNodeCommand(PassRefPtr<ContainerNode> parent, Ref<Node>&& node, EditAction editingAction)
</ins><span class="cx"> : SimpleEditCommand(parent->document(), editingAction)
</span><span class="cx"> , m_parent(parent)
</span><del>- , m_node(node)
</del><ins>+ , m_node(WTF::move(node))
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(m_parent);
</span><del>- ASSERT(m_node);
</del><span class="cx"> ASSERT(!m_node->parentNode());
</span><span class="cx">
</span><span class="cx"> ASSERT(m_parent->hasEditableStyle() || !m_parent->renderer());
</span><span class="lines">@@ -68,10 +67,10 @@
</span><span class="cx"> if (!m_parent->hasEditableStyle() && m_parent->renderer())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- m_parent->appendChild(m_node.get(), IGNORE_EXCEPTION);
</del><ins>+ m_parent->appendChild(m_node.copyRef(), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> if (shouldPostAccessibilityNotification())
</span><del>- sendAXTextChangedIgnoringLineBreaks(m_node.get(), applyEditType());
</del><ins>+ sendAXTextChangedIgnoringLineBreaks(m_node.ptr(), applyEditType());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void AppendNodeCommand::doUnapply()
</span><span class="lines">@@ -81,7 +80,7 @@
</span><span class="cx">
</span><span class="cx"> // Need to notify this before actually deleting the text
</span><span class="cx"> if (shouldPostAccessibilityNotification())
</span><del>- sendAXTextChangedIgnoringLineBreaks(m_node.get(), unapplyEditType());
</del><ins>+ sendAXTextChangedIgnoringLineBreaks(m_node.ptr(), unapplyEditType());
</ins><span class="cx">
</span><span class="cx"> m_node->remove(IGNORE_EXCEPTION);
</span><span class="cx"> }
</span><span class="lines">@@ -90,7 +89,7 @@
</span><span class="cx"> void AppendNodeCommand::getNodesInCommand(HashSet<Node*>& nodes)
</span><span class="cx"> {
</span><span class="cx"> addNodeAndDescendants(m_parent.get(), nodes);
</span><del>- addNodeAndDescendants(m_node.get(), nodes);
</del><ins>+ addNodeAndDescendants(m_node.ptr(), nodes);
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingAppendNodeCommandh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/AppendNodeCommand.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/AppendNodeCommand.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/AppendNodeCommand.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -32,13 +32,13 @@
</span><span class="cx">
</span><span class="cx"> class AppendNodeCommand : public SimpleEditCommand {
</span><span class="cx"> public:
</span><del>- static Ref<AppendNodeCommand> create(PassRefPtr<ContainerNode> parent, PassRefPtr<Node> node, EditAction editingAction)
</del><ins>+ static Ref<AppendNodeCommand> create(PassRefPtr<ContainerNode> parent, Ref<Node>&& node, EditAction editingAction)
</ins><span class="cx"> {
</span><del>- return adoptRef(*new AppendNodeCommand(parent, node, editingAction));
</del><ins>+ return adoptRef(*new AppendNodeCommand(parent, WTF::move(node), editingAction));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- AppendNodeCommand(PassRefPtr<ContainerNode> parent, PassRefPtr<Node>, EditAction);
</del><ins>+ AppendNodeCommand(PassRefPtr<ContainerNode> parent, Ref<Node>&&, EditAction);
</ins><span class="cx">
</span><span class="cx"> virtual void doApply() override;
</span><span class="cx"> virtual void doUnapply() override;
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> RefPtr<ContainerNode> m_parent;
</span><del>- RefPtr<Node> m_node;
</del><ins>+ Ref<Node> m_node;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingCompositeEditCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/CompositeEditCommand.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/CompositeEditCommand.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/CompositeEditCommand.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -395,7 +395,8 @@
</span><span class="cx"> void CompositeEditCommand::appendNode(PassRefPtr<Node> node, PassRefPtr<ContainerNode> parent)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(canHaveChildrenForEditing(parent.get()));
</span><del>- applyCommandToComposite(AppendNodeCommand::create(parent, node, editingAction()));
</del><ins>+ ASSERT(node);
+ applyCommandToComposite(AppendNodeCommand::create(parent, *node, editingAction()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void CompositeEditCommand::removeChildrenInRange(PassRefPtr<Node> node, unsigned from, unsigned to)
</span><span class="lines">@@ -414,7 +415,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (!node || !node->nonShadowBoundaryParentNode())
</span><span class="cx"> return;
</span><del>- applyCommandToComposite(RemoveNodeCommand::create(node, shouldAssumeContentIsAlwaysEditable));
</del><ins>+ applyCommandToComposite(RemoveNodeCommand::create(*node, shouldAssumeContentIsAlwaysEditable));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void CompositeEditCommand::removeNodePreservingChildren(PassRefPtr<Node> node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable)
</span><span class="lines">@@ -1541,7 +1542,7 @@
</span><span class="cx"> return node.release();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Element> createBlockPlaceholderElement(Document& document)
</del><ins>+Ref<Element> createBlockPlaceholderElement(Document& document)
</ins><span class="cx"> {
</span><span class="cx"> return document.createElement(brTag, false);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingDeleteSelectionCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -632,7 +632,7 @@
</span><span class="cx">
</span><span class="cx"> // We need to merge into m_upstreamStart's block, but it's been emptied out and collapsed by deletion.
</span><span class="cx"> if (!mergeDestination.deepEquivalent().deprecatedNode() || !mergeDestination.deepEquivalent().deprecatedNode()->isDescendantOf(enclosingBlock(m_upstreamStart.containerNode())) || m_startsAtEmptyLine) {
</span><del>- insertNodeAt(createBreakElement(document()).get(), m_upstreamStart);
</del><ins>+ insertNodeAt(createBreakElement(document()).ptr(), m_upstreamStart);
</ins><span class="cx"> mergeDestination = VisiblePosition(m_upstreamStart);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -855,7 +855,7 @@
</span><span class="cx">
</span><span class="cx"> removePreviouslySelectedEmptyTableRows();
</span><span class="cx">
</span><del>- RefPtr<Node> placeholder = m_needPlaceholder ? createBreakElement(document()).get() : 0;
</del><ins>+ RefPtr<Node> placeholder = m_needPlaceholder ? createBreakElement(document()).ptr() : nullptr;
</ins><span class="cx">
</span><span class="cx"> if (placeholder) {
</span><span class="cx"> if (m_sanitizeMarkup)
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingEditorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/Editor.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/Editor.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/Editor.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -613,8 +613,8 @@
</span><span class="cx">
</span><span class="cx"> RefPtr<Range> context = document().createRange();
</span><span class="cx"> context->selectNodeContents(elem, ec);
</span><del>- RefPtr<DocumentFragment> fragment = createFragmentFromText(*context.get(), text);
- elem->appendChild(fragment, ec);
</del><ins>+ Ref<DocumentFragment> fragment = createFragmentFromText(*context.get(), text);
+ elem->appendChild(WTF::move(fragment), ec);
</ins><span class="cx">
</span><span class="cx"> // restore element to document
</span><span class="cx"> if (parent) {
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingEditorCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/EditorCommand.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/EditorCommand.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/EditorCommand.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -165,11 +165,11 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static bool executeInsertNode(Frame& frame, PassRefPtr<Node> content)
</del><ins>+static bool executeInsertNode(Frame& frame, Ref<Node>&& content)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<DocumentFragment> fragment = DocumentFragment::create(*frame.document());
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- fragment->appendChild(content, ec);
</del><ins>+ fragment->appendChild(WTF::move(content), ec);
</ins><span class="cx"> if (ec)
</span><span class="cx"> return false;
</span><span class="cx"> return executeInsertFragment(frame, fragment.release());
</span><span class="lines">@@ -464,10 +464,10 @@
</span><span class="cx">
</span><span class="cx"> static bool executeInsertHorizontalRule(Frame& frame, Event*, EditorCommandSource, const String& value)
</span><span class="cx"> {
</span><del>- RefPtr<HTMLHRElement> rule = HTMLHRElement::create(*frame.document());
</del><ins>+ Ref<HTMLHRElement> rule = HTMLHRElement::create(*frame.document());
</ins><span class="cx"> if (!value.isEmpty())
</span><span class="cx"> rule->setIdAttribute(value);
</span><del>- return executeInsertNode(frame, rule.release());
</del><ins>+ return executeInsertNode(frame, WTF::move(rule));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static bool executeInsertHTML(Frame& frame, Event*, EditorCommandSource, const String& value)
</span><span class="lines">@@ -478,9 +478,9 @@
</span><span class="cx"> static bool executeInsertImage(Frame& frame, Event*, EditorCommandSource, const String& value)
</span><span class="cx"> {
</span><span class="cx"> // FIXME: If userInterface is true, we should display a dialog box and let the user choose a local image.
</span><del>- RefPtr<HTMLImageElement> image = HTMLImageElement::create(*frame.document());
</del><ins>+ Ref<HTMLImageElement> image = HTMLImageElement::create(*frame.document());
</ins><span class="cx"> image->setSrc(value);
</span><del>- return executeInsertNode(frame, image.release());
</del><ins>+ return executeInsertNode(frame, WTF::move(image));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static bool executeInsertLineBreak(Frame& frame, Event* event, EditorCommandSource source, const String&)
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingInsertLineBreakCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/InsertLineBreakCommand.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/InsertLineBreakCommand.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/InsertLineBreakCommand.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -129,7 +129,7 @@
</span><span class="cx">
</span><span class="cx"> // Insert an extra br or '\n' if the just inserted one collapsed.
</span><span class="cx"> if (!isStartOfParagraph(positionBeforeNode(nodeToInsert.get())))
</span><del>- insertNodeBefore(nodeToInsert->cloneNode(false).get(), nodeToInsert.get());
</del><ins>+ insertNodeBefore(nodeToInsert->cloneNode(false), nodeToInsert.get());
</ins><span class="cx">
</span><span class="cx"> setEndingSelection(VisibleSelection(positionInParentAfterNode(nodeToInsert.get()), DOWNSTREAM, endingSelection().isDirectional()));
</span><span class="cx"> // If we're inserting after all of the rendered text in a text node, or into a non-text node,
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingInsertNodeBeforeCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/InsertNodeBeforeCommand.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/InsertNodeBeforeCommand.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/InsertNodeBeforeCommand.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> return;
</span><span class="cx"> ASSERT(isEditableNode(*parent));
</span><span class="cx">
</span><del>- parent->insertBefore(m_insertChild.get(), m_refChild.get(), IGNORE_EXCEPTION);
</del><ins>+ parent->insertBefore(*m_insertChild, m_refChild.get(), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> if (shouldPostAccessibilityNotification()) {
</span><span class="cx"> Position position = is<Text>(m_insertChild.get()) ? Position(downcast<Text>(m_insertChild.get()), 0) : createLegacyEditingPosition(m_insertChild.get(), 0);
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingInsertParagraphSeparatorCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -368,7 +368,7 @@
</span><span class="cx"> // created. All of the nodes, starting at visiblePos, are about to be added to the new paragraph
</span><span class="cx"> // element. If the first node to be inserted won't be one that will hold an empty line open, add a br.
</span><span class="cx"> if (isEndOfParagraph(visiblePos) && !lineBreakExistsAtVisiblePosition(visiblePos))
</span><del>- appendNode(createBreakElement(document()).get(), blockToInsert.get());
</del><ins>+ appendNode(createBreakElement(document()), blockToInsert.get());
</ins><span class="cx">
</span><span class="cx"> // Move the start node and the siblings of the start node.
</span><span class="cx"> if (VisiblePosition(insertionPosition) != VisiblePosition(positionBeforeNode(blockToInsert.get()))) {
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingMergeIdenticalElementsCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/MergeIdenticalElementsCommand.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/MergeIdenticalElementsCommand.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/MergeIdenticalElementsCommand.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -47,13 +47,13 @@
</span><span class="cx">
</span><span class="cx"> m_atChild = m_element2->firstChild();
</span><span class="cx">
</span><del>- Vector<RefPtr<Node>> children;
</del><ins>+ Vector<Ref<Node>> children;
</ins><span class="cx"> for (Node* child = m_element1->firstChild(); child; child = child->nextSibling())
</span><del>- children.append(child);
</del><ins>+ children.append(*child);
</ins><span class="cx">
</span><span class="cx"> size_t size = children.size();
</span><span class="cx"> for (size_t i = 0; i < size; ++i)
</span><del>- m_element2->insertBefore(children[i].release(), m_atChild.get(), IGNORE_EXCEPTION);
</del><ins>+ m_element2->insertBefore(WTF::move(children[i]), m_atChild.get(), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> m_element1->remove(IGNORE_EXCEPTION);
</span><span class="cx"> }
</span><span class="lines">@@ -71,17 +71,17 @@
</span><span class="cx">
</span><span class="cx"> ExceptionCode ec = 0;
</span><span class="cx">
</span><del>- parent->insertBefore(m_element1.get(), m_element2.get(), ec);
</del><ins>+ parent->insertBefore(*m_element1, m_element2.get(), ec);
</ins><span class="cx"> if (ec)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- Vector<RefPtr<Node>> children;
</del><ins>+ Vector<Ref<Node>> children;
</ins><span class="cx"> for (Node* child = m_element2->firstChild(); child && child != atChild; child = child->nextSibling())
</span><del>- children.append(child);
</del><ins>+ children.append(*child);
</ins><span class="cx">
</span><span class="cx"> size_t size = children.size();
</span><span class="cx"> for (size_t i = 0; i < size; ++i)
</span><del>- m_element1->appendChild(children[i].release(), ec);
</del><ins>+ m_element1->appendChild(WTF::move(children[i]), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingRemoveNodeCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/RemoveNodeCommand.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/RemoveNodeCommand.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/RemoveNodeCommand.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -34,12 +34,11 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-RemoveNodeCommand::RemoveNodeCommand(PassRefPtr<Node> node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable)
</del><ins>+RemoveNodeCommand::RemoveNodeCommand(Ref<Node>&& node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable)
</ins><span class="cx"> : SimpleEditCommand(node->document())
</span><del>- , m_node(node)
</del><ins>+ , m_node(WTF::move(node))
</ins><span class="cx"> , m_shouldAssumeContentIsAlwaysEditable(shouldAssumeContentIsAlwaysEditable)
</span><span class="cx"> {
</span><del>- ASSERT(m_node);
</del><span class="cx"> ASSERT(m_node->parentNode());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -64,7 +63,7 @@
</span><span class="cx"> if (!parent || !parent->hasEditableStyle())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- parent->insertBefore(m_node.get(), refChild.get(), IGNORE_EXCEPTION);
</del><ins>+ parent->insertBefore(m_node.copyRef(), refChild.get(), IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span><span class="lines">@@ -72,7 +71,7 @@
</span><span class="cx"> {
</span><span class="cx"> addNodeAndDescendants(m_parent.get(), nodes);
</span><span class="cx"> addNodeAndDescendants(m_refChild.get(), nodes);
</span><del>- addNodeAndDescendants(m_node.get(), nodes);
</del><ins>+ addNodeAndDescendants(m_node.ptr(), nodes);
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingRemoveNodeCommandh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/RemoveNodeCommand.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/RemoveNodeCommand.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/RemoveNodeCommand.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -32,13 +32,13 @@
</span><span class="cx">
</span><span class="cx"> class RemoveNodeCommand : public SimpleEditCommand {
</span><span class="cx"> public:
</span><del>- static Ref<RemoveNodeCommand> create(PassRefPtr<Node> node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable)
</del><ins>+ static Ref<RemoveNodeCommand> create(Ref<Node>&& node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable)
</ins><span class="cx"> {
</span><del>- return adoptRef(*new RemoveNodeCommand(node, shouldAssumeContentIsAlwaysEditable));
</del><ins>+ return adoptRef(*new RemoveNodeCommand(WTF::move(node), shouldAssumeContentIsAlwaysEditable));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- explicit RemoveNodeCommand(PassRefPtr<Node>, ShouldAssumeContentIsAlwaysEditable);
</del><ins>+ RemoveNodeCommand(Ref<Node>&&, ShouldAssumeContentIsAlwaysEditable);
</ins><span class="cx">
</span><span class="cx"> virtual void doApply() override;
</span><span class="cx"> virtual void doUnapply() override;
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> void getNodesInCommand(HashSet<Node*>&) override;
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- RefPtr<Node> m_node;
</del><ins>+ Ref<Node> m_node;
</ins><span class="cx"> RefPtr<ContainerNode> m_parent;
</span><span class="cx"> RefPtr<Node> m_refChild;
</span><span class="cx"> ShouldAssumeContentIsAlwaysEditable m_shouldAssumeContentIsAlwaysEditable;
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingReplaceNodeWithSpanCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -48,19 +48,19 @@
</span><span class="cx"> ASSERT(m_elementToReplace);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void swapInNodePreservingAttributesAndChildren(HTMLElement* newNode, HTMLElement* nodeToReplace)
</del><ins>+static void swapInNodePreservingAttributesAndChildren(HTMLElement& newNode, HTMLElement& nodeToReplace)
</ins><span class="cx"> {
</span><del>- ASSERT(nodeToReplace->inDocument());
- RefPtr<ContainerNode> parentNode = nodeToReplace->parentNode();
</del><ins>+ ASSERT(nodeToReplace.inDocument());
+ RefPtr<ContainerNode> parentNode = nodeToReplace.parentNode();
</ins><span class="cx">
</span><span class="cx"> // FIXME: Fix this to send the proper MutationRecords when MutationObservers are present.
</span><del>- newNode->cloneDataFromElement(*nodeToReplace);
</del><ins>+ newNode.cloneDataFromElement(nodeToReplace);
</ins><span class="cx"> NodeVector children;
</span><del>- getChildNodes(*nodeToReplace, children);
</del><ins>+ getChildNodes(nodeToReplace, children);
</ins><span class="cx"> for (auto& child : children)
</span><del>- newNode->appendChild(child.ptr(), ASSERT_NO_EXCEPTION);
</del><ins>+ newNode.appendChild(WTF::move(child), ASSERT_NO_EXCEPTION);
</ins><span class="cx">
</span><del>- parentNode->insertBefore(newNode, nodeToReplace, ASSERT_NO_EXCEPTION);
</del><ins>+ parentNode->insertBefore(newNode, &nodeToReplace, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> parentNode->removeChild(nodeToReplace, ASSERT_NO_EXCEPTION);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -70,14 +70,14 @@
</span><span class="cx"> return;
</span><span class="cx"> if (!m_spanElement)
</span><span class="cx"> m_spanElement = createHTMLElement(m_elementToReplace->document(), spanTag);
</span><del>- swapInNodePreservingAttributesAndChildren(m_spanElement.get(), m_elementToReplace.get());
</del><ins>+ swapInNodePreservingAttributesAndChildren(*m_spanElement, *m_elementToReplace);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ReplaceNodeWithSpanCommand::doUnapply()
</span><span class="cx"> {
</span><span class="cx"> if (!m_spanElement->inDocument())
</span><span class="cx"> return;
</span><del>- swapInNodePreservingAttributesAndChildren(m_elementToReplace.get(), m_spanElement.get());
</del><ins>+ swapInNodePreservingAttributesAndChildren(*m_elementToReplace, *m_spanElement);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingReplaceSelectionCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -238,7 +238,7 @@
</span><span class="cx"> if (!parent)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- parent->removeChild(node.get(), ASSERT_NO_EXCEPTION);
</del><ins>+ parent->removeChild(*node, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ReplacementFragment::insertNodeBefore(PassRefPtr<Node> node, Node* refNode)
</span><span class="lines">@@ -250,14 +250,14 @@
</span><span class="cx"> if (!parent)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- parent->insertBefore(node, refNode, ASSERT_NO_EXCEPTION);
</del><ins>+ parent->insertBefore(*node, refNode, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<StyledElement> ReplacementFragment::insertFragmentForTestRendering(Node* rootEditableElement)
</span><span class="cx"> {
</span><span class="cx"> RefPtr<StyledElement> holder = createDefaultParagraphElement(document());
</span><span class="cx">
</span><del>- holder->appendChild(m_fragment, ASSERT_NO_EXCEPTION);
</del><ins>+ holder->appendChild(*m_fragment, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> rootEditableElement->appendChild(holder.get(), ASSERT_NO_EXCEPTION);
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx">
</span><span class="lines">@@ -270,8 +270,8 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> while (RefPtr<Node> node = holder->firstChild()) {
</span><del>- holder->removeChild(node.get(), ASSERT_NO_EXCEPTION);
- m_fragment->appendChild(node.get(), ASSERT_NO_EXCEPTION);
</del><ins>+ holder->removeChild(*node, ASSERT_NO_EXCEPTION);
+ m_fragment->appendChild(*node, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> removeNode(holder);
</span><span class="lines">@@ -1454,7 +1454,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> while (RefPtr<Node> listItem = listElement->firstChild()) {
</span><del>- listElement->removeChild(listItem.get(), ASSERT_NO_EXCEPTION);
</del><ins>+ listElement->removeChild(*listItem, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> if (isStart || isMiddle) {
</span><span class="cx"> insertNodeBefore(listItem, lastNode);
</span><span class="cx"> insertedNodes.respondToNodeInsertion(listItem.get());
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingSplitElementCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/SplitElementCommand.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/SplitElementCommand.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/SplitElementCommand.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -47,16 +47,16 @@
</span><span class="cx"> if (m_atChild->parentNode() != m_element2)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- Vector<RefPtr<Node>> children;
</del><ins>+ Vector<Ref<Node>> children;
</ins><span class="cx"> for (Node* node = m_element2->firstChild(); node != m_atChild; node = node->nextSibling())
</span><del>- children.append(node);
</del><ins>+ children.append(*node);
</ins><span class="cx">
</span><span class="cx"> ExceptionCode ec = 0;
</span><span class="cx">
</span><span class="cx"> ContainerNode* parent = m_element2->parentNode();
</span><span class="cx"> if (!parent || !parent->hasEditableStyle())
</span><span class="cx"> return;
</span><del>- parent->insertBefore(m_element1.get(), m_element2.get(), ec);
</del><ins>+ parent->insertBefore(*m_element1, m_element2.get(), ec);
</ins><span class="cx"> if (ec)
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -65,7 +65,7 @@
</span><span class="cx">
</span><span class="cx"> size_t size = children.size();
</span><span class="cx"> for (size_t i = 0; i < size; ++i)
</span><del>- m_element1->appendChild(children[i], ec);
</del><ins>+ m_element1->appendChild(WTF::move(children[i]), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void SplitElementCommand::doApply()
</span><span class="lines">@@ -80,15 +80,15 @@
</span><span class="cx"> if (!m_element1 || !m_element1->hasEditableStyle() || !m_element2->hasEditableStyle())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- Vector<RefPtr<Node>> children;
</del><ins>+ Vector<Ref<Node>> children;
</ins><span class="cx"> for (Node* node = m_element1->firstChild(); node; node = node->nextSibling())
</span><del>- children.append(node);
</del><ins>+ children.append(*node);
</ins><span class="cx">
</span><span class="cx"> RefPtr<Node> refChild = m_element2->firstChild();
</span><span class="cx">
</span><span class="cx"> size_t size = children.size();
</span><span class="cx"> for (size_t i = 0; i < size; ++i)
</span><del>- m_element2->insertBefore(children[i].get(), refChild.get(), IGNORE_EXCEPTION);
</del><ins>+ m_element2->insertBefore(WTF::move(children[i]), refChild.get(), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> // Recover the id attribute of the original element.
</span><span class="cx"> const AtomicString& id = m_element1->getIdAttribute();
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingSplitTextNodeCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/SplitTextNodeCommand.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/SplitTextNodeCommand.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/SplitTextNodeCommand.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -95,7 +95,7 @@
</span><span class="cx"> void SplitTextNodeCommand::insertText1AndTrimText2()
</span><span class="cx"> {
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- m_text2->parentNode()->insertBefore(m_text1.get(), m_text2.get(), ec);
</del><ins>+ m_text2->parentNode()->insertBefore(*m_text1, m_text2.get(), ec);
</ins><span class="cx"> if (ec)
</span><span class="cx"> return;
</span><span class="cx"> m_text2->deleteData(0, m_offset, ec);
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingWrapContentsInDummySpanCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/WrapContentsInDummySpanCommand.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/WrapContentsInDummySpanCommand.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/WrapContentsInDummySpanCommand.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -40,15 +40,15 @@
</span><span class="cx">
</span><span class="cx"> void WrapContentsInDummySpanCommand::executeApply()
</span><span class="cx"> {
</span><del>- Vector<RefPtr<Node>> children;
</del><ins>+ Vector<Ref<Node>> children;
</ins><span class="cx"> for (Node* child = m_element->firstChild(); child; child = child->nextSibling())
</span><del>- children.append(child);
</del><ins>+ children.append(*child);
</ins><span class="cx">
</span><span class="cx"> size_t size = children.size();
</span><span class="cx"> for (size_t i = 0; i < size; ++i)
</span><del>- m_dummySpan->appendChild(children[i].release(), IGNORE_EXCEPTION);
</del><ins>+ m_dummySpan->appendChild(WTF::move(children[i]), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><del>- m_element->appendChild(m_dummySpan.get(), IGNORE_EXCEPTION);
</del><ins>+ m_element->appendChild(*m_dummySpan, IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WrapContentsInDummySpanCommand::doApply()
</span><span class="lines">@@ -65,13 +65,13 @@
</span><span class="cx"> if (!m_dummySpan || !m_element->hasEditableStyle())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- Vector<RefPtr<Node>> children;
</del><ins>+ Vector<Ref<Node>> children;
</ins><span class="cx"> for (Node* child = m_dummySpan->firstChild(); child; child = child->nextSibling())
</span><del>- children.append(child);
</del><ins>+ children.append(*child);
</ins><span class="cx">
</span><span class="cx"> size_t size = children.size();
</span><span class="cx"> for (size_t i = 0; i < size; ++i)
</span><del>- m_element->appendChild(children[i].release(), IGNORE_EXCEPTION);
</del><ins>+ m_element->appendChild(WTF::move(children[i]), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> m_dummySpan->remove(IGNORE_EXCEPTION);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingcocoaEditorCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/cocoa/EditorCocoa.mm (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/cocoa/EditorCocoa.mm 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/cocoa/EditorCocoa.mm 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -56,16 +56,16 @@
</span><span class="cx"> if (!typingStyle || !typingStyle->style())
</span><span class="cx"> return &position.deprecatedNode()->renderer()->style();
</span><span class="cx">
</span><del>- RefPtr<Element> styleElement = frame->document()->createElement(HTMLNames::spanTag, false);
</del><ins>+ Ref<Element> styleElement = frame->document()->createElement(HTMLNames::spanTag, false);
</ins><span class="cx">
</span><span class="cx"> String styleText = typingStyle->style()->asText() + " display: inline";
</span><span class="cx"> styleElement->setAttribute(HTMLNames::styleAttr, styleText);
</span><span class="cx">
</span><span class="cx"> styleElement->appendChild(frame->document()->createEditingTextNode(""), ASSERT_NO_EXCEPTION);
</span><span class="cx">
</span><del>- position.deprecatedNode()->parentNode()->appendChild(styleElement, ASSERT_NO_EXCEPTION);
</del><ins>+ position.deprecatedNode()->parentNode()->appendChild(styleElement.copyRef(), ASSERT_NO_EXCEPTION);
</ins><span class="cx">
</span><del>- nodeToRemove = styleElement.get();
</del><ins>+ nodeToRemove = styleElement.ptr();
</ins><span class="cx">
</span><span class="cx"> frame->document()->updateStyleIfNeeded();
</span><span class="cx"> return styleElement->renderer() ? &styleElement->renderer()->style() : nullptr;
</span></span></pre></div>
<a id="trunkSourceWebCoreeditinghtmleditingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/htmlediting.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/htmlediting.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/htmlediting.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -899,20 +899,18 @@
</span><span class="cx"> return !childRenderer->nextSibling();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<HTMLElement> createDefaultParagraphElement(Document& document)
</del><ins>+Ref<HTMLElement> createDefaultParagraphElement(Document& document)
</ins><span class="cx"> {
</span><span class="cx"> switch (document.frame()->editor().defaultParagraphSeparator()) {
</span><span class="cx"> case EditorParagraphSeparatorIsDiv:
</span><span class="cx"> return HTMLDivElement::create(document);
</span><span class="cx"> case EditorParagraphSeparatorIsP:
</span><del>- return HTMLParagraphElement::create(document);
</del><ins>+ break;
</ins><span class="cx"> }
</span><del>-
- ASSERT_NOT_REACHED();
- return 0;
</del><ins>+ return HTMLParagraphElement::create(document);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<HTMLElement> createBreakElement(Document& document)
</del><ins>+Ref<HTMLElement> createBreakElement(Document& document)
</ins><span class="cx"> {
</span><span class="cx"> return HTMLBRElement::create(document);
</span><span class="cx"> }
</span><span class="lines">@@ -971,7 +969,7 @@
</span><span class="cx"> return positionInParentBeforeNode(node);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Element> createTabSpanElement(Document& document, PassRefPtr<Node> prpTabTextNode)
</del><ins>+Ref<Element> createTabSpanElement(Document& document, PassRefPtr<Node> prpTabTextNode)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<Node> tabTextNode = prpTabTextNode;
</span><span class="cx">
</span><span class="lines">@@ -984,17 +982,17 @@
</span><span class="cx"> if (!tabTextNode)
</span><span class="cx"> tabTextNode = document.createEditingTextNode("\t");
</span><span class="cx">
</span><del>- spanElement->appendChild(tabTextNode.release(), ASSERT_NO_EXCEPTION);
</del><ins>+ spanElement->appendChild(tabTextNode.releaseNonNull(), ASSERT_NO_EXCEPTION);
</ins><span class="cx">
</span><del>- return spanElement.release();
</del><ins>+ return spanElement.releaseNonNull();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Element> createTabSpanElement(Document& document, const String& tabText)
</del><ins>+Ref<Element> createTabSpanElement(Document& document, const String& tabText)
</ins><span class="cx"> {
</span><span class="cx"> return createTabSpanElement(document, document.createTextNode(tabText));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Element> createTabSpanElement(Document& document)
</del><ins>+Ref<Element> createTabSpanElement(Document& document)
</ins><span class="cx"> {
</span><span class="cx"> return createTabSpanElement(document, PassRefPtr<Node>());
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreeditinghtmleditingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/htmlediting.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/htmlediting.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/htmlediting.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -206,8 +206,8 @@
</span><span class="cx">
</span><span class="cx"> // Functions returning HTMLElement
</span><span class="cx">
</span><del>-WEBCORE_EXPORT PassRefPtr<HTMLElement> createDefaultParagraphElement(Document&);
-PassRefPtr<HTMLElement> createBreakElement(Document&);
</del><ins>+WEBCORE_EXPORT Ref<HTMLElement> createDefaultParagraphElement(Document&);
+Ref<HTMLElement> createBreakElement(Document&);
</ins><span class="cx"> PassRefPtr<HTMLElement> createOrderedListElement(Document&);
</span><span class="cx"> PassRefPtr<HTMLElement> createUnorderedListElement(Document&);
</span><span class="cx"> PassRefPtr<HTMLElement> createListItemElement(Document&);
</span><span class="lines">@@ -222,10 +222,10 @@
</span><span class="cx"> // Element
</span><span class="cx"> // -------------------------------------------------------------------------
</span><span class="cx">
</span><del>-PassRefPtr<Element> createTabSpanElement(Document&);
-PassRefPtr<Element> createTabSpanElement(Document&, PassRefPtr<Node> tabTextNode);
-PassRefPtr<Element> createTabSpanElement(Document&, const String& tabText);
-PassRefPtr<Element> createBlockPlaceholderElement(Document&);
</del><ins>+Ref<Element> createTabSpanElement(Document&);
+Ref<Element> createTabSpanElement(Document&, PassRefPtr<Node> tabTextNode);
+Ref<Element> createTabSpanElement(Document&, const String& tabText);
+Ref<Element> createBlockPlaceholderElement(Document&);
</ins><span class="cx">
</span><span class="cx"> Element* editableRootForPosition(const Position&, EditableType = ContentIsEditable);
</span><span class="cx"> Element* unsplittableElementForPosition(const Position&);
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingiosEditorIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/ios/EditorIOS.mm (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/ios/EditorIOS.mm 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/ios/EditorIOS.mm 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -397,7 +397,7 @@
</span><span class="cx"> if (fragment) {
</span><span class="cx"> if (newFragment && newFragment->firstChild()) {
</span><span class="cx"> ExceptionCode ec;
</span><del>- fragment->appendChild(newFragment->firstChild(), ec);
</del><ins>+ fragment->appendChild(*newFragment->firstChild(), ec);
</ins><span class="cx"> }
</span><span class="cx"> } else
</span><span class="cx"> fragment = newFragment;
</span><span class="lines">@@ -494,12 +494,12 @@
</span><span class="cx"> return fragment;
</span><span class="cx"> }
</span><span class="cx"> } else {
</span><del>- RefPtr<Element> anchor = frame.document()->createElement(HTMLNames::aTag, false);
</del><ins>+ Ref<Element> anchor = frame.document()->createElement(HTMLNames::aTag, false);
</ins><span class="cx"> anchor->setAttribute(HTMLNames::hrefAttr, url.string());
</span><span class="cx"> anchor->appendChild(frame.document()->createTextNode([[(NSURL *)url absoluteString] precomposedStringWithCanonicalMapping]));
</span><span class="cx">
</span><span class="cx"> RefPtr<DocumentFragment> newFragment = frame.document()->createDocumentFragment();
</span><del>- newFragment->appendChild(anchor.release());
</del><ins>+ newFragment->appendChild(WTF::move(anchor));
</ins><span class="cx"> addFragment(newFragment);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -583,7 +583,7 @@
</span><span class="cx"> if (!resource)
</span><span class="cx"> return nullptr;
</span><span class="cx">
</span><del>- RefPtr<Element> imageElement = m_frame.document()->createElement(HTMLNames::imgTag, false);
</del><ins>+ Ref<Element> imageElement = m_frame.document()->createElement(HTMLNames::imgTag, false);
</ins><span class="cx"> // FIXME: The code in createFragmentAndAddResources calls setDefersLoading(true). Don't we need that here?
</span><span class="cx"> if (DocumentLoader* loader = m_frame.loader().documentLoader())
</span><span class="cx"> loader->addArchiveResource(resource.get());
</span><span class="lines">@@ -592,7 +592,7 @@
</span><span class="cx"> imageElement->setAttribute(HTMLNames::srcAttr, [URL isFileURL] ? [URL absoluteString] : resource->url());
</span><span class="cx">
</span><span class="cx"> RefPtr<DocumentFragment> fragment = m_frame.document()->createDocumentFragment();
</span><del>- fragment->appendChild(imageElement.release());
</del><ins>+ fragment->appendChild(WTF::move(imageElement));
</ins><span class="cx">
</span><span class="cx"> return fragment.release();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingmacEditorMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/mac/EditorMac.mm (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/mac/EditorMac.mm 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/mac/EditorMac.mm 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -527,15 +527,15 @@
</span><span class="cx"> for (size_t i = 0; i < size; i++) {
</span><span class="cx"> String text = paths[i];
</span><span class="cx"> #if ENABLE(ATTACHMENT_ELEMENT)
</span><del>- RefPtr<HTMLAttachmentElement> attachment = HTMLAttachmentElement::create(attachmentTag, document);
</del><ins>+ Ref<HTMLAttachmentElement> attachment = HTMLAttachmentElement::create(attachmentTag, document);
</ins><span class="cx"> attachment->setFile(File::create([[NSURL fileURLWithPath:text] path]).ptr());
</span><del>- fragment->appendChild(attachment.release());
</del><ins>+ fragment->appendChild(WTF::move(attachment));
</ins><span class="cx"> #else
</span><span class="cx"> text = frame.editor().client()->userVisibleString([NSURL fileURLWithPath:text]);
</span><span class="cx">
</span><del>- RefPtr<HTMLElement> paragraph = createDefaultParagraphElement(document);
</del><ins>+ Ref<HTMLElement> paragraph = createDefaultParagraphElement(document);
</ins><span class="cx"> paragraph->appendChild(document.createTextNode(text));
</span><del>- fragment->appendChild(paragraph.release());
</del><ins>+ fragment->appendChild(WTF::move(paragraph));
</ins><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -594,12 +594,12 @@
</span><span class="cx"> if (url.string().isEmpty())
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- RefPtr<Element> anchor = frame.document()->createElement(HTMLNames::aTag, false);
</del><ins>+ Ref<Element> anchor = frame.document()->createElement(HTMLNames::aTag, false);
</ins><span class="cx"> anchor->setAttribute(HTMLNames::hrefAttr, url.string());
</span><span class="cx"> anchor->appendChild(frame.document()->createTextNode([title precomposedStringWithCanonicalMapping]));
</span><span class="cx">
</span><span class="cx"> fragment = frame.document()->createDocumentFragment();
</span><del>- fragment->appendChild(anchor.release());
</del><ins>+ fragment->appendChild(WTF::move(anchor));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -635,11 +635,11 @@
</span><span class="cx"> if (DocumentLoader* loader = m_frame.loader().documentLoader())
</span><span class="cx"> loader->addArchiveResource(resource.get());
</span><span class="cx">
</span><del>- RefPtr<Element> imageElement = document().createElement(HTMLNames::imgTag, false);
</del><ins>+ Ref<Element> imageElement = document().createElement(HTMLNames::imgTag, false);
</ins><span class="cx"> imageElement->setAttribute(HTMLNames::srcAttr, resource->url().string());
</span><span class="cx">
</span><span class="cx"> RefPtr<DocumentFragment> fragment = document().createDocumentFragment();
</span><del>- fragment->appendChild(imageElement.release());
</del><ins>+ fragment->appendChild(WTF::move(imageElement));
</ins><span class="cx">
</span><span class="cx"> return fragment.release();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingmarkupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/markup.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/markup.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/markup.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -704,12 +704,12 @@
</span><span class="cx"> return accumulator.serializeNodes(const_cast<Node&>(node), childrenOnly, tagNamesToSkip);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void fillContainerFromString(ContainerNode* paragraph, const String& string)
</del><ins>+static void fillContainerFromString(ContainerNode& paragraph, const String& string)
</ins><span class="cx"> {
</span><del>- Document& document = paragraph->document();
</del><ins>+ Document& document = paragraph.document();
</ins><span class="cx">
</span><span class="cx"> if (string.isEmpty()) {
</span><del>- paragraph->appendChild(createBlockPlaceholderElement(document), ASSERT_NO_EXCEPTION);
</del><ins>+ paragraph.appendChild(createBlockPlaceholderElement(document), ASSERT_NO_EXCEPTION);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -726,11 +726,11 @@
</span><span class="cx"> // append the non-tab textual part
</span><span class="cx"> if (!s.isEmpty()) {
</span><span class="cx"> if (!tabText.isEmpty()) {
</span><del>- paragraph->appendChild(createTabSpanElement(document, tabText), ASSERT_NO_EXCEPTION);
</del><ins>+ paragraph.appendChild(createTabSpanElement(document, tabText), ASSERT_NO_EXCEPTION);
</ins><span class="cx"> tabText = emptyString();
</span><span class="cx"> }
</span><del>- RefPtr<Node> textNode = document.createTextNode(stringWithRebalancedWhitespace(s, first, i + 1 == numEntries));
- paragraph->appendChild(textNode.release(), ASSERT_NO_EXCEPTION);
</del><ins>+ Ref<Node> textNode = document.createTextNode(stringWithRebalancedWhitespace(s, first, i + 1 == numEntries));
+ paragraph.appendChild(WTF::move(textNode), ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // there is a tab after every entry, except the last entry
</span><span class="lines">@@ -738,7 +738,7 @@
</span><span class="cx"> if (i + 1 != numEntries)
</span><span class="cx"> tabText.append('\t');
</span><span class="cx"> else if (!tabText.isEmpty())
</span><del>- paragraph->appendChild(createTabSpanElement(document, tabText), ASSERT_NO_EXCEPTION);
</del><ins>+ paragraph.appendChild(createTabSpanElement(document, tabText), ASSERT_NO_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> first = false;
</span><span class="cx"> }
</span><span class="lines">@@ -778,13 +778,13 @@
</span><span class="cx"> return container->renderer()->style().preserveNewline();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<DocumentFragment> createFragmentFromText(Range& context, const String& text)
</del><ins>+Ref<DocumentFragment> createFragmentFromText(Range& context, const String& text)
</ins><span class="cx"> {
</span><span class="cx"> Document& document = context.ownerDocument();
</span><del>- RefPtr<DocumentFragment> fragment = document.createDocumentFragment();
</del><ins>+ Ref<DocumentFragment> fragment = document.createDocumentFragment();
</ins><span class="cx">
</span><span class="cx"> if (text.isEmpty())
</span><del>- return fragment.release();
</del><ins>+ return fragment;
</ins><span class="cx">
</span><span class="cx"> String string = text;
</span><span class="cx"> string.replace("\r\n", "\n");
</span><span class="lines">@@ -793,17 +793,17 @@
</span><span class="cx"> if (contextPreservesNewline(context)) {
</span><span class="cx"> fragment->appendChild(document.createTextNode(string), ASSERT_NO_EXCEPTION);
</span><span class="cx"> if (string.endsWith('\n')) {
</span><del>- RefPtr<Element> element = createBreakElement(document);
</del><ins>+ Ref<Element> element = createBreakElement(document);
</ins><span class="cx"> element->setAttribute(classAttr, AppleInterchangeNewline);
</span><del>- fragment->appendChild(element.release(), ASSERT_NO_EXCEPTION);
</del><ins>+ fragment->appendChild(WTF::move(element), ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><del>- return fragment.release();
</del><ins>+ return fragment;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // A string with no newlines gets added inline, rather than being put into a paragraph.
</span><span class="cx"> if (string.find('\n') == notFound) {
</span><del>- fillContainerFromString(fragment.get(), string);
- return fragment.release();
</del><ins>+ fillContainerFromString(fragment, string);
+ return fragment;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Break string into paragraphs. Extra line breaks turn into empty paragraphs.
</span><span class="lines">@@ -829,17 +829,17 @@
</span><span class="cx"> element->setAttribute(classAttr, AppleInterchangeNewline);
</span><span class="cx"> } else if (useLineBreak) {
</span><span class="cx"> element = createBreakElement(document);
</span><del>- fillContainerFromString(fragment.get(), s);
</del><ins>+ fillContainerFromString(fragment, s);
</ins><span class="cx"> } else {
</span><span class="cx"> if (useClonesOfEnclosingBlock)
</span><span class="cx"> element = block->cloneElementWithoutChildren(document);
</span><span class="cx"> else
</span><span class="cx"> element = createDefaultParagraphElement(document);
</span><del>- fillContainerFromString(element.get(), s);
</del><ins>+ fillContainerFromString(*element, s);
</ins><span class="cx"> }
</span><del>- fragment->appendChild(element.release(), ASSERT_NO_EXCEPTION);
</del><ins>+ fragment->appendChild(element.releaseNonNull(), ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><del>- return fragment.release();
</del><ins>+ return fragment;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String documentTypeString(const Document& document)
</span><span class="lines">@@ -945,10 +945,10 @@
</span><span class="cx"> RefPtr<Node> nextChild;
</span><span class="cx"> for (RefPtr<Node> child = element.firstChild(); child; child = nextChild) {
</span><span class="cx"> nextChild = child->nextSibling();
</span><del>- element.removeChild(child.get(), ASSERT_NO_EXCEPTION);
- fragment.insertBefore(child, &element, ASSERT_NO_EXCEPTION);
</del><ins>+ element.removeChild(*child, ASSERT_NO_EXCEPTION);
+ fragment.insertBefore(*child, &element, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><del>- fragment.removeChild(&element, ASSERT_NO_EXCEPTION);
</del><ins>+ fragment.removeChild(element, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<DocumentFragment> createContextualFragment(const String& markup, HTMLElement* element, ParserContentPolicy parserContentPolicy, ExceptionCode& ec)
</span><span class="lines">@@ -990,7 +990,7 @@
</span><span class="cx"> return hasOneChild(node) && node.firstChild()->isTextNode();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void replaceChildrenWithFragment(ContainerNode& container, PassRefPtr<DocumentFragment> fragment, ExceptionCode& ec)
</del><ins>+void replaceChildrenWithFragment(ContainerNode& container, Ref<DocumentFragment>&& fragment, ExceptionCode& ec)
</ins><span class="cx"> {
</span><span class="cx"> Ref<ContainerNode> containerNode(container);
</span><span class="cx"> ChildListMutationScope mutation(containerNode);
</span><span class="lines">@@ -1000,18 +1000,18 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (hasOneTextChild(containerNode) && hasOneTextChild(*fragment)) {
</del><ins>+ if (hasOneTextChild(containerNode) && hasOneTextChild(fragment)) {
</ins><span class="cx"> downcast<Text>(*containerNode->firstChild()).setData(downcast<Text>(*fragment->firstChild()).data(), ec);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (hasOneChild(containerNode)) {
</span><del>- containerNode->replaceChild(fragment, containerNode->firstChild(), ec);
</del><ins>+ containerNode->replaceChild(WTF::move(fragment), *containerNode->firstChild(), ec);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> containerNode->removeChildren();
</span><del>- containerNode->appendChild(fragment, ec);
</del><ins>+ containerNode->appendChild(WTF::move(fragment), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void replaceChildrenWithText(ContainerNode& container, const String& text, ExceptionCode& ec)
</span><span class="lines">@@ -1027,7 +1027,7 @@
</span><span class="cx"> Ref<Text> textNode = Text::create(containerNode->document(), text);
</span><span class="cx">
</span><span class="cx"> if (hasOneChild(containerNode)) {
</span><del>- containerNode->replaceChild(WTF::move(textNode), containerNode->firstChild(), ec);
</del><ins>+ containerNode->replaceChild(WTF::move(textNode), *containerNode->firstChild(), ec);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingmarkuph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/markup.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/markup.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/editing/markup.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -49,7 +49,7 @@
</span><span class="cx"> enum EAbsoluteURLs { DoNotResolveURLs, ResolveAllURLs, ResolveNonLocalURLs };
</span><span class="cx"> enum EFragmentSerialization { HTMLFragmentSerialization, XMLFragmentSerialization };
</span><span class="cx">
</span><del>-WEBCORE_EXPORT PassRefPtr<DocumentFragment> createFragmentFromText(Range& context, const String& text);
</del><ins>+WEBCORE_EXPORT Ref<DocumentFragment> createFragmentFromText(Range& context, const String& text);
</ins><span class="cx"> WEBCORE_EXPORT Ref<DocumentFragment> createFragmentFromMarkup(Document&, const String& markup, const String& baseURL, ParserContentPolicy = AllowScriptingContent);
</span><span class="cx"> PassRefPtr<DocumentFragment> createFragmentForInnerOuterHTML(const String&, Element*, ParserContentPolicy, ExceptionCode&);
</span><span class="cx"> PassRefPtr<DocumentFragment> createFragmentForTransformToFragment(const String&, const String& sourceMIMEType, Document* outputDoc);
</span><span class="lines">@@ -59,11 +59,11 @@
</span><span class="cx">
</span><span class="cx"> // These methods are used by HTMLElement & ShadowRoot to replace the
</span><span class="cx"> // children with respected fragment/text.
</span><del>-void replaceChildrenWithFragment(ContainerNode&, PassRefPtr<DocumentFragment>, ExceptionCode&);
</del><ins>+void replaceChildrenWithFragment(ContainerNode&, Ref<DocumentFragment>&&, ExceptionCode&);
</ins><span class="cx"> void replaceChildrenWithText(ContainerNode&, const String&, ExceptionCode&);
</span><span class="cx">
</span><del>-String createMarkup(const Range&, Vector<Node*>* = 0, EAnnotateForInterchange = DoNotAnnotateForInterchange, bool convertBlocksToInlines = false, EAbsoluteURLs = DoNotResolveURLs);
-String createMarkup(const Node&, EChildrenOnly = IncludeNode, Vector<Node*>* = 0, EAbsoluteURLs = DoNotResolveURLs, Vector<QualifiedName>* tagNamesToSkip = 0, EFragmentSerialization = HTMLFragmentSerialization);
</del><ins>+String createMarkup(const Range&, Vector<Node*>* = nullptr, EAnnotateForInterchange = DoNotAnnotateForInterchange, bool convertBlocksToInlines = false, EAbsoluteURLs = DoNotResolveURLs);
+String createMarkup(const Node&, EChildrenOnly = IncludeNode, Vector<Node*>* = nullptr, EAbsoluteURLs = DoNotResolveURLs, Vector<QualifiedName>* tagNamesToSkip = 0, EFragmentSerialization = HTMLFragmentSerialization);
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT String createFullMarkup(const Node&);
</span><span class="cx"> WEBCORE_EXPORT String createFullMarkup(const Range&);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlBaseChooserOnlyDateAndTimeInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -60,9 +60,9 @@
</span><span class="cx"> {
</span><span class="cx"> DEPRECATED_DEFINE_STATIC_LOCAL(AtomicString, valueContainerPseudo, ("-webkit-date-and-time-value", AtomicString::ConstructFromLiteral));
</span><span class="cx">
</span><del>- RefPtr<HTMLDivElement> valueContainer = HTMLDivElement::create(element().document());
</del><ins>+ Ref<HTMLDivElement> valueContainer = HTMLDivElement::create(element().document());
</ins><span class="cx"> valueContainer->setPseudo(valueContainerPseudo);
</span><del>- element().userAgentShadowRoot()->appendChild(valueContainer.get());
</del><ins>+ element().userAgentShadowRoot()->appendChild(WTF::move(valueContainer));
</ins><span class="cx"> updateAppearance();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlColorInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ColorInputType.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ColorInputType.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/ColorInputType.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -107,12 +107,12 @@
</span><span class="cx"> ASSERT(element().shadowRoot());
</span><span class="cx">
</span><span class="cx"> Document& document = element().document();
</span><del>- RefPtr<HTMLDivElement> wrapperElement = HTMLDivElement::create(document);
</del><ins>+ Ref<HTMLDivElement> wrapperElement = HTMLDivElement::create(document);
</ins><span class="cx"> wrapperElement->setPseudo(AtomicString("-webkit-color-swatch-wrapper", AtomicString::ConstructFromLiteral));
</span><del>- RefPtr<HTMLDivElement> colorSwatch = HTMLDivElement::create(document);
</del><ins>+ Ref<HTMLDivElement> colorSwatch = HTMLDivElement::create(document);
</ins><span class="cx"> colorSwatch->setPseudo(AtomicString("-webkit-color-swatch", AtomicString::ConstructFromLiteral));
</span><del>- wrapperElement->appendChild(colorSwatch.release(), ASSERT_NO_EXCEPTION);
- element().userAgentShadowRoot()->appendChild(wrapperElement.release(), ASSERT_NO_EXCEPTION);
</del><ins>+ wrapperElement->appendChild(WTF::move(colorSwatch), ASSERT_NO_EXCEPTION);
+ element().userAgentShadowRoot()->appendChild(WTF::move(wrapperElement), ASSERT_NO_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> updateColorSwatch();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlFTPDirectoryDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/FTPDirectoryDocument.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/FTPDirectoryDocument.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/FTPDirectoryDocument.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -104,27 +104,27 @@
</span><span class="cx"> RefPtr<Element> rowElement = m_tableElement->insertRow(-1, IGNORE_EXCEPTION);
</span><span class="cx"> rowElement->setAttribute(HTMLNames::classAttr, "ftpDirectoryEntryRow");
</span><span class="cx">
</span><del>- RefPtr<Element> element = document()->createElement(tdTag, false);
</del><ins>+ Ref<Element> element = document()->createElement(tdTag, false);
</ins><span class="cx"> element->appendChild(Text::create(*document(), String(&noBreakSpace, 1)), IGNORE_EXCEPTION);
</span><span class="cx"> if (isDirectory)
</span><span class="cx"> element->setAttribute(HTMLNames::classAttr, "ftpDirectoryIcon ftpDirectoryTypeDirectory");
</span><span class="cx"> else
</span><span class="cx"> element->setAttribute(HTMLNames::classAttr, "ftpDirectoryIcon ftpDirectoryTypeFile");
</span><del>- rowElement->appendChild(element, IGNORE_EXCEPTION);
</del><ins>+ rowElement->appendChild(WTF::move(element), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> element = createTDForFilename(filename);
</span><span class="cx"> element->setAttribute(HTMLNames::classAttr, "ftpDirectoryFileName");
</span><del>- rowElement->appendChild(element, IGNORE_EXCEPTION);
</del><ins>+ rowElement->appendChild(WTF::move(element), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> element = document()->createElement(tdTag, false);
</span><span class="cx"> element->appendChild(Text::create(*document(), date), IGNORE_EXCEPTION);
</span><span class="cx"> element->setAttribute(HTMLNames::classAttr, "ftpDirectoryFileDate");
</span><del>- rowElement->appendChild(element, IGNORE_EXCEPTION);
</del><ins>+ rowElement->appendChild(WTF::move(element), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> element = document()->createElement(tdTag, false);
</span><span class="cx"> element->appendChild(Text::create(*document(), size), IGNORE_EXCEPTION);
</span><span class="cx"> element->setAttribute(HTMLNames::classAttr, "ftpDirectoryFileSize");
</span><del>- rowElement->appendChild(element, IGNORE_EXCEPTION);
</del><ins>+ rowElement->appendChild(WTF::move(element), IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<Element> FTPDirectoryDocumentParser::createTDForFilename(const String& filename)
</span><span class="lines">@@ -135,12 +135,12 @@
</span><span class="cx"> else
</span><span class="cx"> fullURL = fullURL + '/' + filename;
</span><span class="cx">
</span><del>- RefPtr<Element> anchorElement = document()->createElement(aTag, false);
</del><ins>+ Ref<Element> anchorElement = document()->createElement(aTag, false);
</ins><span class="cx"> anchorElement->setAttribute(HTMLNames::hrefAttr, fullURL);
</span><span class="cx"> anchorElement->appendChild(Text::create(*document(), filename), IGNORE_EXCEPTION);
</span><span class="cx">
</span><span class="cx"> Ref<Element> tdElement = document()->createElement(tdTag, false);
</span><del>- tdElement->appendChild(anchorElement, IGNORE_EXCEPTION);
</del><ins>+ tdElement->appendChild(WTF::move(anchorElement), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> return tdElement;
</span><span class="cx"> }
</span><span class="lines">@@ -312,9 +312,9 @@
</span><span class="cx"> // If that fails for some reason, cram it on the end of the document as a last
</span><span class="cx"> // ditch effort
</span><span class="cx"> if (auto* body = document()->bodyOrFrameset())
</span><del>- body->appendChild(m_tableElement, IGNORE_EXCEPTION);
</del><ins>+ body->appendChild(*m_tableElement, IGNORE_EXCEPTION);
</ins><span class="cx"> else
</span><del>- document()->appendChild(m_tableElement, IGNORE_EXCEPTION);
</del><ins>+ document()->appendChild(*m_tableElement, IGNORE_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -325,16 +325,16 @@
</span><span class="cx">
</span><span class="cx"> // FIXME: Make this "basic document" more acceptable
</span><span class="cx">
</span><del>- RefPtr<Element> bodyElement = document()->createElement(bodyTag, false);
</del><ins>+ Ref<Element> bodyElement = document()->createElement(bodyTag, false);
</ins><span class="cx">
</span><del>- document()->appendChild(bodyElement, IGNORE_EXCEPTION);
</del><ins>+ document()->appendChild(bodyElement.copyRef(), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><del>- RefPtr<Element> tableElement = document()->createElement(tableTag, false);
- m_tableElement = downcast<HTMLTableElement>(tableElement.get());
</del><ins>+ Ref<Element> tableElement = document()->createElement(tableTag, false);
+ m_tableElement = downcast<HTMLTableElement>(tableElement.ptr());
</ins><span class="cx"> m_tableElement->setAttribute(HTMLNames::idAttr, "ftpDirectoryTable");
</span><span class="cx"> m_tableElement->setAttribute(HTMLNames::styleAttr, "width:100%");
</span><span class="cx">
</span><del>- bodyElement->appendChild(m_tableElement, IGNORE_EXCEPTION);
</del><ins>+ bodyElement->appendChild(WTF::move(tableElement), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> document()->processViewport("width=device-width", ViewportArguments::ViewportMeta);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLDetailsElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLDetailsElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLDetailsElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLDetailsElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -90,11 +90,11 @@
</span><span class="cx">
</span><span class="cx"> Ref<DetailsSummaryElement> DetailsSummaryElement::create(Document& document)
</span><span class="cx"> {
</span><del>- RefPtr<HTMLSummaryElement> summary = HTMLSummaryElement::create(summaryTag, document);
</del><ins>+ Ref<HTMLSummaryElement> summary = HTMLSummaryElement::create(summaryTag, document);
</ins><span class="cx"> summary->appendChild(Text::create(document, defaultDetailsSummaryText()), ASSERT_NO_EXCEPTION);
</span><span class="cx">
</span><span class="cx"> Ref<DetailsSummaryElement> detailsSummary = adoptRef(*new DetailsSummaryElement(document));
</span><del>- detailsSummary->appendChild(summary);
</del><ins>+ detailsSummary->appendChild(WTF::move(summary));
</ins><span class="cx"> return detailsSummary;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -584,9 +584,9 @@
</span><span class="cx">
</span><span class="cx"> // Add text nodes and <br> elements.
</span><span class="cx"> ec = 0;
</span><del>- RefPtr<DocumentFragment> fragment = textToFragment(text, ec);
</del><ins>+ Ref<DocumentFragment> fragment = textToFragment(text, ec);
</ins><span class="cx"> if (!ec)
</span><del>- replaceChildrenWithFragment(*this, fragment.release(), ec);
</del><ins>+ replaceChildrenWithFragment(*this, WTF::move(fragment), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLElement::setOuterText(const String& text, ExceptionCode& ec)
</span><span class="lines">@@ -621,7 +621,7 @@
</span><span class="cx"> ec = HIERARCHY_REQUEST_ERR;
</span><span class="cx"> if (ec)
</span><span class="cx"> return;
</span><del>- parent->replaceChild(newChild.release(), this, ec);
</del><ins>+ parent->replaceChild(newChild.releaseNonNull(), *this, ec);
</ins><span class="cx">
</span><span class="cx"> RefPtr<Node> node = next ? next->previousSibling() : nullptr;
</span><span class="cx"> if (!ec && is<Text>(node.get()))
</span><span class="lines">@@ -630,7 +630,7 @@
</span><span class="cx"> mergeWithNextTextNode(downcast<Text>(*prev), ec);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Node* HTMLElement::insertAdjacent(const String& where, Node* newChild, ExceptionCode& ec)
</del><ins>+Node* HTMLElement::insertAdjacent(const String& where, Ref<Node>&& newChild, ExceptionCode& ec)
</ins><span class="cx"> {
</span><span class="cx"> // In Internet Explorer if the element has no parent and where is "beforeBegin" or "afterEnd",
</span><span class="cx"> // a document fragment is created and the elements appended in the correct order. This document
</span><span class="lines">@@ -641,18 +641,18 @@
</span><span class="cx">
</span><span class="cx"> if (equalIgnoringCase(where, "beforeBegin")) {
</span><span class="cx"> ContainerNode* parent = this->parentNode();
</span><del>- return (parent && parent->insertBefore(newChild, this, ec)) ? newChild : nullptr;
</del><ins>+ return (parent && parent->insertBefore(newChild.copyRef(), this, ec)) ? newChild.ptr() : nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (equalIgnoringCase(where, "afterBegin"))
</span><del>- return insertBefore(newChild, firstChild(), ec) ? newChild : nullptr;
</del><ins>+ return insertBefore(newChild.copyRef(), firstChild(), ec) ? newChild.ptr() : nullptr;
</ins><span class="cx">
</span><span class="cx"> if (equalIgnoringCase(where, "beforeEnd"))
</span><del>- return appendChild(newChild, ec) ? newChild : nullptr;
</del><ins>+ return appendChild(newChild.copyRef(), ec) ? newChild.ptr() : nullptr;
</ins><span class="cx">
</span><span class="cx"> if (equalIgnoringCase(where, "afterEnd")) {
</span><span class="cx"> ContainerNode* parent = this->parentNode();
</span><del>- return (parent && parent->insertBefore(newChild, nextSibling(), ec)) ? newChild : nullptr;
</del><ins>+ return (parent && parent->insertBefore(newChild.copyRef(), nextSibling(), ec)) ? newChild.ptr() : nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // IE throws COM Exception E_INVALIDARG; this is the best DOM exception alternative.
</span><span class="lines">@@ -668,7 +668,7 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- Node* returnValue = insertAdjacent(where, newChild, ec);
</del><ins>+ Node* returnValue = insertAdjacent(where, *newChild, ec);
</ins><span class="cx"> ASSERT_WITH_SECURITY_IMPLICATION(!returnValue || is<Element>(*returnValue));
</span><span class="cx"> return downcast<Element>(returnValue);
</span><span class="cx"> }
</span><span class="lines">@@ -699,13 +699,12 @@
</span><span class="cx"> RefPtr<DocumentFragment> fragment = createFragmentForInnerOuterHTML(markup, contextElement, AllowScriptingContent, ec);
</span><span class="cx"> if (!fragment)
</span><span class="cx"> return;
</span><del>- insertAdjacent(where, fragment.get(), ec);
</del><ins>+ insertAdjacent(where, fragment.releaseNonNull(), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLElement::insertAdjacentText(const String& where, const String& text, ExceptionCode& ec)
</span><span class="cx"> {
</span><del>- RefPtr<Text> textNode = document().createTextNode(text);
- insertAdjacent(where, textNode.get(), ec);
</del><ins>+ insertAdjacent(where, document().createTextNode(text), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLElement::applyAlignmentAttributeToStyle(const AtomicString& alignment, MutableStyleProperties& style)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLElement.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLElement.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLElement.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -130,7 +130,7 @@
</span><span class="cx">
</span><span class="cx"> virtual HTMLFormElement* virtualForm() const;
</span><span class="cx">
</span><del>- Node* insertAdjacent(const String& where, Node* newChild, ExceptionCode&);
</del><ins>+ Node* insertAdjacent(const String& where, Ref<Node>&& newChild, ExceptionCode&);
</ins><span class="cx"> Ref<DocumentFragment> textToFragment(const String&, ExceptionCode&);
</span><span class="cx">
</span><span class="cx"> void dirAttributeChanged(const AtomicString&);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLImageElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLImageElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLImageElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLImageElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -504,7 +504,7 @@
</span><span class="cx"> if (!imageControls)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- ensureUserAgentShadowRoot().appendChild(imageControls);
</del><ins>+ ensureUserAgentShadowRoot().appendChild(imageControls.releaseNonNull());
</ins><span class="cx">
</span><span class="cx"> auto* renderObject = renderer();
</span><span class="cx"> if (!renderObject)
</span><span class="lines">@@ -521,7 +521,7 @@
</span><span class="cx">
</span><span class="cx"> if (Node* node = shadowRoot->firstChild()) {
</span><span class="cx"> ASSERT_WITH_SECURITY_IMPLICATION(node->isImageControlsRootElement());
</span><del>- shadowRoot->removeChild(node);
</del><ins>+ shadowRoot->removeChild(*node);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> auto* renderObject = renderer();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLKeygenElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLKeygenElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLKeygenElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLKeygenElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- virtual RefPtr<Element> cloneElementWithoutAttributesAndChildren(Document& targetDocument) override
</del><ins>+ virtual Ref<Element> cloneElementWithoutAttributesAndChildren(Document& targetDocument) override
</ins><span class="cx"> {
</span><span class="cx"> return create(targetDocument);
</span><span class="cx"> }
</span><span class="lines">@@ -73,14 +73,14 @@
</span><span class="cx"> Vector<String> keys;
</span><span class="cx"> getSupportedKeySizes(keys);
</span><span class="cx">
</span><del>- RefPtr<HTMLSelectElement> select = KeygenSelectElement::create(document);
</del><ins>+ Ref<HTMLSelectElement> select = KeygenSelectElement::create(document);
</ins><span class="cx"> for (size_t i = 0; i < keys.size(); ++i) {
</span><del>- RefPtr<HTMLOptionElement> option = HTMLOptionElement::create(document);
- select->appendChild(option, IGNORE_EXCEPTION);
</del><ins>+ Ref<HTMLOptionElement> option = HTMLOptionElement::create(document);
+ select->appendChild(option.copyRef(), IGNORE_EXCEPTION);
</ins><span class="cx"> option->appendChild(Text::create(document, keys[i]), IGNORE_EXCEPTION);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- ensureUserAgentShadowRoot().appendChild(select, IGNORE_EXCEPTION);
</del><ins>+ ensureUserAgentShadowRoot().appendChild(WTF::move(select), IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<HTMLKeygenElement> HTMLKeygenElement::create(const QualifiedName& tagName, Document& document, HTMLFormElement* form)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMeterElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMeterElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMeterElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLMeterElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -229,16 +229,16 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(!m_value);
</span><span class="cx">
</span><del>- RefPtr<MeterInnerElement> inner = MeterInnerElement::create(document());
- root->appendChild(inner);
</del><ins>+ Ref<MeterInnerElement> inner = MeterInnerElement::create(document());
+ root->appendChild(inner.copyRef());
</ins><span class="cx">
</span><del>- RefPtr<MeterBarElement> bar = MeterBarElement::create(document());
</del><ins>+ Ref<MeterBarElement> bar = MeterBarElement::create(document());
</ins><span class="cx"> m_value = MeterValueElement::create(document());
</span><span class="cx"> m_value->setWidthPercentage(0);
</span><span class="cx"> m_value->updatePseudo();
</span><del>- bar->appendChild(m_value, ASSERT_NO_EXCEPTION);
</del><ins>+ bar->appendChild(*m_value, ASSERT_NO_EXCEPTION);
</ins><span class="cx">
</span><del>- inner->appendChild(bar, ASSERT_NO_EXCEPTION);
</del><ins>+ inner->appendChild(WTF::move(bar), ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOptionElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOptionElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOptionElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLOptionElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -71,12 +71,12 @@
</span><span class="cx"> {
</span><span class="cx"> RefPtr<HTMLOptionElement> element = adoptRef(new HTMLOptionElement(optionTag, document));
</span><span class="cx">
</span><del>- RefPtr<Text> text = Text::create(document, data.isNull() ? "" : data);
</del><ins>+ Ref<Text> text = Text::create(document, data.isNull() ? "" : data);
</ins><span class="cx">
</span><span class="cx"> ec = 0;
</span><del>- element->appendChild(text.release(), ec);
</del><ins>+ element->appendChild(WTF::move(text), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> if (!value.isNull())
</span><span class="cx"> element->setValue(value);
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> element->setAttribute(selectedAttr, emptyAtom);
</span><span class="cx"> element->setSelected(selected);
</span><span class="cx">
</span><del>- return element.release();
</del><ins>+ return element;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool HTMLOptionElement::isFocusable() const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLProgressElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLProgressElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLProgressElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLProgressElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -149,16 +149,16 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(!m_value);
</span><span class="cx">
</span><del>- RefPtr<ProgressInnerElement> inner = ProgressInnerElement::create(document());
- root->appendChild(inner);
</del><ins>+ Ref<ProgressInnerElement> inner = ProgressInnerElement::create(document());
+ root->appendChild(inner.copyRef());
</ins><span class="cx">
</span><del>- RefPtr<ProgressBarElement> bar = ProgressBarElement::create(document());
- RefPtr<ProgressValueElement> value = ProgressValueElement::create(document());
- m_value = value.get();
</del><ins>+ Ref<ProgressBarElement> bar = ProgressBarElement::create(document());
+ Ref<ProgressValueElement> value = ProgressValueElement::create(document());
+ m_value = value.ptr();
</ins><span class="cx"> m_value->setWidthPercentage(HTMLProgressElement::IndeterminatePosition * 100);
</span><del>- bar->appendChild(m_value, ASSERT_NO_EXCEPTION);
</del><ins>+ bar->appendChild(*m_value, ASSERT_NO_EXCEPTION);
</ins><span class="cx">
</span><del>- inner->appendChild(bar, ASSERT_NO_EXCEPTION);
</del><ins>+ inner->appendChild(WTF::move(bar), ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool HTMLProgressElement::shouldAppearIndeterminate() const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLScriptElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLScriptElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLScriptElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLScriptElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -169,9 +169,9 @@
</span><span class="cx"> dispatchEvent(Event::create(eventNames().loadEvent, false, false));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Element> HTMLScriptElement::cloneElementWithoutAttributesAndChildren(Document& targetDocument)
</del><ins>+Ref<Element> HTMLScriptElement::cloneElementWithoutAttributesAndChildren(Document& targetDocument)
</ins><span class="cx"> {
</span><del>- return adoptRef(new HTMLScriptElement(tagQName(), targetDocument, false, alreadyStarted()));
</del><ins>+ return adoptRef(*new HTMLScriptElement(tagQName(), targetDocument, false, alreadyStarted()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLScriptElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLScriptElement.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLScriptElement.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLScriptElement.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -65,7 +65,7 @@
</span><span class="cx">
</span><span class="cx"> virtual void dispatchLoadEvent() override;
</span><span class="cx">
</span><del>- virtual RefPtr<Element> cloneElementWithoutAttributesAndChildren(Document&) override;
</del><ins>+ virtual Ref<Element> cloneElementWithoutAttributesAndChildren(Document&) override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } //namespace
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -227,7 +227,7 @@
</span><span class="cx"> // Make sure the element is ref'd and deref'd so we don't leak it.
</span><span class="cx"> Ref<HTMLElement> protectNewChild(*element);
</span><span class="cx">
</span><del>- insertBefore(element, beforeElement, ec);
</del><ins>+ insertBefore(*element, beforeElement, ec);
</ins><span class="cx"> updateValidity();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -486,12 +486,12 @@
</span><span class="cx">
</span><span class="cx"> // Removing children fires mutation events, which might mutate the DOM further, so we first copy out a list
</span><span class="cx"> // of elements that we intend to remove then attempt to remove them one at a time.
</span><del>- Vector<RefPtr<Element>> itemsToRemove;
</del><ins>+ Vector<Ref<Element>> itemsToRemove;
</ins><span class="cx"> size_t optionIndex = 0;
</span><span class="cx"> for (auto& item : items) {
</span><span class="cx"> if (is<HTMLOptionElement>(*item) && optionIndex++ >= newLen) {
</span><span class="cx"> ASSERT(item->parentNode());
</span><del>- itemsToRemove.append(item);
</del><ins>+ itemsToRemove.append(*item);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLTableElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -81,7 +81,7 @@
</span><span class="cx"> {
</span><span class="cx"> deleteCaption();
</span><span class="cx"> if (newCaption)
</span><del>- insertBefore(newCaption, firstChild(), ec);
</del><ins>+ insertBefore(*newCaption, firstChild(), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> HTMLTableSectionElement* HTMLTableElement::tHead() const
</span><span class="lines">@@ -110,7 +110,7 @@
</span><span class="cx"> if (child->isElementNode() && !child->hasTagName(captionTag) && !child->hasTagName(colgroupTag))
</span><span class="cx"> break;
</span><span class="cx">
</span><del>- insertBefore(newHead, child, ec);
</del><ins>+ insertBefore(*newHead, child, ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> HTMLTableSectionElement* HTMLTableElement::tFoot() const
</span><span class="lines">@@ -139,57 +139,60 @@
</span><span class="cx"> if (child->isElementNode() && !child->hasTagName(captionTag) && !child->hasTagName(colgroupTag) && !child->hasTagName(theadTag))
</span><span class="cx"> break;
</span><span class="cx">
</span><del>- insertBefore(newFoot, child, ec);
</del><ins>+ insertBefore(*newFoot, child, ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLElement> HTMLTableElement::createTHead()
</del><ins>+Ref<HTMLTableSectionElement> HTMLTableElement::createTHead()
</ins><span class="cx"> {
</span><span class="cx"> if (HTMLTableSectionElement* existingHead = tHead())
</span><del>- return existingHead;
- RefPtr<HTMLTableSectionElement> head = HTMLTableSectionElement::create(theadTag, document());
- setTHead(head, IGNORE_EXCEPTION);
</del><ins>+ return *existingHead;
+ Ref<HTMLTableSectionElement> head = HTMLTableSectionElement::create(theadTag, document());
+ setTHead(head.ptr(), IGNORE_EXCEPTION);
</ins><span class="cx"> return head;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLTableElement::deleteTHead()
</span><span class="cx"> {
</span><del>- removeChild(tHead(), IGNORE_EXCEPTION);
</del><ins>+ if (auto* tHead = this->tHead())
+ removeChild(*tHead, IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLElement> HTMLTableElement::createTFoot()
</del><ins>+Ref<HTMLTableSectionElement> HTMLTableElement::createTFoot()
</ins><span class="cx"> {
</span><span class="cx"> if (HTMLTableSectionElement* existingFoot = tFoot())
</span><del>- return existingFoot;
- RefPtr<HTMLTableSectionElement> foot = HTMLTableSectionElement::create(tfootTag, document());
- setTFoot(foot, IGNORE_EXCEPTION);
</del><ins>+ return *existingFoot;
+ Ref<HTMLTableSectionElement> foot = HTMLTableSectionElement::create(tfootTag, document());
+ setTFoot(foot.ptr(), IGNORE_EXCEPTION);
</ins><span class="cx"> return foot;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLTableElement::deleteTFoot()
</span><span class="cx"> {
</span><del>- removeChild(tFoot(), IGNORE_EXCEPTION);
</del><ins>+ if (auto* tFoot = this->tFoot())
+ removeChild(*tFoot, IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLElement> HTMLTableElement::createTBody()
</del><ins>+Ref<HTMLTableSectionElement> HTMLTableElement::createTBody()
</ins><span class="cx"> {
</span><del>- RefPtr<HTMLTableSectionElement> body = HTMLTableSectionElement::create(tbodyTag, document());
- Node* referenceElement = lastBody() ? lastBody()->nextSibling() : 0;
- insertBefore(body, referenceElement, ASSERT_NO_EXCEPTION);
</del><ins>+ Ref<HTMLTableSectionElement> body = HTMLTableSectionElement::create(tbodyTag, document());
+ Node* referenceElement = lastBody() ? lastBody()->nextSibling() : nullptr;
+ insertBefore(body.copyRef(), referenceElement, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> return body;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLElement> HTMLTableElement::createCaption()
</del><ins>+Ref<HTMLTableCaptionElement> HTMLTableElement::createCaption()
</ins><span class="cx"> {
</span><span class="cx"> if (HTMLTableCaptionElement* existingCaption = caption())
</span><del>- return existingCaption;
- RefPtr<HTMLTableCaptionElement> caption = HTMLTableCaptionElement::create(captionTag, document());
- setCaption(caption, IGNORE_EXCEPTION);
</del><ins>+ return *existingCaption;
+ Ref<HTMLTableCaptionElement> caption = HTMLTableCaptionElement::create(captionTag, document());
+ setCaption(caption.ptr(), IGNORE_EXCEPTION);
</ins><span class="cx"> return caption;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLTableElement::deleteCaption()
</span><span class="cx"> {
</span><del>- removeChild(caption(), IGNORE_EXCEPTION);
</del><ins>+ if (auto* caption = this->caption())
+ removeChild(*caption, IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> HTMLTableSectionElement* HTMLTableElement::lastBody() const
</span><span class="lines">@@ -234,22 +237,22 @@
</span><span class="cx"> else {
</span><span class="cx"> parent = lastBody();
</span><span class="cx"> if (!parent) {
</span><del>- RefPtr<HTMLTableSectionElement> newBody = HTMLTableSectionElement::create(tbodyTag, document());
- RefPtr<HTMLTableRowElement> newRow = HTMLTableRowElement::create(document());
- newBody->appendChild(newRow, ec);
- appendChild(newBody.release(), ec);
- return newRow;
</del><ins>+ Ref<HTMLTableSectionElement> newBody = HTMLTableSectionElement::create(tbodyTag, document());
+ Ref<HTMLTableRowElement> newRow = HTMLTableRowElement::create(document());
+ newBody->appendChild(newRow.copyRef(), ec);
+ appendChild(WTF::move(newBody), ec);
+ return WTF::move(newRow);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- RefPtr<HTMLTableRowElement> newRow = HTMLTableRowElement::create(document());
- parent->insertBefore(newRow, row.get(), ec);
- return newRow;
</del><ins>+ Ref<HTMLTableRowElement> newRow = HTMLTableRowElement::create(document());
+ parent->insertBefore(newRow.copyRef(), row.get(), ec);
+ return WTF::move(newRow);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLTableElement::deleteRow(int index, ExceptionCode& ec)
</span><span class="cx"> {
</span><del>- HTMLTableRowElement* row = 0;
</del><ins>+ HTMLTableRowElement* row = nullptr;
</ins><span class="cx"> if (index == -1)
</span><span class="cx"> row = HTMLTableRowsCollection::lastRow(*this);
</span><span class="cx"> else {
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableElement.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableElement.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLTableElement.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -49,12 +49,12 @@
</span><span class="cx"> HTMLTableSectionElement* tFoot() const;
</span><span class="cx"> void setTFoot(PassRefPtr<HTMLTableSectionElement>, ExceptionCode&);
</span><span class="cx">
</span><del>- RefPtr<HTMLElement> createTHead();
</del><ins>+ Ref<HTMLTableSectionElement> createTHead();
</ins><span class="cx"> void deleteTHead();
</span><del>- RefPtr<HTMLElement> createTFoot();
</del><ins>+ Ref<HTMLTableSectionElement> createTFoot();
</ins><span class="cx"> void deleteTFoot();
</span><del>- RefPtr<HTMLElement> createTBody();
- RefPtr<HTMLElement> createCaption();
</del><ins>+ Ref<HTMLTableSectionElement> createTBody();
+ Ref<HTMLTableCaptionElement> createCaption();
</ins><span class="cx"> void deleteCaption();
</span><span class="cx"> RefPtr<HTMLElement> insertRow(ExceptionCode& ec) { return insertRow(-1, ec); }
</span><span class="cx"> RefPtr<HTMLElement> insertRow(int index, ExceptionCode&);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableRowElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableRowElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableRowElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLTableRowElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx"> #include "ExceptionCode.h"
</span><span class="cx"> #include "GenericCachedHTMLCollection.h"
</span><span class="cx"> #include "HTMLNames.h"
</span><del>-#include "HTMLTableCellElement.h"
</del><span class="cx"> #include "HTMLTableElement.h"
</span><span class="cx"> #include "HTMLTableSectionElement.h"
</span><span class="cx"> #include "NodeList.h"
</span><span class="lines">@@ -119,27 +118,27 @@
</span><span class="cx"> return rIndex;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLElement> HTMLTableRowElement::insertCell(int index, ExceptionCode& ec)
</del><ins>+RefPtr<HTMLTableCellElement> HTMLTableRowElement::insertCell(int index, ExceptionCode& ec)
</ins><span class="cx"> {
</span><span class="cx"> Ref<HTMLCollection> children = cells();
</span><span class="cx"> int numCells = children->length();
</span><span class="cx"> if (index < -1 || index > numCells) {
</span><span class="cx"> ec = INDEX_SIZE_ERR;
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- RefPtr<HTMLTableCellElement> cell = HTMLTableCellElement::create(tdTag, document());
</del><ins>+ Ref<HTMLTableCellElement> cell = HTMLTableCellElement::create(tdTag, document());
</ins><span class="cx"> if (index < 0 || index >= numCells)
</span><del>- appendChild(cell, ec);
</del><ins>+ appendChild(cell.copyRef(), ec);
</ins><span class="cx"> else {
</span><span class="cx"> Node* n;
</span><span class="cx"> if (index < 1)
</span><span class="cx"> n = firstChild();
</span><span class="cx"> else
</span><span class="cx"> n = children->item(index);
</span><del>- insertBefore(cell, n, ec);
</del><ins>+ insertBefore(cell.copyRef(), n, ec);
</ins><span class="cx"> }
</span><del>- return cell;
</del><ins>+ return WTF::move(cell);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLTableRowElement::deleteCell(int index, ExceptionCode& ec)
</span><span class="lines">@@ -150,7 +149,7 @@
</span><span class="cx"> index = numCells-1;
</span><span class="cx"> if (index >= 0 && index < numCells) {
</span><span class="cx"> RefPtr<Node> cell = children->item(index);
</span><del>- HTMLElement::removeChild(cell.get(), ec);
</del><ins>+ HTMLElement::removeChild(*cell, ec);
</ins><span class="cx"> } else
</span><span class="cx"> ec = INDEX_SIZE_ERR;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableRowElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableRowElement.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableRowElement.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLTableRowElement.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -26,6 +26,7 @@
</span><span class="cx"> #ifndef HTMLTableRowElement_h
</span><span class="cx"> #define HTMLTableRowElement_h
</span><span class="cx">
</span><ins>+#include "HTMLTableCellElement.h"
</ins><span class="cx"> #include "HTMLTablePartElement.h"
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="lines">@@ -41,8 +42,8 @@
</span><span class="cx"> int sectionRowIndex() const;
</span><span class="cx"> void setSectionRowIndex(int);
</span><span class="cx">
</span><del>- RefPtr<HTMLElement> insertCell(ExceptionCode& ec) { return insertCell(-1, ec); }
- RefPtr<HTMLElement> insertCell(int index, ExceptionCode&);
</del><ins>+ RefPtr<HTMLTableCellElement> insertCell(ExceptionCode& ec) { return insertCell(-1, ec); }
+ RefPtr<HTMLTableCellElement> insertCell(int index, ExceptionCode&);
</ins><span class="cx"> void deleteCell(int index, ExceptionCode&);
</span><span class="cx">
</span><span class="cx"> Ref<HTMLCollection> cells();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableSectionElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableSectionElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableSectionElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLTableSectionElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -68,14 +68,14 @@
</span><span class="cx"> else {
</span><span class="cx"> row = HTMLTableRowElement::create(trTag, document());
</span><span class="cx"> if (numRows == index || index == -1)
</span><del>- appendChild(row, ec);
</del><ins>+ appendChild(*row, ec);
</ins><span class="cx"> else {
</span><span class="cx"> Node* n;
</span><span class="cx"> if (index < 1)
</span><span class="cx"> n = firstChild();
</span><span class="cx"> else
</span><span class="cx"> n = children->item(index);
</span><del>- insertBefore(row, n, ec);
</del><ins>+ insertBefore(*row, n, ec);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> return row;
</span><span class="lines">@@ -89,7 +89,7 @@
</span><span class="cx"> index = numRows - 1;
</span><span class="cx"> if (index >= 0 && index < numRows) {
</span><span class="cx"> RefPtr<Node> row = children->item(index);
</span><del>- HTMLElement::removeChild(row.get(), ec);
</del><ins>+ HTMLElement::removeChild(*row, ec);
</ins><span class="cx"> } else
</span><span class="cx"> ec = INDEX_SIZE_ERR;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTemplateElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTemplateElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTemplateElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLTemplateElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -68,7 +68,7 @@
</span><span class="cx"> return m_content.get();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Node> HTMLTemplateElement::cloneNodeInternal(Document& targetDocument, CloningOperation type)
</del><ins>+Ref<Node> HTMLTemplateElement::cloneNodeInternal(Document& targetDocument, CloningOperation type)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<Node> clone;
</span><span class="cx"> switch (type) {
</span><span class="lines">@@ -82,8 +82,8 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> if (m_content)
</span><del>- content()->cloneChildNodes(downcast<HTMLTemplateElement>(clone.get())->content());
- return clone.release();
</del><ins>+ content()->cloneChildNodes(*downcast<HTMLTemplateElement>(clone.get())->content());
+ return clone.releaseNonNull();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLTemplateElement::didMoveToNewDocument(Document* oldDocument)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTemplateElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTemplateElement.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTemplateElement.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLTemplateElement.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> private:
</span><span class="cx"> HTMLTemplateElement(const QualifiedName&, Document&);
</span><span class="cx">
</span><del>- virtual RefPtr<Node> cloneNodeInternal(Document&, CloningOperation) override;
</del><ins>+ virtual Ref<Node> cloneNodeInternal(Document&, CloningOperation) override;
</ins><span class="cx"> virtual void didMoveToNewDocument(Document* oldDocument) override;
</span><span class="cx">
</span><span class="cx"> mutable RefPtr<TemplateContentDocumentFragment> m_content;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTextAreaElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTextAreaElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTextAreaElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/HTMLTextAreaElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -406,9 +406,9 @@
</span><span class="cx"> Ref<HTMLTextAreaElement> protectFromMutationEvents(*this);
</span><span class="cx">
</span><span class="cx"> // To preserve comments, remove only the text nodes, then add a single text node.
</span><del>- Vector<RefPtr<Text>> textNodes;
</del><ins>+ Vector<Ref<Text>> textNodes;
</ins><span class="cx"> for (Text* textNode = TextNodeTraversal::firstChild(*this); textNode; textNode = TextNodeTraversal::nextSibling(*textNode))
</span><del>- textNodes.append(textNode);
</del><ins>+ textNodes.append(*textNode);
</ins><span class="cx">
</span><span class="cx"> size_t size = textNodes.size();
</span><span class="cx"> for (size_t i = 0; i < size; ++i)
</span><span class="lines">@@ -523,8 +523,8 @@
</span><span class="cx"> String placeholderText = strippedPlaceholder();
</span><span class="cx"> if (placeholderText.isEmpty()) {
</span><span class="cx"> if (m_placeholder) {
</span><del>- userAgentShadowRoot()->removeChild(m_placeholder, ASSERT_NO_EXCEPTION);
- m_placeholder = 0;
</del><ins>+ userAgentShadowRoot()->removeChild(*m_placeholder, ASSERT_NO_EXCEPTION);
+ m_placeholder = nullptr;
</ins><span class="cx"> }
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -533,7 +533,7 @@
</span><span class="cx"> m_placeholder = placeholder.get();
</span><span class="cx"> m_placeholder->setPseudo(AtomicString("-webkit-input-placeholder", AtomicString::ConstructFromLiteral));
</span><span class="cx"> m_placeholder->setInlineStyleProperty(CSSPropertyDisplay, isPlaceholderVisible() ? CSSValueBlock : CSSValueNone, true);
</span><del>- userAgentShadowRoot()->insertBefore(m_placeholder, innerTextElement()->nextSibling());
</del><ins>+ userAgentShadowRoot()->insertBefore(*m_placeholder, innerTextElement()->nextSibling());
</ins><span class="cx"> }
</span><span class="cx"> m_placeholder->setInnerText(placeholderText, ASSERT_NO_EXCEPTION);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlImageDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ImageDocument.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ImageDocument.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/ImageDocument.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -92,7 +92,7 @@
</span><span class="cx">
</span><span class="cx"> class ImageDocumentElement final : public HTMLImageElement {
</span><span class="cx"> public:
</span><del>- static RefPtr<ImageDocumentElement> create(ImageDocument&);
</del><ins>+ static Ref<ImageDocumentElement> create(ImageDocument&);
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> ImageDocumentElement(ImageDocument& document)
</span><span class="lines">@@ -107,9 +107,9 @@
</span><span class="cx"> ImageDocument* m_imageDocument;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-inline RefPtr<ImageDocumentElement> ImageDocumentElement::create(ImageDocument& document)
</del><ins>+inline Ref<ImageDocumentElement> ImageDocumentElement::create(ImageDocument& document)
</ins><span class="cx"> {
</span><del>- return adoptRef(new ImageDocumentElement(document));
</del><ins>+ return adoptRef(*new ImageDocumentElement(document));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // --------
</span><span class="lines">@@ -210,19 +210,19 @@
</span><span class="cx">
</span><span class="cx"> void ImageDocument::createDocumentStructure()
</span><span class="cx"> {
</span><del>- RefPtr<Element> rootElement = Document::createElement(htmlTag, false);
- appendChild(rootElement);
- downcast<HTMLHtmlElement>(*rootElement).insertedByParser();
</del><ins>+ Ref<Element> rootElement = Document::createElement(htmlTag, false);
+ appendChild(rootElement.copyRef());
+ downcast<HTMLHtmlElement>(rootElement.get()).insertedByParser();
</ins><span class="cx">
</span><span class="cx"> frame()->injectUserScripts(InjectAtDocumentStart);
</span><span class="cx">
</span><del>- RefPtr<Element> body = Document::createElement(bodyTag, false);
</del><ins>+ Ref<Element> body = Document::createElement(bodyTag, false);
</ins><span class="cx"> body->setAttribute(styleAttr, "margin: 0px");
</span><span class="cx"> if (MIMETypeRegistry::isPDFMIMEType(document().loader()->responseMIMEType()))
</span><del>- downcast<HTMLBodyElement>(*body).setInlineStyleProperty(CSSPropertyBackgroundColor, "white", CSSPrimitiveValue::CSS_IDENT);
- rootElement->appendChild(body);
</del><ins>+ downcast<HTMLBodyElement>(body.get()).setInlineStyleProperty(CSSPropertyBackgroundColor, "white", CSSPrimitiveValue::CSS_IDENT);
+ rootElement->appendChild(body.copyRef());
</ins><span class="cx">
</span><del>- RefPtr<ImageDocumentElement> imageElement = ImageDocumentElement::create(*this);
</del><ins>+ Ref<ImageDocumentElement> imageElement = ImageDocumentElement::create(*this);
</ins><span class="cx"> if (m_shouldShrinkImage)
</span><span class="cx"> imageElement->setAttribute(styleAttr, "-webkit-user-select:none; display:block; margin:auto;");
</span><span class="cx"> else
</span><span class="lines">@@ -230,7 +230,7 @@
</span><span class="cx"> imageElement->setLoadManually(true);
</span><span class="cx"> imageElement->setSrc(url().string());
</span><span class="cx"> imageElement->cachedImage()->setResponse(loader()->response());
</span><del>- body->appendChild(imageElement);
</del><ins>+ body->appendChild(imageElement.copyRef());
</ins><span class="cx">
</span><span class="cx"> if (m_shouldShrinkImage) {
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="lines">@@ -244,7 +244,7 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><del>- m_imageElement = imageElement.get();
</del><ins>+ m_imageElement = imageElement.ptr();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ImageDocument::imageUpdated()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlMediaDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/MediaDocument.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/MediaDocument.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/MediaDocument.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -78,30 +78,30 @@
</span><span class="cx">
</span><span class="cx"> void MediaDocumentParser::createDocumentStructure()
</span><span class="cx"> {
</span><del>- RefPtr<Element> rootElement = document()->createElement(htmlTag, false);
- document()->appendChild(rootElement, IGNORE_EXCEPTION);
- document()->setCSSTarget(rootElement.get());
- downcast<HTMLHtmlElement>(*rootElement).insertedByParser();
</del><ins>+ Ref<Element> rootElement = document()->createElement(htmlTag, false);
+ document()->appendChild(rootElement.copyRef(), IGNORE_EXCEPTION);
+ document()->setCSSTarget(rootElement.ptr());
+ downcast<HTMLHtmlElement>(rootElement.get()).insertedByParser();
</ins><span class="cx">
</span><span class="cx"> if (document()->frame())
</span><span class="cx"> document()->frame()->injectUserScripts(InjectAtDocumentStart);
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span><del>- RefPtr<Element> headElement = document()->createElement(headTag, false);
- rootElement->appendChild(headElement, IGNORE_EXCEPTION);
</del><ins>+ Ref<Element> headElement = document()->createElement(headTag, false);
+ rootElement->appendChild(headElement.copyRef(), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><del>- RefPtr<Element> metaElement = document()->createElement(metaTag, false);
</del><ins>+ Ref<Element> metaElement = document()->createElement(metaTag, false);
</ins><span class="cx"> metaElement->setAttribute(nameAttr, "viewport");
</span><span class="cx"> metaElement->setAttribute(contentAttr, "width=device-width,initial-scale=1,user-scalable=no");
</span><del>- headElement->appendChild(metaElement, IGNORE_EXCEPTION);
</del><ins>+ headElement->appendChild(WTF::move(metaElement), IGNORE_EXCEPTION);
</ins><span class="cx"> #endif
</span><span class="cx">
</span><del>- RefPtr<Element> body = document()->createElement(bodyTag, false);
- rootElement->appendChild(body, IGNORE_EXCEPTION);
</del><ins>+ Ref<Element> body = document()->createElement(bodyTag, false);
+ rootElement->appendChild(body.copyRef(), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><del>- RefPtr<Element> mediaElement = document()->createElement(videoTag, false);
</del><ins>+ Ref<Element> mediaElement = document()->createElement(videoTag, false);
</ins><span class="cx">
</span><del>- m_mediaElement = downcast<HTMLVideoElement>(mediaElement.get());
</del><ins>+ m_mediaElement = downcast<HTMLVideoElement>(mediaElement.ptr());
</ins><span class="cx"> m_mediaElement->setAttribute(controlsAttr, emptyAtom);
</span><span class="cx"> m_mediaElement->setAttribute(autoplayAttr, emptyAtom);
</span><span class="cx">
</span><span class="lines">@@ -114,15 +114,15 @@
</span><span class="cx"> #endif
</span><span class="cx"> m_mediaElement->setAttribute(styleAttr, elementStyle.toString());
</span><span class="cx">
</span><del>- RefPtr<Element> sourceElement = document()->createElement(sourceTag, false);
- HTMLSourceElement& source = downcast<HTMLSourceElement>(*sourceElement);
</del><ins>+ Ref<Element> sourceElement = document()->createElement(sourceTag, false);
+ HTMLSourceElement& source = downcast<HTMLSourceElement>(sourceElement.get());
</ins><span class="cx"> source.setSrc(document()->url());
</span><span class="cx">
</span><span class="cx"> if (DocumentLoader* loader = document()->loader())
</span><span class="cx"> source.setType(loader->responseMIMEType());
</span><span class="cx">
</span><del>- m_mediaElement->appendChild(sourceElement, IGNORE_EXCEPTION);
- body->appendChild(mediaElement, IGNORE_EXCEPTION);
</del><ins>+ m_mediaElement->appendChild(WTF::move(sourceElement), IGNORE_EXCEPTION);
+ body->appendChild(WTF::move(mediaElement), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> Frame* frame = document()->frame();
</span><span class="cx"> if (!frame)
</span><span class="lines">@@ -253,7 +253,7 @@
</span><span class="cx"> if (documentLoader)
</span><span class="cx"> embedElement.setAttribute(typeAttr, documentLoader->writer().mimeType());
</span><span class="cx">
</span><del>- videoElement->parentNode()->replaceChild(&embedElement, videoElement, IGNORE_EXCEPTION);
</del><ins>+ videoElement->parentNode()->replaceChild(embedElement, *videoElement, IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlPluginDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/PluginDocument.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/PluginDocument.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/PluginDocument.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -67,9 +67,9 @@
</span><span class="cx">
</span><span class="cx"> void PluginDocumentParser::createDocumentStructure()
</span><span class="cx"> {
</span><del>- RefPtr<Element> rootElement = document()->createElement(htmlTag, false);
- document()->appendChild(rootElement, IGNORE_EXCEPTION);
- downcast<HTMLHtmlElement>(*rootElement).insertedByParser();
</del><ins>+ Ref<Element> rootElement = document()->createElement(htmlTag, false);
+ document()->appendChild(rootElement.copyRef(), IGNORE_EXCEPTION);
+ downcast<HTMLHtmlElement>(rootElement.get()).insertedByParser();
</ins><span class="cx">
</span><span class="cx"> if (document()->frame())
</span><span class="cx"> document()->frame()->injectUserScripts(InjectAtDocumentStart);
</span><span class="lines">@@ -79,7 +79,7 @@
</span><span class="cx"> document()->processViewport(ASCIILiteral("user-scalable=no"), ViewportArguments::PluginDocument);
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- RefPtr<Element> body = document()->createElement(bodyTag, false);
</del><ins>+ Ref<Element> body = document()->createElement(bodyTag, false);
</ins><span class="cx"> body->setAttribute(marginwidthAttr, AtomicString("0", AtomicString::ConstructFromLiteral));
</span><span class="cx"> body->setAttribute(marginheightAttr, AtomicString("0", AtomicString::ConstructFromLiteral));
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="lines">@@ -88,11 +88,11 @@
</span><span class="cx"> body->setAttribute(styleAttr, AtomicString("background-color: rgb(38,38,38)", AtomicString::ConstructFromLiteral));
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- rootElement->appendChild(body, IGNORE_EXCEPTION);
</del><ins>+ rootElement->appendChild(body.copyRef(), IGNORE_EXCEPTION);
</ins><span class="cx">
</span><del>- RefPtr<Element> embedElement = document()->createElement(embedTag, false);
</del><ins>+ Ref<Element> embedElement = document()->createElement(embedTag, false);
</ins><span class="cx">
</span><del>- m_embedElement = downcast<HTMLEmbedElement>(embedElement.get());
</del><ins>+ m_embedElement = downcast<HTMLEmbedElement>(embedElement.ptr());
</ins><span class="cx"> m_embedElement->setAttribute(widthAttr, "100%");
</span><span class="cx"> m_embedElement->setAttribute(heightAttr, "100%");
</span><span class="cx">
</span><span class="lines">@@ -106,7 +106,7 @@
</span><span class="cx">
</span><span class="cx"> downcast<PluginDocument>(*document()).setPluginElement(m_embedElement);
</span><span class="cx">
</span><del>- body->appendChild(embedElement, IGNORE_EXCEPTION);
</del><ins>+ body->appendChild(WTF::move(embedElement), IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void PluginDocumentParser::appendBytes(DocumentWriter&, const char*, size_t)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlRangeInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/RangeInputType.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/RangeInputType.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/RangeInputType.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -253,12 +253,12 @@
</span><span class="cx"> ASSERT(element().userAgentShadowRoot());
</span><span class="cx">
</span><span class="cx"> Document& document = element().document();
</span><del>- RefPtr<HTMLDivElement> track = HTMLDivElement::create(document);
</del><ins>+ Ref<HTMLDivElement> track = HTMLDivElement::create(document);
</ins><span class="cx"> track->setPseudo(AtomicString("-webkit-slider-runnable-track", AtomicString::ConstructFromLiteral));
</span><span class="cx"> track->appendChild(SliderThumbElement::create(document), IGNORE_EXCEPTION);
</span><del>- RefPtr<HTMLElement> container = SliderContainerElement::create(document);
- container->appendChild(track.release(), IGNORE_EXCEPTION);
- element().userAgentShadowRoot()->appendChild(container.release(), IGNORE_EXCEPTION);
</del><ins>+ Ref<HTMLElement> container = SliderContainerElement::create(document);
+ container->appendChild(WTF::move(track), IGNORE_EXCEPTION);
+ element().userAgentShadowRoot()->appendChild(WTF::move(container), IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> HTMLElement* RangeInputType::sliderTrackElement() const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlSearchInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/SearchInputType.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/SearchInputType.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/SearchInputType.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -107,14 +107,14 @@
</span><span class="cx"> ASSERT(container);
</span><span class="cx"> ASSERT(textWrapper);
</span><span class="cx">
</span><del>- RefPtr<SearchFieldResultsButtonElement> resultsButton = SearchFieldResultsButtonElement::create(element().document());
- m_resultsButton = resultsButton.get();
- updateResultButtonPseudoType(*m_resultsButton, element().maxResults());
- container->insertBefore(m_resultsButton, textWrapper, IGNORE_EXCEPTION);
</del><ins>+ Ref<SearchFieldResultsButtonElement> resultsButton = SearchFieldResultsButtonElement::create(element().document());
+ m_resultsButton = resultsButton.ptr();
+ updateResultButtonPseudoType(resultsButton.get(), element().maxResults());
+ container->insertBefore(WTF::move(resultsButton), textWrapper, IGNORE_EXCEPTION);
</ins><span class="cx">
</span><del>- RefPtr<SearchFieldCancelButtonElement> cancelButton = SearchFieldCancelButtonElement::create(element().document());
- m_cancelButton = cancelButton.get();
- container->insertBefore(m_cancelButton, textWrapper->nextSibling(), IGNORE_EXCEPTION);
</del><ins>+ Ref<SearchFieldCancelButtonElement> cancelButton = SearchFieldCancelButtonElement::create(element().document());
+ m_cancelButton = cancelButton.ptr();
+ container->insertBefore(WTF::move(cancelButton), textWrapper->nextSibling(), IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> HTMLElement* SearchInputType::resultsButtonElement() const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlTextFieldInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/TextFieldInputType.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/TextFieldInputType.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/TextFieldInputType.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -274,7 +274,7 @@
</span><span class="cx"> m_innerText = TextControlInnerTextElement::create(document);
</span><span class="cx">
</span><span class="cx"> if (!createsContainer) {
</span><del>- element().userAgentShadowRoot()->appendChild(m_innerText, IGNORE_EXCEPTION);
</del><ins>+ element().userAgentShadowRoot()->appendChild(*m_innerText, IGNORE_EXCEPTION);
</ins><span class="cx"> updatePlaceholderText();
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -284,7 +284,7 @@
</span><span class="cx">
</span><span class="cx"> if (shouldHaveSpinButton) {
</span><span class="cx"> m_innerSpinButton = SpinButtonElement::create(document, *this);
</span><del>- m_container->appendChild(m_innerSpinButton, IGNORE_EXCEPTION);
</del><ins>+ m_container->appendChild(*m_innerSpinButton, IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (shouldHaveCapsLockIndicator) {
</span><span class="lines">@@ -294,7 +294,7 @@
</span><span class="cx"> bool shouldDrawCapsLockIndicator = this->shouldDrawCapsLockIndicator();
</span><span class="cx"> m_capsLockIndicator->setInlineStyleProperty(CSSPropertyDisplay, shouldDrawCapsLockIndicator ? CSSValueBlock : CSSValueNone, true);
</span><span class="cx">
</span><del>- m_container->appendChild(m_capsLockIndicator, IGNORE_EXCEPTION);
</del><ins>+ m_container->appendChild(*m_capsLockIndicator, IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> updateAutoFillButton();
</span><span class="lines">@@ -461,7 +461,7 @@
</span><span class="cx"> String placeholderText = element().strippedPlaceholder();
</span><span class="cx"> if (placeholderText.isEmpty()) {
</span><span class="cx"> if (m_placeholder) {
</span><del>- m_placeholder->parentNode()->removeChild(m_placeholder.get(), ASSERT_NO_EXCEPTION);
</del><ins>+ m_placeholder->parentNode()->removeChild(*m_placeholder, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> m_placeholder = nullptr;
</span><span class="cx"> }
</span><span class="cx"> return;
</span><span class="lines">@@ -470,7 +470,7 @@
</span><span class="cx"> m_placeholder = HTMLDivElement::create(element().document());
</span><span class="cx"> m_placeholder->setPseudo(AtomicString("-webkit-input-placeholder", AtomicString::ConstructFromLiteral));
</span><span class="cx"> m_placeholder->setInlineStyleProperty(CSSPropertyDisplay, element().isPlaceholderVisible() ? CSSValueBlock : CSSValueNone, true);
</span><del>- element().userAgentShadowRoot()->insertBefore(m_placeholder, m_container ? m_container.get() : innerTextElement(), ASSERT_NO_EXCEPTION);
</del><ins>+ element().userAgentShadowRoot()->insertBefore(*m_placeholder, m_container ? m_container.get() : innerTextElement(), ASSERT_NO_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> }
</span><span class="cx"> m_placeholder->setInnerText(placeholderText, ASSERT_NO_EXCEPTION);
</span><span class="lines">@@ -600,10 +600,10 @@
</span><span class="cx"> m_container->setPseudo(AtomicString("-webkit-textfield-decoration-container", AtomicString::ConstructFromLiteral));
</span><span class="cx">
</span><span class="cx"> m_innerBlock = TextControlInnerElement::create(element().document());
</span><del>- m_innerBlock->appendChild(m_innerText, IGNORE_EXCEPTION);
- m_container->appendChild(m_innerBlock, IGNORE_EXCEPTION);
</del><ins>+ m_innerBlock->appendChild(*m_innerText, IGNORE_EXCEPTION);
+ m_container->appendChild(*m_innerBlock, IGNORE_EXCEPTION);
</ins><span class="cx">
</span><del>- element().userAgentShadowRoot()->appendChild(m_container, IGNORE_EXCEPTION);
</del><ins>+ element().userAgentShadowRoot()->appendChild(*m_container, IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void TextFieldInputType::createAutoFillButton()
</span><span class="lines">@@ -612,7 +612,7 @@
</span><span class="cx">
</span><span class="cx"> m_autoFillButton = AutoFillButtonElement::create(element().document(), *this);
</span><span class="cx"> m_autoFillButton->setPseudo(AtomicString("-webkit-auto-fill-button", AtomicString::ConstructFromLiteral));
</span><del>- m_container->appendChild(m_autoFillButton, IGNORE_EXCEPTION);
</del><ins>+ m_container->appendChild(*m_autoFillButton, IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void TextFieldInputType::updateAutoFillButton()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlValidationMessagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ValidationMessage.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ValidationMessage.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/ValidationMessage.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -180,32 +180,32 @@
</span><span class="cx"> // Need to force position:absolute because RenderMenuList doesn't assume it
</span><span class="cx"> // contains non-absolute or non-fixed renderers as children.
</span><span class="cx"> m_bubble->setInlineStyleProperty(CSSPropertyPosition, CSSValueAbsolute);
</span><del>- shadowRoot.appendChild(m_bubble.get(), ASSERT_NO_EXCEPTION);
</del><ins>+ shadowRoot.appendChild(*m_bubble, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> document.updateLayout();
</span><span class="cx"> adjustBubblePosition(m_element->renderer()->absoluteBoundingBoxRect(), m_bubble.get());
</span><span class="cx">
</span><del>- RefPtr<HTMLDivElement> clipper = HTMLDivElement::create(document);
</del><ins>+ Ref<HTMLDivElement> clipper = HTMLDivElement::create(document);
</ins><span class="cx"> clipper->setPseudo(AtomicString("-webkit-validation-bubble-arrow-clipper", AtomicString::ConstructFromLiteral));
</span><del>- RefPtr<HTMLDivElement> bubbleArrow = HTMLDivElement::create(document);
</del><ins>+ Ref<HTMLDivElement> bubbleArrow = HTMLDivElement::create(document);
</ins><span class="cx"> bubbleArrow->setPseudo(AtomicString("-webkit-validation-bubble-arrow", AtomicString::ConstructFromLiteral));
</span><del>- clipper->appendChild(bubbleArrow.release(), ASSERT_NO_EXCEPTION);
- m_bubble->appendChild(clipper.release(), ASSERT_NO_EXCEPTION);
</del><ins>+ clipper->appendChild(WTF::move(bubbleArrow), ASSERT_NO_EXCEPTION);
+ m_bubble->appendChild(WTF::move(clipper), ASSERT_NO_EXCEPTION);
</ins><span class="cx">
</span><del>- RefPtr<HTMLElement> message = HTMLDivElement::create(document);
</del><ins>+ Ref<HTMLElement> message = HTMLDivElement::create(document);
</ins><span class="cx"> message->setPseudo(AtomicString("-webkit-validation-bubble-message", AtomicString::ConstructFromLiteral));
</span><del>- RefPtr<HTMLElement> icon = HTMLDivElement::create(document);
</del><ins>+ Ref<HTMLElement> icon = HTMLDivElement::create(document);
</ins><span class="cx"> icon->setPseudo(AtomicString("-webkit-validation-bubble-icon", AtomicString::ConstructFromLiteral));
</span><del>- message->appendChild(icon.release(), ASSERT_NO_EXCEPTION);
- RefPtr<HTMLElement> textBlock = HTMLDivElement::create(document);
</del><ins>+ message->appendChild(WTF::move(icon), ASSERT_NO_EXCEPTION);
+ Ref<HTMLElement> textBlock = HTMLDivElement::create(document);
</ins><span class="cx"> textBlock->setPseudo(AtomicString("-webkit-validation-bubble-text-block", AtomicString::ConstructFromLiteral));
</span><span class="cx"> m_messageHeading = HTMLDivElement::create(document);
</span><span class="cx"> m_messageHeading->setPseudo(AtomicString("-webkit-validation-bubble-heading", AtomicString::ConstructFromLiteral));
</span><del>- textBlock->appendChild(m_messageHeading, ASSERT_NO_EXCEPTION);
</del><ins>+ textBlock->appendChild(*m_messageHeading, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> m_messageBody = HTMLDivElement::create(document);
</span><span class="cx"> m_messageBody->setPseudo(AtomicString("-webkit-validation-bubble-body", AtomicString::ConstructFromLiteral));
</span><del>- textBlock->appendChild(m_messageBody, ASSERT_NO_EXCEPTION);
- message->appendChild(textBlock.release(), ASSERT_NO_EXCEPTION);
- m_bubble->appendChild(message.release(), ASSERT_NO_EXCEPTION);
</del><ins>+ textBlock->appendChild(*m_messageBody, ASSERT_NO_EXCEPTION);
+ message->appendChild(WTF::move(textBlock), ASSERT_NO_EXCEPTION);
+ m_bubble->appendChild(WTF::move(message), ASSERT_NO_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> setMessageDOMAndStartTimer();
</span><span class="cx">
</span><span class="lines">@@ -237,7 +237,7 @@
</span><span class="cx"> if (m_bubble) {
</span><span class="cx"> m_messageHeading = nullptr;
</span><span class="cx"> m_messageBody = nullptr;
</span><del>- m_element->userAgentShadowRoot()->removeChild(m_bubble.get(), ASSERT_NO_EXCEPTION);
</del><ins>+ m_element->userAgentShadowRoot()->removeChild(*m_bubble, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> m_bubble = nullptr;
</span><span class="cx"> }
</span><span class="cx"> m_message = String();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowMediaControlElementscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/MediaControlElements.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/MediaControlElements.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/shadow/MediaControlElements.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -807,21 +807,21 @@
</span><span class="cx"> CaptionUserPreferences* captionPreferences = document().page()->group().captionPreferences();
</span><span class="cx"> Vector<RefPtr<TextTrack>> tracksForMenu = captionPreferences->sortedTrackListForMenu(trackList);
</span><span class="cx">
</span><del>- RefPtr<Element> captionsHeader = document().createElement(h3Tag, ASSERT_NO_EXCEPTION);
</del><ins>+ Ref<Element> captionsHeader = document().createElement(h3Tag, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> captionsHeader->appendChild(document().createTextNode(textTrackSubtitlesText()));
</span><del>- appendChild(captionsHeader);
- RefPtr<Element> captionsMenuList = document().createElement(ulTag, ASSERT_NO_EXCEPTION);
</del><ins>+ appendChild(WTF::move(captionsHeader));
+ Ref<Element> captionsMenuList = document().createElement(ulTag, ASSERT_NO_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> for (unsigned i = 0, length = tracksForMenu.size(); i < length; ++i) {
</span><span class="cx"> RefPtr<TextTrack> textTrack = tracksForMenu[i];
</span><del>- RefPtr<Element> menuItem = document().createElement(liTag, ASSERT_NO_EXCEPTION);
</del><ins>+ Ref<Element> menuItem = document().createElement(liTag, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> menuItem->appendChild(document().createTextNode(captionPreferences->displayNameForTrack(textTrack.get())));
</span><del>- captionsMenuList->appendChild(menuItem);
- m_menuItems.append(menuItem);
- m_menuToTrackMap.add(menuItem, textTrack);
</del><ins>+ captionsMenuList->appendChild(menuItem.copyRef());
+ m_menuItems.append(menuItem.ptr());
+ m_menuToTrackMap.add(menuItem.ptr(), textTrack);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- appendChild(captionsMenuList);
</del><ins>+ appendChild(WTF::move(captionsMenuList));
</ins><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1186,16 +1186,16 @@
</span><span class="cx"> // track cue region identifier, run the following substeps:
</span><span class="cx"> if (displayBox->hasChildNodes() && !contains(displayBox.get())) {
</span><span class="cx"> // Note: the display tree of a cue is removed when the active flag of the cue is unset.
</span><del>- appendChild(displayBox, ASSERT_NO_EXCEPTION);
</del><ins>+ appendChild(*displayBox, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> cue->setFontSize(m_fontSize, m_videoDisplaySize.size(), m_fontSizeIsImportant);
</span><span class="cx"> }
</span><span class="cx"> } else {
</span><span class="cx"> // Let region be the WebVTT region whose region identifier
</span><span class="cx"> // matches the text track cue region identifier of cue.
</span><del>- RefPtr<HTMLDivElement> regionNode = region->getDisplayTree();
</del><ins>+ Ref<HTMLDivElement> regionNode = region->getDisplayTree();
</ins><span class="cx">
</span><span class="cx"> // Append the region to the viewport, if it was not already.
</span><del>- if (!contains(regionNode.get()))
</del><ins>+ if (!contains(regionNode.ptr()))
</ins><span class="cx"> appendChild(region->getDisplayTree());
</span><span class="cx">
</span><span class="cx"> region->appendTextTrackCueBox(displayBox);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowMediaControlscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/MediaControls.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/MediaControls.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/shadow/MediaControls.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -380,14 +380,14 @@
</span><span class="cx"> if (m_textDisplayContainer)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- RefPtr<MediaControlTextTrackContainerElement> textDisplayContainer = MediaControlTextTrackContainerElement::create(document());
- m_textDisplayContainer = textDisplayContainer.get();
</del><ins>+ Ref<MediaControlTextTrackContainerElement> textDisplayContainer = MediaControlTextTrackContainerElement::create(document());
+ m_textDisplayContainer = textDisplayContainer.ptr();
</ins><span class="cx">
</span><span class="cx"> if (m_mediaController)
</span><span class="cx"> m_textDisplayContainer->setMediaController(m_mediaController);
</span><span class="cx">
</span><span class="cx"> // Insert it before the first controller element so it always displays behind the controls.
</span><del>- insertBefore(textDisplayContainer.release(), m_panel, IGNORE_EXCEPTION);
</del><ins>+ insertBefore(WTF::move(textDisplayContainer), m_panel, IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void MediaControls::showTextTrackDisplay()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowMediaControlsApplecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/MediaControlsApple.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/MediaControlsApple.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/shadow/MediaControlsApple.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -63,165 +63,165 @@
</span><span class="cx"> PassRefPtr<MediaControlsApple> MediaControlsApple::createControls(Document& document)
</span><span class="cx"> {
</span><span class="cx"> if (!document.page())
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> RefPtr<MediaControlsApple> controls = adoptRef(new MediaControlsApple(document));
</span><span class="cx">
</span><del>- RefPtr<MediaControlPanelElement> panel = MediaControlPanelElement::create(document);
</del><ins>+ Ref<MediaControlPanelElement> panel = MediaControlPanelElement::create(document);
</ins><span class="cx">
</span><span class="cx"> ExceptionCode ec;
</span><span class="cx">
</span><del>- RefPtr<MediaControlRewindButtonElement> rewindButton = MediaControlRewindButtonElement::create(document);
- controls->m_rewindButton = rewindButton.get();
- panel->appendChild(rewindButton.release(), ec);
</del><ins>+ Ref<MediaControlRewindButtonElement> rewindButton = MediaControlRewindButtonElement::create(document);
+ controls->m_rewindButton = rewindButton.ptr();
+ panel->appendChild(WTF::move(rewindButton), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- RefPtr<MediaControlPlayButtonElement> playButton = MediaControlPlayButtonElement::create(document);
- controls->m_playButton = playButton.get();
- panel->appendChild(playButton.release(), ec);
</del><ins>+ Ref<MediaControlPlayButtonElement> playButton = MediaControlPlayButtonElement::create(document);
+ controls->m_playButton = playButton.ptr();
+ panel->appendChild(WTF::move(playButton), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- RefPtr<MediaControlReturnToRealtimeButtonElement> returnToRealtimeButton = MediaControlReturnToRealtimeButtonElement::create(document);
- controls->m_returnToRealTimeButton = returnToRealtimeButton.get();
- panel->appendChild(returnToRealtimeButton.release(), ec);
</del><ins>+ Ref<MediaControlReturnToRealtimeButtonElement> returnToRealtimeButton = MediaControlReturnToRealtimeButtonElement::create(document);
+ controls->m_returnToRealTimeButton = returnToRealtimeButton.ptr();
+ panel->appendChild(WTF::move(returnToRealtimeButton), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> if (document.page()->theme().usesMediaControlStatusDisplay()) {
</span><del>- RefPtr<MediaControlStatusDisplayElement> statusDisplay = MediaControlStatusDisplayElement::create(document);
- controls->m_statusDisplay = statusDisplay.get();
- panel->appendChild(statusDisplay.release(), ec);
</del><ins>+ Ref<MediaControlStatusDisplayElement> statusDisplay = MediaControlStatusDisplayElement::create(document);
+ controls->m_statusDisplay = statusDisplay.ptr();
+ panel->appendChild(WTF::move(statusDisplay), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- RefPtr<MediaControlTimelineContainerElement> timelineContainer = MediaControlTimelineContainerElement::create(document);
</del><ins>+ Ref<MediaControlTimelineContainerElement> timelineContainer = MediaControlTimelineContainerElement::create(document);
</ins><span class="cx">
</span><del>- RefPtr<MediaControlCurrentTimeDisplayElement> currentTimeDisplay = MediaControlCurrentTimeDisplayElement::create(document);
- controls->m_currentTimeDisplay = currentTimeDisplay.get();
- timelineContainer->appendChild(currentTimeDisplay.release(), ec);
</del><ins>+ Ref<MediaControlCurrentTimeDisplayElement> currentTimeDisplay = MediaControlCurrentTimeDisplayElement::create(document);
+ controls->m_currentTimeDisplay = currentTimeDisplay.ptr();
+ timelineContainer->appendChild(WTF::move(currentTimeDisplay), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- RefPtr<MediaControlTimelineElement> timeline = MediaControlTimelineElement::create(document, controls.get());
- controls->m_timeline = timeline.get();
- timelineContainer->appendChild(timeline.release(), ec);
</del><ins>+ Ref<MediaControlTimelineElement> timeline = MediaControlTimelineElement::create(document, controls.get());
+ controls->m_timeline = timeline.ptr();
+ timelineContainer->appendChild(WTF::move(timeline), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- RefPtr<MediaControlTimeRemainingDisplayElement> timeRemainingDisplay = MediaControlTimeRemainingDisplayElement::create(document);
- controls->m_timeRemainingDisplay = timeRemainingDisplay.get();
- timelineContainer->appendChild(timeRemainingDisplay.release(), ec);
</del><ins>+ Ref<MediaControlTimeRemainingDisplayElement> timeRemainingDisplay = MediaControlTimeRemainingDisplayElement::create(document);
+ controls->m_timeRemainingDisplay = timeRemainingDisplay.ptr();
+ timelineContainer->appendChild(WTF::move(timeRemainingDisplay), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- controls->m_timelineContainer = timelineContainer.get();
- panel->appendChild(timelineContainer.release(), ec);
</del><ins>+ controls->m_timelineContainer = timelineContainer.ptr();
+ panel->appendChild(WTF::move(timelineContainer), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> // FIXME: Only create when needed <http://webkit.org/b/57163>
</span><del>- RefPtr<MediaControlSeekBackButtonElement> seekBackButton = MediaControlSeekBackButtonElement::create(document);
- controls->m_seekBackButton = seekBackButton.get();
- panel->appendChild(seekBackButton.release(), ec);
</del><ins>+ Ref<MediaControlSeekBackButtonElement> seekBackButton = MediaControlSeekBackButtonElement::create(document);
+ controls->m_seekBackButton = seekBackButton.ptr();
+ panel->appendChild(WTF::move(seekBackButton), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> // FIXME: Only create when needed <http://webkit.org/b/57163>
</span><del>- RefPtr<MediaControlSeekForwardButtonElement> seekForwardButton = MediaControlSeekForwardButtonElement::create(document);
- controls->m_seekForwardButton = seekForwardButton.get();
- panel->appendChild(seekForwardButton.release(), ec);
</del><ins>+ Ref<MediaControlSeekForwardButtonElement> seekForwardButton = MediaControlSeekForwardButtonElement::create(document);
+ controls->m_seekForwardButton = seekForwardButton.ptr();
+ panel->appendChild(WTF::move(seekForwardButton), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> if (document.page()->theme().supportsClosedCaptioning()) {
</span><del>- RefPtr<MediaControlClosedCaptionsContainerElement> closedCaptionsContainer = MediaControlClosedCaptionsContainerElement::create(document);
</del><ins>+ Ref<MediaControlClosedCaptionsContainerElement> closedCaptionsContainer = MediaControlClosedCaptionsContainerElement::create(document);
</ins><span class="cx">
</span><del>- RefPtr<MediaControlClosedCaptionsTrackListElement> closedCaptionsTrackList = MediaControlClosedCaptionsTrackListElement::create(document, controls.get());
- controls->m_closedCaptionsTrackList = closedCaptionsTrackList.get();
- closedCaptionsContainer->appendChild(closedCaptionsTrackList.release(), ec);
</del><ins>+ Ref<MediaControlClosedCaptionsTrackListElement> closedCaptionsTrackList = MediaControlClosedCaptionsTrackListElement::create(document, controls.get());
+ controls->m_closedCaptionsTrackList = closedCaptionsTrackList.ptr();
+ closedCaptionsContainer->appendChild(WTF::move(closedCaptionsTrackList), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- RefPtr<MediaControlToggleClosedCaptionsButtonElement> toggleClosedCaptionsButton = MediaControlToggleClosedCaptionsButtonElement::create(document, controls.get());
- controls->m_toggleClosedCaptionsButton = toggleClosedCaptionsButton.get();
- panel->appendChild(toggleClosedCaptionsButton.release(), ec);
</del><ins>+ Ref<MediaControlToggleClosedCaptionsButtonElement> toggleClosedCaptionsButton = MediaControlToggleClosedCaptionsButtonElement::create(document, controls.get());
+ controls->m_toggleClosedCaptionsButton = toggleClosedCaptionsButton.ptr();
+ panel->appendChild(WTF::move(toggleClosedCaptionsButton), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- controls->m_closedCaptionsContainer = closedCaptionsContainer.get();
- controls->appendChild(closedCaptionsContainer.release(), ec);
</del><ins>+ controls->m_closedCaptionsContainer = closedCaptionsContainer.ptr();
+ controls->appendChild(WTF::move(closedCaptionsContainer), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // FIXME: Only create when needed <http://webkit.org/b/57163>
</span><del>- RefPtr<MediaControlFullscreenButtonElement> fullScreenButton = MediaControlFullscreenButtonElement::create(document);
- controls->m_fullScreenButton = fullScreenButton.get();
- panel->appendChild(fullScreenButton.release(), ec);
</del><ins>+ Ref<MediaControlFullscreenButtonElement> fullScreenButton = MediaControlFullscreenButtonElement::create(document);
+ controls->m_fullScreenButton = fullScreenButton.ptr();
+ panel->appendChild(WTF::move(fullScreenButton), ec);
</ins><span class="cx">
</span><span class="cx"> // The mute button and the slider element should be in the same div.
</span><del>- RefPtr<HTMLDivElement> panelVolumeControlContainer = HTMLDivElement::create(document);
</del><ins>+ Ref<HTMLDivElement> panelVolumeControlContainer = HTMLDivElement::create(document);
</ins><span class="cx">
</span><span class="cx"> if (document.page()->theme().usesMediaControlVolumeSlider()) {
</span><del>- RefPtr<MediaControlVolumeSliderContainerElement> volumeSliderContainer = MediaControlVolumeSliderContainerElement::create(document);
</del><ins>+ Ref<MediaControlVolumeSliderContainerElement> volumeSliderContainer = MediaControlVolumeSliderContainerElement::create(document);
</ins><span class="cx">
</span><del>- RefPtr<MediaControlPanelVolumeSliderElement> slider = MediaControlPanelVolumeSliderElement::create(document);
- controls->m_volumeSlider = slider.get();
- volumeSliderContainer->appendChild(slider.release(), ec);
</del><ins>+ Ref<MediaControlPanelVolumeSliderElement> slider = MediaControlPanelVolumeSliderElement::create(document);
+ controls->m_volumeSlider = slider.ptr();
+ volumeSliderContainer->appendChild(WTF::move(slider), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> // This is a duplicate mute button, which is visible in some ports at the bottom of the volume bar.
</span><span class="cx"> // It's important only when the volume bar is displayed below the controls.
</span><del>- RefPtr<MediaControlVolumeSliderMuteButtonElement> volumeSliderMuteButton = MediaControlVolumeSliderMuteButtonElement::create(document);
- controls->m_volumeSliderMuteButton = volumeSliderMuteButton.get();
- volumeSliderContainer->appendChild(volumeSliderMuteButton.release(), ec);
</del><ins>+ Ref<MediaControlVolumeSliderMuteButtonElement> volumeSliderMuteButton = MediaControlVolumeSliderMuteButtonElement::create(document);
+ controls->m_volumeSliderMuteButton = volumeSliderMuteButton.ptr();
+ volumeSliderContainer->appendChild(WTF::move(volumeSliderMuteButton), ec);
</ins><span class="cx">
</span><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- controls->m_volumeSliderContainer = volumeSliderContainer.get();
- panelVolumeControlContainer->appendChild(volumeSliderContainer.release(), ec);
</del><ins>+ controls->m_volumeSliderContainer = volumeSliderContainer.ptr();
+ panelVolumeControlContainer->appendChild(WTF::move(volumeSliderContainer), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- RefPtr<MediaControlPanelMuteButtonElement> panelMuteButton = MediaControlPanelMuteButtonElement::create(document, controls.get());
- controls->m_panelMuteButton = panelMuteButton.get();
- panelVolumeControlContainer->appendChild(panelMuteButton.release(), ec);
</del><ins>+ Ref<MediaControlPanelMuteButtonElement> panelMuteButton = MediaControlPanelMuteButtonElement::create(document, controls.get());
+ controls->m_panelMuteButton = panelMuteButton.ptr();
+ panelVolumeControlContainer->appendChild(WTF::move(panelMuteButton), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- panel->appendChild(panelVolumeControlContainer, ec);
</del><ins>+ panel->appendChild(WTF::move(panelVolumeControlContainer), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> // FIXME: Only create when needed <http://webkit.org/b/57163>
</span><del>- RefPtr<MediaControlFullscreenVolumeMinButtonElement> fullScreenMinVolumeButton = MediaControlFullscreenVolumeMinButtonElement::create(document);
- controls->m_fullScreenMinVolumeButton = fullScreenMinVolumeButton.get();
- panel->appendChild(fullScreenMinVolumeButton.release(), ec);
</del><ins>+ Ref<MediaControlFullscreenVolumeMinButtonElement> fullScreenMinVolumeButton = MediaControlFullscreenVolumeMinButtonElement::create(document);
+ controls->m_fullScreenMinVolumeButton = fullScreenMinVolumeButton.ptr();
+ panel->appendChild(WTF::move(fullScreenMinVolumeButton), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- RefPtr<MediaControlFullscreenVolumeSliderElement> fullScreenVolumeSlider = MediaControlFullscreenVolumeSliderElement::create(document);
- controls->m_fullScreenVolumeSlider = fullScreenVolumeSlider.get();
- panel->appendChild(fullScreenVolumeSlider.release(), ec);
</del><ins>+ Ref<MediaControlFullscreenVolumeSliderElement> fullScreenVolumeSlider = MediaControlFullscreenVolumeSliderElement::create(document);
+ controls->m_fullScreenVolumeSlider = fullScreenVolumeSlider.ptr();
+ panel->appendChild(WTF::move(fullScreenVolumeSlider), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- RefPtr<MediaControlFullscreenVolumeMaxButtonElement> fullScreenMaxVolumeButton = MediaControlFullscreenVolumeMaxButtonElement::create(document);
- controls->m_fullScreenMaxVolumeButton = fullScreenMaxVolumeButton.get();
- panel->appendChild(fullScreenMaxVolumeButton.release(), ec);
</del><ins>+ Ref<MediaControlFullscreenVolumeMaxButtonElement> fullScreenMaxVolumeButton = MediaControlFullscreenVolumeMaxButtonElement::create(document);
+ controls->m_fullScreenMaxVolumeButton = fullScreenMaxVolumeButton.ptr();
+ panel->appendChild(WTF::move(fullScreenMaxVolumeButton), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- controls->m_panel = panel.get();
- controls->appendChild(panel.release(), ec);
</del><ins>+ controls->m_panel = panel.ptr();
+ controls->appendChild(WTF::move(panel), ec);
</ins><span class="cx"> if (ec)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> return controls.release();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowSliderThumbElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -612,7 +612,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Element> SliderThumbElement::cloneElementWithoutAttributesAndChildren(Document& targetDocument)
</del><ins>+Ref<Element> SliderThumbElement::cloneElementWithoutAttributesAndChildren(Document& targetDocument)
</ins><span class="cx"> {
</span><span class="cx"> return create(targetDocument);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowSliderThumbElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/SliderThumbElement.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/SliderThumbElement.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/shadow/SliderThumbElement.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx"> SliderThumbElement(Document&);
</span><span class="cx">
</span><span class="cx"> virtual RenderPtr<RenderElement> createElementRenderer(Ref<RenderStyle>&&, const RenderTreePosition&) override;
</span><del>- virtual RefPtr<Element> cloneElementWithoutAttributesAndChildren(Document&) override;
</del><ins>+ virtual Ref<Element> cloneElementWithoutAttributesAndChildren(Document&) override;
</ins><span class="cx"> virtual bool isDisabledFormControl() const override;
</span><span class="cx"> virtual bool matchesReadWritePseudoClass() const override;
</span><span class="cx"> virtual Element* focusDelegate() override;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowmacImageControlsRootElementMaccpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/mac/ImageControlsRootElementMac.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/mac/ImageControlsRootElementMac.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/shadow/mac/ImageControlsRootElementMac.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -85,12 +85,13 @@
</span><span class="cx"> if (!document.page())
</span><span class="cx"> return nullptr;
</span><span class="cx">
</span><del>- RefPtr<ImageControlsRootElementMac> controls = adoptRef(*new ImageControlsRootElementMac(document));
</del><ins>+ Ref<ImageControlsRootElementMac> controls = adoptRef(*new ImageControlsRootElementMac(document));
</ins><span class="cx"> controls->setAttribute(HTMLNames::classAttr, "x-webkit-image-controls");
</span><span class="cx">
</span><del>- controls->appendChild(ImageControlsButtonElementMac::maybeCreate(document));
</del><ins>+ if (RefPtr<ImageControlsButtonElementMac> button = ImageControlsButtonElementMac::maybeCreate(document))
+ controls->appendChild(button.releaseNonNull());
</ins><span class="cx">
</span><del>- return controls.release();
</del><ins>+ return WTF::move(controls);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ImageControlsRootElementMac::ImageControlsRootElementMac(Document& document)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackVTTCuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/VTTCue.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/VTTCue.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/track/VTTCue.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -496,7 +496,7 @@
</span><span class="cx"> clonedNode = downcast<WebVTTElement>(*node).createEquivalentHTMLElement(ownerDocument());
</span><span class="cx"> else
</span><span class="cx"> clonedNode = node->cloneNode(false);
</span><del>- parent->appendChild(clonedNode, ASSERT_NO_EXCEPTION);
</del><ins>+ parent->appendChild(*clonedNode, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> if (is<ContainerNode>(*node))
</span><span class="cx"> copyWebVTTNodeToDOMTree(downcast<ContainerNode>(node), downcast<ContainerNode>(clonedNode.get()));
</span><span class="cx"> }
</span><span class="lines">@@ -518,10 +518,10 @@
</span><span class="cx"> RefPtr<DocumentFragment> clonedFragment;
</span><span class="cx"> createWebVTTNodeTree();
</span><span class="cx"> if (!m_webVTTNodeTree)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> clonedFragment = DocumentFragment::create(ownerDocument());
</span><del>- m_webVTTNodeTree->cloneChildNodes(clonedFragment.get());
</del><ins>+ m_webVTTNodeTree->cloneChildNodes(*clonedFragment);
</ins><span class="cx"> return clonedFragment.release();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -785,7 +785,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> markFutureAndPastNodes(referenceTree.get(), startMediaTime(), movieTime);
</span><del>- m_cueHighlightBox->appendChild(referenceTree);
</del><ins>+ m_cueHighlightBox->appendChild(referenceTree.releaseNonNull());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> VTTCueBox* VTTCue::getDisplayTree(const IntSize& videoSize, int fontSize)
</span><span class="lines">@@ -812,8 +812,8 @@
</span><span class="cx"> m_cueHighlightBox->setPseudo(cueShadowPseudoId());
</span><span class="cx">
</span><span class="cx"> m_cueBackdropBox->setPseudo(cueBackdropShadowPseudoId());
</span><del>- m_cueBackdropBox->appendChild(m_cueHighlightBox, ASSERT_NO_EXCEPTION);
- displayTree->appendChild(m_cueBackdropBox, ASSERT_NO_EXCEPTION);
</del><ins>+ m_cueBackdropBox->appendChild(*m_cueHighlightBox, ASSERT_NO_EXCEPTION);
+ displayTree->appendChild(*m_cueBackdropBox, ASSERT_NO_EXCEPTION);
</ins><span class="cx">
</span><span class="cx"> // FIXME(BUG 79916): Runs of children of WebVTT Ruby Objects that are not
</span><span class="cx"> // WebVTT Ruby Text Objects must be wrapped in anonymous boxes whose
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackVTTRegioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/VTTRegion.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/VTTRegion.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/track/VTTRegion.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -354,7 +354,7 @@
</span><span class="cx"> if (m_cueContainer->contains(displayBox.get()))
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- m_cueContainer->appendChild(displayBox, ASSERT_NO_EXCEPTION);
</del><ins>+ m_cueContainer->appendChild(*displayBox, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> displayLastTextTrackCueBox();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -404,14 +404,14 @@
</span><span class="cx"> m_cueContainer->setInlineStyleProperty(CSSPropertyTop, m_currentTop, CSSPrimitiveValue::CSS_PX);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<HTMLDivElement> VTTRegion::getDisplayTree()
</del><ins>+HTMLDivElement& VTTRegion::getDisplayTree()
</ins><span class="cx"> {
</span><span class="cx"> if (!m_regionDisplayTree) {
</span><span class="cx"> m_regionDisplayTree = HTMLDivElement::create(*ownerDocument());
</span><span class="cx"> prepareRegionDisplayTree();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return m_regionDisplayTree;
</del><ins>+ return *m_regionDisplayTree;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void VTTRegion::prepareRegionDisplayTree()
</span><span class="lines">@@ -453,7 +453,7 @@
</span><span class="cx"> m_cueContainer->setInlineStyleProperty(CSSPropertyTop, 0.0f, CSSPrimitiveValue::CSS_PX);
</span><span class="cx">
</span><span class="cx"> m_cueContainer->setPseudo(textTrackCueContainerShadowPseudoId());
</span><del>- m_regionDisplayTree->appendChild(m_cueContainer);
</del><ins>+ m_regionDisplayTree->appendChild(*m_cueContainer);
</ins><span class="cx">
</span><span class="cx"> // 7.5 Every WebVTT region object is initialised with the following CSS
</span><span class="cx"> m_regionDisplayTree->setPseudo(textTrackRegionShadowPseudoId());
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackVTTRegionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/VTTRegion.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/VTTRegion.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/track/VTTRegion.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -89,7 +89,7 @@
</span><span class="cx">
</span><span class="cx"> bool isScrollingRegion() { return m_scroll; }
</span><span class="cx">
</span><del>- PassRefPtr<HTMLDivElement> getDisplayTree();
</del><ins>+ HTMLDivElement& getDisplayTree();
</ins><span class="cx">
</span><span class="cx"> void appendTextTrackCueBox(PassRefPtr<VTTCueBox>);
</span><span class="cx"> void displayLastTextTrackCueBox();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackWebVTTElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/WebVTTElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/WebVTTElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/track/WebVTTElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -80,11 +80,11 @@
</span><span class="cx"> return adoptRef(*new WebVTTElement(nodeType, document));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Element> WebVTTElement::cloneElementWithoutAttributesAndChildren(Document& targetDocument)
</del><ins>+Ref<Element> WebVTTElement::cloneElementWithoutAttributesAndChildren(Document& targetDocument)
</ins><span class="cx"> {
</span><del>- RefPtr<WebVTTElement> clone = create(static_cast<WebVTTNodeType>(m_webVTTNodeType), targetDocument);
</del><ins>+ Ref<WebVTTElement> clone = create(static_cast<WebVTTNodeType>(m_webVTTNodeType), targetDocument);
</ins><span class="cx"> clone->setLanguage(m_language);
</span><del>- return clone;
</del><ins>+ return WTF::move(clone);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<HTMLElement> WebVTTElement::createEquivalentHTMLElement(Document& document)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackWebVTTElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/WebVTTElement.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/WebVTTElement.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/html/track/WebVTTElement.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -49,7 +49,7 @@
</span><span class="cx"> static Ref<WebVTTElement> create(const WebVTTNodeType, Document&);
</span><span class="cx"> PassRefPtr<HTMLElement> createEquivalentHTMLElement(Document&);
</span><span class="cx">
</span><del>- virtual RefPtr<Element> cloneElementWithoutAttributesAndChildren(Document&) override;
</del><ins>+ virtual Ref<Element> cloneElementWithoutAttributesAndChildren(Document&) override;
</ins><span class="cx">
</span><span class="cx"> void setWebVTTNodeType(WebVTTNodeType type) { m_webVTTNodeType = static_cast<unsigned>(type); }
</span><span class="cx"> WebVTTNodeType webVTTNodeType() const { return static_cast<WebVTTNodeType>(m_webVTTNodeType); }
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorCSSAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -796,7 +796,7 @@
</span><span class="cx"> // Set this flag, so when we create it, we put it into the via inspector map.
</span><span class="cx"> m_creatingViaInspectorStyleSheet = true;
</span><span class="cx"> InlineStyleOverrideScope overrideScope(document);
</span><del>- targetNode->appendChild(styleElement, ec);
</del><ins>+ targetNode->appendChild(styleElement.releaseNonNull(), ec);
</ins><span class="cx"> m_creatingViaInspectorStyleSheet = false;
</span><span class="cx"> if (ec)
</span><span class="cx"> return nullptr;
</span></span></pre></div>
<a id="trunkSourceWebCorepageDragControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DragController.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DragController.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/page/DragController.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -138,7 +138,7 @@
</span><span class="cx"> String title;
</span><span class="cx"> String url = dragData.asURL(DragData::DoNotConvertFilenames, &title);
</span><span class="cx"> if (!url.isEmpty()) {
</span><del>- RefPtr<HTMLAnchorElement> anchor = HTMLAnchorElement::create(document);
</del><ins>+ Ref<HTMLAnchorElement> anchor = HTMLAnchorElement::create(document);
</ins><span class="cx"> anchor->setHref(url);
</span><span class="cx"> if (title.isEmpty()) {
</span><span class="cx"> // Try the plain text first because the url might be normalized or escaped.
</span><span class="lines">@@ -147,20 +147,19 @@
</span><span class="cx"> if (title.isEmpty())
</span><span class="cx"> title = url;
</span><span class="cx"> }
</span><del>- RefPtr<Node> anchorText = document.createTextNode(title);
- anchor->appendChild(anchorText, IGNORE_EXCEPTION);
- RefPtr<DocumentFragment> fragment = document.createDocumentFragment();
- fragment->appendChild(anchor, IGNORE_EXCEPTION);
- return fragment.get();
</del><ins>+ anchor->appendChild(document.createTextNode(title), IGNORE_EXCEPTION);
+ Ref<DocumentFragment> fragment = document.createDocumentFragment();
+ fragment->appendChild(WTF::move(anchor), IGNORE_EXCEPTION);
+ return fragment.ptr();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> if (allowPlainText && dragData.containsPlainText()) {
</span><span class="cx"> chosePlainText = true;
</span><del>- return createFragmentFromText(context, dragData.asPlainText()).get();
</del><ins>+ return createFragmentFromText(context, dragData.asPlainText()).ptr();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool DragController::dragIsMove(FrameSelection& selection, DragData& dragData)
</span></span></pre></div>
<a id="trunkSourceWebCorepageiosFrameIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/ios/FrameIOS.mm (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/ios/FrameIOS.mm 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/page/ios/FrameIOS.mm 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -95,8 +95,8 @@
</span><span class="cx"> if (!style.isEmpty())
</span><span class="cx"> body->setAttribute(HTMLNames::styleAttr, style);
</span><span class="cx">
</span><del>- rootElement->appendChild(body, ec);
- document->appendChild(rootElement, ec);
</del><ins>+ rootElement->appendChild(body.releaseNonNull(), ec);
+ document->appendChild(rootElement.releaseNonNull(), ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const ViewportArguments& Frame::viewportArguments() const
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGScriptElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGScriptElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGScriptElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/svg/SVGScriptElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -156,9 +156,9 @@
</span><span class="cx"> return hasAttribute(XLinkNames::hrefAttr);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Element> SVGScriptElement::cloneElementWithoutAttributesAndChildren(Document& targetDocument)
</del><ins>+Ref<Element> SVGScriptElement::cloneElementWithoutAttributesAndChildren(Document& targetDocument)
</ins><span class="cx"> {
</span><del>- return adoptRef(new SVGScriptElement(tagQName(), targetDocument, false, alreadyStarted()));
</del><ins>+ return adoptRef(*new SVGScriptElement(tagQName(), targetDocument, false, alreadyStarted()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGScriptElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGScriptElement.h (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGScriptElement.h 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/svg/SVGScriptElement.h 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -65,7 +65,7 @@
</span><span class="cx">
</span><span class="cx"> virtual void dispatchLoadEvent() override { SVGExternalResourcesRequired::dispatchLoadEvent(this); }
</span><span class="cx">
</span><del>- virtual RefPtr<Element> cloneElementWithoutAttributesAndChildren(Document&) override;
</del><ins>+ virtual Ref<Element> cloneElementWithoutAttributesAndChildren(Document&) override;
</ins><span class="cx"> virtual bool rendererIsNeeded(const RenderStyle&) override { return false; }
</span><span class="cx">
</span><span class="cx"> // SVGExternalResourcesRequired
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGUseElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGUseElement.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGUseElement.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/svg/SVGUseElement.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -332,7 +332,7 @@
</span><span class="cx"> for (auto* element : disallowedElements) {
</span><span class="cx"> for (auto& descendant : descendantsOfType<SVGElement>(*element))
</span><span class="cx"> descendant.setCorrespondingElement(nullptr);
</span><del>- element->parentNode()->removeChild(element);
</del><ins>+ element->parentNode()->removeChild(*element);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -405,7 +405,7 @@
</span><span class="cx">
</span><span class="cx"> void SVGUseElement::cloneTarget(ContainerNode& container, SVGElement& target) const
</span><span class="cx"> {
</span><del>- Ref<SVGElement> targetClone = static_pointer_cast<SVGElement>(target.cloneElementWithChildren(document())).releaseNonNull();
</del><ins>+ Ref<SVGElement> targetClone = static_cast<SVGElement&>(target.cloneElementWithChildren(document()).get());
</ins><span class="cx"> associateClonesWithOriginals(targetClone.get(), target);
</span><span class="cx"> removeDisallowedElementsFromSubtree(targetClone.get());
</span><span class="cx"> transferSizeAttributesToTargetClone(targetClone.get());
</span><span class="lines">@@ -419,7 +419,7 @@
</span><span class="cx"> ASSERT(!replacementClone.parentNode());
</span><span class="cx">
</span><span class="cx"> replacementClone.cloneDataFromElement(originalClone);
</span><del>- originalClone.cloneChildNodes(&replacementClone);
</del><ins>+ originalClone.cloneChildNodes(replacementClone);
</ins><span class="cx"> associateReplacementClonesWithOriginals(replacementClone, originalClone);
</span><span class="cx"> removeDisallowedElementsFromSubtree(replacementClone);
</span><span class="cx"> }
</span><span class="lines">@@ -448,7 +448,7 @@
</span><span class="cx"> if (target)
</span><span class="cx"> originalClone.cloneTarget(replacementClone.get(), *target);
</span><span class="cx">
</span><del>- originalClone.parentNode()->replaceChild(replacementClone.ptr(), &originalClone);
</del><ins>+ originalClone.parentNode()->replaceChild(replacementClone.copyRef(), originalClone);
</ins><span class="cx">
</span><span class="cx"> // Resume iterating, starting just inside the replacement clone.
</span><span class="cx"> it = descendants.from(replacementClone.get());
</span><span class="lines">@@ -472,7 +472,7 @@
</span><span class="cx"> auto replacementClone = SVGSVGElement::create(document());
</span><span class="cx"> cloneDataAndChildren(replacementClone.get(), originalClone);
</span><span class="cx">
</span><del>- originalClone.parentNode()->replaceChild(replacementClone.ptr(), &originalClone);
</del><ins>+ originalClone.parentNode()->replaceChild(replacementClone.copyRef(), originalClone);
</ins><span class="cx">
</span><span class="cx"> // Resume iterating, starting just inside the replacement clone.
</span><span class="cx"> it = descendants.from(replacementClone.get());
</span></span></pre></div>
<a id="trunkSourceWebCorexmlXMLTreeViewercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/XMLTreeViewer.cpp (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/XMLTreeViewer.cpp 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebCore/xml/XMLTreeViewer.cpp 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -61,8 +61,8 @@
</span><span class="cx"> m_document.frame()->script().evaluate(ScriptSourceCode(AtomicString("prepareWebKitXMLViewer('This XML file does not appear to have any style information associated with it. The document tree is shown below.');")));
</span><span class="cx">
</span><span class="cx"> String cssString = StringImpl::createWithoutCopying(XMLViewer_css, sizeof(XMLViewer_css));
</span><del>- RefPtr<Text> text = m_document.createTextNode(cssString);
- m_document.getElementById(String(ASCIILiteral("xml-viewer-style")))->appendChild(text, IGNORE_EXCEPTION);
</del><ins>+ Ref<Text> text = m_document.createTextNode(cssString);
+ m_document.getElementById(String(ASCIILiteral("xml-viewer-style")))->appendChild(WTF::move(text), IGNORE_EXCEPTION);
</ins><span class="cx"> m_document.styleResolverChanged(RecalcStyleImmediately);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-09-10 Chris Dumez <cdumez@apple.com>
+
+ Node.appendChild(null) / replaceChild(null, null) / removeChild(null) / insertBefore(null, ref) should throw a TypeError
+ https://bugs.webkit.org/show_bug.cgi?id=148971
+ <rdar://problem/22560883>
+ <rdar://problem/22559225>
+
+ Reviewed by Ryosuke Niwa.
+
+ ContainerNode::appendChild() now takes a Ref<Node>&& parameter so we
+ need to update the call site.
+
+ * WebView/WebFrame.mm:
+ (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
+
</ins><span class="cx"> 2015-09-07 Andy Estes <aestes@apple.com>
</span><span class="cx">
</span><span class="cx"> [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebFramemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebFrame.mm (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebFrame.mm 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebKit/mac/WebView/WebFrame.mm 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -890,9 +890,9 @@
</span><span class="cx"> RefPtr<DocumentFragment> fragment = document->createDocumentFragment();
</span><span class="cx">
</span><span class="cx"> for (auto* node : nodesVector) {
</span><del>- RefPtr<Element> element = createDefaultParagraphElement(*document);
- element->appendChild(node);
- fragment->appendChild(element.release());
</del><ins>+ Ref<Element> element = createDefaultParagraphElement(*document);
+ element->appendChild(*node);
+ fragment->appendChild(WTF::move(element));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> return kit(fragment.release().get());
</span><span class="lines">@@ -1873,7 +1873,7 @@
</span><span class="cx"> {
</span><span class="cx"> RefPtr<Range> range = _private->coreFrame->selection().toNormalizedRange();
</span><span class="cx">
</span><del>- DOMDocumentFragment* fragment = range ? kit(createFragmentFromText(*range, text).get()) : nil;
</del><ins>+ DOMDocumentFragment* fragment = range ? kit(createFragmentFromText(*range, text).ptr()) : nil;
</ins><span class="cx"> [self _replaceSelectionWithFragment:fragment selectReplacement:selectReplacement smartReplace:smartReplace matchStyle:matchStyle];
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1958,7 +1958,7 @@
</span><span class="cx"> {
</span><span class="cx"> RefPtr<Range> range = _private->coreFrame->selection().toNormalizedRange();
</span><span class="cx">
</span><del>- DOMDocumentFragment* fragment = range ? kit(createFragmentFromText(*range, text).get()) : nil;
</del><ins>+ DOMDocumentFragment* fragment = range ? kit(createFragmentFromText(*range, text).ptr()) : nil;
</ins><span class="cx"> [self _replaceSelectionWithFragment:fragment selectReplacement:selectReplacement smartReplace:smartReplace matchStyle:YES];
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2264,7 +2264,7 @@
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> - (DOMDocumentFragment *)_documentFragmentForText:(NSString *)text
</span><span class="cx"> {
</span><del>- return kit(createFragmentFromText(*_private->coreFrame->selection().toNormalizedRange().get(), text).get());
</del><ins>+ return kit(createFragmentFromText(*_private->coreFrame->selection().toNormalizedRange().get(), text).ptr());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (DOMDocumentFragment *)_documentFragmentForWebArchive:(WebArchive *)webArchive
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebHTMLViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebHTMLView.mm (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -2267,7 +2267,7 @@
</span><span class="cx"> if (pboardType == NSStringPboardType) {
</span><span class="cx"> if (!context)
</span><span class="cx"> return nil;
</span><del>- return kit(createFragmentFromText(*core(context), [[pasteboard stringForType:NSStringPboardType] precomposedStringWithCanonicalMapping]).get());
</del><ins>+ return kit(createFragmentFromText(*core(context), [[pasteboard stringForType:NSStringPboardType] precomposedStringWithCanonicalMapping]).ptr());
</ins><span class="cx"> }
</span><span class="cx"> return nil;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebKit2/ChangeLog 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-09-10 Chris Dumez <cdumez@apple.com>
+
+ Node.appendChild(null) / replaceChild(null, null) / removeChild(null) / insertBefore(null, ref) should throw a TypeError
+ https://bugs.webkit.org/show_bug.cgi?id=148971
+ <rdar://problem/22560883>
+ <rdar://problem/22559225>
+
+ Reviewed by Ryosuke Niwa.
+
+ ContainerNode::appendChild() now takes a Ref<Node>&& parameter so we
+ need to update the call sites.
+
+ * WebProcess/Plugins/PDF/PDFPlugin.mm:
+ (WebKit::PDFPlugin::PDFPlugin):
+ * WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
+ (WebKit::PDFPluginAnnotation::attach):
+ (WebKit::PDFPluginAnnotation::~PDFPluginAnnotation):
+ * WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
+ (WebKit::PDFPluginChoiceAnnotation::createAnnotationElement):
+
</ins><span class="cx"> 2015-09-10 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Make WebInspectorProxy inspectorURL path methods static
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessPluginsPDFPDFPluginmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -525,11 +525,11 @@
</span><span class="cx"> m_annotationContainer = document->createElement(divTag, false);
</span><span class="cx"> m_annotationContainer->setAttribute(idAttr, "annotationContainer");
</span><span class="cx">
</span><del>- RefPtr<Element> m_annotationStyle = document->createElement(styleTag, false);
- m_annotationStyle->setTextContent(annotationStyle, ASSERT_NO_EXCEPTION);
</del><ins>+ Ref<Element> annotationStyleElement = document->createElement(styleTag, false);
+ annotationStyleElement->setTextContent(annotationStyle, ASSERT_NO_EXCEPTION);
</ins><span class="cx">
</span><del>- m_annotationContainer->appendChild(m_annotationStyle.get());
- document->bodyOrFrameset()->appendChild(m_annotationContainer.get());
</del><ins>+ m_annotationContainer->appendChild(WTF::move(annotationStyleElement));
+ document->bodyOrFrameset()->appendChild(*m_annotationContainer);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> m_accessibilityObject = adoptNS([[WKPDFPluginAccessibilityObject alloc] initWithPDFPlugin:this]);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessPluginsPDFPDFPluginAnnotationmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -74,7 +74,7 @@
</span><span class="cx">
</span><span class="cx"> updateGeometry();
</span><span class="cx">
</span><del>- m_parent->appendChild(m_element);
</del><ins>+ m_parent->appendChild(*m_element);
</ins><span class="cx">
</span><span class="cx"> // FIXME: The text cursor doesn't blink after this. Why?
</span><span class="cx"> m_element->focus();
</span><span class="lines">@@ -92,7 +92,7 @@
</span><span class="cx">
</span><span class="cx"> m_eventListener->setAnnotation(0);
</span><span class="cx">
</span><del>- m_parent->removeChild(element());
</del><ins>+ m_parent->removeChild(*element());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void PDFPluginAnnotation::updateGeometry()
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessPluginsPDFPDFPluginChoiceAnnotationmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm (189575 => 189576)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm 2015-09-10 17:47:16 UTC (rev 189575)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm 2015-09-10 18:02:15 UTC (rev 189576)
</span><span class="lines">@@ -83,14 +83,14 @@
</span><span class="cx"> NSString *selectedChoice = choiceAnnotation.stringValue;
</span><span class="cx">
</span><span class="cx"> for (NSString *choice in choices) {
</span><del>- RefPtr<Element> choiceOption = document.createElement(optionTag, false);
</del><ins>+ Ref<Element> choiceOption = document.createElement(optionTag, false);
</ins><span class="cx"> choiceOption->setAttribute(valueAttr, choice);
</span><span class="cx"> choiceOption->setTextContent(choice, ASSERT_NO_EXCEPTION);
</span><span class="cx">
</span><span class="cx"> if (choice == selectedChoice)
</span><span class="cx"> choiceOption->setAttribute(selectedAttr, "selected");
</span><span class="cx">
</span><del>- styledElement->appendChild(choiceOption);
</del><ins>+ styledElement->appendChild(WTF::move(choiceOption));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> return element;
</span></span></pre>
</div>
</div>
</body>
</html>