<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189566] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189566">189566</a></dd>
<dt>Author</dt> <dd>changseok.oh@collabora.com</dd>
<dt>Date</dt> <dd>2015-09-10 02:10:11 -0700 (Thu, 10 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Volume bar is broken
https://bugs.webkit.org/show_bug.cgi?id=145639
Reviewed by Philippe Normand.
Source/WebCore:
The ControlPart enum values' order has mismatched the one of values in CSSValueKeywords.in
after <a href="http://trac.webkit.org/projects/webkit/changeset/180965">r180965</a>. The MediaVolumeSliderPart should be prior to the MediaVolumeSliderContainerpart.
Tests: media/click-volume-bar-not-pausing.html
media/volume-bar-empty-when-muted.html
* platform/ThemeTypes.h:
LayoutTests:
Unblock relevant tests. media/click-volume-bar-not-pausing.html, media/volume-bar-empty-when-muted.html
* platform/gtk/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformThemeTypesh">trunk/Source/WebCore/platform/ThemeTypes.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (189565 => 189566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-09-10 02:16:22 UTC (rev 189565)
+++ trunk/LayoutTests/ChangeLog 2015-09-10 09:10:11 UTC (rev 189566)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-09-10 ChangSeok Oh <changseok.oh@collabora.com>
+
+ [GTK] Volume bar is broken
+ https://bugs.webkit.org/show_bug.cgi?id=145639
+
+ Reviewed by Philippe Normand.
+
+ Unblock relevant tests. media/click-volume-bar-not-pausing.html, media/volume-bar-empty-when-muted.html
+
+ * platform/gtk/TestExpectations:
+
</ins><span class="cx"> 2015-09-09 Dewei Zhu <dewei_zhu@apple.com>
</span><span class="cx">
</span><span class="cx"> Document.characterSet should return "UTF-8" by default.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (189565 => 189566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2015-09-10 02:16:22 UTC (rev 189565)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2015-09-10 09:10:11 UTC (rev 189566)
</span><span class="lines">@@ -1350,7 +1350,6 @@
</span><span class="cx"> webkit.org/b/142491 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Timeout ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/142820 fast/images/animated-gif-body-outside-viewport.html [ Timeout Pass ]
</span><del>-webkit.org/b/142491 media/click-volume-bar-not-pausing.html [ Timeout ]
</del><span class="cx"> webkit.org/b/143473 editing/pasteboard/drag-and-drop-attachment-contenteditable.html [ Timeout ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/143477 fast/writing-mode/broken-ideograph-small-caps.html [ Timeout Pass ]
</span><span class="lines">@@ -2234,8 +2233,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/132235 fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-percent.html [ ImageOnlyFailure ]
</span><span class="cx">
</span><del>-webkit.org/b/132253 media/volume-bar-empty-when-muted.html [ Failure ]
-
</del><span class="cx"> webkit.org/b/132910 editing/pasteboard/drag-drop-paragraph-crasher.html [ Failure ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/132914 http/tests/security/drag-drop-local-file.html [ Failure ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (189565 => 189566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-10 02:16:22 UTC (rev 189565)
+++ trunk/Source/WebCore/ChangeLog 2015-09-10 09:10:11 UTC (rev 189566)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-09-10 ChangSeok Oh <changseok.oh@collabora.com>
+
+ [GTK] Volume bar is broken
+ https://bugs.webkit.org/show_bug.cgi?id=145639
+
+ Reviewed by Philippe Normand.
+
+ The ControlPart enum values' order has mismatched the one of values in CSSValueKeywords.in
+ after r180965. The MediaVolumeSliderPart should be prior to the MediaVolumeSliderContainerpart.
+
+ Tests: media/click-volume-bar-not-pausing.html
+ media/volume-bar-empty-when-muted.html
+
+ * platform/ThemeTypes.h:
+
</ins><span class="cx"> 2015-09-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
</span><span class="cx">
</span><span class="cx"> Remove all uses of PassRefPtr in WebCore/svg
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformThemeTypesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ThemeTypes.h (189565 => 189566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ThemeTypes.h 2015-09-10 02:16:22 UTC (rev 189565)
+++ trunk/Source/WebCore/platform/ThemeTypes.h 2015-09-10 09:10:11 UTC (rev 189566)
</span><span class="lines">@@ -38,8 +38,8 @@
</span><span class="cx"> MediaFullScreenVolumeSliderThumbPart, MediaMuteButtonPart, MediaOverlayPlayButtonPart,
</span><span class="cx"> MediaPlayButtonPart, MediaReturnToRealtimeButtonPart, MediaRewindButtonPart, MediaSeekBackButtonPart,
</span><span class="cx"> MediaSeekForwardButtonPart, MediaSliderPart, MediaSliderThumbPart, MediaTimeRemainingPart,
</span><del>- MediaToggleClosedCaptionsButtonPart, MediaVolumeSliderContainerPart, MediaVolumeSliderMuteButtonPart,
- MediaVolumeSliderPart, MediaVolumeSliderThumbPart,
</del><ins>+ MediaToggleClosedCaptionsButtonPart, MediaVolumeSliderPart, MediaVolumeSliderContainerPart,
+ MediaVolumeSliderMuteButtonPart, MediaVolumeSliderThumbPart,
</ins><span class="cx"> MenulistPart, MenulistButtonPart, MenulistTextPart, MenulistTextFieldPart, MeterPart, ProgressBarPart, ProgressBarValuePart,
</span><span class="cx"> SliderHorizontalPart, SliderVerticalPart, SliderThumbHorizontalPart,
</span><span class="cx"> SliderThumbVerticalPart, CaretPart, SearchFieldPart, SearchFieldDecorationPart,
</span></span></pre>
</div>
</div>
</body>
</html>