<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189565] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189565">189565</a></dd>
<dt>Author</dt> <dd>gyuyoung.kim@webkit.org</dd>
<dt>Date</dt> <dd>2015-09-09 19:16:22 -0700 (Wed, 09 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove all uses of PassRefPtr in WebCore/svg
https://bugs.webkit.org/show_bug.cgi?id=148472
Reviewed by Darin Adler.
Clean up all uses of PassRefPtr in WebCore/svg.
* Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::addEventListener):
* Modules/webaudio/AudioScheduledSourceNode.h:
* Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::addEventListener):
* Modules/webaudio/ScriptProcessorNode.h:
* dom/EventListenerMap.cpp:
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
* dom/EventTarget.cpp:
(WebCore::EventTarget::addEventListener):
* dom/EventTarget.h:
* dom/MessagePort.cpp:
(WebCore::MessagePort::addEventListener):
* dom/MessagePort.h:
* dom/Node.cpp:
(WebCore::tryAddEventListener):
(WebCore::Node::addEventListener):
* dom/Node.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::addEventListener):
* html/HTMLMediaElement.h:
* html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure):
* html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::showClosedCaptionTrackList):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
* page/DOMWindow.h:
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives):
* svg/SVGElement.cpp:
(WebCore::SVGElement::addEventListener):
* svg/SVGElement.h:
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::pathSegListChanged):
* svg/SVGPathUtilities.cpp:
(WebCore::appendSVGPathByteStreamFromSVGPathSeg):
* svg/SVGPathUtilities.h:
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefTargetEventListener::attach):
(WebCore::SVGTRefElement::buildPendingResource):
* svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
* svg/graphics/filters/SVGFilterBuilder.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioAudioScheduledSourceNodecpp">trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioAudioScheduledSourceNodeh">trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioScriptProcessorNodecpp">trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioScriptProcessorNodeh">trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.h</a></li>
<li><a href="#trunkSourceWebCoredomEventListenerMapcpp">trunk/Source/WebCore/dom/EventListenerMap.cpp</a></li>
<li><a href="#trunkSourceWebCoredomEventTargetcpp">trunk/Source/WebCore/dom/EventTarget.cpp</a></li>
<li><a href="#trunkSourceWebCoredomEventTargeth">trunk/Source/WebCore/dom/EventTarget.h</a></li>
<li><a href="#trunkSourceWebCoredomMessagePortcpp">trunk/Source/WebCore/dom/MessagePort.cpp</a></li>
<li><a href="#trunkSourceWebCoredomMessagePorth">trunk/Source/WebCore/dom/MessagePort.h</a></li>
<li><a href="#trunkSourceWebCoredomNodecpp">trunk/Source/WebCore/dom/Node.cpp</a></li>
<li><a href="#trunkSourceWebCoredomNodeh">trunk/Source/WebCore/dom/Node.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMediaElementcpp">trunk/Source/WebCore/html/HTMLMediaElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMediaElementh">trunk/Source/WebCore/html/HTMLMediaElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlImageDocumentcpp">trunk/Source/WebCore/html/ImageDocument.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowMediaControlsApplecpp">trunk/Source/WebCore/html/shadow/MediaControlsApple.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDOMWindowcpp">trunk/Source/WebCore/page/DOMWindow.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDOMWindowh">trunk/Source/WebCore/page/DOMWindow.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGResourceFiltercpp">trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGElementcpp">trunk/Source/WebCore/svg/SVGElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGElementh">trunk/Source/WebCore/svg/SVGElement.h</a></li>
<li><a href="#trunkSourceWebCoresvgSVGPathElementcpp">trunk/Source/WebCore/svg/SVGPathElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGPathUtilitiescpp">trunk/Source/WebCore/svg/SVGPathUtilities.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGPathUtilitiesh">trunk/Source/WebCore/svg/SVGPathUtilities.h</a></li>
<li><a href="#trunkSourceWebCoresvgSVGTRefElementcpp">trunk/Source/WebCore/svg/SVGTRefElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvggraphicsfiltersSVGFilterBuildercpp">trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp</a></li>
<li><a href="#trunkSourceWebCoresvggraphicsfiltersSVGFilterBuilderh">trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/ChangeLog 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -1,3 +1,57 @@
</span><ins>+2015-09-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
+
+ Remove all uses of PassRefPtr in WebCore/svg
+ https://bugs.webkit.org/show_bug.cgi?id=148472
+
+ Reviewed by Darin Adler.
+
+ Clean up all uses of PassRefPtr in WebCore/svg.
+
+ * Modules/webaudio/AudioScheduledSourceNode.cpp:
+ (WebCore::AudioScheduledSourceNode::addEventListener):
+ * Modules/webaudio/AudioScheduledSourceNode.h:
+ * Modules/webaudio/ScriptProcessorNode.cpp:
+ (WebCore::ScriptProcessorNode::addEventListener):
+ * Modules/webaudio/ScriptProcessorNode.h:
+ * dom/EventListenerMap.cpp:
+ (WebCore::copyListenersNotCreatedFromMarkupToTarget):
+ * dom/EventTarget.cpp:
+ (WebCore::EventTarget::addEventListener):
+ * dom/EventTarget.h:
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::addEventListener):
+ * dom/MessagePort.h:
+ * dom/Node.cpp:
+ (WebCore::tryAddEventListener):
+ (WebCore::Node::addEventListener):
+ * dom/Node.h:
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::addEventListener):
+ * html/HTMLMediaElement.h:
+ * html/ImageDocument.cpp:
+ (WebCore::ImageDocument::createDocumentStructure):
+ * html/shadow/MediaControlsApple.cpp:
+ (WebCore::MediaControlsApple::showClosedCaptionTrackList):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::addEventListener):
+ * page/DOMWindow.h:
+ * rendering/svg/RenderSVGResourceFilter.cpp:
+ (WebCore::RenderSVGResourceFilter::buildPrimitives):
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::addEventListener):
+ * svg/SVGElement.h:
+ * svg/SVGPathElement.cpp:
+ (WebCore::SVGPathElement::pathSegListChanged):
+ * svg/SVGPathUtilities.cpp:
+ (WebCore::appendSVGPathByteStreamFromSVGPathSeg):
+ * svg/SVGPathUtilities.h:
+ * svg/SVGTRefElement.cpp:
+ (WebCore::SVGTRefTargetEventListener::attach):
+ (WebCore::SVGTRefElement::buildPendingResource):
+ * svg/graphics/filters/SVGFilterBuilder.cpp:
+ (WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
+ * svg/graphics/filters/SVGFilterBuilder.h:
+
</ins><span class="cx"> 2015-09-09 Dewei Zhu <dewei_zhu@apple.com>
</span><span class="cx">
</span><span class="cx"> Document.characterSet should return "UTF-8" instead of null by default.
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioAudioScheduledSourceNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -211,9 +211,9 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool AudioScheduledSourceNode::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
</del><ins>+bool AudioScheduledSourceNode::addEventListener(const AtomicString& eventType, RefPtr<EventListener>&& listener, bool useCapture)
</ins><span class="cx"> {
</span><del>- bool success = AudioNode::addEventListener(eventType, listener, useCapture);
</del><ins>+ bool success = AudioNode::addEventListener(eventType, WTF::move(listener), useCapture);
</ins><span class="cx"> if (success && eventType == eventNames().endedEvent)
</span><span class="cx"> m_hasEndedListener = hasEventListeners(eventNames().endedEvent);
</span><span class="cx"> return success;
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioAudioScheduledSourceNodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -103,7 +103,7 @@
</span><span class="cx"> static const double UnknownTime;
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- bool addEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture) override;
</del><ins>+ bool addEventListener(const AtomicString& eventType, RefPtr<EventListener>&&, bool useCapture) override;
</ins><span class="cx"> bool removeEventListener(const AtomicString& eventType, EventListener*, bool useCapture) override;
</span><span class="cx"> void removeAllEventListeners() override;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioScriptProcessorNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -273,9 +273,9 @@
</span><span class="cx"> return std::numeric_limits<double>::infinity();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool ScriptProcessorNode::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
</del><ins>+bool ScriptProcessorNode::addEventListener(const AtomicString& eventType, RefPtr<EventListener>&& listener, bool useCapture)
</ins><span class="cx"> {
</span><del>- bool success = AudioNode::addEventListener(eventType, listener, useCapture);
</del><ins>+ bool success = AudioNode::addEventListener(eventType, WTF::move(listener), useCapture);
</ins><span class="cx"> if (success && eventType == eventNames().audioprocessEvent)
</span><span class="cx"> m_hasAudioProcessListener = hasEventListeners(eventNames().audioprocessEvent);
</span><span class="cx"> return success;
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioScriptProcessorNodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.h (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.h 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.h 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx">
</span><span class="cx"> void fireProcessEvent();
</span><span class="cx">
</span><del>- bool addEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture) override;
</del><ins>+ bool addEventListener(const AtomicString& eventType, RefPtr<EventListener>&&, bool useCapture) override;
</ins><span class="cx"> bool removeEventListener(const AtomicString& eventType, EventListener*, bool useCapture) override;
</span><span class="cx"> void removeAllEventListeners() override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventListenerMapcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EventListenerMap.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EventListenerMap.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/dom/EventListenerMap.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -187,7 +187,7 @@
</span><span class="cx"> // Event listeners created from markup have already been transfered to the shadow tree during cloning.
</span><span class="cx"> if ((*listenerVector)[i].listener->wasCreatedFromMarkup())
</span><span class="cx"> continue;
</span><del>- target->addEventListener(eventType, (*listenerVector)[i].listener, (*listenerVector)[i].useCapture);
</del><ins>+ target->addEventListener(eventType, (*listenerVector)[i].listener.copyRef(), (*listenerVector)[i].useCapture);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventTargetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EventTarget.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EventTarget.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/dom/EventTarget.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -74,9 +74,9 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool EventTarget::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
</del><ins>+bool EventTarget::addEventListener(const AtomicString& eventType, RefPtr<EventListener>&& listener, bool useCapture)
</ins><span class="cx"> {
</span><del>- return ensureEventTargetData().eventListenerMap.add(eventType, listener, useCapture);
</del><ins>+ return ensureEventTargetData().eventListenerMap.add(eventType, WTF::move(listener), useCapture);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool EventTarget::removeEventListener(const AtomicString& eventType, EventListener* listener, bool useCapture)
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventTargeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EventTarget.h (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EventTarget.h 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/dom/EventTarget.h 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -120,7 +120,7 @@
</span><span class="cx"> virtual DOMWindow* toDOMWindow();
</span><span class="cx"> virtual bool isMessagePort() const;
</span><span class="cx">
</span><del>- virtual bool addEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture);
</del><ins>+ virtual bool addEventListener(const AtomicString& eventType, RefPtr<EventListener>&&, bool useCapture);
</ins><span class="cx"> virtual bool removeEventListener(const AtomicString& eventType, EventListener*, bool useCapture);
</span><span class="cx"> virtual void removeAllEventListeners();
</span><span class="cx"> virtual bool dispatchEvent(PassRefPtr<Event>);
</span></span></pre></div>
<a id="trunkSourceWebCoredomMessagePortcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MessagePort.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MessagePort.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/dom/MessagePort.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -224,11 +224,11 @@
</span><span class="cx"> return portArray;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool MessagePort::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
</del><ins>+bool MessagePort::addEventListener(const AtomicString& eventType, RefPtr<EventListener>&& listener, bool useCapture)
</ins><span class="cx"> {
</span><span class="cx"> if (listener && listener->isAttribute() && eventType == eventNames().messageEvent)
</span><span class="cx"> start();
</span><del>- return EventTargetWithInlineData::addEventListener(eventType, listener, useCapture);
</del><ins>+ return EventTargetWithInlineData::addEventListener(eventType, WTF::move(listener), useCapture);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoredomMessagePorth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MessagePort.h (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MessagePort.h 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/dom/MessagePort.h 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -93,7 +93,7 @@
</span><span class="cx"> // A port gets neutered when it is transferred to a new owner via postMessage().
</span><span class="cx"> bool isNeutered() { return !m_entangledChannel; }
</span><span class="cx">
</span><del>- bool addEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture) override;
</del><ins>+ bool addEventListener(const AtomicString& eventType, RefPtr<EventListener>&&, bool useCapture) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> explicit MessagePort(ScriptExecutionContext&);
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/dom/Node.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -1867,11 +1867,9 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static inline bool tryAddEventListener(Node* targetNode, const AtomicString& eventType, PassRefPtr<EventListener> prpListener, bool useCapture)
</del><ins>+static inline bool tryAddEventListener(Node* targetNode, const AtomicString& eventType, RefPtr<EventListener>&& listener, bool useCapture)
</ins><span class="cx"> {
</span><del>- RefPtr<EventListener> listener = prpListener;
-
- if (!targetNode->EventTarget::addEventListener(eventType, listener, useCapture))
</del><ins>+ if (!targetNode->EventTarget::addEventListener(eventType, listener.copyRef(), useCapture))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> targetNode->document().addListenerTypeIfNeeded(eventType);
</span><span class="lines">@@ -1889,7 +1887,7 @@
</span><span class="cx"> // This code was added to address <rdar://problem/5846492> Onorientationchange event not working for document.body.
</span><span class="cx"> // Forward this call to addEventListener() to the window since these are window-only events.
</span><span class="cx"> if (eventType == eventNames().orientationchangeEvent || eventType == eventNames().resizeEvent)
</span><del>- targetNode->document().domWindow()->addEventListener(eventType, listener, useCapture);
</del><ins>+ targetNode->document().domWindow()->addEventListener(eventType, WTF::move(listener), useCapture);
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(TOUCH_EVENTS)
</span><span class="cx"> if (eventNames().isTouchEventType(eventType))
</span><span class="lines">@@ -1905,9 +1903,9 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool Node::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
</del><ins>+bool Node::addEventListener(const AtomicString& eventType, RefPtr<EventListener>&& listener, bool useCapture)
</ins><span class="cx"> {
</span><del>- return tryAddEventListener(this, eventType, listener, useCapture);
</del><ins>+ return tryAddEventListener(this, eventType, WTF::move(listener), useCapture);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static inline bool tryRemoveEventListener(Node* targetNode, const AtomicString& eventType, EventListener* listener, bool useCapture)
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.h (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.h 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/dom/Node.h 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -521,7 +521,7 @@
</span><span class="cx"> virtual EventTargetInterface eventTargetInterface() const override;
</span><span class="cx"> virtual ScriptExecutionContext* scriptExecutionContext() const override final; // Implemented in Document.h
</span><span class="cx">
</span><del>- virtual bool addEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture) override;
</del><ins>+ virtual bool addEventListener(const AtomicString& eventType, RefPtr<EventListener>&&, bool useCapture) override;
</ins><span class="cx"> virtual bool removeEventListener(const AtomicString& eventType, EventListener*, bool useCapture) override;
</span><span class="cx">
</span><span class="cx"> using EventTarget::dispatchEvent;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMediaElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -5046,13 +5046,13 @@
</span><span class="cx"> return HTMLElement::dispatchEvent(event);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool HTMLMediaElement::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
</del><ins>+bool HTMLMediaElement::addEventListener(const AtomicString& eventType, RefPtr<EventListener>&& listener, bool useCapture)
</ins><span class="cx"> {
</span><span class="cx"> if (eventType != eventNames().webkitplaybacktargetavailabilitychangedEvent)
</span><del>- return Node::addEventListener(eventType, listener, useCapture);
</del><ins>+ return Node::addEventListener(eventType, WTF::move(listener), useCapture);
</ins><span class="cx">
</span><span class="cx"> bool isFirstAvailabilityChangedListener = !hasEventListeners(eventNames().webkitplaybacktargetavailabilitychangedEvent);
</span><del>- if (!Node::addEventListener(eventType, listener, useCapture))
</del><ins>+ if (!Node::addEventListener(eventType, WTF::move(listener), useCapture))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> if (isFirstAvailabilityChangedListener) {
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMediaElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMediaElement.h 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -335,7 +335,7 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(WIRELESS_PLAYBACK_TARGET)
</span><span class="cx"> void webkitShowPlaybackTargetPicker();
</span><del>- virtual bool addEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture) override;
</del><ins>+ virtual bool addEventListener(const AtomicString& eventType, RefPtr<EventListener>&&, bool useCapture) override;
</ins><span class="cx"> virtual bool removeEventListener(const AtomicString& eventType, EventListener*, bool useCapture) override;
</span><span class="cx">
</span><span class="cx"> virtual void wirelessRoutesAvailableDidChange() override;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlImageDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ImageDocument.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ImageDocument.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/html/ImageDocument.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -239,8 +239,8 @@
</span><span class="cx"> #else
</span><span class="cx"> RefPtr<EventListener> listener = ImageEventListener::create(*this);
</span><span class="cx"> if (DOMWindow* window = this->domWindow())
</span><del>- window->addEventListener("resize", listener, false);
- imageElement->addEventListener("click", listener.release(), false);
</del><ins>+ window->addEventListener("resize", listener.copyRef(), false);
+ imageElement->addEventListener("click", WTF::move(listener), false);
</ins><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowMediaControlsApplecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/MediaControlsApple.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/MediaControlsApple.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/html/shadow/MediaControlsApple.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -509,15 +509,15 @@
</span><span class="cx"> m_panel->setInlineStyleProperty(CSSPropertyPointerEvents, CSSValueNone);
</span><span class="cx">
</span><span class="cx"> RefPtr<EventListener> listener = eventListener();
</span><del>- m_closedCaptionsContainer->addEventListener(eventNames().wheelEvent, listener, true);
</del><ins>+ m_closedCaptionsContainer->addEventListener(eventNames().wheelEvent, listener.copyRef(), true);
</ins><span class="cx">
</span><span class="cx"> // Track click events in the capture phase at two levels, first at the document level
</span><span class="cx"> // such that a click outside of the <video> may dismiss the track list, second at the
</span><span class="cx"> // media controls level such that a click anywhere outside of the track list hides the
</span><span class="cx"> // track list. These two levels are necessary since it would not be possible to get a
</span><span class="cx"> // reference to the track list when handling the event outside of the shadow tree.
</span><del>- document().addEventListener(eventNames().clickEvent, listener, true);
- addEventListener(eventNames().clickEvent, listener, true);
</del><ins>+ document().addEventListener(eventNames().clickEvent, listener.copyRef(), true);
+ addEventListener(eventNames().clickEvent, WTF::move(listener), true);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void MediaControlsApple::hideClosedCaptionTrackList()
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMWindowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMWindow.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMWindow.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/page/DOMWindow.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -1692,9 +1692,9 @@
</span><span class="cx"> window->sessionStorage(IGNORE_EXCEPTION);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool DOMWindow::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
</del><ins>+bool DOMWindow::addEventListener(const AtomicString& eventType, RefPtr<EventListener>&& listener, bool useCapture)
</ins><span class="cx"> {
</span><del>- if (!EventTarget::addEventListener(eventType, listener, useCapture))
</del><ins>+ if (!EventTarget::addEventListener(eventType, WTF::move(listener), useCapture))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> if (Document* document = this->document()) {
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMWindowh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMWindow.h (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMWindow.h 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/page/DOMWindow.h 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -273,7 +273,7 @@
</span><span class="cx">
</span><span class="cx"> // Events
</span><span class="cx"> // EventTarget API
</span><del>- virtual bool addEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture) override;
</del><ins>+ virtual bool addEventListener(const AtomicString& eventType, RefPtr<EventListener>&&, bool useCapture) override;
</ins><span class="cx"> virtual bool removeEventListener(const AtomicString& eventType, EventListener*, bool useCapture) override;
</span><span class="cx"> virtual void removeAllEventListeners() override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGResourceFiltercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -87,11 +87,11 @@
</span><span class="cx"> builder->clearEffects();
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><del>- builder->appendEffectToEffectReferences(effect, element.renderer());
</del><ins>+ builder->appendEffectToEffectReferences(effect.copyRef(), element.renderer());
</ins><span class="cx"> element.setStandardAttributes(effect.get());
</span><span class="cx"> effect->setEffectBoundaries(SVGLengthContext::resolveRectangle<SVGFilterPrimitiveStandardAttributes>(&element, filterElement().primitiveUnits(), targetBoundingBox));
</span><span class="cx"> effect->setOperatingColorSpace(element.renderer()->style().svgStyle().colorInterpolationFilters() == CI_LINEARRGB ? ColorSpaceLinearRGB : ColorSpaceDeviceRGB);
</span><del>- builder->add(element.result(), effect.release());
</del><ins>+ builder->add(element.result(), WTF::move(effect));
</ins><span class="cx"> }
</span><span class="cx"> return builder;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGElement.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGElement.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/svg/SVGElement.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -571,12 +571,10 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool SVGElement::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> prpListener, bool useCapture)
-{
- RefPtr<EventListener> listener = prpListener;
-
</del><ins>+bool SVGElement::addEventListener(const AtomicString& eventType, RefPtr<EventListener>&& listener, bool useCapture)
+{
</ins><span class="cx"> // Add event listener to regular DOM element
</span><del>- if (!Node::addEventListener(eventType, listener, useCapture))
</del><ins>+ if (!Node::addEventListener(eventType, listener.copyRef(), useCapture))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> if (containingShadowRoot())
</span><span class="lines">@@ -586,7 +584,7 @@
</span><span class="cx"> ASSERT(!instanceUpdatesBlocked());
</span><span class="cx"> for (auto* instance : instances()) {
</span><span class="cx"> ASSERT(instance->correspondingElement() == this);
</span><del>- bool result = instance->Node::addEventListener(eventType, listener, useCapture);
</del><ins>+ bool result = instance->Node::addEventListener(eventType, listener.copyRef(), useCapture);
</ins><span class="cx"> ASSERT_UNUSED(result, result);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGElement.h (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGElement.h 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/svg/SVGElement.h 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -34,7 +34,6 @@
</span><span class="cx"> #include "Timer.h"
</span><span class="cx"> #include <wtf/HashMap.h>
</span><span class="cx"> #include <wtf/HashSet.h>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="lines">@@ -141,7 +140,7 @@
</span><span class="cx">
</span><span class="cx"> virtual bool haveLoadedRequiredResources();
</span><span class="cx">
</span><del>- virtual bool addEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture) override;
</del><ins>+ virtual bool addEventListener(const AtomicString& eventType, RefPtr<EventListener>&&, bool useCapture) override;
</ins><span class="cx"> virtual bool removeEventListener(const AtomicString& eventType, EventListener*, bool useCapture) override;
</span><span class="cx"> bool hasFocusEventListeners() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGPathElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGPathElement.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGPathElement.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/svg/SVGPathElement.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -359,7 +359,7 @@
</span><span class="cx"> case PathSegUnalteredRole:
</span><span class="cx"> if (listModification == ListModificationAppend) {
</span><span class="cx"> ASSERT(!m_pathSegList.value.isEmpty());
</span><del>- appendSVGPathByteStreamFromSVGPathSeg(m_pathSegList.value.last(), m_pathByteStream.get(), UnalteredParsing);
</del><ins>+ appendSVGPathByteStreamFromSVGPathSeg(m_pathSegList.value.last().copyRef(), m_pathByteStream.get(), UnalteredParsing);
</ins><span class="cx"> } else
</span><span class="cx"> buildSVGPathByteStreamFromSVGPathSegList(m_pathSegList.value, m_pathByteStream.get(), UnalteredParsing);
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGPathUtilitiescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGPathUtilities.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGPathUtilities.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/svg/SVGPathUtilities.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -139,14 +139,14 @@
</span><span class="cx"> return ok;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool appendSVGPathByteStreamFromSVGPathSeg(PassRefPtr<SVGPathSeg> pathSeg, SVGPathByteStream* result, PathParsingMode parsingMode)
</del><ins>+bool appendSVGPathByteStreamFromSVGPathSeg(RefPtr<SVGPathSeg>&& pathSeg, SVGPathByteStream* result, PathParsingMode parsingMode)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(result);
</span><span class="cx"> // FIXME: https://bugs.webkit.org/show_bug.cgi?id=15412 - Implement normalized path segment lists!
</span><span class="cx"> ASSERT(parsingMode == UnalteredParsing);
</span><span class="cx">
</span><span class="cx"> SVGPathSegList appendedItemList(PathSegUnalteredRole);
</span><del>- appendedItemList.append(pathSeg);
</del><ins>+ appendedItemList.append(WTF::move(pathSeg));
</ins><span class="cx"> auto appendedByteStream = std::make_unique<SVGPathByteStream>();
</span><span class="cx">
</span><span class="cx"> SVGPathByteStreamBuilder* builder = globalSVGPathByteStreamBuilder(appendedByteStream.get());
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGPathUtilitiesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGPathUtilities.h (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGPathUtilities.h 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/svg/SVGPathUtilities.h 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx">
</span><span class="cx"> // SVGPathSegList/String -> SVGPathByteStream
</span><span class="cx"> bool buildSVGPathByteStreamFromSVGPathSegList(const SVGPathSegList&, SVGPathByteStream*, PathParsingMode);
</span><del>-bool appendSVGPathByteStreamFromSVGPathSeg(PassRefPtr<SVGPathSeg>, SVGPathByteStream*, PathParsingMode);
</del><ins>+bool appendSVGPathByteStreamFromSVGPathSeg(RefPtr<SVGPathSeg>&&, SVGPathByteStream*, PathParsingMode);
</ins><span class="cx"> bool buildSVGPathByteStreamFromString(const String&, SVGPathByteStream*, PathParsingMode);
</span><span class="cx">
</span><span class="cx"> // SVGPathByteStream/SVGPathSegList -> String
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGTRefElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGTRefElement.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGTRefElement.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/svg/SVGTRefElement.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -65,7 +65,7 @@
</span><span class="cx"> return listener->type() == SVGTRefTargetEventListenerType ? static_cast<const SVGTRefTargetEventListener*>(listener) : nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- void attach(PassRefPtr<Element> target);
</del><ins>+ void attach(RefPtr<Element>&& target);
</ins><span class="cx"> void detach();
</span><span class="cx"> bool isAttached() const { return m_target.get(); }
</span><span class="cx">
</span><span class="lines">@@ -86,7 +86,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SVGTRefTargetEventListener::attach(PassRefPtr<Element> target)
</del><ins>+void SVGTRefTargetEventListener::attach(RefPtr<Element>&& target)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(!isAttached());
</span><span class="cx"> ASSERT(target.get());
</span><span class="lines">@@ -94,7 +94,7 @@
</span><span class="cx">
</span><span class="cx"> target->addEventListener(eventNames().DOMSubtreeModifiedEvent, this, false);
</span><span class="cx"> target->addEventListener(eventNames().DOMNodeRemovedFromDocumentEvent, this, false);
</span><del>- m_target = target;
</del><ins>+ m_target = WTF::move(target);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void SVGTRefTargetEventListener::detach()
</span><span class="lines">@@ -249,7 +249,7 @@
</span><span class="cx"> // expects every element instance to have an associated shadow tree element - which is not the
</span><span class="cx"> // case when we land here from SVGUseElement::buildShadowTree().
</span><span class="cx"> if (!isInShadowTree())
</span><del>- m_targetListener->attach(target);
</del><ins>+ m_targetListener->attach(target.copyRef());
</ins><span class="cx">
</span><span class="cx"> updateReferencedText(target.get());
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoresvggraphicsfiltersSVGFilterBuildercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -62,10 +62,8 @@
</span><span class="cx"> return m_namedEffects.get(id);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SVGFilterBuilder::appendEffectToEffectReferences(PassRefPtr<FilterEffect> prpEffect, RenderObject* object)
</del><ins>+void SVGFilterBuilder::appendEffectToEffectReferences(RefPtr<FilterEffect>&& effect, RenderObject* object)
</ins><span class="cx"> {
</span><del>- RefPtr<FilterEffect> effect = prpEffect;
-
</del><span class="cx"> // The effect must be a newly created filter effect.
</span><span class="cx"> ASSERT(!m_effectReferences.contains(effect));
</span><span class="cx"> ASSERT(object && !m_effectRenderer.contains(object));
</span></span></pre></div>
<a id="trunkSourceWebCoresvggraphicsfiltersSVGFilterBuilderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.h (189564 => 189565)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.h 2015-09-10 02:04:02 UTC (rev 189564)
+++ trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.h 2015-09-10 02:16:22 UTC (rev 189565)
</span><span class="lines">@@ -25,7 +25,6 @@
</span><span class="cx">
</span><span class="cx"> #include <wtf/HashMap.h>
</span><span class="cx"> #include <wtf/HashSet.h>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/text/AtomicStringHash.h>
</span><span class="cx"> #include <wtf/text/WTFString.h>
</span><span class="cx">
</span><span class="lines">@@ -44,7 +43,7 @@
</span><span class="cx"> FilterEffect* getEffectById(const AtomicString& id) const;
</span><span class="cx"> FilterEffect* lastEffect() const { return m_lastEffect.get(); }
</span><span class="cx">
</span><del>- void appendEffectToEffectReferences(PassRefPtr<FilterEffect>, RenderObject*);
</del><ins>+ void appendEffectToEffectReferences(RefPtr<FilterEffect>&&, RenderObject*);
</ins><span class="cx">
</span><span class="cx"> inline FilterEffectSet& effectReferences(FilterEffect* effect)
</span><span class="cx"> {
</span></span></pre>
</div>
</div>
</body>
</html>