<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189502] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189502">189502</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-09-08 12:39:40 -0700 (Tue, 08 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>document.importNode(node, deep): deep's default value should be false
https://bugs.webkit.org/show_bug.cgi?id=148959
<rdar://problem/22558915>
Reviewed by Alexey Proskuryakov.
LayoutTests/imported/w3c:
* web-platform-tests/dom/nodes/Document-importNode-expected.txt:
Rebaseline now that an additional check is passing.
Source/WebCore:
Switch deep parameter's default value for document.importNode() to
false, as per the latest DOM specification:
- https://dom.spec.whatwg.org/#interface-document
- https://dom.spec.whatwg.org/#dom-document-importnode
Firefox and Chrome follow the specification. However, WebKit was using
"true" for deep's default value.
No new tests, already covered by:
imported/w3c/web-platform-tests/dom/nodes/Document-importNode.html
* dom/Document.h:
(WebCore::Document::importNode):
LayoutTests:
* fast/dom/document-importNode-arguments.html:
Explicitly pass deep parameter as the test wants a deep clone.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomdocumentimportNodeargumentshtml">trunk/LayoutTests/fast/dom/document-importNode-arguments.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesDocumentimportNodeexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-importNode-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/Document.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (189501 => 189502)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2015-09-08 19:11:04 UTC (rev 189501)
+++ trunk/LayoutTests/ChangeLog        2015-09-08 19:39:40 UTC (rev 189502)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-09-08 Chris Dumez <cdumez@apple.com>
+
+ document.importNode(node, deep): deep's default value should be false
+ https://bugs.webkit.org/show_bug.cgi?id=148959
+ <rdar://problem/22558915>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * fast/dom/document-importNode-arguments.html:
+ Explicitly pass deep parameter as the test wants a deep clone.
+
</ins><span class="cx"> 2015-09-08 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Move PrettyPrinting tests into LayoutTests
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomdocumentimportNodeargumentshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/document-importNode-arguments.html (189501 => 189502)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/document-importNode-arguments.html        2015-09-08 19:11:04 UTC (rev 189501)
+++ trunk/LayoutTests/fast/dom/document-importNode-arguments.html        2015-09-08 19:39:40 UTC (rev 189502)
</span><span class="lines">@@ -14,7 +14,7 @@
</span><span class="cx"> var d = document.createElement("div");
</span><span class="cx"> d.innerHTML = "<span>hello </span><span>world</span>";
</span><span class="cx">
</span><del>-imported = document.importNode(d);
</del><ins>+imported = document.importNode(d, true);
</ins><span class="cx"> shouldBe('imported.childNodes.length','2');
</span><span class="cx"> shouldBeTrue("imported.textContent == 'hello world'");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (189501 => 189502)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog        2015-09-08 19:11:04 UTC (rev 189501)
+++ trunk/LayoutTests/imported/w3c/ChangeLog        2015-09-08 19:39:40 UTC (rev 189502)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-09-08 Chris Dumez <cdumez@apple.com>
+
+ document.importNode(node, deep): deep's default value should be false
+ https://bugs.webkit.org/show_bug.cgi?id=148959
+ <rdar://problem/22558915>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * web-platform-tests/dom/nodes/Document-importNode-expected.txt:
+ Rebaseline now that an additional check is passing.
+
</ins><span class="cx"> 2015-09-07 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, fixup a few recently imported W3C HTML tests.
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesDocumentimportNodeexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-importNode-expected.txt (189501 => 189502)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-importNode-expected.txt        2015-09-08 19:11:04 UTC (rev 189501)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-importNode-expected.txt        2015-09-08 19:39:40 UTC (rev 189502)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx">
</span><del>-FAIL No 'deep' argument. assert_equals: expected null but got Element node <span></span>
</del><ins>+PASS No 'deep' argument.
</ins><span class="cx"> PASS Undefined 'deep' argument.
</span><span class="cx"> PASS True 'deep' argument.
</span><span class="cx"> PASS False 'deep' argument.
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (189501 => 189502)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2015-09-08 19:11:04 UTC (rev 189501)
+++ trunk/Source/WebCore/ChangeLog        2015-09-08 19:39:40 UTC (rev 189502)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2015-09-08 Chris Dumez <cdumez@apple.com>
+
+ document.importNode(node, deep): deep's default value should be false
+ https://bugs.webkit.org/show_bug.cgi?id=148959
+ <rdar://problem/22558915>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Switch deep parameter's default value for document.importNode() to
+ false, as per the latest DOM specification:
+ - https://dom.spec.whatwg.org/#interface-document
+ - https://dom.spec.whatwg.org/#dom-document-importnode
+
+ Firefox and Chrome follow the specification. However, WebKit was using
+ "true" for deep's default value.
+
+ No new tests, already covered by:
+ imported/w3c/web-platform-tests/dom/nodes/Document-importNode.html
+
+ * dom/Document.h:
+ (WebCore::Document::importNode):
+
</ins><span class="cx"> 2015-09-08 Per Arne Vollan <peavo@outlook.com>
</span><span class="cx">
</span><span class="cx"> [Win][HighDPI] Video window placement is incorrect.
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h (189501 => 189502)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.h        2015-09-08 19:11:04 UTC (rev 189501)
+++ trunk/Source/WebCore/dom/Document.h        2015-09-08 19:39:40 UTC (rev 189502)
</span><span class="lines">@@ -375,7 +375,7 @@
</span><span class="cx"> RefPtr<Attr> createAttribute(const String& name, ExceptionCode&);
</span><span class="cx"> RefPtr<Attr> createAttributeNS(const String& namespaceURI, const String& qualifiedName, ExceptionCode&, bool shouldIgnoreNamespaceChecks = false);
</span><span class="cx"> RefPtr<EntityReference> createEntityReference(const String& name, ExceptionCode&);
</span><del>- RefPtr<Node> importNode(Node* importedNode, ExceptionCode& ec) { return importNode(importedNode, true, ec); }
</del><ins>+ RefPtr<Node> importNode(Node* importedNode, ExceptionCode& ec) { return importNode(importedNode, false, ec); }
</ins><span class="cx"> RefPtr<Node> importNode(Node* importedNode, bool deep, ExceptionCode&);
</span><span class="cx"> WEBCORE_EXPORT RefPtr<Element> createElementNS(const String& namespaceURI, const String& qualifiedName, ExceptionCode&);
</span><span class="cx"> WEBCORE_EXPORT Ref<Element> createElement(const QualifiedName&, bool createdByParser);
</span></span></pre>
</div>
</div>
</body>
</html>