<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[189444] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/189444">189444</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-09-06 07:38:12 -0700 (Sun, 06 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Simplify JIT::emit_op_mod()
https://bugs.webkit.org/show_bug.cgi?id=148908
Patch by Sukolsak Sakshuwong <sukolsak@gmail.com> on 2015-09-06
Reviewed by Michael Saboff.
The IDIV instruction on x86 divides the value in the EDX:EAX registers
by the source operand and stores the quotient in EAX and the remainder
in EDX. Therefore, we store the values that we don't want to be
overwritten by IDIV in registers that are not EAX or EDX. This patch
makes the intention clearer and makes the code easier to read.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mod):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITArithmeticcpp">trunk/Source/JavaScriptCore/jit/JITArithmetic.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (189443 => 189444)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-09-06 06:30:44 UTC (rev 189443)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-09-06 14:38:12 UTC (rev 189444)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-09-06 Sukolsak Sakshuwong <sukolsak@gmail.com>
+
+ Simplify JIT::emit_op_mod()
+ https://bugs.webkit.org/show_bug.cgi?id=148908
+
+ Reviewed by Michael Saboff.
+
+ The IDIV instruction on x86 divides the value in the EDX:EAX registers
+ by the source operand and stores the quotient in EAX and the remainder
+ in EDX. Therefore, we store the values that we don't want to be
+ overwritten by IDIV in registers that are not EAX or EDX. This patch
+ makes the intention clearer and makes the code easier to read.
+
+ * jit/JITArithmetic.cpp:
+ (JSC::JIT::emit_op_mod):
+
</ins><span class="cx"> 2015-09-05 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix JSDollarVMPrototype after r189160.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITArithmeticcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JITArithmetic.cpp (189443 => 189444)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JITArithmetic.cpp 2015-09-06 06:30:44 UTC (rev 189443)
+++ trunk/Source/JavaScriptCore/jit/JITArithmetic.cpp 2015-09-06 14:38:12 UTC (rev 189444)
</span><span class="lines">@@ -611,19 +611,11 @@
</span><span class="cx"> int op2 = currentInstruction[3].u.operand;
</span><span class="cx">
</span><span class="cx"> // Make sure registers are correct for x86 IDIV instructions.
</span><del>-#if CPU(X86)
- auto edx = regT1;
- auto ecx = regT2;
-#elif OS(WINDOWS)
- auto edx = regT1;
- auto ecx = regT5;
-#else
- auto edx = regT2;
- auto ecx = regT3;
-#endif
</del><span class="cx"> ASSERT(regT0 == X86Registers::eax);
</span><del>- ASSERT(edx == X86Registers::edx);
- ASSERT(ecx == X86Registers::ecx);
</del><ins>+ auto edx = X86Registers::edx;
+ auto ecx = X86Registers::ecx;
+ ASSERT(regT4 != edx);
+ ASSERT(regT4 != ecx);
</ins><span class="cx">
</span><span class="cx"> emitGetVirtualRegisters(op1, regT4, op2, ecx);
</span><span class="cx"> emitJumpSlowCaseIfNotImmediateInteger(regT4);
</span></span></pre>
</div>
</div>
</body>
</html>